February 2014 - Wine-devel - list.winehq.org

Temporary Directories
by C.W. Betts 05 Feb '14

05 Feb '14

I’m wondering if Wine has some way of marking temporary directories and/or files as such. I’m mainly asking because OS X has APIs to mark directories (and maybe files) excluded from backup from their Time Machine software. And temporary directories are often modified a lot, making backups of them taking awhile to complete.

3 2

Re: server: Fix generic access mapping for a thread.
by Marvin 05 Feb '14

05 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4597 Your paranoid android. === wvista (32 bit security) === security.c:4990: Test failed: 4: expected 0x1f03ff, got 0x1fffff === w2008s64 (32 bit security) === security.c:4990: Test failed: 4: expected 0x1f03ff, got 0x1fffff === w7pro64 (32 bit security) === security.c:4990: Test failed: 4: expected 0x1f03ff, got 0x1fffff === w2008s64 (64 bit security) === security.c:4990: Test failed: 4: expected 0x1f03ff, got 0x1fffff === w7pro64 (64 bit security) === security.c:4990: Test failed: 4: expected 0x1f03ff, got 0x1fffff

1 0

Re: ws2_32/tests: Fix AcceptEx tests related to address length
by Marvin 05 Feb '14

05 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4593 Your paranoid android. === wxppro (32 bit sock) === sock.c:557: Test failed: oob_server (af4): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0 sock: unhandled exception c0000005 at 00000000 === w2008s64 (64 bit sock) === sock.c:557: Test failed: oob_server (750): unexpectedly at the OOB mark: 0

1 0

Wine fiscal governance, Conservancy role, new initiatives
by Jeremy White 04 Feb '14

04 Feb '14

Hey Folks, At FOSDEM, Alexandre, Michael and I sat down and talked with Bradley Kuhn from the Software Freedom Conservancy about the Wine Project. For those who are not aware, the SFC is the umbrella organization that holds Wine's money and it's trademarks. They also help us if we have legal questions, or just odd this and thats that are helpful to a project like ours. They (and Bradley in particular) have been quite helpful through the years. Again for the record, spending decisions are controlled by a committee of 5, and we require a majority vote of a quorum for any spending. The quorum for any given decision cannot itself have a majority from any one company. The current committee is myself, Alexandre, Michael Stefaniuc, Marcus, and Austin English. The committee is self replacing, so if one steps down, the remaining members nominate a replacement. The SFC will recognize a 'revolution'; if the committee is clearly out of step with a majority of Wine contributors, it will force a change. In practice, the committee mostly decides who to fund for travel to the annual Wine conference. We have in the past agreed to provide SFC with 10% of our income to help them provide the support and staffing. We are still working on revising the formal paperwork to back this, and will likely be presenting that formal paperwork sometime this year (hopefully :-/). Bradley proposed one new idea that I think is worth while: sponsoring Wine evangelism. That is, sponsoring travel to various shows to present talks on Wine, or to man a table to talk up Wine. That seems like a good idea, and we will likely pursue it. If anyone is excited about the idea of being a Wine 'evangelism coordinator', drop me a line. Now get back to work; I expect test.winehq.org to be showing green before the next release... <grin> Cheers, Jeremy

1 0

Re: Assorted typos fixes (resend 2)
by Nikolay Sivov 04 Feb '14

04 Feb '14

On 2/4/2014 17:21, Andrey Gusev wrote: > - FIXME("(%p)->(%s,%p,%p,%08x): stub !\n", iface, lpszFileName, pec, pvRef, dwFlags); > + FIXME("(%p)->(%s,%p,%p,%08x): stub!\n", iface, lpszFileName, pec, pvRef, dwFlags); It's nice to have a proper spacing of course, but I don't think it justifies such changes. > -#define WINE_FILENAME_STR "dpnadr.dll" > +#define WINE_FILENAME_STR "dpnaddr.dll" > - ok(dip_gain_get.dwData==dip_gain_set.dwData, "Gain not udated: %i\n", dip_gain_get.dwData); > + ok(dip_gain_get.dwData==dip_gain_set.dwData, "Gain not updated: %i\n", dip_gain_get.dwData); These ones are valid, and some others too. But the rest is a noise.

1 0

Re: winmm/tests: Avoid spurious test failures on Windows.
by Marvin 04 Feb '14

04 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=4578 Your paranoid android. === wxppro (32 bit mci) === mci.c:1212: Test failed: mci status "C:\Documents and Settings\winetest\My Documents\tempfile.wav" mode returned MCIERR_INVALID_DEVICE_NAME mci.c:1277: Test failed: mci re-auto-open status mode returned MCIERR_INVALID_DEVICE_NAME mci.c:1293: Test failed: mci auto-open pause returned MCIERR_INVALID_DEVICE_NAME

2 1

Official retirement of 'old' wine test bot, celebration of the work of Gé van Geldorp
by Jeremy White 04 Feb '14

04 Feb '14

Folks, Arno van Geldorp has let us know that this will be the last month that the original test bot continues to run. We will be redirecting the 'testbot' urls to the new wine test bot as a result. These intervening years have made clear just how great Gé's gift to us was. It has taken us multiple people many years to begin to replicate his work. But I think we'll be okay; Francois has done a lot of hard work, and once Huw is a qemu expert, I think we will come out of the woods. We also owe a great deal to the van Geldorp family for so graciously paying to host the old wine testbot, long after the time that Gé had asked for. That, too, was a very generous gift. So please join me in thanking the entire family of Gé van Geldorp for their incredible gifts to Wine over the years. Cheers, Jeremy

1 0

[PATCH v7 0/7] Add O_DENY* support for VFS and CIFS/NFS
by Pavel Shilovsky 04 Feb '14

04 Feb '14

This patchset adds support of O_DENY* flags for Linux fs layer. These flags can be used by any application that needs share reservations to organize a file access. VFS already has some sort of this capability - now it's done through flock/LOCK_MAND mechanis, but that approach is non-atomic. This patchset build new capabilities on top of the existing one but doesn't bring any changes into the flock call semantic. These flags can be used by NFS (built-in-kernel) and CIFS (Samba) servers and Wine applications through VFS (for local filesystems) or CIFS/NFS modules. This will help when e.g. Samba and NFS server share the same directory for Windows and Linux users or Wine applications use Samba/NFS share to access the same data from different clients. According to the previous discussions the most problematic question is how to prevent situations like DoS attacks where e.g /lib/liba.so file can be open with DENYREAD, or smth like this. That's why extra mount option 'sharelock' is added for switching on/off O_DENY* flags processing. It allows to avoid use of these flags on critical places (like /, /lib) and turn them on if we really want it proccessed that way. So, we have 3 new flags: O_DENYREAD - to prevent other opens with read access, O_DENYWRITE - to prevent other opens with write access, O_DENYDELETE - to prevent delete operations The patchset avoids data races problem on newely created files: open with O_CREAT can return the -ESHAREDENIED error for a successfully created file if this files was locked with a sharelock by another task. Also, it turns flock/LOCK_MAND capability off for mounts with 'sharelock' option. This lets not mix one share reservation approach with another. Patches #1, #2 and #3 add O_DENY* flags to fcntl and implement VFS part. A patch #4 is related to CIFS client changes, #5 -- NFSD, #6 and #7 describe NFSv4 client parts. The preliminary patch for Samba that replaces the existing use of flock/LOCK_MAND mechanism with O_DENY* flags: http://git.etersoft.ru/people/piastry/packages/?p=samba.git;a=commitdiff;h=… The future part of open man page patch: ----- O_DENYREAD, O_DENYWRIYE, O_DENYDELETE - used to inforce a mandatory share reservation scheme of the file access. If these flag is passed, the open fails with -ESHAREDENIED in following cases: 1) if O_DENYREAD flag is specified and there is another open with READ access to the file; 2) if O_DENYWRITE flag is specified and there is another open with WRITE access to the file; 3) if READ access is requested and there is another open with O_DENYREAD flags; 4) if WRITE access is requested and there is another open with O_DENYWRITE flags. If O_DENYDELETE flag is specified and the open succeded, any further unlink operation will fail with -ESHAREDENIED untill this open is closed. Now this flag is processed by VFS and CIFS filesystem. NFS returns -EINVAL for opens with this flag. This mechanism is done through flocks. If O_DENY* flags are specified, flock syscall is processed after the open. The share modes are translated into flock according the following rules: 1) !O_DENYREAD -> LOCK_READ | LOCK_MAND 2) !O_DENYWRITE -> LOCK_WRITE | LOCK_MAND 3) !O_DENYDELETE -> LOCK_DELETE | LOCK_MAND ----- Pavel Shilovsky (7): VFS: Introduce new O_DENY* open flags VFS: Add O_DENYDELETE support for VFS locks: Disable LOCK_MAND support for MS_SHARELOCK mounts CIFS: Add O_DENY* open flags support NFSD: Pass share reservations flags to VFS NFSv4: Add deny state handling for nfs4_state struct NFSv4: Add O_DENY* open flags support arch/alpha/include/uapi/asm/errno.h | 2 + arch/alpha/include/uapi/asm/fcntl.h | 3 + arch/mips/include/uapi/asm/errno.h | 2 + arch/parisc/include/uapi/asm/errno.h | 2 + arch/parisc/include/uapi/asm/fcntl.h | 3 + arch/sparc/include/uapi/asm/errno.h | 2 + arch/sparc/include/uapi/asm/fcntl.h | 3 + fs/cifs/cifsacl.c | 2 + fs/cifs/cifsfs.c | 2 +- fs/cifs/cifsglob.h | 17 +- fs/cifs/cifssmb.c | 2 +- fs/cifs/dir.c | 6 + fs/cifs/file.c | 20 ++- fs/cifs/inode.c | 12 +- fs/cifs/link.c | 2 + fs/cifs/netmisc.c | 2 +- fs/cifs/smb1ops.c | 3 + fs/cifs/smb2inode.c | 1 + fs/cifs/smb2maperror.c | 2 +- fs/cifs/smb2ops.c | 6 + fs/cifs/smb2pdu.c | 2 +- fs/fcntl.c | 5 +- fs/locks.c | 161 ++++++++++++++++-- fs/namei.c | 56 +++++- fs/nfs/dir.c | 39 ++++- fs/nfs/inode.c | 8 +- fs/nfs/internal.h | 3 +- fs/nfs/nfs4_fs.h | 83 ++++++++- fs/nfs/nfs4file.c | 8 +- fs/nfs/nfs4proc.c | 310 +++++++++++++++++++++++----------- fs/nfs/nfs4state.c | 65 ++++--- fs/nfs/nfs4super.c | 9 +- fs/nfs/nfs4xdr.c | 21 ++- fs/nfs/super.c | 7 +- fs/nfsd/nfs4state.c | 46 ++++- fs/nfsd/nfsproc.c | 1 + fs/proc_namespace.c | 1 + include/linux/fs.h | 15 ++ include/linux/nfs_fs.h | 5 +- include/linux/nfs_xdr.h | 1 + include/uapi/asm-generic/errno.h | 2 + include/uapi/asm-generic/fcntl.h | 12 ++ include/uapi/linux/fs.h | 1 + 43 files changed, 789 insertions(+), 166 deletions(-) -- 1.7.10.4

4 18

Re: Assorted typos fixes (resend)
by Michael Stefaniuc 04 Feb '14

04 Feb '14

Hello Andrey, On 02/04/2014 12:19 PM, Andrey Gusev wrote: > diff --git a/dlls/dpnet/client.c b/dlls/dpnet/client.c > index 637dcb8..e94eea6 100644 > --- a/dlls/dpnet/client.c > +++ b/dlls/dpnet/client.c > @@ -54,7 +54,7 @@ static HRESULT WINAPI IDirectPlay8ClientImpl_QueryInterface(IDirectPlay8Client * > return DPN_OK; > } > > - WARN("(%p)->(%s,%p),not found\n",This,debugstr_guid(riid),ppobj); > + WARN("(%p)->(%s,%p), not found\n",This,debugstr_guid(riid),ppobj); when you do those can you please fix the obvious whitespace issues and add a space after the "," in the argument list? thanks bye michael

1 0

Re: Assorted typos fixes
by Alexandre Julliard 04 Feb '14

04 Feb '14

Andrey Gusev <andrey.goosev(a)gmail.com> writes: > @@ -81,6 +81,6 @@ HRESULT WINAPI DllGetClassObject(REFCLSID rclsid, REFIID riid, LPVOID *ppv) > */ > HRESULT WINAPI DllUnregisterServer(void) > { > - FIXME(":stub\n"); > + FIXME(": stub\n"); I'm not against fixing real typos, but please don't overdo it, that kind of whitespace change is not necessary. -- Alexandre Julliard julliard(a)winehq.org

1 0