February 2014 - Wine-devel - list.winehq.org

Re: [PATCH] winegcc: Don't set stdcall and fastcall attributes on ARM.
by Alexandre Julliard 26 Feb '14

26 Feb '14

Grazvydas Ignotas <notasas(a)gmail.com> writes: > Otherwise we get lots of "attribute directive ignored" warnings. > Wine headers can take care defining __stdcall to nothing on ARM. If we wanted to rely on the headers we wouldn't need any of this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3d9/tests: Fix some test failures on Windows 2000.
by Bruno Jesus 26 Feb '14

26 Feb '14

On Mon, Feb 24, 2014 at 7:54 PM, Francois Gouget <fgouget(a)codeweavers.com> wrote: > --- > > This fixes some tests on the WineTestBot VM. > > dlls/d3d9/tests/device.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) I was not aware that we are adding broken for Windows 2000. Otherwise I would not have sent http://source.winehq.org/git/wine.git/commitdiff/de0c46fd52b9f9f4ebfff256c7… I thought broken was for <= NT only. Bruno

2 1

Re: user32: Check WS_CHILD style in IsChild function (try3)
by Marvin 26 Feb '14

26 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5184 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0003007A fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030150 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040024 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000501BA fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000300F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w7pro64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040140 fg 00010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040190 fg 00010048 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6189: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000501BA fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000300F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040140 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Re: user32: Check WS_CHILD style in IsChild function (try2)
by Marvin 26 Feb '14

26 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5182 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0003007A fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00030150 fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040024 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000501BA fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000300F4 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00040190 fg 00010048 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6189: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000501BA fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000300F4 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000040140 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

1 0

Patch to fix bug 34324
by Zhenbo Li 26 Feb '14

26 Feb '14

Hello, I've been working on http://bugs.winehq.org/show_bug.cgi?id=34324. Till now, I have found two solutions, one is simple and one is complex. Both of them would fix #34324, and I don't know which one is better. As Alexandre Julliard mentioned[1], I would use the value of GetLastError() as the return (error) value in delete_files(). The simple patch would fix part of the 'todo_wine' marks. Meanwhile, the complex patch would fix *all* todo marks about return value in test_delete(). I really appreciate your help (especially for Dmitry Timoshkov, thank you very much). And I'm looking for your feedbacks. Thank you. [1]: http://markmail.org/message/fblet7gadeusyauv#query:+page:1+mid:6eu2a72uuchh… -- Have a nice day! Zhenbo Li

2 5

Re: usp10: Use BOOL type where appropriate
by Nikolay Sivov 26 Feb '14

26 Feb '14

On 2/26/2014 11:12, Frédéric Delanoy wrote: > cf. http://msdn.microsoft.com/en-us/library/windows/desktop/dd374096%28v=vs.85%… > --- > dlls/usp10/opentype.c | 32 ++++++++++++++++---------------- > dlls/usp10/shape.c | 36 ++++++++++++++++++------------------ > dlls/usp10/usp10.c | 26 +++++++++++++------------- > 3 files changed, 47 insertions(+), 47 deletions(-) > > diff --git a/dlls/usp10/opentype.c b/dlls/usp10/opentype.c > index 166d823..5b3bdc7 100644 > --- a/dlls/usp10/opentype.c > +++ b/dlls/usp10/opentype.c > @@ -645,34 +645,34 @@ void OpenType_GDEF_UpdateGlyphProps(ScriptCache *psc, const WORD *pwGlyphs, cons > { > case 0: > case BaseGlyph: > - pGlyphProp[i].sva.fClusterStart = 1; > - pGlyphProp[i].sva.fDiacritic = 0; > - pGlyphProp[i].sva.fZeroWidth = 0; > + pGlyphProp[i].sva.fClusterStart = TRUE; > + pGlyphProp[i].sva.fDiacritic = FALSE; > + pGlyphProp[i].sva.fZeroWidth = FALSE; > break; I think it's a wrong change.Even if msdn says you can use TRUE/FALSE here, field is not defined as of 'BOOL' type.

3 5

Re: [PATCH] oleaut32: Implement DISPID_PICT_RENDER dispid
by Alistair Leslie-Hughes 26 Feb '14

26 Feb '14

On 26/02/2014 8:05 PM, Nikolay Sivov wrote: > --- > dlls/oleaut32/olepicture.c | 51 ++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 47 insertions(+), 4 deletions(-) > I submitted a similar patch http://www.winehq.org/pipermail/wine-patches/2011-December/109566.html It was rejected because it lacked tests. Best Regards Alistair Leslie-Hughes

2 1

Re: usp10/tests: Use BOOL type where appropriate
by Marvin 26 Feb '14

26 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5166 Your paranoid android. === w8 (32 bit usp10) === usp10.c:497: Test failed: 0:Wrong fRTL(0) usp10.c:497: Test failed: 0:Wrong fLayoutRTL(0) usp10.c:497: Test failed: 0:Wrong BidiLevel(0) usp10.c:498: Test failed: 1:Wrong fRTL(0) usp10.c:498: Test failed: 1:Wrong fLayoutRTL(0) usp10.c:498: Test failed: 1:Wrong BidiLevel(0)

1 0

Getting Introduced with the Community and Looking forward to Contribute to the Project as part of Gsoc 2014
by Gaurav Bansal 26 Feb '14

26 Feb '14

Hi, Firstly I, Gaurav would like to introduce myself to the developers of this commmunity. I am a sophomore from Birla Institute of Science and Technology Pilani, India currently pursuing Bachelors in Computer Science and Engineering. My skills include Programming languages: GNU C/C++, Python, Java,PHP/MySQL Version control systems and Git/Github. I am also aware with many of the web development application tools and content management systems. I am an ambitous person willing to learn other technologies when need in future. I choose this organisation for the contribution as the work the community does looks very appealing and interesting to me and useful for the whole community. The skills used by the organisation for the development of open source software matches with my skills to much extent. I had installed the required necessary tools and setup the environment in my system needed for the contribution to open source software. I had got myself aware of the source to some extent. I had also read the contribution, development tutorial on the community webpage. I would like to seek the mentors help in the selection of the project for which the idea has been proposed for the Gsoc and someone is willing to mentor the project idea. I will highly appreciate with any kind of help, guidance from the mentors to help me move forward to contribute to the software starting off with some easy tasks and then moving levels higher so as to make a strong proposal for the upcoming Google Summer of Code 2014. [1] Github : https://github.com/gauravb7090 [2] IRC : gauravb7090 *--Gaurav*

1 0

Re: user32: Check WS_CHILD style in IsChild function
by Marvin 25 Feb '14

25 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5155 Your paranoid android. === w2000pro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00050094 fg 00020036 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wxppro (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005013E fg 00030052 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === wvista (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000602B4 fg 00020222 in hook HCBT_ACTIVATE === wvistau64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000C0132 fg 0001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w2008s64 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 000600F0 fg 0001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 === w8 (32 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0005018C fg 00010048 in hook HCBT_ACTIVATE win.c:6397: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1010000: window rect 0,0-1024,768 win.c:6397: Test failed: 0x80/0x81c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x40000/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x80/0x41c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6397: Test failed: 0x80/0x1c50000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1050000: window rect 0,0-1024,768 win.c:6397: Test failed: 0x80/0x1c10000: window rect 0,0-1024,768 must be in 0,0-1024,728 win.c:6419: Test failed: 0x80/0x1410000: window rect 0,0-1024,768 win.c:2952: Test failed: GetActiveWindow() = 00000000 win.c:2952: Test failed: GetFocus() = 00000000 win.c:2975: Test failed: GetActiveWindow() = 00000000 win.c:2975: Test failed: GetFocus() = 00000000 win.c:3036: Test failed: GetActiveWindow() = 00000000 win.c:3036: Test failed: GetFocus() = 00000000 win.c:6180: Test failed: wrong error 31 === wvistau64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000C0132 fg 000000000001006A in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w2008s64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 00000000000600F0 fg 000000000001004E in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000 === w7pro64 (64 bit win) === win.c:892: Test failed: wrong dwWindowStatus: 0001 != 0000 active 0000000000060106 fg 0000000000010064 in hook HCBT_ACTIVATE win.c:2952: Test failed: GetActiveWindow() = 0000000000000000 win.c:2952: Test failed: GetFocus() = 0000000000000000 win.c:2975: Test failed: GetActiveWindow() = 0000000000000000 win.c:2975: Test failed: GetFocus() = 0000000000000000 win.c:3036: Test failed: GetActiveWindow() = 0000000000000000 win.c:3036: Test failed: GetFocus() = 0000000000000000

2 1