February 2014 - Wine-devel - list.winehq.org

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure.
by Henri Verbeet 25 Feb '14

25 Feb '14

On 24 February 2014 15:37, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -1976,6 +1976,19 @@ static inline void context_invalidate_active_texture(struct wined3d_context *con > context_invalidate_state(context, STATE_SAMPLER(sampler)); > } > > +struct wined3d_privstore > +{ > + struct list content; > +}; > + > +struct wined3d_privstore *wined3d_privstore_create(void) DECLSPEC_HIDDEN; > +void wined3d_privstore_destroy(struct wined3d_privstore *store) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_free_private_data(struct wined3d_privstore *store, const GUID *guid); > +HRESULT wined3d_privstore_get_private_data(const struct wined3d_privstore *store, > + const GUID *guid, void *data, DWORD *data_size, BOOL addref) DECLSPEC_HIDDEN; > +HRESULT wined3d_privstore_set_private_data(struct wined3d_privstore *store, > + const GUID *guid, const void *data, DWORD data_size, DWORD flags) DECLSPEC_HIDDEN; > + > #define WINED3D_RESOURCE_ACCESS_GPU 0x1 > #define WINED3D_RESOURCE_ACCESS_CPU 0x2 > I'm not entirely convinced this is how we want this to work. Calling HeapAlloc() for a struct list seems less than ideal, and I'd like the WINED3DSPD_IUNKNOWN handling to be done by the callers.

2 1

Re: [2/2] bcrypt/tests: Added conformance test for BCryptGetFipsAlgorithmMode (try 3)
by Bruno Jesus 25 Feb '14

25 Feb '14

Please rebase and resend your patches. On Fri, Jan 24, 2014 at 5:46 PM, Kai Blaschke <kai.blaschke(a)kb-dev.net> wrote: > Load registry functions dynamically, test caused an error message box to pop > up on Windows XP instead of skipping the test, causing a timout error. > > Test now queries registry values to compare them with the function's result. > > --- > configure | 1 + > configure.ac | 1 + > dlls/bcrypt/tests/Makefile.in | 4 ++ > dlls/bcrypt/tests/bcrypt.c | 107 > ++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 113 insertions(+) > > >

1 0

Re: Raise the minimum version of FreeBSD to 8.0. (PING)
by Lauri Kenttä 25 Feb '14

25 Feb '14

On 2014-02-24 00:15, Gerald Pfeifer wrote: > Any problem why this patch was not included yet? At least you have not changed all 7.0's to 8.0's, for example README.sv: "FreeBSD-versioner äldre än 7.0." -- Lauri Kenttä

1 0

Re: winmm/tests: Change the current directory to a place that will be writable.
by Marvin 25 Feb '14

25 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5140 Your paranoid android. === w8 (32 bit mci) === mci.c:1123: Test failed: got 0001 instead of MCI_NOTIFY_xyz 0004 from command play (aborted by close)

2 1

Re: Assorted typos fixes (try 2)
by Nikolay Sivov 25 Feb '14

25 Feb '14

On 2/25/2014 13:53, Andrey Gusev wrote: > --- a/dlls/dssenh/tests/dssenh.c > +++ b/dlls/dssenh/tests/dssenh.c > @@ -405,7 +405,7 @@ struct hash_test { > }; > > static const char testHashVal1[] = "I love working with Wine"; > -static const char testHashVal2[] = "Wine is not an emulater."; > +static const char testHashVal2[] = "Wine is not an emulator."; > static const char testHashVal3[] = ""; > This breaks now. Don't forget to do a 'make test' after making changes to test data.

1 0

Suggested RFP: LinuxFest Northwest
by Jeremy White 25 Feb '14

25 Feb '14

As part of our new initiative, we're trying to encourage people to submit RFPs to give Wine talks. The Wine project can potentially help defray travel costs, although the ideal is to encourage folks that don't have to travel far. So here's one: http://linuxfestnorthwest.org/present LinuxFest Northwest. About 1500 Linux geeks. I'm told by an organizer that a Wine talk would be welcome. Anyone on the US West coast up for giving a talk? Cheers, Jeremy

3 2

Re: Assorted typos fixes (try 2)
by Marvin 25 Feb '14

25 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5149 Your paranoid android. === w2000pro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wxppro (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvista (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w8 (32 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === wvistau64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w2008s64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output. === w7pro64 (64 bit dssenh) === dssenh.c:470: Test failed: Incorrect hash output. dssenh.c:470: Test failed: Incorrect hash output.

1 0

Re: msi: Add tests for [un]registering progids.
by Marvin 24 Feb '14

24 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5134 Your paranoid android. === w2000pro (32 bit action) === action.c:6337: Test failed: Expected ERROR_SUCCESS, got 1603 action.c:6343: Test failed: key not created action.c:6347: Test failed: key not created action.c:6351: Test failed: key not created action.c:6355: Test failed: key not created action.c:6359: Test failed: key not created action.c:6363: Test failed: key not created action.c:6381: Test failed: Expected ERROR_SUCCESS, got 1605 === wxppro (32 bit action) === action.c:6337: Test failed: Expected ERROR_SUCCESS, got 1603 action.c:6343: Test failed: key not created action.c:6347: Test failed: key not created action.c:6351: Test failed: key not created action.c:6355: Test failed: key not created action.c:6359: Test failed: key not created action.c:6363: Test failed: key not created action.c:6381: Test failed: Expected ERROR_SUCCESS, got 1605

1 0

Re: [PATCH 2/5] wined3d: Make use of WGL_WINE_make_current extension to restore the previous GL context without reference to its DC.
by Henri Verbeet 24 Feb '14

24 Feb '14

On 23 February 2014 23:58, Ken Thomases <ken(a)codeweavers.com> wrote: > + if (gl_info->supported[WGL_WINE_MAKE_CURRENT] && > + !(gl_info->p_wglMakeContextCurrentWINE = (void *)wglGetProcAddress("wglMakeContextCurrentWINE"))) > + gl_info->supported[WGL_WINE_MAKE_CURRENT] = FALSE; Why can't load_gl_funcs() take care of this? > {"WGL_WINE_pixel_format_passthrough", WGL_WINE_PIXEL_FORMAT_PASSTHROUGH}, > + {"WGL_WINE_make_current", WGL_WINE_MAKE_CURRENT}, ... > WGL_WINE_PIXEL_FORMAT_PASSTHROUGH, > + WGL_WINE_MAKE_CURRENT, With the (obvious) exceptions of WINED3D_GL_EXT_NONE and WINED3D_GL_EXT_COUNT, the wined3d_gl_extension enum is supposed to be in lexicographical order.

2 2

Re: urlmon: Fixed some tests on IE11.
by Marvin 24 Feb '14

24 Feb '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5116 Your paranoid android. === w8 (32 bit protocol) === protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20 protocol.c:1388: Test failed: unexpected ulStringType 20

1 0