March 2014 - Wine-devel - list.winehq.org

Re: [PATCH] winedump: Improve typelib header dumping
by Jacek Caban 14 Mar '14

14 Mar '14

Hi Nikolay, On 03/14/14 14:48, Nikolay Sivov wrote: > + if (flags & 1) > + printf("%s%c", libflags[i++], flags & ~1 ? '|' : 0); > + flags >>= 1; i should be increased on each iteration, not only when the flag is found. Cheers, Jacek

1 1

Re: [PATCH] msxml3: Fix some test failures on Win8.1
by Alexandre Julliard 13 Mar '14

13 Mar '14

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > --- > dlls/msxml3/schema.c | 9 +++++++-- > dlls/msxml3/tests/domdoc.c | 28 +++++++++++++++++----------- > 2 files changed, 24 insertions(+), 13 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M msxml3.dll -p msxml3_test.exe.so schema && touch schema.ok schema.c:1526: Test failed: got 0x80004003, expected 0x80004001 make: *** [schema.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: vbscript: Allow empty brackets in argument declarations.
by Marvin 13 Mar '14

13 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5671 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found

1 0

Re: shell32: Supply a module name to CreateProcess (try 5)
by Alexandre Julliard 13 Mar '14

13 Mar '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Corrected the accidental line being removed. > > Changelog: > shell32: Supply a module name to CreateProcess It doesn't work: ../../../tools/runtest -q -P wine -T ../../.. -M shell32.dll -p shell32_test.exe.so shlexec && touch shlexec.ok Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA4 expected 'p2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p3', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 10, but got 10 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1446: Test failed: ShellExecuteEx(mask="0x200", verb="Params20", file="C:\users\julliard\Temp\wtcedd.tmp\test file.shlexec", params="p"): the cmdline is '(null)' instead of ' "p0"' shlexec.c:1457: Test failed: argvA4 expected 'p0', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1446: Test failed: ShellExecuteEx(mask="0x200", verb="Params23456", file="C:\users\julliard\Temp\wtcedd.tmp\test file.shlexec", params="'p2 p3` p4\ $even"): the cmdline is '(null)' instead of ' "'p2" "p3`" "p4\" "$even" ""' shlexec.c:1457: Test failed: argvA4 expected ''p2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p3`', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA4 expected 'p=2', but key not found or empty shlexec.c:1457: Test failed: argvA5 expected 'p-3', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 12, but got 12 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1457: Test failed: argvA8 expected '', but key not found or empty shlexec.c:1457: Test failed: argvA9 expected '', but key not found or empty shlexec.c:1457: Test failed: argvA10 expected '', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 12, but got 12 Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 9, but got 9 shlexec.c:1457: Test failed: argvA8 expected '', but key not found or empty Fatal: test 'file.shlexec' does not exist. shlexec.c:218: Test failed: WaitForSingleObject returned 258 shlexec.c:1436: Test succeeded inside todo block: argcA expected 9, but got 9 Fatal: test 'file.shlexec' does not exist. etc. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: riched20/tests: Fix a SysAllocString leak
by Nikolay Sivov 13 Mar '14

13 Mar '14

On 3/12/2014 19:36, Jactry Zeng wrote: > I made this leak, sorry.. :( > "What goes around comes around" was confirmed! :p > VariantInit(&testfile); > V_VT(&testfile) = VT_BSTR; > V_BSTR(&testfile) = SysAllocString(filename); No need for VariantInit() here. > + SysFreeString(V_BSTR(&testfile)); It's cleaner to use VariantClear().

2 1

Re: [PATCH 4/4] mshtml: Added support for target attribute in submit function implementation.
by Qian Hong 13 Mar '14

13 Mar '14

Hi Jacek, + + hres = get_frame_by_name(top_window, target, TRUE, &ret_window); + if(FAILED(hres) || !window) { + *use_new_window = TRUE; + return NULL; + } Is there a typo here? Is "!window" suppose to be "!ret_window"? Thanks for the work!

2 1

Re: [PATCH 1/3] msvcrt: Improve tolower_l implementation (try2)
by Alexandre Julliard 13 Mar '14

13 Mar '14

Piotr Caban <piotr(a)codeweavers.com> writes: > + if(!WideCharToMultiByte(locinfo->lc_codepage, 0, > + &lower, 1, (char*)str, 2, NULL, NULL)) > + return c; You'd also have to handle the case of the length being just 1. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] msvcrt: Improve tolower_l implementation
by Alexandre Julliard 13 Mar '14

13 Mar '14

Piotr Caban <piotr(a)codeweavers.com> writes: > + if(!MultiByteToWideChar(locinfo->lc_codepage, > + MB_ERR_INVALID_CHARS, (char*)str, p-str, &wide, 1)) > + return c; > + > + lower = tolowerW(wide); > + if(lower == wide) > + return str[0] + (str[1]<<8); > + > + WideCharToMultiByte(locinfo->lc_codepage, 0, > + &lower, 1, (char*)str, 2, NULL, NULL); You should probably also check the resulting length here. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 3/5] d3d8/tests: Move some stateblock tests to device.c.
by Marvin 13 Mar '14

13 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5656 Your paranoid android. === w8 (32 bit device) === device.c:2396: Test failed: Expected foreground window 0005025E, got 00010048. device.c:3038: Test failed: Expected wndproc 0x411180, got 0x411180.

1 0

Re: TestBot job 5654 results: [PATCH] msxml3: Respect stylesheet output mode when dumping resulting document
by Nikolay Sivov 13 Mar '14

13 Mar '14

On 3/13/2014 15:41, Marvin wrote: > > === w8 (32 bit domdoc) === > > msxml3: > domdoc.c:10385: Test failed: got 00000000 > domdoc.c:10399: Test failed: got 00000000 > domdoc.c:10451: Test failed: got 0 > domdoc.c:10476: Test failed: got 00000000 > domdoc.c:10550: Test failed: got 00000000 > domdoc.c:10565: Test failed: got 00000000 > domdoc.c:10619: Test failed: got 0 > domdoc.c:11268: Test failed: got 00000000 > domdoc.c:11294: Test failed: got 00000000 This is unrelated, I'll send a patch.

1 0