March 2014 - Wine-devel - list.winehq.org

FYI Re: wined3d_mutex
by Max TenEyck Woodbury 17 Mar '14

17 Mar '14

I have told you about the long delays I have encountered with Guild Wars 2 under wine. I mentioned that I suspected the wined3d_mutex was the source of the problem. I have just finished a test that shows that it is NOT the source of this problem. Specifically, I dummied the wined3d_mutex_lock and wined3d_mutex_unloc procedures so that they did nothing, That version showed the same pattern of delays that the unaltered system showed. If anybody has an idea about what might be causing these delays, please tell me. Note that my review of the use of this mutex indicates that it is of very questionable value. In my opinion it should be replaced by a set of read/write locks built into the individual data structures. Comments? max

3 6

GSoC 2014: Mentor signups are open
by Austin English 17 Mar '14

17 Mar '14

Howdy, Signups for mentors is open. Please register at: https://www.google-melange.com/gsoc/org2/google/gsoc2014/wine Our ideas page is at http://wiki.winehq.org/SummerOfCode, if you have any ideas for projects. -- -Austin

3 4

Wine test week 1
by Jeremy White 17 Mar '14

17 Mar '14

My current view: http://www.winehq.org/~jwhite/2bb1059ad249.html We have about 32 tests that fail on the new test bots. Some of the failures are timing related; most of them look hard. We've made some solid progress (There is new yellow on our main page. Yay!) I'm going to stop being so chatty; I'll try to work each day to annotate one more test, and then circle back in a few weeks with a summary. Cheers, Jeremy

1 0

Re: dpnet: Forward declare IDirectPlay8Address when you include dpaddr.h (resend)
by Alexandre Julliard 17 Mar '14

17 Mar '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > Changelog: > dpnet: Forward declare IDirectPlay8Address when you include dpaddr.h You can't do that: In file included from dxerr9.c:38: ../../include/dplay8.h:30: error: redefinition of typedef 'IDirectPlay8Address' ../../include/dpaddr.h:222: error: previous declaration of 'IDirectPlay8Address' was here make[1]: *** [dxerr9.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: kernel32: improve GetNumaHighestNodeNumber
by Matteo Bruni 17 Mar '14

17 Mar '14

2014-03-17 11:56 GMT+01:00 Austin English <austinenglish(a)gmail.com>: > Fixes https://bugs.winehq.org/show_bug.cgi?id=35596 > > -- > -Austin > > diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c > index 60156aa..86055d3 100644 > --- a/dlls/kernel32/process.c > +++ b/dlls/kernel32/process.c > @@ -3911,9 +3911,9 @@ HRESULT WINAPI RegisterApplicationRecoveryCallback(APPLICATION_RECOVERY_CALLBACK */ > BOOL WINAPI GetNumaHighestNodeNumber(PULONG highestnode) > { > - FIXME("(%p): stub\n", highestnode); > - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); > - return FALSE; > + *highestnode = 0; > + WARN("(%p): semi-stub\n", highestnode); > + return TRUE; Not a big deal I guess but I don't think WARN is appropriate here, it should still be a FIXME IMO.

1 0

Cross-regressions between wine and mesa: how to handle them?
by Ruslan Kabatsayev 17 Mar '14

17 Mar '14

Hi all, I've come across a problem, which may be simplest to see in the following workability diagram, tested on GTAVC on a i915 machine: _____________________________________________ Mesa_\_Wine_|__1.3.21__|__1.5.17__|__1.5.24+_| ____9.0_____|____OK____|____OK____|___slow___| ___~9.1-____|____OK____|___slow___|___slow___| ___~9.1+____|____OK____|_GL_error_|_GL_error_| Here ~9.1- and ~9.1+ are bisected commits between 9.0 and 9.1, with "-" earlier commit and "+" later one. "slow" means slide show instead of normal animation. "GL error" is a set of errors like "err:d3d:device_clear_render_targets >>>>>>>>>>>>>>>>> GL_INVALID_FRAMEBUFFER_OPERATION (0x506) from glClear @ device.c / 677". Wine version 1.5.24+ means any wine newer than 1.5.24 up to 1.7.11. All these things are related to wine trying to use GLSL as much as possible, and Mesa trying to make it seem that it supports OpenGL 2+, even on chips like i915, which don't support it. For end user this looks like failing software, and moreover, it's not easy to understand which software does have bug. Wine perspective: On the one hand, wine seems to use what Mesa exposes. On the other, why use shaders for games which don't need them? Mesa perspective: On the one hand, it wants to advertise more support for latest OpenGL standards. On the other, why do it for very old HW which doesn't support it? So, I'm not sure where I should report these regressions - to bugs.winehq.org or to bugs.freedesktop.org? I remember some similar bugs reported to wine being closed as UPSTREAM (e.g. bug 33964), and fixed (or worked around?) in Mesa. But on the other hand, wine 1.3 worked perfectly for all Mesa versions - is it really Mesa fault that newer versions of wine don't work? Could someone please explain how to handle such situations? Regards, Ruslan

4 13

Re: [PATCH 5/5] wined3d: Remove the version parameter.
by Henri Verbeet 17 Mar '14

17 Mar '14

On 16 March 2014 20:39, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h > index 7bb37d6..df725e2 100644 > --- a/include/wine/wined3d.h > +++ b/include/wine/wined3d.h > @@ -1221,6 +1221,7 @@ enum wined3d_display_rotation > #define WINED3D_NO3D 0x00000002 > #define WINED3D_VIDMEM_ACCOUNTING 0x00000004 > #define WINED3D_PRESENT_CONVERSION 0x00000008 > +#define WINED3D_ALLOW_3D_DISABLE 0x00000010 > Do we really need this? It's perhaps unfortunate that setting "DirectDrawRenderer" to "gdi" would also prevent 3D in d3d8+, but I'm not sure if avoiding that is really worth an extra flag.

2 2

Re: [PATCH] widl: Fix default value types
by Alexandre Julliard 17 Mar '14

17 Mar '14

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > http://bugs.winehq.org/show_bug.cgi?id=35778 > > --- > tools/widl/write_msft.c | 29 +++++++++++++++++++++++++---- > 1 file changed, 25 insertions(+), 4 deletions(-) This is causing warning: can't write value of type 29 yet during the build, that's probably not good. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: rpcrt4/tests: Add a couple of tests for marshalling an array of strings.
by Marvin 17 Mar '14

17 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5719 Your paranoid android. === w2000pro (32 bit server) === server.c:1241: Test failed: expected Hello, got H# server.c:1243: Test failed: expected World!, got W# server.c:1253: Test failed: expected Hello, got L"H#\0178#\4d4c\4d45\86b8#\8640#" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H# server.c:1243: Test failed: expected World!, got W# server.c:1253: Test failed: expected Hello, got L"H#\0178#\4d4c\4d45\6868#\67c0#" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H# server.c:1243: Test failed: expected World!, got W# server.c:1253: Test failed: expected Hello, got L"H#\0198#\4d4c\4d45\7280#\6288#\7280#\0003\0004\0100\000c" server.c:1255: Test failed: expected World!, got L"W" === wxppro (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W$ server.c:1253: Test failed: expected Hello, got L"H$\01b8$\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H$ server.c:1243: Test failed: expected World!, got W$ server.c:1253: Test failed: expected Hello, got L"H$\0178$\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H$ server.c:1243: Test failed: expected World!, got W$ server.c:1253: Test failed: expected Hello, got L"H$\0408$\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W" === wvista (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === wvistau64 (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"Hdow\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"Wem3\4d4c\4d45\0008" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"Hem3\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"W;C:\4d4c\4d45\0008" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"Hdow\4d4c\4d45\0008" server.c:1255: Test failed: expected World!, got L"Wem3\4d4c\4d45\0008" === w2008s64 (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w7pro64 (32 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w8 (32 bit server) === server.c:984: Test failed: get_ranged_enum() returned 1997012995 instead of RE3 server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:984: Test failed: get_ranged_enum() returned -65533 instead of RE3 server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:984: Test failed: get_ranged_enum() returned 1997012995 instead of RE3 server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === wvistau64 (64 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w2008s64 (64 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" === w7pro64 (64 bit server) === server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W" server.c:1241: Test failed: expected Hello, got H server.c:1243: Test failed: expected World!, got W server.c:1253: Test failed: expected Hello, got L"H" server.c:1255: Test failed: expected World!, got L"W"

3 2

Re: [PATCH 1/2] ddraw/tests: Add mipmap private data tests (try 2).
by Marvin 16 Mar '14

16 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5717 Your paranoid android. === w8 (32 bit ddraw4) === Failure running script in VM: timed out waiting for the child process

1 0