March 2014 - Wine-devel - list.winehq.org

Re: StrCatChainW implementation
by Nikolay Sivov 07 Mar '14

07 Mar '14

On 3/6/2014 15:17, Huw Campbell wrote: > Hello > > Please see my implementation of this function, which has not been > seen in wine previously. Explorer.exe calls it, so it's kind of important. > > I ran a lot of tests on the edge cases: including: same ends, 0 ends, > end beyond the length... Hi, Huw. We need those tests in shlwapi/tests. Now regarding patch itself. > +DWORD WINAPI StrCatChainW(PWSTR pszDst, DWORD cchDst, DWORD ichAt, PCWSTR pszSrc) Please use lower case naming that's more readable, like 'dest', 'dest_len', 'at', 'src'. > +{ > + LPWSTR d = pszDst; > + LPCWSTR s = pszSrc; It doesn't look like you need this 'd' and 's', you could use passed pointers. > + DWORD mark; > + > + TRACE("(%s,%i,%i,%s)\n", debugstr_w(pszDst), cchDst, ichAt, debugstr_w(pszSrc)); Is it possible that destination buffer is uninitialized? In this case you can't trace in like this. > + > + if (ichAt == -1) > + mark = strlenW(pszDst); > + else > + mark = ichAt; > + if (mark > cchDst || cchDst == 0) > + return mark; > + if (mark == cchDst) > + mark--; > + d = d + mark; > + if (pszSrc) > + { > + while ((mark < cchDst-1) && *s) > + { > + mark++; > + *d++ = *s++; > + } > + } > + *d = 0; What happens if 'd' is null? Could this loop be replaced with StrNCatW or something similar? > + return mark; > +}

1 0

Re: [PATCH 2/3] gdiplus: Set outer pointer to NULL when image loading functions fail.
by Dmitry Timoshkov 07 Mar '14

07 Mar '14

Qian Hong <qhong(a)codeweavers.com> wrote: > @@ -1365,10 +1365,12 @@ GpStatus WINGDIPAPI GdipCreateBitmapFromFile(GDIPCONST WCHAR* filename, > if(!filename || !bitmap) > return InvalidParameter; > > + *bitmap = NULL; Is there an application that depends on this behaviour? > stat = GdipCreateStreamOnFile(filename, GENERIC_READ, &stream); > > if(stat != Ok) > - return stat; > + return InvalidParameter; Probably GdipCreateStreamOnFile should be fixed instead (with tests of course). > > stat = GdipCreateBitmapFromStream(stream, bitmap); > > @@ -2923,10 +2925,12 @@ GpStatus WINGDIPAPI GdipLoadImageFromFile(GDIPCONST WCHAR* filename, > if (!filename || !image) > return InvalidParameter; > > + *image = NULL; Same question as above. > stat = GdipCreateStreamOnFile(filename, GENERIC_READ, &stream); > > if (stat != Ok) > - return stat; > + return OutOfMemory; Same note about GdipCreateStreamOnFile. And I don't think that's a good idea to replicate weird return error codes without actually getting any memory allocation errors. -- Dmitry.

2 7

Re: [1/6] user32: Add a test for empty popup menus.
by Dmitry Timoshkov 07 Mar '14

07 Mar '14

Vincent Povirk <madewokherd(a)gmail.com> wrote: > Even with the message test (patch 3), I think this one is worthwhile > as it includes the cases of popup menu initialization in wndproc, and > reusing the HMENU after the error path. These patches look good to me. -- Dmitry.

1 0

Re: [PATCH 1/2] dinput8: Flush input events queue before calling GetDeviceData
by Marvin 07 Mar '14

07 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5461 Your paranoid android. === w8 (32 bit device) === device.c:125: Test failed: GetDeviceData() failed: 00000000 device.c:128: Test failed: GetDeviceData() failed: 00000000 cnt:0

1 0

Re: ws2_32/tests: Free TLS after WSACleanup
by Marvin 07 Mar '14

07 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5460 Your paranoid android. === w2000pro (32 bit sock) === sock: unhandled exception c0000005 at C0000241 === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 71AB4047 === w2008s64 (32 bit sock) === sock: unhandled exception c0000005 at 00000000

1 0

Re: [6/6] user32: Skip menu loop for empty popup menus.
by Marvin 07 Mar '14

07 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5456 Your paranoid android. === w8 (32 bit msg) === msg.c:5991: Test failed: Update region shouldn't be empty msg.c:6225: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6227: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:12121: Test failed: unexpected message 31f msg.c:12122: Test failed: bad wparam 1 msg.c:12132: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000

1 0

Re: [5/6] user32: Set capture on the owner of popup menus.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5455 Your paranoid android. === w8 (32 bit msg) === msg.c:5991: Test failed: Update region shouldn't be empty msg.c:6225: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6227: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:12121: Test failed: unexpected message 31f msg.c:12122: Test failed: bad wparam 1 msg.c:12132: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000

1 0

Re: [3/6] user32: Add message tests for TrackPopupMenu.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5454 Your paranoid android. === w8 (32 bit msg) === msg.c:5991: Test failed: Update region shouldn't be empty msg.c:6225: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6227: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:5997: Test failed: Regions are different msg.c:8398: Test failed: did not get expected count for minimum timeout (54 != ~64). msg.c:12121: Test failed: unexpected message 31f msg.c:12122: Test failed: bad wparam 1 msg.c:12132: Test failed: unicode WM_CHAR: 0: the msg sequence is not complete: expected 0102 - actual 0000

1 0

Re: [3/3] ws2_32/tests: Get rid of the do_oob_send helper function
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5420 Your paranoid android. === wvistau64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFF0720C0 === w2008s64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFE4220C0

3 4

Wine test day #2: an easy lob
by Jeremy White 06 Mar '14

06 Mar '14

So it looks like the easy test for the day is drag/drop: http://test.winehq.org/data/tests/ole32:dragdrop.html Evidence suggests both that Piotr broke it, but is also working to fix it, so I don't think I get to shame him publicly...yet <grin>. Cheers, Jeremy

3 3