March 2014 - Wine-devel - list.winehq.org

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure (try 5).
by Henri Verbeet 06 Mar '14

06 Mar '14

On 6 March 2014 16:59, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static inline HRESULT wined3d_private_store_free_private_data(struct wined3d_private_store *store, const GUID *guid) > +{ > + struct wined3d_private_data *entry; > + > + entry = wined3d_private_store_get_private_data(store, guid); > + if (!entry) > + return WINED3DERR_NOTFOUND; > + > + if (entry->flags & WINED3DSPD_IUNKNOWN) > + IUnknown_Release(entry->content.object); > + else > + HeapFree(GetProcessHeap(), 0, entry->content.data); > + > + list_remove(&entry->entry); > + HeapFree(GetProcessHeap(), 0, entry); > + > + return WINED3D_OK; > +} I think it would make more sense to pass this a struct wined3d_private_data pointer instead of a GUID.

2 1

Re: [PATCH] wined3d: Decouple private data from the resource structure (try 4).
by Alexandre Julliard 06 Mar '14

06 Mar '14

Stefan Dösinger <stefan(a)codeweavers.com> writes: > This supersedes patch 103000. > > Try 4: Replace a leftover return E_OUTOFMEMORY with return FALSE. > > Try 3: Move this out of wined3d and wined3d.h and use its own header > with inline functions. This is to avoid COM-related code inside wined3d > among other reasons. I don't think that justifies adding a new global header. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] wined3d: Decouple private data from the resource structure (try 3).
by Henri Verbeet 06 Mar '14

06 Mar '14

On 6 March 2014 10:42, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static inline BOOL wined3d_private_store_set_private_data(struct wined3d_private_store *store, > + const GUID *guid, const void *data, DWORD data_size, DWORD flags) ... > + return E_OUTOFMEMORY; That's pretty ugly.

2 1

Re: [PATCH 1/1] d3d9/tests: Use create_device() in more tests.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5436 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 5/5] d3d9/tests: Use create_device() in more tests.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5434 Your paranoid android. === w2000pro (32 bit device) === device: unhandled exception c0000005 at 00407D13 === wxppro (32 bit device) === device: unhandled exception c0000005 at 00407D13 === wvista (32 bit device) === device: unhandled exception c0000005 at 00407D13 === wvistau64 (32 bit device) === device: unhandled exception c0000005 at 00407D13 === w2008s64 (32 bit device) === device: unhandled exception c0000005 at 00407D13 === w7pro64 (32 bit device) === device: unhandled exception c0000005 at 00407D13 === wvistau64 (64 bit device) === device: unhandled exception c0000005 at 0000000000407038 === w2008s64 (64 bit device) === device: unhandled exception c0000005 at 0000000000407038 === w7pro64 (64 bit device) === device: unhandled exception c0000005 at 0000000000407038

1 0

Re: [PATCH 3/5] d3d8/tests: Don't bother handling Direct3DCreate8() failures, we verified it works earlier.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5431 Your paranoid android. === w8 (32 bit device) === device.c:2533: Test failed: Expected foreground window 00030180, got 00010048. device.c:3207: Test failed: Expected wndproc 0x410390, got 0x410390.

1 0

Re: [PATCH 2/5] ddraw/tests: Verify that creating a ddraw object works before running any real tests.
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5430 Your paranoid android. === w8 (32 bit ddraw2) === ddraw2.c:5071: Test failed: Got unexpected refcount 3. ddraw2.c:5090: Test failed: Got unexpected refcount 3. ddraw2.c:5097: Test failed: Got unexpected hr 0. ddraw2.c:5100: Test failed: Got unexpected refcount 3. ddraw2.c:5102: Test failed: Got unexpected refcount 2. ddraw2.c:5108: Test failed: Got unexpected hr 0. ddraw2.c:5111: Test failed: Got unexpected refcount 2. ddraw2.c:5113: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw1) === ddraw1.c:3968: Test failed: Got unexpected refcount 3. ddraw1.c:3987: Test failed: Got unexpected refcount 3. ddraw1.c:3994: Test failed: Got unexpected hr 0. ddraw1.c:3997: Test failed: Got unexpected refcount 3. ddraw1.c:3999: Test failed: Got unexpected refcount 2. ddraw1.c:4005: Test failed: Got unexpected hr 0. ddraw1.c:4008: Test failed: Got unexpected refcount 2. ddraw1.c:4010: Test failed: Got unexpected refcount 1. === w8 (32 bit ddraw7) === ddraw7.c:5595: Test failed: Got unexpected refcount 3. ddraw7.c:5614: Test failed: Got unexpected refcount 3. ddraw7.c:5621: Test failed: Got unexpected hr 0. ddraw7.c:5624: Test failed: Got unexpected refcount 3. ddraw7.c:5626: Test failed: Got unexpected refcount 2. ddraw7.c:5632: Test failed: Got unexpected hr 0. ddraw7.c:5635: Test failed: Got unexpected refcount 2. ddraw7.c:5637: Test failed: Got unexpected refcount 1. ddraw7.c:5639: Test failed: Got unexpected refcount 6. ddraw7.c:5756: Test failed: Failed to set cooperative level, hr 0x8876023b. === w8 (32 bit ddraw4) === The test timed out

1 0

Re: [2/3] ws2_32/tests: Test OOB data more sequential by sending bidirectional
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5419 Your paranoid android. === wvistau64 (64 bit sock) === sock: unhandled exception c0000005 at 000007FEFF0720C0

1 0

Re: [1/3] ws2_32/tests: Call WSACleanup only once
by Marvin 06 Mar '14

06 Mar '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=5418 Your paranoid android. === w2000pro (32 bit sock) === sock.c:613: Test failed: oob_server (464): unexpectedly at the OOB mark: 0 === wxppro (32 bit sock) === sock.c:613: Test failed: oob_server (b24): unexpectedly at the OOB mark: 0 === wvistau64 (32 bit sock) === sock.c:613: Test failed: oob_server (744): unexpectedly at the OOB mark: 0 === w2008s64 (32 bit sock) === sock.c:613: Test failed: oob_server (768): unexpectedly at the OOB mark: 0 === wvistau64 (64 bit sock) === sock.c:613: Test failed: oob_server (744): unexpectedly at the OOB mark: 0 === w2008s64 (64 bit sock) === sock.c:613: Test failed: oob_server (654): unexpectedly at the OOB mark: 0

1 0

Re: kernel32: Cache locale info from the registry.
by Alexandre Julliard 05 Mar '14

05 Mar '14

Vincent Povirk <madewokherd(a)gmail.com> writes: > + case LOCALE_ICALENDARTYPE: *cache_index = 0; return iCalendarTypeW; > + case LOCALE_ICURRDIGITS: *cache_index = 1; return iCurrDigitsW; > + case LOCALE_ICURRENCY: *cache_index = 2; return iCurrencyW; > + case LOCALE_IDIGITS: *cache_index = 3; return iDigitsW; > + case LOCALE_IFIRSTDAYOFWEEK: *cache_index = 4; return iFirstDayOfWeekW; > + case LOCALE_IFIRSTWEEKOFYEAR: *cache_index = 5; return iFirstWeekOfYearW; > + case LOCALE_ILZERO: *cache_index = 6; return iLZeroW; > + case LOCALE_IMEASURE: *cache_index = 7; return iMeasureW; > + case LOCALE_INEGCURR: *cache_index = 8; return iNegCurrW; > + case LOCALE_INEGNUMBER: *cache_index = 9; return iNegNumberW; > + case LOCALE_IPAPERSIZE: *cache_index = 10; return iPaperSizeW; > + case LOCALE_ITIME: *cache_index = 11; return iTimeW; > + case LOCALE_S1159: *cache_index = 12; return s1159W; > + case LOCALE_S2359: *cache_index = 13; return s2359W; > + case LOCALE_SCURRENCY: *cache_index = 14; return sCurrencyW; > + case LOCALE_SDATE: *cache_index = 15; return sDateW; > + case LOCALE_SDECIMAL: *cache_index = 16; return sDecimalW; > + case LOCALE_SGROUPING: *cache_index = 17; return sGroupingW; > + case LOCALE_SLIST: *cache_index = 18; return sListW; > + case LOCALE_SLONGDATE: *cache_index = 19; return sLongDateW; > + case LOCALE_SMONDECIMALSEP: *cache_index = 20; return sMonDecimalSepW; > + case LOCALE_SMONGROUPING: *cache_index = 21; return sMonGroupingW; > + case LOCALE_SMONTHOUSANDSEP: *cache_index = 22; return sMonThousandSepW; > + case LOCALE_SNEGATIVESIGN: *cache_index = 23; return sNegativeSignW; > + case LOCALE_SPOSITIVESIGN: *cache_index = 24; return sPositiveSignW; > + case LOCALE_SSHORTDATE: *cache_index = 25; return sShortDateW; > + case LOCALE_STHOUSAND: *cache_index = 26; return sThousandW; > + case LOCALE_STIME: *cache_index = 27; return sTimeW; > + case LOCALE_STIMEFORMAT: *cache_index = 28; return sTimeFormatW; > + case LOCALE_SYEARMONTH: *cache_index = 29; return sYearMonthW; You clearly want some sort of array here. -- Alexandre Julliard julliard(a)winehq.org

1 0