April 2014 - Wine-devel - list.winehq.org

Re: [PATCH 3/5] ddraw: Validate the pitch for user memory surfaces against the unaligned minimum pitch.
by Marvin 24 Apr '14

24 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6514 Your paranoid android. === w864 (32 bit ddraw2) === ddraw2.c:5096: Test failed: Got unexpected refcount 3. ddraw2.c:5115: Test failed: Got unexpected refcount 3. ddraw2.c:5122: Test failed: Got unexpected hr 0. ddraw2.c:5125: Test failed: Got unexpected refcount 3. ddraw2.c:5127: Test failed: Got unexpected refcount 2. ddraw2.c:5133: Test failed: Got unexpected hr 0. ddraw2.c:5136: Test failed: Got unexpected refcount 2. ddraw2.c:5138: Test failed: Got unexpected refcount 1. === w864 (32 bit ddraw1) === ddraw1.c:3991: Test failed: Got unexpected refcount 3. ddraw1.c:4010: Test failed: Got unexpected refcount 3. ddraw1.c:4017: Test failed: Got unexpected hr 0. ddraw1.c:4020: Test failed: Got unexpected refcount 3. ddraw1.c:4022: Test failed: Got unexpected refcount 2. ddraw1.c:4028: Test failed: Got unexpected hr 0. ddraw1.c:4031: Test failed: Got unexpected refcount 2. ddraw1.c:4033: Test failed: Got unexpected refcount 1. === wxppro (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00247AE8. ddraw7: unhandled exception c0000005 at 0045C03B === wvista (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 00314A78. ddraw7: unhandled exception c0000005 at 0045C03B === w2008s64 (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 005BFE60. ddraw7: unhandled exception c0000005 at 0045C03B === w7u (32 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 00000000, expected 0076BEB8. ddraw7: unhandled exception c0000005 at 0045C03B === w864 (32 bit ddraw7) === ddraw7.c:5629: Test failed: Got unexpected refcount 3. ddraw7.c:5648: Test failed: Got unexpected refcount 3. ddraw7.c:5655: Test failed: Got unexpected hr 0. ddraw7.c:5658: Test failed: Got unexpected refcount 3. ddraw7.c:5660: Test failed: Got unexpected refcount 2. ddraw7.c:5666: Test failed: Got unexpected hr 0. ddraw7.c:5669: Test failed: Got unexpected refcount 2. ddraw7.c:5673: Test failed: Got unexpected refcount 6. ddraw7.c:5790: Test failed: Failed to set cooperative level, hr 0x8876023b. === w2008s64 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 0000000000762980. ddraw7: unhandled exception c0000005 at 00000000004520D1 === w864 (64 bit ddraw7) === ddraw7.c:5652: Test failed: Got unexpected palette 0000000000000000, expected 00000000007150E0. ddraw7: unhandled exception c0000005 at 00000000004520D1 === w864 (32 bit ddraw4) === ddraw4.c:5756: Test failed: Got unexpected refcount 3. ddraw4.c:5775: Test failed: Got unexpected refcount 3. ddraw4.c:5782: Test failed: Got unexpected hr 0. ddraw4.c:5785: Test failed: Got unexpected refcount 3. ddraw4.c:5787: Test failed: Got unexpected refcount 2. ddraw4.c:5793: Test failed: Got unexpected hr 0. ddraw4.c:5796: Test failed: Got unexpected refcount 2. ddraw4.c:5798: Test failed: Got unexpected refcount 1. ddraw4.c:5800: Test failed: Got unexpected refcount 6. ddraw4.c:5920: Test failed: Failed to set cooperative level, hr 0x8876023b. ddraw4.c:5959: Test failed: Failed to attach surface, hr 0x887600e1. ddraw4.c:5962: Test failed: Got unexpected hr 0. ddraw4.c:5964: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5967: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5970: Test failed: Got unexpected hr 0x887601c2. ddraw4.c:5972: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5975: Test failed: Failed to attach surface, hr 0x887601c2. ddraw4.c:5977: Test failed: Failed to detach surface, hr 0x887601c2. ddraw4.c:5980: Test failed: Got unexpected hr 0x887600e1. ddraw4.c:5982: Test failed: Got unexpected hr 0x887601c2.

1 0

GSoC 2014 - accepted proposals announcement
by Austin English 23 Apr '14

23 Apr '14

The accepted proposals for Google's Summer of Code 2014 have been announced. We have accepted 4 proposals this year. * Implement missing and improve existing D3DX9 APIs - by Gediminas Jakutis, mentored by: Matteo Bruni and Stefan Dösinger * Implement ITextDocument::Range and ITextRange - by Jactry Zeng, mentored by Huw Davies and André Hentschel * Implement VBScript built-in functions - by Shuai Meng, mentored by Piotr Caban and Detlef Riekenberg * Implemention for mshtml.dll - by Zhenbo Li, mentored by Jacek Caban and Ulrich Czekalla Congratulations! Students, this is the community bonding period ( http://googlesummerofcode.blogspot.com/2007/04/so-what-is-this-community-bo…) which you should use to get up to speed on your project. In other words, discuss your goals/milestones with your mentors, reviewing bugs in those areas, reading the code, etc. Coding begins May 19th, and mid term reviews are June 23-27th. If you have any GSoC questions, please contact your mentors or the administrators (myself and André Hentschel). Technical questions should be discussed with your mentor or on wine-devel/#winehackers on Freenode IRC. Once again, congratulations! Welcome to Wine, and good luck on your project. -- -Austin

1 0

Re: wined3d: Add NVIDIA Geforce GTX 780 Ti to supported device list
by Henri Verbeet 23 Apr '14

23 Apr '14

On 23 April 2014 00:17, André Hentschel <nerv(a)dawncrow.de> wrote: > Information gathered at: > http://pci-ids.ucw.cz/read/PC/10de > https://freedesktop.org/nouveau/CodeNames/ > http://www.nvidia.de/object/geforce-gtx-780-ti-de.html#pdpContent=2 > > Should i rather add a whole bunch of cards using these sources of information? > I'd prefer this kind of patch to be verified against the actual Windows and Linux drivers.

1 0

Re: [PATCH] vbscript: Implemented IsNumeric
by Jacek Caban 23 Apr '14

23 Apr '14

On 04/23/14 02:20, Shuai Meng wrote: > --- a/dlls/vbscript/global.c > +++ b/dlls/vbscript/global.c > @@ -557,8 +557,41 @@ static HRESULT Global_IsNull(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VA > > static HRESULT Global_IsNumeric(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > { > - FIXME("\n"); > - return E_NOTIMPL; > + TRACE("(%s)\n", debugstr_variant(arg)); > + > + assert(args_cnt == 1); > + > + if(res) { > + V_VT(res) = VT_BOOL; You can't assume that res is non-NULL. > + switch(V_VT(arg)) { > + case VT_UI1: > + case VT_I2: > + case VT_I4: > + case VT_I8: > + case VT_R4: > + case VT_R8: > + case VT_BOOL: > + case VT_EMPTY: > + case VT_CY: > + V_BOOL(res) = VARIANT_TRUE; > + break; > + case VT_BSTR: { > + HRESULT hRet; > + double d; > + > + hRet = VarR8FromStr(V_BSTR(arg), LOCALE_USER_DEFAULT, 0, &d); > + if(SUCCEEDED(hRet)) > + V_BOOL(res) = VARIANT_TRUE; > + else > + V_BOOL(res) = VARIANT_FALSE; > + break; > + } > + default: > + V_BOOL(res) = VARIANT_FALSE; > + break; That's a risky assumption. There are tons of other VT_* types possible and at least VT_UI2, VT_UI4 and alike should most likely return true. It's much safer to add explicit list of *tested* cases to return false and FIXME(); return E_NOTIMPL for other cases. > + } > + } > + return S_OK; > } > > static HRESULT Global_IsArray(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) > diff --git a/dlls/vbscript/tests/api.vbs b/dlls/vbscript/tests/api.vbs > index beee4d4..cf63fb9 100644 > --- a/dlls/vbscript/tests/api.vbs > +++ b/dlls/vbscript/tests/api.vbs > @@ -170,6 +170,25 @@ Call ok(not isNull(4), "isNull(4) is true?") > Call ok(not isNull("x"), "isNull(""x"") is true?") > Call ok(isNull(Null), "isNull(Null) is not true?") > > +Call ok(isNumeric(empty), "isNumeric(empty) is not true?") > +Call ok(not isNumeric(Null), "isNumeric(Null) is not true?") > +Call ok(isNumeric(32767), "isNumeric(32767) is true?") > +Call ok(isNumeric(32768), "isNumeric(32768) is true?") > +Call ok(isNumeric(CSng(3242.4)), "isNumeric(CSng(3242.4)) is true?") > +Call ok(isNumeric(32768.4), "isNumeric(32768.4) is true?") > +Call ok(isNumeric(CCur(32768.4)), "isNumeric(CCur(32768.4)) is true?") > +Call ok(not isNumeric(CDate(32)), "isNumeric(CDate(32)) is true?") > +Call ok(isNumeric("44"), "isNumeric(""44"") is true?") > +Call ok(not isNumeric("rwrf"), "isNumeric(""rwrf"") is not true?") > +Call ok(not isNumeric(Nothing), "isNumeric(Nothing) is not true?") > +Call ok(not isNumeric(New EmptyClass), "isNumeric(New EmptyClass) is not true?") > +Call ok(isNumeric(true), "isNumeric(true) is true?") > +Call ok(isNumeric(CByte(32)), "isNumeric(CByte(32)) is true?") > +Dim arr(2) > +arr(0) = 2 > +arr(1) = 3 > +Call ok(not isNumeric(arr), "isNumeric(arr) is not true?") > + > Call ok(getVT(err) = "VT_DISPATCH", "getVT(err) = " & getVT(err)) > Your tests depend on your previous patches that were not committed and I already commented them. Please concentrate on getting them committed first. Jacek

1 1

Re: imagehlp: Implement (parts of) BindImageEx (try 4)
by Marvin 23 Apr '14

23 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6512 Your paranoid android. === w2000pro (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINNT\system32\KERNEL32.DLL === wxppro (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINDOWS\system32\KERNEL32.DLL === wvista (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\Windows\system32\KERNEL32.DLL === w2008s64 (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\Windows\system32\KERNEL32.DLL === w7u (32 bit image) === image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\Windows\system32\KERNEL32.DLL === w864 (32 bit image) === image.c:382: Test failed: expected ERROR_FILE_NOT_FOUND, got 87 image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINDOWS\SYSTEM32\KERNEL32.DLL === w2008s64 (64 bit image) === image.c:382: Test failed: expected ERROR_FILE_NOT_FOUND, got 87 === w864 (64 bit image) === image.c:382: Test failed: expected ERROR_FILE_NOT_FOUND, got 87 image.c:298: Test failed: expected DllName to be KERNEL32.DLL, got C:\WINDOWS\SYSTEM32\KERNEL32.DLL

1 0

Re: [PATCH] vbscript: Implemented IsNumeric
by Marvin 23 Apr '14

23 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6508 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvista (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found

1 0

Wine Talks at LinuxTag 2014
by Michael Stefaniuc 22 Apr '14

22 Apr '14

Hello guys, here are the two Wine related talks that got accepted for LinuxTag 2014: Pipelight: Windows Plugins in Linux Browsers by Michael Müller (Pipelight-Team), Sebastian Lackner (Pipelight-Team), Erich Hoover (Pipelight-Team) Thursday, 8th May, Stage E, 18:30-19:15 CEST (UTC+2) http://www.linuxtag.org/2014/de/programm/vortragsdetails/?eventid=1342 Is Wine Still Relevant? - A Status Update on Wine by Michael Stefaniuc (Wine Project) Friday, 9th May, Stage C, 16:00-16:45 CEST (UTC+2) http://www.linuxtag.org/2014/de/programm/vortragsdetails/?eventid=2532 bye michael

1 0

Re: [patch]Japanese Translation for Wine 1.7.17(try 2)
by Akihiro Sagawa 22 Apr '14

22 Apr '14

On Mon, 21 Apr 2014 05:56:33 -0400 (EDT), Toshiaki Hirose wrote: > From ce340a6aff2f17d41b35c217692ece6abb17d88e Mon Sep 17 00:00:00 2001 > From: Toshiaki Hirose <t_hirose(a)aol.com> > Date: Sun, 20 Apr 2014 13:34:34 +0900 > Subject: [PATCH] Japanese Translation for Wine 1.7.17 > > --- > po/ja.po | 59 ++++++++++++++++++++++++++++++++++++----------------------- > 1 file changed, 36 insertions(+), 23 deletions(-) Hello Hirose-san, Welcome to Wine development! I'm one of Japanese translation contributors of Wine. About your patch, it looks good at first glance. But, I found some (nit-picking) issues on that. Could you read the comments and give us your feedback? > @@ -1,18 +1,20 @@ > # Japanese translations for Wine > +# Toshiaki Hirose <t_hirose(a)aol.com>, 2014. I'm not sure this change is needed. Please keep it simple. > -"PO-Revision-Date: 2013-12-05 20:08+0900\n" > -"Last-Translator: Akira Nakagawa <matyapiro31(a)yahoo.co.jp>\n" > -"Language-Team: 日本語 <>\n" > +"PO-Revision-Date: 2014-04-20 11:53+0900\n" > +"Last-Translator: Toshiaki Hirose <t_hirose(a)aol.com>\n" > +"Language-Team: 日本語 < kobayashi-ubuntu(a)junkobayashi.jp >\n" The Language Team's e-mail address seems not valid, i.e. Jun Kobayashi is a male Japanese name. Did you get his approval? > "Language: Japanese\n" > "MIME-Version: 1.0\n" > "Content-Type: text/plain; charset=UTF-8\n" > "Content-Transfer-Encoding: 8bit\n" > "Plural-Forms: nplurals=1; plural=0;\n" > +"X-Generator: Gtranslator 2.91.6\n" I'm not sure about this, too. > @@ -11682,54 +11684,65 @@ msgid "" > " [/n] Do not call DllRegisterServer. This option must be used with [/i].\n" > "\n" > msgstr "" > +"用法:\n" > +" regsvr32 [/u] [/s] [/n] [/i[:cmdline]] Dll名\n" > +"\n" > +"オプション:\n" > +" [/u] サーバを登録消去\n" Please use a sentence form here, e.g. 「～消去します。」. Because original text is sentence. > @@ -11682,54 +11684,65 @@ msgid "" > " [/n] Do not call DllRegisterServer. This option must be used with [/i].\n" > "\n" > msgstr "" > +"用法:\n" Please translate `Usage' into 「使い方」 to keep consistency with other translations. For instance, see hostname.rc:30. > +" regsvr32 [/u] [/s] [/n] [/i[:cmdline]] Dll名\n" > +"\n" > +"オプション:\n" > +" [/s] サイレントモード (一切のメッセージが表示されません)。\n" Please insert a space character between adopted compound word, i.e. サイレントモード. This point based on MS's Japanese style guide [1] at the last line in p.19. [1] http://download.microsoft.com/download/B/3/4/B34F7185-AFCA-4846-8FBF-672A1B… > +" [/i] DllInstallを呼び出し、追加の[cmdline]をパスします。\n" I think 「パス」 is not commonly used in this case. > +"\t[/u]を付けて使った場合、DllInstallはアンインストールモードで呼び出されま" > +"す。 \n" Same as 「サイレントモード」 case. (compound word) > #: regsvr32.rc:41 > msgid "" > "regsvr32: Invalid or unrecognized switch [%1]\n" > "\n" > msgstr "" > +"regsvr32: 無効な選択または認識できない選択です[%1]\n" > +"\n" In my opinion, 「選択」 is not widely used in this situation. How about to use 「スイッチ」 instead? > #: regsvr32.rc:43 > msgid "regsvr32: %1 not implemented in DLL '%2'\n" > -msgstr "" > +msgstr "regsvr32: %1はDLL '%2'内で実装されていません。\n" Can you remove the last 「。」? As original text doesn't have full-stop character. > #: regsvr32.rc:44 > #: regsvr32.rc:45 > #: regsvr32.rc:46 > #: regsvr32.rc:47 > #: regsvr32.rc:48 > #: regsvr32.rc:49 > #: regsvr32.rc:50 > #: regsvr32.rc:51 Same as above. If you would like to contact me, please e-mail to me. Of course, I can understand Japanese. However, in wine development, I prefer open discussion on wine-devel mailing list. Regards, Akihiro Sagawa

1 0

Re: mshtml: Added IHTMLTable::width property implementation.
by Jacek Caban 21 Apr '14

21 Apr '14

Hi Zhenbo, It looks better now. On 04/19/14 03:38, Zhenbo Li wrote: > @@ -395,15 +422,60 @@ static HRESULT WINAPI HTMLTable_get_rows(IHTMLTable *iface, IHTMLElementCollecti > static HRESULT WINAPI HTMLTable_put_width(IHTMLTable *iface, VARIANT v) > { > HTMLTable *This = impl_from_IHTMLTable(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v)); > - return E_NOTIMPL; > + nsAString val; > + HRESULT hres; > + nsresult nsres; > + > + TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); > + hres = var2str(&val, &v); > + > + if (hres != S_OK){ > + ERR("Set Width(%s) failed when initializing a nsAString!\n", > + debugstr_variant(&v)); > + nsAString_Finish(&val); val is not initialized here, so you shouldn't call nsAString_Finish on it. > + return hres; > + } > + > + nsres = nsIDOMHTMLTableElement_SetWidth(This->nstable, &val); > + nsAString_Finish(&val); > + > + if (NS_FAILED(nsres)){ > + ERR("Set Width(%s) failed!\n", debugstr_variant(&v)); > + return E_FAIL; > + } > + > + return S_OK; > } > > static HRESULT WINAPI HTMLTable_get_width(IHTMLTable *iface, VARIANT *p) > { > HTMLTable *This = impl_from_IHTMLTable(iface); > - FIXME("(%p)->(%p)\n", This, p); > - return E_NOTIMPL; > + nsAString val; > + nsresult nsres; > + DOUBLE width; > + const PRUnichar *str; > + > + TRACE("(%p)->(%p)\n", This, p); > + nsAString_Init(&val, NULL); > + nsres = nsIDOMHTMLTableElement_GetWidth(This->nstable, &val); > + if (NS_FAILED(nsres)){ > + ERR("Get Width(%s) failed!\n", debugstr_variant(p)); > + nsAString_Finish(&val); > + return E_FAIL; > + } > + > + nsAString_GetData(&val, &str); > + nsres = VarR8FromStr(str, 0, 0, &width); > + if (nsres == S_OK){ > + V_VT(p) = VT_I4; > + V_I4(p) = (LONG)width; > + } else { /* Symbols are in this string */ > + V_VT(p) = VT_BSTR; > + V_BSTR(p) = SysAllocString(str); > + if (!V_BSTR(p)) > + return E_OUTOFMEMORY; > + } > + return S_OK; > } > > static HRESULT WINAPI HTMLTable_put_height(IHTMLTable *iface, VARIANT v) > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index 23677f4..10aca6c 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -5721,6 +5721,25 @@ static void _test_table_cell_spacing(unsigned line, IHTMLTable *table, const cha > VariantClear(&v); > } > > +#define cmp_length(a,b) _cmp_length(__LINE__,a,b) > +static void _cmp_length(unsigned line, VARIANT got, const char * exstr) > +{ > + static char buf[64]; > + ok_(__FILE__,line) (V_VT(&got)==VT_BSTR || V_VT(&got)==VT_I4, > + "V_VT is %hu, expected VT_BSTR(%hu) or VT_I4(%hu)\n", > + V_VT(&got), VT_BSTR, VT_I4); Please make it stricter and allow only one, exactly expected in given case, type. According to my quick tests (as I mentioned earlier), it's always VT_BSTR. Did you ever see it being VT_I4 in real Windows? If my testing is tight, this test hides a problem with your getter implementation. Cheers, Jacek

2 1

Re: [PATCH 1/4] msvcrt: Don't raise exception in _invalid_parameter (try2)
by Marvin 21 Apr '14

21 Apr '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=6473 Your paranoid android. === wxppro (32 bit misc) === misc.c:335: Test failed: buf = C:\Documents and Settings\winetest\My Documents\msvcrt_test.exe misc popen misc.c:338: Test failed: _pclose returned 1, expected 0x37

2 1