June 2014 - Wine-devel - list.winehq.org

Re: [PATCH 1/2] riched20: Implement ITextSelection::GetText.
by Jactry Zeng 13 Jun '14

13 Jun '14

Hello, Could someone take a look at this patch? Any comment will be appreciate! Thanks. 2014-05-28 15:17 GMT+08:00 Jactry Zeng <wine(a)jactry.com>: > ChangeLog: > - skip a test in native 64bit riched20 > - implementing without helper function > > --- > dlls/riched20/richole.c | 28 +++++++++++++- > dlls/riched20/tests/richole.c | 88 ++++++++++++++++++++++++++++++ > ++++++++++++- > 2 files changed, 113 insertions(+), 3 deletions(-) > > > > > > -- Regards, Jactry Zeng

1 0

Re: [PATCH 2/2] vbscript: Fixed CStr
by Jacek Caban 13 Jun '14

13 Jun '14

Hi Shuai, On 06/13/14 06:26, Shuai Meng wrote: > - hres = to_string(arg, &str); > + assert(args_cnt == 1); > + > + V_VT(&v) = VT_EMPTY; > + hres = VariantChangeType(&v, arg, VARIANT_LOCALBOOL, VT_BSTR); Why do you change it? to_string() already does the same call. Jacek

2 1

Re: [3/4] msvcrt: change default buffer size to 4k.
by Piotr Caban 13 Jun '14

13 Jun '14

On 06/13/14 01:27, Grazvydas Ignotas wrote: > -#define MSVCRT_BUFSIZ 512 > +#define MSVCRT_BUFSIZ 4096 You can't change BUFSIZ value.

2 2

Re: [PATCH 2/2] vbscript: Fixed CStr
by Piotr Caban 13 Jun '14

13 Jun '14

On 06/13/14 06:26, Shuai Meng wrote: > --- > dlls/vbscript/global.c | 16 +++++++++++++--- > dlls/vbscript/tests/api.vbs | 21 +++++++++++++++++++++ > 2 files changed, 34 insertions(+), 3 deletions(-) > You have probably sent wrong patch, one that you've sent me earlier is better (https://github.com/Shuai-Meng/wine/commit/54bb6a783a623a3bf30c8fe33187c8a35…) Taking in account you'll need to resend it, could you please also change: + if(!res) + return DISP_E_BADVARTYPE; + else { + *res = v; + return S_OK; + } to if(!res) return DISP_E_BADVARTYPE; *res = v; return S_OK; It's a style change that makes your code similar to other code in global.c Thanks, Piotr

1 0

Re: [PATCH 2/2] vbscript: Fixed CStr
by Marvin 13 Jun '14

13 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7468 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/2] msvcrt: Add _strxfrm_l implementation
by Marvin 12 Jun '14

12 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7457 Your paranoid android. === w2000pro (32 bit string) === string: unhandled exception c0000005 at 78010362 === wxppro (32 bit string) === string: unhandled exception c0000005 at 77C47AD8

1 0

Re: services: Defer service delete until all handles are closed
by Marvin 12 Jun '14

12 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7438 Your paranoid android. === w7u (32 bit service) === service.c:1381: Test failed: Something wrong in the calculation service.c:1417: Test failed: Active services mismatch 1 The test timed out

2 1

Re: [PATCH 07/10] dmloader: Use the generic DirectMusicObject implementation for DMContainer.
by Marvin 12 Jun '14

12 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7450 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: [PATCH 09/10] dmloader: Add and use a generic IPersistStream_GetClassID.
by Marvin 12 Jun '14

12 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7452 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 08/10] dmloader/tests: Add more DirectMusicCollection tests.
by Marvin 12 Jun '14

12 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7451 Your paranoid android. === build (build) === Patch failed to apply

1 0