June 2014 - Wine-devel - list.winehq.org

Re: Revert "windowscodecs: Fix leak in test_QueryCapability."
by Marvin 19 Jun '14

19 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7603 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ntdll: Add exception tests for RtlUnwind on i386.
by Marvin 19 Jun '14

19 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7598 Your paranoid android. === w2000pro (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00950000/00950001 exception: unhandled exception 80000004 at 00950000 exception.c:484: Test failed: 42: Wrong exception address 7C5C20B0/00950001 === wxppro (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00A30000/00A30001 exception: unhandled exception 80000004 at 00A30000 exception.c:484: Test failed: 42: Wrong exception address 7C80DF3C/00A30001 === wvistau64 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 002D0000/002D0001 exception: unhandled exception 80000004 at 002D0000 exception.c:484: Test failed: 42: Wrong exception address 7751ED97/002D0001 === w2008s64 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 002D0000/002D0001 exception: unhandled exception 80000004 at 002D0000 exception.c:484: Test failed: 42: Wrong exception address 77E5ED97/002D0001 === w7u (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 003C0000/003C0001 exception: unhandled exception 80000004 at 003C0000 exception.c:484: Test failed: 42: Wrong exception address 77CDE34F/003C0001 === w8 (32 bit exception) === exception.c:484: Test failed: 42: Wrong exception address 00310000/00310001 exception: unhandled exception 80000004 at 00310000 exception.c:484: Test failed: 42: Wrong exception address 77174D17/00310001

1 0

Re: windowscodecs: Fix leak in test_QueryCapability.
by Marvin 18 Jun '14

18 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7580 Your paranoid android. === wvistau64 (32 bit tiffformat) === tiffformat.c:245: Test failed: CreateDecoderFromStream error 0x88982f8b tiffformat: unhandled exception c0000005 at 0EEE3AA7 === w2008s64 (32 bit tiffformat) === tiffformat.c:245: Test failed: CreateDecoderFromStream error 0x88982f8b tiffformat: unhandled exception c0000005 at 0EEE3AA7 === w7u (32 bit tiffformat) === tiffformat.c:245: Test failed: CreateDecoderFromStream error 0x88982f8b tiffformat: unhandled exception c0000005 at 0EEE3AA7 === w8 (32 bit tiffformat) === tiffformat: unhandled exception c0000005 at 0042395C === wvistau64 (64 bit tiffformat) === No test summary line found === w2008s64 (64 bit tiffformat) === No test summary line found

1 0

Re: [PATCH 1/4] packager: Implement IOleObject::SetClientSite
by Marvin 18 Jun '14

18 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7573 Your paranoid android. === build (build) === Patch failed to apply

1 0

WineHQ Downtime
by Jeremy Newman 18 Jun '14

18 Jun '14

WineHQ will be going offline starting at 10:00 CDT tomorrow (Wednesday 2014-06-18) and will be down for up to an hour. We are moving the site and all services (other than the Wiki) to new hardware. This includes: WineHQ.org, Forums, AppDB, Bugzilla, Git, FTP, Mailing lists, and WineTestBot Web Even after the things come back online, some services may need some tweaking. We will be on the issues as fast as we can. -N

4 4

Re: oleaut32: Fix TLB dependencies lookup (retry 3)
by Marvin 18 Jun '14

18 Jun '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=7567 Your paranoid android. === w2000pro (32 bit typelib) === typelib.c:5491: Test failed: got: 80029c4a

1 0

Re: [2/3] msvcrt: Clear _cnt on buffer flush.
by Piotr Caban 18 Jun '14

18 Jun '14

On 06/18/14 02:03, Grazvydas Ignotas wrote: > @@ -3662,6 +3662,7 @@ int CDECL MSVCRT__flsbuf(int c, MSVCRT_FILE* file) > if(file->_cnt <= 0) > res = msvcrt_flush_buffer(file); > if(!res) { > + file->_cnt=file->_bufsiz; > *file->_ptr++ = c; > file->_cnt--; > } file->_cnt value should only be set if msvcrt_flush_buffer was called. Cheers, Piotr

1 0

Re: [4/5] msvcrt: Move write flag setting code for reuse.
by Piotr Caban 17 Jun '14

17 Jun '14

On 06/14/14 01:23, Grazvydas Ignotas wrote: > --- > dlls/msvcrt/file.c | 27 +++++++++++++++------------ > 1 file changed, 15 insertions(+), 12 deletions(-) > > diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c > index 7523bbb..d6fb9ef 100644 > --- a/dlls/msvcrt/file.c > +++ b/dlls/msvcrt/file.c > @@ -3641,6 +3641,17 @@ MSVCRT_wchar_t * CDECL MSVCRT_fgetws(MSVCRT_wchar_t *s, int size, MSVCRT_FILE* f > return buf_start; > } > > +static inline int msvcrt_set_write_direction(MSVCRT_FILE* file) > +{ > + if(!(file->_flag & MSVCRT__IOWRT)) { > + if(file->_flag & MSVCRT__IORW) > + file->_flag |= MSVCRT__IOWRT; > + else > + return MSVCRT_EOF; > + } > + return 0; > +} I don't see a good reason for making this code reusable. The code is used to inform how the buffer is used (if it's used for writing or reading). This means that it doesn't make sense to set it if buffer is not used. The only valid use of it I can see in wine sources is _flsbuf. I've wrote a test that shows that _IOWRT flag is not set if _bufsiz==0 or in the case you're implementing. You can see it's code and result on windows here: https://testbot.winehq.org/JobDetails.pl?Key=7552

2 1

Re: [PATCH 2/2] packager: Add loading support for Ole10Native storage objects
by Vincent Povirk 17 Jun '14

17 Jun '14

+ hr = IStorage_OpenStream(pStg, ole10nativeW, NULL, + STGM_READWRITE | STGM_SHARE_EXCLUSIVE, 0, &stream); You should probably use STGM_READ here.

1 0

Re: [PATCH 1/5] d2d1: Implement d2d_d3d_render_target_CreateSolidColorBrush().
by Jacek Caban 17 Jun '14

17 Jun '14

Hi Henri, On 06/16/14 13:13, Henri Verbeet wrote: > diff --git a/dlls/d2d1/d2d1_private.h b/dlls/d2d1/d2d1_private.h > index 5609db6..9e91728 100644 > --- a/dlls/d2d1/d2d1_private.h > +++ b/dlls/d2d1/d2d1_private.h > @@ -33,4 +33,13 @@ struct d2d_d3d_render_target > void d2d_d3d_render_target_init(struct d2d_d3d_render_target *render_target, ID2D1Factory *factory, > IDXGISurface *surface, const D2D1_RENDER_TARGET_PROPERTIES *desc) DECLSPEC_HIDDEN; > > +struct d2d_brush > +{ > + ID2D1Brush ID2D1Brush_iface; Given how you use this object, this should be ID2D1SolidColorBrush. I guess you want to somehow reuse this struct for other brush types, but there should be better ways for this. Then: +void d2d_solid_color_brush_init(struct d2d_brush *brush, ID2D1RenderTarget *render_target, + const D2D1_COLOR_F *color, const D2D1_BRUSH_PROPERTIES *desc) +{ + FIXME("Ignoring brush properties.\n"); + + brush->ID2D1Brush_iface.lpVtbl = (ID2D1BrushVtbl *)&d2d_solid_color_brush_vtbl; + brush->refcount = 1; +} This cast should not be needed. > + LONG refcount; > +}; > + > +void d2d_solid_color_brush_init(struct d2d_brush *brush, ID2D1RenderTarget *render_target, > + const D2D1_COLOR_F *color, const D2D1_BRUSH_PROPERTIES *desc) DECLSPEC_HIDDEN; > + > #endif /* __WINE_D2D1_PRIVATE_H */ > diff --git a/dlls/d2d1/render_target.c b/dlls/d2d1/render_target.c > index be9c1b6..e8c56a0 100644 > --- a/dlls/d2d1/render_target.c > +++ b/dlls/d2d1/render_target.c > @@ -117,9 +117,19 @@ static HRESULT STDMETHODCALLTYPE d2d_d3d_render_target_CreateBitmapBrush(ID2D1Re > static HRESULT STDMETHODCALLTYPE d2d_d3d_render_target_CreateSolidColorBrush(ID2D1RenderTarget *iface, > const D2D1_COLOR_F *color, const D2D1_BRUSH_PROPERTIES *desc, ID2D1SolidColorBrush **brush) > { > - FIXME("iface %p, color %p, desc %p, brush %p stub!\n", iface, color, desc, brush); > + struct d2d_brush *object; > > - return E_NOTIMPL; > + TRACE("iface %p, color %p, desc %p, brush %p.\n", iface, color, desc, brush); > + > + if (!(object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)))) > + return E_OUTOFMEMORY; > + > + d2d_solid_color_brush_init(object, iface, color, desc); > + > + TRACE("Created brush %p.\n", object); > + *brush = (ID2D1SolidColorBrush *)&object->ID2D1Brush_iface; Same here, the cast should not be needed. Also allocating memory in brush.c seems more logical to me (although that's a matter of taste). Cheers, Jacek

2 7