August 2014 - Wine-devel - list.winehq.org

Re: msvcp90: Added complex_float_pow impletation(Fix precision) and tests(Try 3)
by Piotr Caban 15 Aug '14

15 Aug '14

On 08/10/14 10:32, YongHao Hu wrote: > +complex_float* __cdecl complex_float_pow_ci(complex_float *ret, const complex_float *l, int r) > +{ > + complex_float c = *l; > + complex_float temp = { 1.0, 0 }; > + complex_float_assign(ret, &temp); > + > + if(r < 0){ > + r = -r; > + complex_float_div(&c, &temp, l); > + } > + > + for(; r>0; r>>=1) > + { > + if( (r%2)&1 ) Please fix the if condition. You're also using tabs in the patch, please use spaces instead. Thanks, Piotr

3 3

Re: msvcp90: Add complex_float << implementation
by Piotr Caban 15 Aug '14

15 Aug '14

On 08/10/14 10:32, YongHao Hu wrote: > --- > dlls/msvcp90/ios.c | 28 ++++++++++++++++++++++++++++ > dlls/msvcp90/msvcp90.spec | 4 ++-- > 2 files changed, 30 insertions(+), 2 deletions(-) > > This implementation is not behaving well in following case: complex<float> c = complex<float>(3.1, -0.5); cout.width(20); cout << c << endl; The width should affect whole complex value instead of first float. Cheers, Piotr

2 2

Re: [3/3] mshtml/tests: Add tests for modifying IHTMLTable.
by Jacek Caban 15 Aug '14

15 Aug '14

Hi Zhenbo, On 07/29/14 11:08, Zhenbo Li wrote: > To avoid affecting other tests, I squashed the tests for > insertRow / deleteRow. It would be interesting that the table not only contains given row, but also it is in the right place. For that I'd suggest to have test_table_rows_length, to test that the size changed, and another helper that would check if given row has expected id (or that a row with given id is in the right place). Cheers, Jacek

2 1

Re: [PATCH 7/7] vbscript: Implemented Atn(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8490 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 6/7] vbscript: Implemented Sqr(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8489 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 5/7] vbscript: Implemented Log(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8488 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/7] vbscript: Implemented Exp(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8487 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/7] vbscript: Implemented Tan(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8486 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/7] vbscript: Implemented Sin(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8485 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] vbscript: Implemented Cos(try 2)
by Marvin 14 Aug '14

14 Aug '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8484 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0