September 2014 - Wine-devel

Re: [PATCH 1/2] riched20: Stub for ITextFont interface and implement ITextRange::GetFont. (try 3)
by Huw Davies 19 Sep '14

19 Sep '14

On Fri, Sep 19, 2014 at 08:58:51PM +0800, Jactry Zeng wrote: > dlls/riched20/richole.c | 786 > +++++++++++++++++++++++++++++++++++++++++- > dlls/riched20/tests/richole.c | 47 +++ > 2 files changed, 831 insertions(+), 2 deletions(-) These two look good to me. Huw.

1 0

Re: rpcrt4: Fix buffer size calculation for arrays with embedded pointers
by Huw Davies 19 Sep '14

19 Sep '14

On Thu, Sep 18, 2014 at 02:29:07PM +0200, Eric Kohl wrote: > I finally found the bug in the function EmbeddedPointerBufferSize where > the pointer to the current array element was not incremented while the > surrounding for loop traversed the array. The pointer was always > pointing at the first element of the array. I also found the same bug in > the function EmbeddedPointerMarshall. Perhaps also EmbeddedPointerFree? We probably need some tests. Huw.

1 1

Re: [PATCH 1/2] riched20: Stub for ITextFont interface and implement ITextRange::GetFont. (try 2)
by Huw Davies 19 Sep '14

19 Sep '14

On Thu, Sep 18, 2014 at 09:15:11PM +0800, Jactry Zeng wrote: > +static IRichEditOleImpl *get_reOle(ITextFontImpl *txtFont) > +{ > + if (txtFont->txtRge) > + return txtFont->txtRge->reOle; > + else > + return txtFont->txtSel->reOle; > +} You're using two-space indents here, while the rest is four-space. A couple of these have sneaked in in earlier patches too - make sure your editor is set up correctly! > +static HRESULT CreateITextFont(ITextFontImpl **ptxtFont) > +{ > + ITextFontImpl *txtFont = NULL; This initialization isn't very useful. > + txtFont = heap_alloc(sizeof(ITextFontImpl)); > + if (!txtFont) > + return E_OUTOFMEMORY; > + > + txtFont->ITextFont_iface.lpVtbl = &tfvt; > + txtFont->ref = 1; > + *ptxtFont = txtFont; > + return S_OK; > +} It would make more sense to initialize txtSel and txtRge to NULL here - the caller then only needs to touch the one it needs. Otherwise, this one and the next one look good to me. Huw.

2 1

Re: [PATCH] vbscript: Implemented RGB
by Qian Hong 19 Sep '14

19 Sep '14

Hi Shuai, Please don't use C++ style comment, see: http://wiki.winehq.org/DeveloperFaq#head-24502845ecdabaeb82c82889a665c445d8… https://www.winehq.org/site/docs/winedev-guide/style-notes

2 1

Re: wined3d: Correctly display fog for right-handed projection matrix
by Bruno Jesus 18 Sep '14

18 Sep '14

On Thu, Sep 18, 2014 at 3:30 PM, Joachim Priesner <joachim.priesner(a)web.de> wrote: > + // A right-handed perspective projection matrix designed so that vertices > + // (x in [-1..1], y in [-1..1], z = 0.1) will be mapped to the view plane. > + // Obtained from D3DXMatrixPerspectiveFovRH with the parameters > + // fov=84.29deg, aspect=640/480 near=0.01, far=100 Hi, Joachim. Please don't use C++ style comments, see: http://wiki.winehq.org/DeveloperFaq#head-24502845ecdabaeb82c82889a665c445d8… https://www.winehq.org/site/docs/winedev-guide/style-notes

1 0

Re: [PATCH] vbscript: Implemented RGB
by Marvin 18 Sep '14

18 Sep '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8974 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/5] riched20: Stub for ITextFont interface and implement ITextRange::GetFont.
by Huw Davies 17 Sep '14

17 Sep '14

On Wed, Sep 17, 2014 at 05:39:23PM +0800, Jactry Zeng wrote: > > +typedef struct ITextFontImpl { > + ITextFont ITextFont_iface; > + LONG ref; > + struct list entry; > + > + IRichEditOleImpl *reOle; > + ITextRangeImpl *txtRge; > + ITextSelectionImpl *txtSel; > +} ITextFontImpl; Since the ITextFont objects do hold a ref on their parent range / selection objects I don't think we need the list stuff again. I wouldn't store the reOle pointer here, but use txtRge / txtSel to access it (and check for disconnections). You probably want a helper function to do that. Huw.

2 1

Re: [PATCH 4/5] riched20: Implement ITextRange::Collapse. (try 2)
by Indrek Altpere 17 Sep '14

17 Sep '14

This seems to be a typo, I think the original variable name was mean to be isedge or is_edge. Perhaps this check would be simpler to understand and would not create local variable if it were like this? if (*end == *start) return S_FALSE; Regards, Indrek

3 2

Re: winedbg: Respect TMPDIR environment variable
by Michael Stefaniuc 17 Sep '14

17 Sep '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/16/2014 09:25 PM, André Hentschel wrote: > First attack on https://bugs.winehq.org/show_bug.cgi?id=14838 > > diff --git a/programs/winedbg/gdbproxy.c > b/programs/winedbg/gdbproxy.c index 0865f44..d7596a0 100644 --- > a/programs/winedbg/gdbproxy.c +++ b/programs/winedbg/gdbproxy.c @@ > -2342,11 +2342,13 @@ static BOOL gdb_exec(const char* wine_path, > unsigned port, unsigned flags) { char buf[MAX_PATH]; int > fd; - const char* gdb_path; + const char *gdb_path, > *tmp_path; FILE* f; > > if (!(gdb_path = getenv("WINE_GDB"))) gdb_path = "gdb"; - > strcpy(buf,"/tmp/winegdb.XXXXXX"); + if (!(tmp_path = > getenv("TMPDIR"))) tmp_path = "/tmp"; + strcpy(buf, tmp_path); + > strcat(buf, "/winegdb.XXXXXX"); Just wondering, as we already have the .wine-$UID directory in TMPDIR shouldn't this file be placed in that directory too? > fd = mkstemps(buf, 0); if (fd == -1) return FALSE; if ((f = > fdopen(fd, "w+")) == NULL) return FALSE; > bye michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) iD8DBQFUGVSO0ei8kcpE1VERAgC/AJ9Ow9H7xnu/qQ3VYlh49BXOgG75pACePrh7 aLhMgo8NZ7EhpQCB2cs8NnY= =OHEq -----END PGP SIGNATURE-----

1 0

Re: [PATCH 4/5] riched20: Implement ITextRange::Collapse. (try 2)
by Huw Davies 17 Sep '14

17 Sep '14

On Tue, Sep 16, 2014 at 06:39:32PM +0800, Jactry Zeng wrote: > +static HRESULT range_Collapse(LONG bStart, LONG *start, LONG *end) > +{ > + BOOL isdege = !(*end - *start); This is a strange way to test for an equality! Also, isdegen or is_degen would be much better choices for the variable name. Huw.

1 1