September 2014 - Wine-devel

Re: dpnet/tests: Make test_lobbyclient() static.
by Marvin 11 Sep '14

11 Sep '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8895 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/8] riched20: Implement ITextSelection::GetChar and ITextRange::GetChar. (resend try2)
by Marvin 11 Sep '14

11 Sep '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8888 Your paranoid android. === wxppro (32 bit richole) === Failure running script in VM: Timed out in create_socket while connecting to testnet.winehq.org:22001:10.42.42.134:4242

1 0

Re: reg: Add reg.exe test suite. (try 2)
by Alexandre Julliard 10 Sep '14

10 Sep '14

Akihiro Sagawa <sagawa.aki(a)gmail.com> writes: > Try 2: > - Avoid memory allocation in run_reg_exe_ function. > - Add more broken tests in WinXP. > - Compare the exit code outside of run_reg_exe function. > - Introduce REG_EXIT_SUCCESS/REG_EXIT_FAILURE constant and use it. It fails here on 64-bit: ../../../../wine/tools/runtest -q -P wine -T ../../.. -M reg.exe -p reg.exe_test.exe.so reg && touch reg.ok reg.c:180: Test succeeded inside todo block: got wrong data make: *** [reg.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3]dwrite: build non-system font collections as a list of font families
by Nikolay Sivov 10 Sep '14

10 Sep '14

On 09/09/2014 04:10 AM, Aric Stewart wrote: > @@ -920,6 +939,8 @@ static UINT32 WINAPI dwritefontcollection_GetFontFamilyCount(IDWriteFontCollecti > { > struct dwrite_fontcollection *This = impl_from_IDWriteFontCollection(iface); > TRACE("(%p)\n", This); > + if (This->family_count) > + return This->family_count; > return This->count; This looks particularly suspicious, probably naming needs some work. Other parts need to be improved as well I think, like avoiding impl_from_* in your own internal functions.

1 0

Re: mshtml: Bind events to document node instead of body element.
by Marvin 10 Sep '14

10 Sep '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8870 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: reg: Add reg.exe test suite.
by Marvin 09 Sep '14

09 Sep '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8862 Your paranoid android. === wxppro (32 bit reg) === reg.c:132: Test failed: got exit code 0, expected 1

1 0

Re: dxguid: Add dvoice.h
by Alexandre Julliard 09 Sep '14

09 Sep '14

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > > > Changelog: > dxguid: Add dvoice.h There shouldn't be any need to do that. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: (try 7)[1/5] imm32: Move thread data from TLSEntry to an internal list
by Alexandre Julliard 09 Sep '14

09 Sep '14

Aric Stewart <aric(a)codeweavers.com> writes: > + if (thread_data->defaultContext) /* someone beat us */ > + IMM_DestroyContext(defaultContext); I don't think you should be doing that inside the thread lock. > + IMMThreadData* thread_data = IMM_GetThreadData(0); > + if (thread_data->hwndDefault == NULL) > + thread_data->hwndDefault = CreateWindowExW( WS_EX_TOOLWINDOW, That one is suspicious too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] wineps.drv: Allow text copy paste from print to pdf
by Huw Davies 09 Sep '14

09 Sep '14

On Mon, Sep 08, 2014 at 09:19:54PM -0700, Daniel Horn wrote: > -void get_glyph_name(HDC hdc, WORD index, char *name) > +void get_glyph_name(HDC hdc, BOOL unicode, WORD index, char *name) > { > - /* FIXME */ > - sprintf(name, "g%04x", index); > + if(unicode) > + sprintf(name, "uni%04X", index); > + else > + sprintf(name, "g%04x", index); > return; > } The right way to do this is to look up the glyph's name in the font's 'post' table. Huw.

1 0

Re: [1/3] wineps.drv: Avoid marking composite unicode subglyphs as downloaded (resend)
by Huw Davies 09 Sep '14

09 Sep '14

On Mon, Sep 08, 2014 at 09:18:51PM -0700, Daniel Horn wrote: > Fixes a bug with caching composite unicode glyphs (if a ñ came before any n in the document, > then all subsequent n's would appear as a box) > This was because the glyph was marked as having been sent down when it was only a component > of a more complex glyph This shouldn't be necessary, I suspect something else is going wrong. If the 'n' has been downloaded as part of a 'ñ' then it really shouldn't be necessary to download the 'n' again. Huw.

2 2