October 2015 - Wine-devel - list.winehq.org

ws2_32: Implement a basic synchronous TransmitFile.
by Hugh McMaster 21 Oct '15

21 Oct '15

Hi Erich, When checking another Wine component, I noticed build warnings for dlls/ws2_32/socket.c. The relevant commit is 4d081f36efefd3ccf702cacea4d20c5616cfbae1, which was your patch, so I thought I'd let you know. socket.c: In function ‘WS2_TransmitFile’: socket.c:2826:46: warning: ‘iosb.Information’ may be used uninitialized in this function [-Wmaybe-uninitialized] wsa->write.iovec[0].iov_len = iosb.Information; ^ socket.c:2808:25: note: ‘iosb.Information’ was declared here IO_STATUS_BLOCK iosb; ^ Adding iosb.Information = 0 before status = WS2_ReadFile( wsa->file, &iosb, wsa->buffer, bytes_per_send ); fixes the warning, but I have no idea if that is correct for for ws2_32. -- Hugh McMaster

2 1

Re: [PATCH 3/4] kernel32/tests: Add tests for GetCurrentConsoleFont
by Marvin 21 Oct '15

21 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17531 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

Re: [PATCH 1/4 v2] server: Add console font table information
by Sebastian Lackner 21 Oct '15

21 Oct '15

On 21.10.2015 02:43, Hugh McMaster wrote: > Changes since version 1: > * Removed an unintentional newline > * Simplified a few comments > > We must use the server because kernel32 does not export a function for this purpose. > The struct font_info can also be expanded to support all elements from CONSOLE_FONT_INFOEX. > > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > server/console.c | 19 +++++++++++++++++++ > server/protocol.def | 7 ++++++- > 2 files changed, 25 insertions(+), 1 deletion(-) > font.index is unused, it would make more sense to add it later, when it is actually required. Also see my previous mail, where I point out that you could implement the XP-version of those functions without any wineserver changes at all.

1 0

Re: kernel32/tests: Remove unnecessary busy loop (PVS-Studio).
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17527 Your paranoid android. === w1064 (32 bit thread) === thread.c:1086: Test failed: got 0 with 5 (expected FALSE with ERROR_GEN_FAILURE)

1 0

Re: [PATCH] shell32: Implement IShellDispatch2::ShellExecute
by Huw Davies 20 Oct '15

20 Oct '15

On 20 Oct 2015, at 19:25, Andrew Eikum wrote: > -static HRESULT WINAPI ShellDispatch_ShellExecute(IShellDispatch6 *iface, BSTR file, VARIANT args, VARIANT dir, > - VARIANT op, VARIANT show) > +static HRESULT WINAPI ShellDispatch_ShellExecute(IShellDispatch6 *iface, > + BSTR file, VARIANT v_args, VARIANT v_dir, VARIANT v_op, VARIANT v_show) > { > - FIXME("(%s): stub\n", debugstr_w(file)); > - return E_NOTIMPL; > + VARIANT args_str, dir_str, op_str, show_str; > + WCHAR *args = NULL, *dir = NULL, *op = NULL; > + INT show = 0; > + HINSTANCE ret; > + > + TRACE("(%s, %s, %s, %s, %s)\n", debugstr_w(file), debugstr_variant(&v_args), > + debugstr_variant(&v_dir), debugstr_variant(&v_op), debugstr_variant(&v_show)); > + > + VariantInit(&v_args); Did you mean to args_str here? > + VariantChangeType(&args_str, &v_args, 0, VT_BSTR); > + if (V_VT(&v_args) == VT_BSTR) > + args = V_BSTR(&v_args); and also args_str here? (and similar occurrences below). Huw.

2 1

Marvin says... (was: [v2] d3d8: Adjust D3DCOLOR_ARGB to avoid shift overflow.)
by Gerald Pfeifer 20 Oct '15

20 Oct '15

On Tue, 20 Oct 2015, Marvin wrote: > Thank you for your contribution to Wine! > > This is an automated notification to let you know that your patch has > been reviewed and its status set to "Committed". > > This means that your patch has been approved, and committed to the > main git tree. Congratulations! Sooo, this is officially cool. For casual contributors like me, this is especially nice and helpful, and it saves me time to check (git and/or mailing list archives) manually. Thank you! Gerald

1 0

Re: [PATCH 03/10] d3d9: move GetDC check to actual d3d9_surface_GetDC call
by Henri Verbeet 20 Oct '15

20 Oct '15

On 19 October 2015 at 19:07, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > @@ -360,7 +379,6 @@ static const struct wined3d_parent_ops d3d9_surface_wined3d_parent_ops = > void surface_init(struct d3d9_surface *surface, struct wined3d_texture *wined3d_texture, unsigned int sub_resource_idx, > struct wined3d_surface *wined3d_surface, const struct wined3d_parent_ops **parent_ops) > { > - struct wined3d_resource_desc desc; > IDirect3DBaseTexture9 *texture; > > surface->IDirect3DSurface9_iface.lpVtbl = &d3d9_surface_vtbl; > @@ -379,23 +397,6 @@ void surface_init(struct d3d9_surface *surface, struct wined3d_texture *wined3d_ > IDirect3DBaseTexture9_Release(texture); > } > > - wined3d_resource_get_desc(wined3d_surface_get_resource(wined3d_surface), &desc); > - switch (d3dformat_from_wined3dformat(desc.format)) > - { > - case D3DFMT_A8R8G8B8: > - case D3DFMT_X8R8G8B8: > - case D3DFMT_R5G6B5: > - case D3DFMT_X1R5G5B5: > - case D3DFMT_A1R5G5B5: > - case D3DFMT_R8G8B8: > - surface->getdc_supported = TRUE; > - break; > - > - default: > - surface->getdc_supported = FALSE; > - break; > - } > - > *parent_ops = &d3d9_surface_wined3d_parent_ops; > } I guess you're moving this to avoid wined3d_texture_get_sub_resource() in surface_init(), but you don't really need that. You can get the format from the texture, since it's the same for all sub-resources.

2 2

Re: [PATCH 02/10] d3d9: avoid using a wined3d_surface in get_desc calls inside d3d9_device_StretchRect
by Henri Verbeet 20 Oct '15

20 Oct '15

On 19 October 2015 at 19:07, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > + if (!(sub_resource = wined3d_texture_get_sub_resource(dst->wined3d_texture, dst->sub_resource_idx))) > + goto done; This should never fail.

2 2

Re: d3d9/tests: Test the return of CreateDepthStencilSurface()
by Henri Verbeet 20 Oct '15

20 Oct '15

On 20 October 2015 at 09:48, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > hr = IDirect3DDevice9_CreateDepthStencilSurface(device, 640, 480, D3DFMT_D24S8, > D3DMULTISAMPLE_NONE, 0, TRUE, &ds, NULL); > + ok(SUCCEEDED(hr), "Failed to create depth stencil surface, hr = %08x.\n", hr); Please use the same style as the other messages in the test. (I.e., "hr %#x.\n".)

1 0

Re: [PATCH] wintrust/tests: Use proper return types when calling provider funcs (PVS-Studio)
by Marvin 20 Oct '15

20 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17516 Your paranoid android. === w1064 (32 bit softpub) === softpub: unhandled exception c0000005 at 757DC81B === w864 (64 bit softpub) === softpub: unhandled exception c0000005 at 00007FFB7AFF266C === w1064 (64 bit softpub) === softpub.c:255: Test failed: Expected S_OK, got 00000001 softpub.c:258: Test failed: Expected S_OK, got 00000001 softpub: unhandled exception c0000005 at 00007FF85A339A5D

1 0