October 2015 - Wine-devel - list.winehq.org

Re: [2/2] msrle32: Add support to uncompressed frames video (resend)
by Marvin 17 Oct '15

17 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17423 Your paranoid android. === build (build) === Make failed

1 0

Re: [2/2] msrle32: Add support to uncompressed frames video
by Marvin 17 Oct '15

17 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17420 Your paranoid android. === build (build) === Make failed

1 0

Re: [1/2] msrle32/tests: Add uncompressed video tests using MRLE as codec
by Marvin 17 Oct '15

17 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17419 Your paranoid android. === build (build) === Make failed

1 0

Re: fltmgr.sys: add FltInitializePushLock stub (try 2)
by Alexandre Julliard 16 Oct '15

16 Oct '15

Austin English <austinenglish(a)gmail.com> writes: > +++ b/include/ddk/ntifs.h > @@ -19,6 +19,18 @@ > #ifndef __NTIFS_H__ > #define __NTIFS_H__ > > +typedef struct _EX_PUSH_LOCK { > + union { > + struct { > + ULONG waiting : 1; > + ULONG exclusive : 1; > + ULONG shared : 30; > + } DUMMYSTRUCTNAME; > + ULONG value; > + VOID *ptr; > + } DUMMYUNIONNAME; > +} EX_PUSH_LOCK, *PEX_PUSH_LOCK; Where does this come from? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: d3d8: Adjust D3DCOLOR_ARGB to avoid shift overflow.
by Stefan Dösinger 16 Oct '15

16 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-09-13 um 22:56 schrieb Gerald Pfeifer: > -#define D3DCOLOR_ARGB(a,r,g,b) ((D3DCOLOR)((((a)&0xff)<<24)|(((r)&0xff)<<16)|(((g)&0xff)<<8)|((b)&0xff))) > +#define D3DCOLOR_ARGB(a,r,g,b) ((D3DCOLOR)((((a)&0xffu)<<24)|(((r)&0xff)<<16)|(((g)&0xff)<<8)|((b)&0xff))) Wouldn't it make sense to make the masks for the other channels unsigned too? Are there any possible side effects when compiling code with winelib? The native header uses a signed 0xff. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJV9o1AAAoJEN0/YqbEcdMwVwUP/3G2g6LM41sKgJt3/mxlhkQ4 BdxJ+Oj2Sz1FdefWNzohcRGI5V8AaRSfoCyCQCvSvFRUm72VY9aMKvK3Nhg7gku0 OmP9z81GEDIb13eLNGrcGNmU97wsqk69MtahHFZ3tj8gYLEWVW3sZPwU64VOa89g 7eLLrx5xXGAhoyzN/q85rV7oGj6xmCzv8YKzasv7BAQIdARVwoSVzmyH2kqbuJFf ENVHyoPSJpphYBc4vxSOLVelgVCGEeAdAECnaGpGG+UfT8Sha3GTFu5q6Nn8P9Gx 3irwIPv7nfgqgdBFDRZUOuck/P5mirM9K3YQLB5309usVh7czusvR6LRWR7g5/gD aCf3fub02sfVe0+Sl2NBMfjF361qaOcMpv63e6+QGToKRIXSE9Ht/v4oUeblNi+h H6K/ljyv/kXr9mDUQBRbRUFlcKtp9Cm49xHAK7cT2xDrIj9z18mExKeARz+V1hiF Fs9W/sJao6F+LN9p1XpdZ+Ha10zvFUrsF3OPj09nyv/C+lXdIt5WgFIiI6gzsD/Z +vKFEoiYWnea9xBO9hUprnr4HTNlCMCZroQrvgeJm3xVxhcZZ9d7XQk7Q+oS1UlU S1g4FJL/Ea8EPNW5bq35F9x50azgZVKmdgIDe1ZtogDF+tgGwuuHN5DiqHAhU2cM deINoftjzz/ztYWqm2Yh =kZgE -----END PGP SIGNATURE-----

2 1

Re: d3drm/tests: Release two retrieved interfaces to allow proper cleanup.
by Stefan Dösinger 16 Oct '15

16 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-15 um 21:54 schrieb Bernhard Übelacker: > + hr = IDirect3DRMFrame_DeleteChild(pFrameP2, pFrameC); > + ok(hr == D3DRM_OK, "Cannot remove child frame (hr = %x)\n", hr); > + CHECK_REFCOUNT(pFrameC, 1); > + > + CHECK_REFCOUNT(pFrameP1, 2); > + hr = IDirect3DRMFrame_DeleteChild(pFrameP2, pFrameP1); > + ok(hr == D3DRM_OK, "Cannot remove child frame (hr = %x)\n", hr); > + CHECK_REFCOUNT(pFrameP1, 1); Are these necessary? I'd expect the frame children to be detached when their parent is destroyed, similarly to how it works in ddraw. I'm not opposed to explicitly removing them, so I'll send my signed-off-by to wine-patches. But it's something someone (Jamm? ;-) ) could write an explicit test for. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWINjmAAoJEN0/YqbEcdMwQFAQAIcW8C+DxXKqNfUX2gxN3HtP FHrr2i+Ufy694aoL/O+hcWgL0mxS/Hv9F9RnXth+m5x1FKBkKJx1DA3wXZl+N6Ea w961wIDiPZCzCr2Hb1HGeQEEKBoPXnY3oxtGmOipv8bYEpjSXLngYKXVmM9U0Ojl BjAKCPraAukui5sLaMr3Bypf6jrOylrceWnyXo70Q7E1Gg5Lq5auTawYDvDsYxKF WISMIn5eBXsNDr4irRneuW/2JDwbB/FePzkqxhVfKzkw9K0A72enuzHMWkfeXAHS zQvZr+uSC+KanwWJq41VdFhWzFNhudUklHT/Ne5vl/nPeFibtCmB6CxoGtVJPaqT Htzb2MoPV4cV/efp+2+oZPPZxOeAgXhdFmWqGUYZ02/rHpthH8saRJ1mGZoWY7DU R82s3k0vXBmwzhK1CHvs2zZgi6mt25qZqeJwM7Ehci/VLwjaREjts8yetGL8NoKP 9ZFx+Hg4LD4w8mBOc5utkerODw6fwIZ3KKCfdX2S9FAIbqWsZ0/cN4rmJkIjRMGq FiYyOZ9GU2H93CyRTtQfv3mVcXGh2LXxvxsgviR5gzBxo4XbVqiYe/cFcCfTtJQu NrTYURDXQxFFkjq5rZXYP4bUItGAbuoC5/Kh4C/ATONahQq9yqEo7qDQRsP9IRS6 AX+rnn4Sagutm0q/OJc8 =R0Nv -----END PGP SIGNATURE-----

3 3

Re: [PATCH 1/3] ws2_32: Implement a basic synchronous TransmitFile (try 5).
by Marvin 16 Oct '15

16 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17393 Your paranoid android. === w7pro64 (32 bit sock) === sock.c:7350: Test failed: bytesReturned isn't supposed to be 1 sock.c:7374: Test failed: GetOverlappedResult failed, error 0

3 2

Re: [PATCH] shell32: Implement IShellDispatch2::ShellExecute
by Dmitry Timoshkov 16 Oct '15

16 Oct '15

Andrew Eikum <aeikum(a)codeweavers.com> wrote: > + TRACE("(%s, %s, %s, %s, %s): stub\n", debugstr_w(file), debugstr_variant(&v_args), > + debugstr_variant(&v_dir), debugstr_variant(&v_op), debugstr_variant(&v_show)); Probably ": stub" part should be removed. > + if (V_VT(&v_op) == VT_BSTR) > + op = V_BSTR(&v_op); > + > + if (V_VT(&v_args) == VT_BSTR) > + args = V_BSTR(&v_args); > + > + if (V_VT(&v_dir) == VT_BSTR) > + dir = V_BSTR(&v_dir); > + > + if (V_VT(&v_show) == VT_INT) > + show = V_INT(&v_show); > + > + ShellExecuteW(NULL, op, file, args, dir, show); > + > + return S_OK; Shouldn't return value somehow reflect what ShellExecute returns? Also as usually it would be nice to see some tests for this, especially with not handled variant types. -- Dmitry.

2 1

Re: [PATCH] configure: Check for linker relocation support before relying on prelink
by Alexandre Julliard 16 Oct '15

16 Oct '15

Michael Cronenworth <mike(a)cchtml.com> writes: > @@ -988,10 +988,17 @@ wine-installed: main.o > *) LDEXECFLAGS="$LDEXECFLAGS -Wl,--section-start,.interp=0x7bf00400" ;; > esac > ]) > - AC_PATH_PROG(PRELINK, prelink, false, [/sbin /usr/sbin $PATH]) > - if test "x$PRELINK" = xfalse > + WINE_TRY_CFLAGS([-Wl,-Ttext-segment=0x7bc00000], > + [AC_DEFINE([HAVE_TTEXT_SEGMENT],[1],[Define if > +linker supports -Ttext-segment.])], > + [HAVE_TTEXT_SEGMENT="no"]) > + if test "x$HAVE_TTEXT_SEGMENT" = "xno" The check should be done at run-time. Check how winegcc does it for other linker flags. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: d3drm/tests: Skip following tests when device creation fails.
by Stefan Dösinger 16 Oct '15

16 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-15 um 21:54 schrieb Bernhard Übelacker: > hr = IDirect3DRM3_CreateDeviceFromClipper(d3drm, pClipper, &driver, rc.right, rc.bottom, &device); > ok(hr == D3DRM_OK, "Cannot get IDirect3DRMDevice interface (hr = %x)\n", hr); > + if (FAILED(hr)) > + { > + skip("Cannot get IDirect3DRMDevice interface (hr = %x), skipping tests\n", hr); > + IDirectDrawClipper_Release(pClipper); > + IDirect3DRM_Release(d3drm); > + DestroyWindow(window); > + return; > + } The test will fail regardless, so you don't gain too much. It would be nicer if the test skips without a failing ok() statement in this case. Do you have a Windows VM to test how native d3drm responds if d3d is not available? I.e., which error code is returned? It might be a bit tricky to test because we request a software device that Wine doesn't implement but should be available everywhere on Windows. If you need help finding that out I can play a bit with my Windows XP box. (Technically failing is correct because we should have a software device without host GL in theory, but I don't expect that we'll ever implement one, so I think not failing the test if GL isn't available is the best thing to do) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWINx5AAoJEN0/YqbEcdMwcDYP/1mLNoDkllStJ4gySEeUgfxK QUuTt7vIFiWGVl8/x9QUsO9dWakZ+2fPZJSl3cO8cUxuk/GbpwmKNYFG3IEcQUIo 1nTn5aM6kTxv4b+uVT2BnX/CwJLouQnjuFnsTxTORJad1WsPk/qTVcPAmknnTPlX uHs30ed8QBm7ZWwi+549rQfFeGjp41xf05BVqjtSILtIhPiRYfnfsXAV/zFmUPMB hCG3QtaSL4Ea4zS3aEr0II0aV6TcSSY1t+V0+SvCuZEgZDKbYF5qbEeKRiXubdga mQEtEWcun0NUwtRD7ftNA6Ad5WumHUv3hj3fwb0q4hA0AtjvsW1L4zuYQs/DVb2v T/vpyZLowUpUn4peTOwuNU5rBeUY9BRqeoqcE1ccyVUFQ2nt6Iq3XJGvzjRWf3RT e5j1F9OyM31j8eDTVRO3Vr5SXqH3yDiwzSoLPJzTrE9AV4r1hj30Vb7MWjlqmOlq 03P83KwPDyNg5JBtr7R6a9TxQn7zhfZNzHctuJWI2ZSvXhbPTHgh0GZd1ka9ITkT 273sIi/VKU8e1HoBz5zTnGHYgE3utdqBk6RHVzSk/L+fhsVxD8LccyytRs7de+ai 7ut0IFuLsM3jd22g9FF3PTmpgZx3nEDUn0WN628hQO4w+Lf7w+MUmGslHMSrqx1r yiscxon1fyODz+BewWKG =NOTo -----END PGP SIGNATURE-----

3 4