October 2015 - Wine-devel - list.winehq.org

Re: [2/2] ntdll: wait_thread_proc should not terminate on user APC.
by Marvin 09 Oct '15

09 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17207 Your paranoid android. === w7u (32 bit threadpool) === threadpool.c:1097: Test failed: WaitForSingleObject returned 258

2 1

Re: [2/2] wininet/tests: Add test for using NULL as proxy server. (v2)
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17183 Your paranoid android. === w1064 (32 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87 === w1064 (64 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87

1 0

Re: [PATCH 1/5] d3d8: Call IDirect3DSwapChain8::Present in IDirect3DDevice8::Present.
by Stefan Dösinger 08 Oct '15

08 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2015-10-08 um 20:09 schrieb Stefan Dösinger: > I'll send a mail to wine-devel with the patches that implement the > actual flipping in wined3d. Please have a look at them, as the > client lib pointer update is fairly useless without them. > > Changes from the previous flip version: *) I'm keeping track of > views in their resource, that way we can update their resource > pointer and take action for GL_ARB_texture_view. *) Put some > thoughts into how this will work with CSMT. *) Implement resource > pointer updates in dxgi. Here's the rest of the patches. DXGI is tricky because of the way it interacts with d3d11 (patch 8). Some async vs sync accesses aren't easy to place so far without the command stream. If in doubt I used async. For transition purposes the main thread can always wait for the worker to finish. The other way doesn't work. Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWFrJsAAoJEN0/YqbEcdMwTP4P/R6xDgSYiHfPVdyFGR0L4lu5 KwlSWw6q2nzURsNZPb4itWxADMMjRjYiHyHg6a7QCsWkkPq5FJutDTjRHZzpCx1H /oWKhJ6G5T9wEmewRyr5YuzmTh4Qt2dTfjR1pekI4p0oObBaY+O3Pzht6sElLWwW ILvJT7HwlHV0k5eyYI7q26VBLBb91E4QKzVugjnB6xrWYKAkkUBtJuxvFPqWlvJE mKW+hof0U5zRC5jcWRgHpEZwihsPamBEPmfnf+EmW6LYD3V1M+fNa80vOo1VJtR8 P5amAKQV9RZP19tgil8NBznbc60JEMa/hv3wpUN6Ddf3X5Ess1ORlKRSgrbhNMhg oqZCCD7/bgnIa6U/tEQpf/yua3MaA+SoXavMup+U6IiX5YGXTHlSEI7C1mXwSTBl e9adECuCKX9vD6PWQY6TiiMw5ZioHALW27dH68bvWcg13+qhCEJJHhLJEMovY4UX zNFZDo5YEvYBAkebn5KzQQwMKnYTwSWRijaWZshwnA4tgKT9gzqLsuZ7a3h5GNOf y1cwRCrppjmfaM9wYERjUo5giHhQq2jol1Y1NaVe8roOvhToNIKnTwI7VK+VVxHZ TbLvU+aHCVN4sJAuTQ6Y/Hgo55oi9Ts6RC26AqtNH0A6zGEBmIEN5xeJbVGEq5iO kX55vB1808MtThZBIRc1 =BJLE -----END PGP SIGNATURE-----

1 0

RE: [PATCH 2/2] reg: merge key open code
by Michel Zou 08 Oct '15

08 Oct '15

Hi, I saw the 1/2 patch has been commited, this is the second half that corresponds to the commit 1 of 4 by jnvsor in a preliminary work to add reg query functionality: https://github.com/jnvsor/wine/commits/reg.exe I split this commit in two after the review from Stefan Dösinger. I did not want to submit all at once because it seems pretty hard to get patches accepted. M. > Subject: Re: [PATCH 2/2] reg: merge key open code > To: wine-patches(a)winehq.org > From: stefandoesinger(a)gmail.com > Date: Mon, 5 Oct 2015 11:43:52 +0200 > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Am 2015-10-04 um 21:14 schrieb Michel Zou: > > From: Jonathan Vollebregt <jnvsor(a)gmail.com> > > > > Signed-off-by: Michel Zou <xantares09(a)hotmail.com> > Signed-off-by: Stefan Dösinger <stefan(a)codeweavers.com> > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIcBAEBCAAGBQJWEkZYAAoJEN0/YqbEcdMwHoIP/RbWUWDNwqoDGiEY/b+IX+Ik > JuOwKGS/VJ36CrAUE03qgJ4XOBzIvfKMO+5UmjztQLPh60bvzKozzTVFJlYlCExQ > jzuOyz24P+7QBx195Ov9YV56p7isk2g2ShL9zg/XVub4b/47snRzncmjC7kAM2my > Zxfhcg5wxqHE3+905LXf4VcL9a1vbZG5+sIjMCfB5q6/b0EtyDBomIuH3YRgGuHu > iH57nTjUu+bMD+lH5PvmD0mAhMFEwSjbdXCsSqQhyDUg7WQaYo/XE17XtA2N4gb1 > tHl66PPdazaKxJGrTBdJtHhtgA8LO2ahfa7Ses5x3z6+/oGlO1OsdPPNRJusUC4V > 93tcacPj7IpWSLknZDFPHfcaHhv0IBMkI64lqiB9uEjQmylFd9+N1hYbnuB9ddpB > 21W4JE+Yfk7XDK0N4LDfKOGOblS7id58FoOJVIOGbYwklD9LXRGwiRkQe5yPGu6u > oAG0eWGySkU1egL6eXQ1fTzmF2RDzx3nFUUDB86kjeHa6mbeYzCtZEDzDaGOJkdI > 3J61hbUhY6VMMoSFsyokYwK++DJMvxhjk6Dy8cnU/qXM5MsDQWJUHePA9FZYOaOy > BBTcNUt1x2zNZjrsoCpdwHWGCpnht199cH+GElTIXp/CIaolxvEgl8TmyW6v5M42 > KfJ1DoYOZjEcs/gVwPDA > =Go1E > -----END PGP SIGNATURE----- > >

3 2

Re: [PATCH] vcomp120: add vcomp120 stub dll
by Nikolay Sivov 08 Oct '15

08 Oct '15

On 08.10.2015 19:02, Daniel Lehman wrote: > > diff --git a/dlls/vcomp120/main.c b/dlls/vcomp120/main.c > new file mode 100644 > index 0000000..a534bc7 > --- /dev/null > +++ b/dlls/vcomp120/main.c > @@ -0,0 +1,46 @@ > +/* > + * > + * vcomp120 implementation > + * > + * Copyright 2012 AndrÃ© Hentschel It's a new file, so I think it's better to add yourself too, you can of course keep Andre as original author you copied from. > +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + TRACE("(0x%p, %d, %p)\n", hinstDLL, fdwReason, lpvReserved); > + > + switch (fdwReason) Please rename them to 'instance', 'reason' and 'reserved'.

1 0

Re: [PATCH] vcomp120: add vcomp120 stub dll
by Sebastian Lackner 08 Oct '15

08 Oct '15

On 08.10.2015 18:02, Daniel Lehman wrote: > > > > There is one export missing compared to the vcomp120 version I have here (C2VectParallel). Also, variable names like lpvReserved should be avoided nowadays. It might be better to use the names from vcomp110/main.c. Regards, Sebastian

1 0

Re: [1/2] wininet/tests: Add test for using NULL as proxy server.
by Jacek Caban 08 Oct '15

08 Oct '15

Hi Sebastian, On 10/08/15 07:15, Sebastian Lackner wrote: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > Testbot is broken again, so here a link to a run with precompiled test: > https://newtestbot.winehq.org/JobDetails.pl?Key=17153 > > dlls/wininet/tests/internet.c | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) It fails here: fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub fixme:wininet:get_proxy_autoconfig_url no support on this platform fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub fixme:wininet:get_proxy_autoconfig_url no support on this platform fixme:wininet:query_global_option INTERNET_OPTION_PER_CONNECTION_OPTION stub internet.c:1387: Test failed: InternetSetOption should've succeeded Cheers, Jacek

2 1

Re: [2/2] wininet: Disabling proxy should return success when no proxy was enabled.
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17155 Your paranoid android. === w1064 (32 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87 === w1064 (64 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87

1 0

Re: [1/2] wininet/tests: Add test for using NULL as proxy server.
by Marvin 08 Oct '15

08 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17154 Your paranoid android. === w1064 (32 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87 === w1064 (64 bit internet) === internet.c:1507: Test failed: Got 0, expected 1223 (12042) internet.c:1514: Test failed: Got 0, expected 1223 (12042) internet.c:1525: Test failed: Got 0, expected 1223 (12042) internet.c:1074: Test failed: expected ret == 0, got 87

1 0

Re: [PATCH 1/6] d3d9/tests: Fix color_match().
by Henri Verbeet 08 Oct '15

08 Oct '15

On 8 October 2015 at 01:26, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > Clang on OS X complains about calling abs() on an unsigned value and > I think it has a point since technically the unsigned to signed > conversion is implementation-dependent when the value can't be > represented in the signed integer type (i.e. for the "negative" numbers). > ...and I don't suppose you accidentally compiled with -Wpedantic. The warning isn't wrong, but it's not terribly useful either. On two's complement systems (i.e., anything relevant) the reasonable thing to do is also the correct thing. This function exists in other places as well, of course.

2 1