October 2015 - Wine-devel - list.winehq.org

Re: [1/3] msi/tests: Add a test for MsiInstallProduct with command line containing double quotes inside of the property.
by Marvin 06 Oct '15

06 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17052 Your paranoid android. === wvistau64 (32 bit install) === The test timed out

2 1

Re: [6/6] oleaut32/tests: Add more tests for typelib data. Take 2.
by Marvin 06 Oct '15

06 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17051 Your paranoid android. === wxppro (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2003std (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7u (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w8 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4415: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4402: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4403: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4415: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c}

1 0

Re: [v2 03/10] wined3d: pass wined3d_texture and sub_resource idx to device_volume_created callback
by Stefan Dösinger 06 Oct '15

06 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 This patch causes a crash in the d3d8 tests here: Unhandled exception: page fault on read access to 0x00000008 in 32-bit code (0x7ec1adda). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7ec1adda ESP:0033f450 EBP:0033f488 EFLAGS:00010246( R- -- I Z- -P- ) EAX:7ec887f5 EBX:7ec72000 ECX:0033f4a0 EDX:7eca7e80 ESI:0015c920 EDI:00000000 Stack dump: 0x0033f450: 00000000 7bc3cc86 0033f480 7ec72000 0x0033f460: 0015c920 00000000 0033f498 7ec1c369 0x0033f470: 00000010 7ec1adc6 0033f4a0 7eca8000 0x0033f480: 0015c920 00000000 0033f4c8 7ec9941c 0x0033f490: 0033f4b0 7eca8000 7ec887f5 7ec9941c 0x0033f4a0: 00000000 00000000 7ec8859d 7ec99411 Backtrace: =>0 0x7ec1adda wined3d_volume_unmap+0x2a(volume=<couldn't compute location>) [/home/stefan/build/wine/dlls/wined3d/../../../../src/wine/dlls/wined3d/volume.c:683] in wined3d (0x0033f488) 1 0x7ec9941c d3d8_volume_UnlockBox+0x5b(iface=<couldn't compute location>) [/home/stefan/build/wine/dlls/d3d8/../../../../src/wine/dlls/d3d8/volume.c:170] in d3d8 (0x0033f4c8) 2 0x7ec952e6 d3d8_texture_3d_UnlockBox+0x55(iface=<couldn't compute location>, level=<couldn't compute location>) [/home/stefan/build/wine/dlls/d3d8/../../../../src/wine/dlls/d3d8/texture.c:1068] in d3d8 (0x0033f508) 3 0x7ecea1d1 test_volume_locking+0x160() [/home/stefan/build/wine/dlls/d3d8/tests/../../../../../src/wine/dlls/d3d8/tests/device.c:5761] in d3d8_test (0x0033f668) 4 0x7ecff26a func_device+0x4e39() [/home/stefan/build/wine/dlls/d3d8/tests/../../../../../src/wine/dlls/d3d8/tests/device.c:7533] in d3d8_test (0x0033fd38) 5 0x7ece2536 main+0x385(argc=<is not available>, argv=<is not available>) [/home/stefan/build/wine/dlls/d3d8/tests/../../../../../src/wine/include/wine/test.h:584] in d3d8_test (0x0033fdf8) 6 0x7ed1ff0f __wine_spec_exe_entry+0x6e(peb=<couldn't compute location>) [/home/stefan/build/wine/dlls/winecrt0/../../../../src/wine/dlls/winecrt0/exe_entry.c:36] in d3d8_test (0x0033fe48) 7 0x7b85d97c call_process_entry+0xb() in kernel32 (0x0033fe68) 8 0x7b85e9ba start_process+0x59(peb=<couldn't compute location>) [/home/stefan/build/wine/dlls/kernel32/../../../../src/wine/dlls/kernel32/process.c:1104] in kernel32 (0x0033fe98) 9 0x7bc7e5e0 call_thread_func_wrapper+0xb() in ntdll (0x0033feb8) 10 0x7bc8151f call_thread_func+0xce(entry=0x7b85e960, arg=0x7ffdf000, frame=0x33ffc8) [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/signal_i386.c:2732] in ntdll (0x0033ffa8) 11 0x7bc7e5be call_thread_entry_point+0x11() in ntdll (0x0033ffc8) 12 0x7bc53de7 start_process+0x16(kernel_start=0x7b85e960) [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/loader.c:3040] in ntdll (0x0033ffe8) 13 0xf759138d wine_call_on_stack+0x1c() in libwine.so.1 (0x00000000) 14 0xf7591500 wine_switch_to_stack+0x1f(func=0x7bc53dd0, arg=0x7b85e960, stack=0x340000) [/home/stefan/build/wine/libs/wine/../../../../src/wine/libs/wine/port.c:59] in libwine.so.1 (0xffccfbd8) 15 0x7bc59b31 LdrInitializeThunk+0x1f0(kernel_start=<couldn't compute location>, unknown2=<couldn't compute location>, unknown3=<couldn't compute location>, unknown4=<couldn't compute location>) [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/loader.c:3094] in ntdll (0xffccfc18) 16 0x7b864812 __wine_kernel_init+0x871() [/home/stefan/build/wine/dlls/kernel32/../../../../src/wine/dlls/kernel32/process.c:1276] in kernel32 (0xffcd0d88) 17 0x7bc5a973 __wine_process_init+0x162() [/home/stefan/build/wine/dlls/ntdll/../../../../src/wine/dlls/ntdll/loader.c:3303] in ntdll (0xffcd0e08) 18 0xf758f003 wine_init+0x2d2(argc=0x3, argv=0xffcd1364, error="", error_size=0x400) [/home/stefan/build/wine/libs/wine/../../../../src/wine/libs/wine/loader.c:958] in libwine.so.1 (0xffcd0e68) 19 0x7bf00d52 main+0x81(argc=<is not available>, argv=<is not available>) [/home/stefan/build/wine/loader/../../../src/wine/loader/main.c:247] in <wine-loader> (0xffcd12b8) 20 0xf739b973 __libc_start_main+0xf2() in libc.so.6 (0x00000000) 0x7ec1adda wined3d_volume_unmap+0x2a [/home/stefan/build/wine/dlls/wined3d/../../../../src/wine/dlls/wined3d/volume.c:683] in wined3d: movl 0x8(%edi),%eax 683 if (!volume->resource.map_count) Modules: Module Address Debug info Name (60 modules) ELF 7a800000-7a92f000 Deferred opengl32<elf> \-PE 7a820000-7a92f000 \ opengl32 ELF 7b800000-7ba62000 Dwarf kernel32<elf> \-PE 7b810000-7ba62000 \ kernel32 ELF 7bc00000-7bced000 Dwarf ntdll<elf> \-PE 7bc10000-7bced000 \ ntdll ELF 7bf00000-7bf04000 Dwarf <wine-loader> ELF 7e321000-7e327000 Deferred libxfixes.so.3 ELF 7e327000-7e332000 Deferred libxcursor.so.1 ELF 7e332000-7e341000 Deferred libxi.so.6 ELF 7e341000-7e345000 Deferred libxcomposite.so.1 ELF 7e345000-7e34f000 Deferred libxrandr.so.2 ELF 7e34f000-7e359000 Deferred libxrender.so.1 ELF 7e359000-7e35f000 Deferred libxxf86vm.so.1 ELF 7e35f000-7e363000 Deferred libxinerama.so.1 ELF 7e363000-7e36a000 Deferred libxdmcp.so.6 ELF 7e36a000-7e36e000 Deferred libxau.so.6 ELF 7e36e000-7e38f000 Deferred libxcb.so.1 ELF 7e38f000-7e4a8000 Deferred libx11.so.6 ELF 7e4a8000-7e4b9000 Deferred libxext.so.6 ELF 7e50b000-7e59a000 Deferred winex11<elf> \-PE 7e520000-7e59a000 \ winex11 ELF 7e59a000-7e5be000 Deferred imm32<elf> \-PE 7e5a0000-7e5be000 \ imm32 ELF 7e683000-7e6a2000 Deferred libexpat.so.1 ELF 7e6a2000-7e6d7000 Deferred libfontconfig.so.1 ELF 7e6d7000-7e706000 Deferred libpng16.so.16 ELF 7e706000-7e71a000 Deferred libz.so.1 ELF 7e71a000-7e7a8000 Deferred libfreetype.so.6 ELF 7e7a8000-7e7e5000 Deferred libncurses.so.5 ELF 7e837000-7e851000 Deferred version<elf> \-PE 7e840000-7e851000 \ version ELF 7e851000-7e9a2000 Deferred user32<elf> \-PE 7e860000-7e9a2000 \ user32 ELF 7e9a2000-7ea19000 Deferred advapi32<elf> \-PE 7e9b0000-7ea19000 \ advapi32 ELF 7ea19000-7eb34000 Deferred gdi32<elf> \-PE 7ea30000-7eb34000 \ gdi32 ELF 7eb34000-7ec76000 Dwarf wined3d<elf> \-PE 7eb40000-7ec76000 \ wined3d ELF 7ec76000-7ecaa000 Dwarf d3d8<elf> \-PE 7ec80000-7ecaa000 \ d3d8 ELF 7ecd0000-7ed37000 Dwarf d3d8_test<elf> \-PE 7ece0000-7ed37000 \ d3d8_test ELF 7ef37000-7ef44000 Deferred libnss_files.so.2 ELF 7ef44000-7ef50000 Deferred libnss_nis.so.2 ELF 7ef50000-7ef69000 Deferred libnsl.so.1 ELF 7ef69000-7efae000 Deferred libm.so.6 ELF 7efb2000-7efbf000 Deferred libbz2.so.1 ELF f4f8f000-f4fab000 Deferred libgcc_s.so.1 ELF f5147000-f721b000 Deferred libnvidia-glcore.so.355.11 ELF f726d000-f7370000 Deferred libgl.so.1 ELF f737c000-f7381000 Deferred libdl.so.2 ELF f7382000-f751c000 Dwarf libc.so.6 ELF f751c000-f7536000 Deferred libpthread.so.0 ELF f7537000-f7540000 Deferred libnss_compat.so.2 ELF f757b000-f7580000 Deferred libnvidia-tls.so.355.11 ELF f7588000-f7740000 Dwarf libwine.so.1 ELF f7741000-f7763000 Deferred ld-linux.so.2 ELF f7765000-f7766000 Deferred [vdso].so Threads: process tid prio (all id:s are in hex) 0000000e services.exe 0000002f 0 0000002e 0 00000028 0 00000022 0 0000001c 0 00000014 0 00000010 0 0000000f 0 00000012 winedevice.exe 00000019 0 00000018 0 00000013 0 0000001a winedevice.exe 0000001f 0 0000001e 0 0000001b 0 00000020 winedevice.exe 00000025 0 00000024 0 00000021 0 00000026 plugplay.exe 0000002b 0 0000002a 0 00000027 0 0000002c winedevice.exe 00000031 0 00000030 0 0000002d 0 00000032 explorer.exe 00000037 0 00000036 0 00000035 0 00000034 0 00000033 0 0000003b (D) Z:\home\stefan\build\wine\dlls\d3d8\tests\d3d8_test.exe 00000040 0 <== System information: Wine build: wine-1.7.52-49-gc171ca1 Platform: i386 (WOW64) Host system: Linux Host version: 4.0.5-aufs -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWE38aAAoJEN0/YqbEcdMw/XQP/jP/uppjezHsceuRmebdi44J F/RPugTszK6FVR3/c7+x/q4zVq5tdJXYD2W5Sa07k7F63P/t8lneWk0ADaASSdI6 XETTWQ9dEdP3mndOdlw2oftGwmDomgZXc7jAeGE6N7yvwRfUKUat8IRslIGmpmu2 VdeV3aYk6VL/KDxWIBVdid26hiEWVkgqQWEK2m4rZHiu5ZehE7HEf5sA+NQ3d+GX VThFQcaNRUZ1988W0iDfIEB5r621V9eedVWdPktwGh+trdJMlObTtDoihEiF9IUi Q0r5LYa47HcI6KpHhJYF+dSXFUy8c8dm+CX7xA+EhO7X4W0HL/EBE4C2sF3mZ8mO 0tAg/lrCb0o9PJJ21I/fckQ3qhAJWyA1I/BQxrBfE16W9Ywh65SA5CLDKg5hXX45 jervpWtfi6jjkgCy9A/lmmJ0pUKL7RsES8Ot8eI/aUMpmwaGf4rYuk+ZjrQiEJ9v 2xT439SXYuQw6RK3EJUeaLiMr8PiYDEluWSPbD5uYtxjUwI4L/PXRGMuqxUz+TSz 7O2jC8FHHRYuGLAskgZetd3RYi8Ip3ApPySntkZJ0B4HwNSg4AzSUaiL6UYVnNZH 8PB+dJKSx94Zb+gRA/IgonsXM0AuD9roOeVXYMCiE92ubzHHboO8YQ6dsaYM9Ial vlyz2JJWEYqBCTBD5P/c =PHTE -----END PGP SIGNATURE-----

2 1

Re: [6/6] oleaut32/tests: Add more tests for typelib data.
by Andrew Eikum 06 Oct '15

06 Oct '15

On Mon, Oct 05, 2015 at 08:36:31PM +0800, Dmitry Timoshkov wrote: > +{ > + "a", > + "{00000000-0000-0000-0000-000000000000}", > + /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4, > + /*#vtbl*/ 0, /*#func*/ 0 > +}, ... > +{ > + "c", > + "{016fe2ec-b2c8-45f8-b23b-39e53a75396b}", > + /*kind*/ TKIND_ALIAS, /*flags*/ 0, /*align*/ 1, /*size*/ 4, > + /*#vtbl*/ 0, /*#func*/ 0 > +}, These two tests fail on my Win7 VM: typelib.c:4378: Interface a typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4378: Interface _a typelib.c:4378: Interface aa typelib.c:4378: Interface _b typelib.c:4378: Interface bb typelib.c:4378: Interface c typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4378: Interface _c I get the same failures when running the tests on Wine. Unlike the testbot, everything else passes on my VM. Andrew

2 3

Re: [1/2] user32/tests: Add a test for sending WM_SIZE message to edit control.
by Nikolay Sivov 05 Oct '15

05 Oct '15

On 06.10.2015 0:42, Sebastian Lackner wrote: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > The test failure "edit.c:1521: Test failed: got 1, 1" on Win7 is unrelated to this patch. > > dlls/user32/tests/edit.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/dlls/user32/tests/edit.c b/dlls/user32/tests/edit.c > index e8b41c2..88bb364 100644 > --- a/dlls/user32/tests/edit.c > +++ b/dlls/user32/tests/edit.c > @@ -1481,6 +1481,15 @@ static void test_margins(void) > ok(new_rect.top == old_rect.top, "The top border of the rectangle has changed\n"); > ok(new_rect.bottom == old_rect.bottom, "The bottom border of the rectangle has changed\n"); > > + /* The lParam argument of the WM_SIZE message should be ignored. */ > + SendMessageA(hwEdit, EM_GETRECT, 0, (LPARAM)&old_rect); > + SendMessageA(hwEdit, WM_SIZE, 0, 0); > + SendMessageA(hwEdit, EM_GETRECT, 0, (LPARAM)&new_rect); > + ok(new_rect.left == old_rect.left, "The left border of the rectangle has changed\n"); > + todo_wine ok(new_rect.right == old_rect.right, "The right border of the rectangle has changed\n"); > + todo_wine ok(new_rect.top == old_rect.top, "The top border of the rectangle has changed\n"); > + todo_wine ok(new_rect.bottom == old_rect.bottom, "The bottom border of the rectangle has changed\n"); > + Maybe use EqualRect()? Could you add more tests for that? For example non-zero lParam, different combinations of wParam modes (with SIZE_RESTORED instead of 0). > DestroyWindow (hwEdit); > > memset(&lf, 0, sizeof(lf)); >

1 0

Re: [PATCH 2/5] ddraw/tests: Add Direct3D3 test section
by Stefan Dösinger 05 Oct '15

05 Oct '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi, Your mails ended up in my spam folder for some reason. Google says it has large similarities to other known spam mail, which seems unlikely to me. Am 2015-10-04 um 19:52 schrieb Andrew D'Addesio: > To avoid confusion, CreateDirect3D/ReleaseDirect3D is also renamed to > CreateDirect3D7/ReleaseDirect3D7. > --- > dlls/ddraw/tests/d3d.c | 167 +++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 154 insertions(+), 13 deletions(-) New tests should be added to ddraw*.c, ideally in all ddraw versions that offer the tested feature. The long term goal for d3d.c, dsurface.c, etc is to be migrated to those files. If you want to modify an existing test in d3d.c please move the existing code to ddraw*.c, then add your new test features to it. These files have some exising helper functions like create_device, so you don't have to take stuff like d3d3_create_objects along. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWEh67AAoJEN0/YqbEcdMwGUEQAIskKamXUC/+Kik99/eqbcpp 3SohARAHPivs+bf2GM68dBBeON9SbzlllfH/cIog9Z9oAUr2fGWDUMLQnyb96ANH +g39WlGO/HFEvqBI9B+mLrZO1VQaePwNH6Sv6p4d09OLWlyRa0PfGrImdqxBNwS2 /Z9j9PmHMQ2oV2KAM3vyqAGAX7VrLH+kr/fQqQofLhHGidHhXUZgkpOT67Drwp4/ 98B3QzFgFyo58Z1AWJ2hAJt4PZQ/uLIn3zQdnYzgsC2H3a9maLC2iB0l3CvXeMgi N8Sb+Nazvjtlu7ut6sNc7cOaharjnYLzKjTpqC0IV0TjFysa0BcwXAm1dj660KzK 2RAy6HeTbE4OpgbT+jU482GNTzhKtRX0EmyCIWD1YZV6li5SO4/mkqPp54D14pHK jgnMV689ZCayn+TpdbO2Q30USJD1tI3HwvXFWyweTFeB59ERmtruLJNDUQ3TtWct Wvcg9AMY8PaSFha/fhGis8/HUFmwWnRWt/E4rhVGmA5wLUD9NO7k0sGOxdRja6mE mNs/dE9ibLn3WB9K9NNLylI2W/4ATbUZoypdEb5H4hyejzfvsbj4LK+772qvLEkS +CEqcT5JwXVF2/XaGrXEkIWt1hz8CnGPHDFrylDoXdXBO5LYKkgKuXmBfFV7DU7Y HM8/Zo1J7TZ9r3yZjmm+ =cNFg -----END PGP SIGNATURE-----

2 2

Re: [6/6] oleaut32/tests: Add more tests for typelib data.
by Marvin 05 Oct '15

05 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17010 Your paranoid android. === wxppro (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2003std (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7u (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w8 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (32 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 40 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === wvistau64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w2008s64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w7pro64 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w864 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c} === w1064 (64 bit typelib) === typelib.c:4370: Test failed: ITypeLib_GetTypeInfoCount(typelib) expected 13 got 15 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4381: Test failed: bstrIfName expected "_b" got "aa" typelib.c:4381: Test failed: bstrIfName expected "bb" got "_b" typelib.c:4381: Test failed: bstrIfName expected "c" got "bb" typelib.c:4385: Test failed: typeattr->typekind expected 6 got 0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 1 got 4 typelib.c:4402: Test failed: got wrong guid {00000000-0000-0000-0000-000000000000} typelib.c:4381: Test failed: bstrIfName expected "_c" got "c" typelib.c:4385: Test failed: typeattr->typekind expected 0 got 6 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 4 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396b} typelib.c:4381: Test failed: bstrIfName expected "cc" got "_c" typelib.c:4381: Test failed: bstrIfName expected "ITestIface" got "cc" typelib.c:4385: Test failed: typeattr->typekind expected 3 got 6 typelib.c:4386: Test failed: typeattr->wTypeFlags expected 0x1000 got 0x0 typelib.c:4387: Test failed: typeattr->cbAlignment expected 4 got 1 typelib.c:4388: Test failed: typeattr->cbSizeInstance expected 8 got 0 typelib.c:4389: Test failed: typeattr->cbSizeVft expected 80 got 0 typelib.c:4390: Test failed: typeattr->cFuncs expected 3 got 0 typelib.c:4402: Test failed: got wrong guid {016fe2ec-b2c8-45f8-b23b-39e53a75396c}

2 1

Re: [PATCH 4/7] wined3d: Initialize unwritten texcoord varyings in the VS.
by Henri Verbeet 05 Oct '15

05 Oct '15

On 2 October 2015 at 14:54, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -4998,7 +4996,22 @@ static GLuint generate_param_reorder_function(struct shader_glsl_priv *priv, > output->register_idx, reg_mask[1]); > } > } > - shader_addline(buffer, "}\n"); > + > + for (i = 0; i < MAX_TEXTURES; ++i) > + { > + if (ps && !(ps->reg_maps.texcoord & (1u << i))) > + continue; > + > + if (texcoords_written_mask[i] != WINED3DSP_WRITEMASK_ALL) > + { > + if (gl_info->limits.glsl_varyings < wined3d_max_compat_varyings(gl_info) > + && !texcoords_written_mask[i]) > + continue; > + > + shader_glsl_write_mask_to_str(~texcoords_written_mask[i] & WINED3DSP_WRITEMASK_ALL, reg_mask); > + shader_addline(buffer, "gl_TexCoord[%u]%s = vec4(0.0)%s;\n", i, reg_mask, reg_mask); > + } > + } > } > else > { Doesn't this end up writing 0.0 to .w instead of 1.0? IIRC unwritten texture coordinates are assumed to be (0, 0, 0, 1) in D3D. May apply to the previous patch in the series as well.

3 4

Re: [3/6] oleaut32/tests: Update the typelib test generator to match existing data.
by Marvin 05 Oct '15

05 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17007 Your paranoid android. === wvistau64 (32 bit typelib) === The test timed out

1 0

Re: [PATCH] hidclass.sys: fixed copy/paste error (Coverity)
by Ken Thomases 05 Oct '15

05 Oct '15

On Oct 3, 2015, at 2:52 AM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > > 1325460 Identical code for different branches > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/hidclass.sys/descriptor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/hidclass.sys/descriptor.c b/dlls/hidclass.sys/descriptor.c > index 6f8e45e..35057f1 100644 > --- a/dlls/hidclass.sys/descriptor.c > +++ b/dlls/hidclass.sys/descriptor.c > @@ -414,7 +414,7 @@ void parse_io_feature(unsigned int bSize, int itemVal, int bTag, unsigned int *f > if ((itemVal & INPUT_ARRAY) == 0) > feature->isArray= TRUE; > else > - feature->isArray= TRUE; /* Var */ > + feature->isArray= FALSE; /* Var */ Hmm. First, doesn't that logic seem backward? You're now setting isArray to true only if itemVal does NOT contain INPUT_ARRAY. And wouldn't it be better to just replace that whole if statement by: feature->isArray = (itemVal & INPUT_ARRAY) != 0; ? (For what it's worth, I started to suggest the style refactoring first and that's what made it so obvious that the logic was wrong. The power of good style to improve comprehension!) > if ((itemVal & INPUT_ABS) == 0) > feature->IsAbsolute = TRUE; > else The rest of this function looks like it's riddled with similar backward logic. :( -Ken

2 3