October 2015 - Wine-devel - list.winehq.org

Re: wldap32: Remove superfluous const in ldap_init declarations.
by Hans Leidekker 30 Oct '15

30 Oct '15

On Sun, 2015-10-18 at 11:08 +0200, Thomas Faber wrote: > diff --git a/dlls/wldap32/winldap_private.h b/dlls/wldap32/winldap_private.h > index a19ceb1..8596d1d 100644 > --- a/dlls/wldap32/winldap_private.h > +++ b/dlls/wldap32/winldap_private.h > @@ -361,8 +361,8 @@ PCHAR * CDECL ldap_get_valuesA(WLDAP32_LDAP*,WLDAP32_LDAPMessage*,PCHAR); > PWCHAR * CDECL ldap_get_valuesW(WLDAP32_LDAP*,WLDAP32_LDAPMessage*,PWCHAR); > PBERVAL * CDECL ldap_get_values_lenA(WLDAP32_LDAP*,WLDAP32_LDAPMessage*,PCHAR); > PBERVAL * CDECL ldap_get_values_lenW(WLDAP32_LDAP*,WLDAP32_LDAPMessage*,PWCHAR); > -WLDAP32_LDAP * CDECL ldap_initA(const PCHAR,ULONG); > -WLDAP32_LDAP * CDECL ldap_initW(const PWCHAR,ULONG); > +WLDAP32_LDAP * CDECL ldap_initA(PCHAR,ULONG); > +WLDAP32_LDAP * CDECL ldap_initW(PWCHAR,ULONG); You should make the implementation match the prototype instead.

3 4

Re: d3d8types.h: Convert the D3DVSD_...SHIFT constants to unsigned.
by Gerald Pfeifer 30 Oct '15

30 Oct '15

On Sat, 24 Oct 2015, Gerald Pfeifer wrote: > This avoids potential shift overflows. I only should be necessary > for D3DVSD_TOKENTYPESHIFT, but it makes sense to have this consistent. Correction, this per se does not avoid shift overflows, I sent an older patch. It still may make sense to apply (please advise), but we'd need a different change in addition. I'll have a look. Gerald

2 2

Re: [PATCH] xmllite/tests: Fix memory leak (valgrind)
by Nikolay Sivov 30 Oct '15

30 Oct '15

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com>

1 0

Re: [PATCH] msctf/tests: Fix memory leaks (valgrind)
by Marvin 30 Oct '15

30 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17842 Your paranoid android. === w1064 (32 bit inputprocessor) === inputprocessor.c:791: Test failed: Deactivation came unexpectedly

1 0

Re: [PATCH 1/3] msctf: Add ITfThreadMgrEx stub.
by Alistair Leslie-Hughes 29 Oct '15

29 Oct '15

Hi Matteo, On 29/10/15 08:27, Matteo Bruni wrote: > Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> > --- > This avoids a crash on exit with World of Warships when the OS version > is set to Windows 7. > > dlls/msctf/threadmgr.c | 145 ++++++++++++++++++++++++++++--------------------- > include/msctf.idl | 14 +++++ > 2 files changed, 96 insertions(+), 63 deletions(-) Can you please provide tests? Best Regards Alistair Leslie-Hughes

2 1

Re: [PATCH 2/5] winepulse: Add format and period probing
by Andrew Eikum 29 Oct '15

29 Oct '15

On Tue, Oct 20, 2015 at 12:15:22PM +0900, Alexandre Julliard wrote: > Andrew Eikum <aeikum(a)codeweavers.com> writes: > > > Hm, it works here whether PA is running or not. What's your setup? PA > > is obviously installed. Is it running? What version do you have > > installed? Can you give me a +devenum,+mmdevapi,+pulse,+alsa,+tid,+seh > > log? > > Version 7.0, it's running AFAICT. Log is attached. Note that this is > with only the first patch applied, it also crashes (but not always which > is why I missed it at first). Other sound tests crash as well. > This was seen in my patchset, and not in wine-staging, because we unload the pulse driver after it returns Low priority which is lower than winealsa's Preferred priority. Winepulse misbehaved when it was unloaded. In wine-staging, the Pulse driver is always Preferred and so would never be unloaded. I believe the crash happened because the DLL would be unloaded while the PA mainloop thread was still running. DllMain does call pa_mainloop_quit, but doesn't wait for the thread to actually exit. The mainloop thread would occasionally trigger a callback after the module has been unloaded, before acknowledging the quit status. This is why you didn't always see the crash. This has been remedied in the latest patchset. We now wait for the thread to quit in DllMain, see patch 3/5. Andrew

1 0

Re: [PATCH 3/3] msvcp120: implement _Thrd_create/join
by Piotr Caban 29 Oct '15

29 Oct '15

On 10/29/15 15:50, Daniel Lehman wrote: > +int __cdecl _Thrd_join(_Thrd_t thr, int *unk) > +{ > + DWORD ret; > + > + TRACE("(%p %u %p)\n", thr.hnd, thr.id, unk); > + ret = WaitForSingleObject(thr.hnd, INFINITE); > + if (unk) > + GetExitCodeThread(thr.hnd, (DWORD *)unk); Please rename the unk parameter. You already know that it's a thread exit code. You should probably also exit earlier if WaitForSingleObject fails. It doesn't really make sense call GetExitCodeThread in this case. Probably there's also no need to close the handle if WaitForSingleObject fails. Thanks, Piotr

1 0

Re: [PATCH 04/4] msvcp120/tests: Add tests of tr2_sys__Open_dir, tr2_sys__Read_dir and tr2_sys__Close_dir.(try4)
by Marvin 29 Oct '15

29 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17823 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 3/3] msvcp120: implement _Thrd_create/join
by Marvin 29 Oct '15

29 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17817 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 2/3] msvcp120: implement _Thrd_current
by Marvin 29 Oct '15

29 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17816 Your paranoid android. === build (build) === Patch failed to apply

1 0