October 2015 - Wine-devel - list.winehq.org

Re: msasn1: implement ASN1_CreateModule
by Nikolay Sivov 28 Oct '15

28 Oct '15

On 27.10.2015 23:10, Austin English wrote: > This is based on code from the FreeRDP project, used with permission > of the author, Marc-André Moreau <marcandre.moreau(a)gmail.com> Do you plan to reuse more from there? Is it clean license-wise? And more importantly, how did FreeRDP project came up with that implementation? > > For https://bugs.winehq.org/show_bug.cgi?id=38020 > > + > +ASN1module_t WINAPI ASN1_CreateModule(ASN1uint32_t version, ASN1encodingrule_e rule, ASN1uint32_t flags, ASN1uint32_t pdu, const ASN1GenericFun_t encoder[], const ASN1GenericFun_t decoder[], const ASN1FreeFun_t freememory[], const ASN1uint32_t size[], ASN1magic_t modulename) arg[] notation seems redundant, *arg is cleaner and more common for Wine. > + ASN1module_t module = NULL; No need to init this. > + if (!((encoder) && (decoder) && (freememory) && (size))) > + return NULL; ... > + module = (ASN1module_t) malloc(sizeof(struct tagASN1module_t)); > + ZeroMemory(module, sizeof(struct tagASN1module_t)); Heap* API please. And you don't need to zero-init it, or use tag* names. All structures seem to be documented well, what's a reason to reuse simple parts like such structure allocations? Can this be tested by directly calling ASN1_* functions? If yes, simple test would be nice to have.

3 2

Re: [v3 signed 1/6] d3d9: improved d3d9_device_UpdateSurface
by Henri Verbeet 28 Oct '15

28 Oct '15

On 22 October 2015 at 12:01, Riccardo Bortolato <rikyz619(a)gmail.com> wrote: > enabled previously failing test in device.c > removed wined3d_device_update_surface from wined3d and replaced its usage with surface_upload_from_surface. > This was mentioned in the discussion in the other thread, but just for the record, the options are either wined3d_device_update_sub_resource() or wined3d_device_copy_sub_resource_region().

2 5

Re: mshtml: Fixed more test failures on win10.
by Marvin 28 Oct '15

28 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17770 Your paranoid android. === w1064 (32 bit htmldoc) === htmldoc.c:3569: Test failed: unexpected call IsErrorUrl

1 0

Re: [PATCH] vbscript/tests: Show IActiveScriptSite OnScriptError is called on error
by Jacek Caban 28 Oct '15

28 Oct '15

Hi Alistair, On 10/26/15 09:56, Alistair Leslie-Hughes wrote: > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/vbscript/tests/run.c | 47 ++++++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 46 insertions(+), 1 deletion(-) > > diff --git a/dlls/vbscript/tests/run.c b/dlls/vbscript/tests/run.c > index a86711a..e625136 100644 > --- a/dlls/vbscript/tests/run.c > +++ b/dlls/vbscript/tests/run.c > @@ -100,6 +100,7 @@ DEFINE_EXPECT(Next); > DEFINE_EXPECT(GetWindow); > DEFINE_EXPECT(GetUIBehavior); > DEFINE_EXPECT(EnableModeless); > +DEFINE_EXPECT(on_script_error); Please use OnScriptError for consistency. > #define DISPID_GLOBAL_REPORTSUCCESS 1000 > #define DISPID_GLOBAL_TRACE 1001 > @@ -138,6 +139,7 @@ static const char *test_name = "(null)"; > static int test_counter; > static SCRIPTUICHANDLING uic_handling = SCRIPTUICHANDLING_NOUIERROR; > static IDispatchEx testObj; > +static BOOL overwrite_return = FALSE; How about using HRESULT here... > static BSTR a2bstr(const char *str) > { > @@ -1623,7 +1625,22 @@ static HRESULT WINAPI ActiveScriptSite_OnStateChange(IActiveScriptSite *iface, S > > static HRESULT WINAPI ActiveScriptSite_OnScriptError(IActiveScriptSite *iface, IActiveScriptError *pscripterror) > { > - return E_NOTIMPL; > + HRESULT hr; > + EXCEPINFO ei = {0}; > + > + CHECK_EXPECT(on_script_error); > + > + hr = IActiveScriptError_GetExceptionInfo(pscripterror, &ei); > + ok(hr == S_OK, "GetExceptionInfo %x\n", hr); > + > + if(overwrite_return) > + { > + overwrite_return = FALSE; > + return S_OK; > + } > + > + /* We return the EXCEPINFO error since returning S_OK means we have handled the error */ > + return ei.scode; ... and return it here for simplicity? Thanks, Jacek

2 3

Re: [PATCH 3/3] rpcrt4: Added RpcMgmtIsServerListening tests.
by Marvin 28 Oct '15

28 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17748 Your paranoid android. === w8 (32 bit server) === server.c:984: Test failed: get_ranged_enum() returned 1997799427 instead of RE3 === w864 (32 bit server) === server.c:984: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 server.c:984: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 server.c:984: Test failed: get_ranged_enum() returned 2009071619 instead of RE3 === w864 (64 bit server) === server.c:984: Test failed: get_ranged_enum() returned 184549379 instead of RE3 === w1064 (64 bit server) === server.c:984: Test failed: get_ranged_enum() returned 2883587 instead of RE3 server.c:984: Test failed: get_ranged_enum() returned 5767171 instead of RE3

2 1

Re: [PATCH] comctl32/listview: Fix printf format (PVS-Studio)
by Alexandre Julliard 28 Oct '15

28 Oct '15

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -587,7 +587,7 @@ static const char* debugscrollinfo(const SCROLLINFO *pScrollInfo) > int len, size = DEBUG_BUFFER_SIZE; > > if (pScrollInfo == NULL) return "(null)"; > - len = snprintf(buf, size, "{cbSize=%d, ", pScrollInfo->cbSize); > + len = snprintf(buf, size, "{cbSize=%u, ", pScrollInfo->cbSize); That doesn't seem very necessary. I don't mind a few fixes like that, but I'm concerned that there would be a million of them. How many do you expect? -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: dhcpcsvc: add a stub for DhcpRequestParams (try 3)
by Matteo Bruni 28 Oct '15

28 Oct '15

2015-10-27 17:28 GMT+01:00 Austin English <austinenglish(a)gmail.com>: +typedef struct _DHCPAPI_PARAMS_ARRAY That is typoed as "ARARAY" in the header from MS (the one from the 8.1 SDK at least), so this probably needs the same treatment. The "Params" field has additional stuff for the midl case, not sure we care about that though.

1 0

Re: kernel32/tests: Simplify an ok() condition (PVS-Studio)
by Marvin 28 Oct '15

28 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17766 Your paranoid android. === wxppro (32 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:882: Test failed: WaitCommEvent error 0 comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:887: WaitCommEvent for EV_TXEMPTY took 1500 ms (timeout 1500) comm.c:888: Test failed: WaitCommEvent used 1500 ms for waiting comm.c:1553: test_AbortWaitCts timeout 500 handle 00000770 comm.c:1520: Changing CommMask on the fly for handle 00000770 after timeout 500 === w2003std (32 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:882: Test failed: WaitCommEvent error 0 comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:887: WaitCommEvent for EV_TXEMPTY took 1500 ms (timeout 1500) comm.c:888: Test failed: WaitCommEvent used 1500 ms for waiting comm.c:1553: test_AbortWaitCts timeout 500 handle 00000760 comm.c:1520: Changing CommMask on the fly for handle 00000760 after timeout 500 === w2008s64 (32 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:882: Test failed: WaitCommEvent error 0 comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:887: WaitCommEvent for EV_TXEMPTY took 1500 ms (timeout 1500) comm.c:888: Test failed: WaitCommEvent used 1500 ms for waiting comm.c:1553: test_AbortWaitCts timeout 500 handle 000000BC comm.c:1520: Changing CommMask on the fly for handle 000000BC after timeout 500 === w7pro64 (32 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:882: Test failed: WaitCommEvent error 0 comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:887: WaitCommEvent for EV_TXEMPTY took 1514 ms (timeout 1500) comm.c:888: Test failed: WaitCommEvent used 1514 ms for waiting comm.c:1553: test_AbortWaitCts timeout 500 handle 00000128 comm.c:1520: Changing CommMask on the fly for handle 00000128 after timeout 500 === wvistau64 (64 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:882: Test failed: WaitCommEvent error 0 comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:887: WaitCommEvent for EV_TXEMPTY took 1514 ms (timeout 1500) comm.c:888: Test failed: WaitCommEvent used 1514 ms for waiting === w7pro64 (64 bit comm) === comm.c:861: Test failed: WaitCommEvent failed with a timeout comm.c:872: recovering after WAIT_TIMEOUT... comm.c:882: Test failed: WaitCommEvent error 0 comm.c:883: Test failed: WaitCommEvent: expected EV_TXEMPTY, got 0 comm.c:887: WaitCommEvent for EV_TXEMPTY took 1514 ms (timeout 1500) comm.c:888: Test failed: WaitCommEvent used 1514 ms for waiting

2 1

Re: rsaenh/tests: Mark an old behavior as broken (PVS-Studio)
by Marvin 28 Oct '15

28 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17767 Your paranoid android. === w1064 (32 bit rsaenh) === rsaenh.c:2804: Test failed: 80090020

2 1

Re: [PATCH 6/6] kernel32/tests: Add tests for GetConsoleFontSize (v2)
by Marvin 28 Oct '15

28 Oct '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=17765 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1689: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2359244 === w864 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2686924 console.c:1689: Test failed: [13] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [15] Expected output count to be 0, got 2686924 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2686924 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [15] Expected output count to be 0, got 2752460 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2752460 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

2 1