November 2015 - Wine-devel - list.winehq.org

Re: winspool: Remove dead code (Clang)
by Alex Henrie 29 Nov '15

29 Nov '15

- if(WINSPOOL_GetStringFromReg(hkeyPrinter, NameW, ptr, left, &size)) { - if(space && size <= left) { - pi4->pPrinterName = (LPWSTR)ptr; - ptr += size; - left -= size; - } else + if(WINSPOOL_GetStringFromReg(hkeyPrinter, NameW, buf, left, &size)) { + if(space && size <= left) + pi4->pPrinterName = (LPWSTR)buf; + else Could you indent this better? -Alex

1 0

Scan-build report uploaded
by André Hentschel 29 Nov '15

29 Nov '15

Hi, in case someone is interested, i've uploaded a scan-build here: http://dawncrow.de/scan-build-2015-11-28-143038-14935-1/index.html Wine source is 1.8-rc2

1 0

Re: [PATCH 1/7] msctf: Add a partial implementation of ITfThreadMgrEx_ActivateEx().
by Marvin 27 Nov '15

27 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18605 Your paranoid android. === w1064 (32 bit inputprocessor) === inputprocessor.c:791: Test failed: Deactivation came unexpectedly

2 1

Re: winedbg: suppress bogus clone() frames in backtrace
by Alexandre Julliard 27 Nov '15

27 Nov '15

Daniel Santos <daniel.santos(a)pobox.com> writes: > Signed-off-by: Daniel Santos <daniel.santos(a)pobox.com> > --- > programs/winedbg/stack.c | 27 ++++++++++++++++++++++----- > 1 file changed, 22 insertions(+), 5 deletions(-) This is only hiding the bug. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winedbg: suppress bogus clone() frames in backtrace
by Ralf Habacker 27 Nov '15

27 Nov '15

Am 26.11.2015 um 09:25 schrieb Daniel Santos: > Signed-off-by: Daniel Santos <daniel.santos(a)pobox.com> > --- > programs/winedbg/stack.c | 27 ++++++++++++++++++++++----- > 1 file changed, 22 insertions(+), 5 deletions(-) > > diff --git a/programs/winedbg/stack.c b/programs/winedbg/stack.c > index f49480a..8ef2dbc 100644 > --- a/programs/winedbg/stack.c > +++ b/programs/winedbg/stack.c > @@ -307,6 +307,11 @@ static void stack_print_addr_and_args(int nf) > im.ModuleName, (DWORD_PTR)(ihsf.InstructionOffset - im.BaseOfImage)); > } > > +static int addr_is_nonzero(const ADDRESS64 *addr) > +{ > + return addr->Offset && (addr->Mode != AddrModeFlat || addr->Segment); > +} > + > /****************************************************************** > * backtrace > * > @@ -322,12 +327,24 @@ static void backtrace(void) > dbg_curr_thread->curr_frame < dbg_curr_thread->num_frames; > dbg_curr_thread->curr_frame++) > { > - dbg_printf("%s%d ", > - (cf == dbg_curr_thread->curr_frame ? "=>" : " "), > - dbg_curr_thread->curr_frame); > - stack_print_addr_and_args(dbg_curr_thread->curr_frame); > + const unsigned nf = dbg_curr_thread->curr_frame; > + const ADDRESS64 *addr = &dbg_curr_thread->frames[nf].addr_frame; > + > + /* suppress bogus clone() frames from repeating */ Hi, any idea if the mentioned bug have the same reason https://bugs.winehq.org/show_bug.cgi?id=39606 Regards Ralf

1 0

Re: Fix warning: logical not is only applied to the left hand side of this comparison
by Bruno Jesus 26 Nov '15

26 Nov '15

On Fri, Nov 27, 2015 at 4:49 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > Thanks Bruno for the critics. > Now I rebase the patches to recent wine-1.8-rc1-89-g4a315cd > and split them to separate commits. > Now only two files because third is already corrected. You are almost there, but each patch must have it's own email with the correct subject.

1 0

Re: po: Update Simplified Chinese translation.
by Jactry Zeng 26 Nov '15

26 Nov '15

Hi Boyuan, Thanks for your contribution! This patch looks fine to me, but I'm not sure should we add translation which is fuzzy: > #: cryptui.rc:286 > +#, fuzzy > > #: cryptui.rc:376 > +#, fuzzy -- Regards, Jactry Zeng

2 2

Re: [PATCH] Assorted typos fixes
by Marvin 26 Nov '15

26 Nov '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18579 Your paranoid android. === w1064 (32 bit misc) === misc.c:756: Test failed: [52] wrong mime: L"image/x-icon"

1 0

What is the meaning of the 200 __clone lines in backtraces?
by Bruno Jesus 26 Nov '15

26 Nov '15

Hi all, this is something I have been curious for a long time. When an application crashes it is very common to see that the backtraces at some point start showing: 42 0xf750962e __clone+0x5d() in libc.so.6 (0x00000000) 43 0xf750962e __clone+0x5d() in libc.so.6 (0x00000000) 44 0xf750962e __clone+0x5d() in libc.so.6 (0x00000000) 45 0xf750962e __clone+0x5d() in libc.so.6 (0x00000000) Up to 200. Is this a bug or it is just not possible to identify when the backtrace ends and 200 is a hard limit or what else could it be? Best wishes, Bruno

3 2

Re: Fix warning: logical not is only applied to the left hand side of this comparison
by Bruno Jesus 26 Nov '15

26 Nov '15

On Thu, Nov 26, 2015 at 3:11 AM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > It may cause a mistake if will work not as intended. > > Signed-off-by: Sergey Isakov <isakov-sl(a)bk.ru> Hi, Sergey. Please split your changes to 1 patch per DLL and adjust the subject line according to the guidelines (http://wiki.winehq.org/SubmittingPatches) for example: msi/tests: Simplify the logic in a if condition tapi32: Simplify the logic in a if condition winex11.drv: Simplify the logic in a if condition

3 2