December 2015 - Wine-devel - list.winehq.org

Re: ntdll: Fix NtQueryDirectoryFile behavior on short file names on case insensitive file systems
by Marvin 21 Dec '15

21 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19069 Your paranoid android. === w1064 (32 bit directory) === directory.c:302: Test failed: incorrect long file name: L"longfilename.tmp\7434,"

1 0

Re: kernel32/tests: Add test for process object destruction.
by Marvin 21 Dec '15

21 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19056 Your paranoid android. === wvistau64 (32 bit process) === process.c:2791: Test failed: WaitForSingleObject returned 258 === wvistau64 (64 bit process) === prporocess: process1 tests executed (0 marked .c:2791: Test failed: Waias todotForSingleObject ret, 0 failures), 0urned 258

2 1

Re: [PATCH] user32/tests: One more activation context test for interthread SendMessage
by Marvin 21 Dec '15

21 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19044 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:10623: Test failed: expected PeekMessage to return FALSE, got 1 === w1064 (32 bit msg) === msg.c:6095: Test failed: Update region shouldn't be empty msg.c:6329: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6331: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6101: Test failed: Regions are different msg.c:6101: Test failed: Regions are different msg.c:6101: Test failed: Regions are different

2 1

Re: services: Consistently use debug functions with WINE_ prefix.
by Michael Stefaniuc 21 Dec '15

21 Dec '15

On 12/21/2015 05:55 AM, Sebastian Lackner wrote: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> --- > > Similar mistakes exist in many of the other programs. Is this > something we want to fix for consistency reasons? I did that but the other way around aka consistently use the un-prefixed versions. > > programs/services/rpc.c | 2 +- programs/services/services.c > | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/programs/services/rpc.c b/programs/services/rpc.c > index 89a8c91..591d7d1 100644 --- a/programs/services/rpc.c +++ > b/programs/services/rpc.c @@ -1434,7 +1434,7 @@ DWORD __cdecl > svcctl_EnumServicesStatusExW( needed, returned, > wine_dbgstr_w(group)); > > if (resume_handle) - FIXME("resume handle not > supported\n"); + WINE_FIXME("resume handle not > supported\n"); > > if (!type || !state) return ERROR_INVALID_PARAMETER; diff --git > a/programs/services/services.c b/programs/services/services.c index > 1335837..2ec465e 100644 --- a/programs/services/services.c +++ > b/programs/services/services.c @@ -684,7 +684,7 @@ static DWORD > get_service_binary_path(const struct service_entry *service_entry, > strcatW( redirected, &(*path)[len] ); HeapFree( GetProcessHeap(), > 0, *path ); *path = redirected; - TRACE("redirected to > %s\n", debugstr_w(redirected)); + WINE_TRACE("redirected to > %s\n", debugstr_w(redirected)); } > > return ERROR_SUCCESS; > bye michael

1 0

Re: [PATCH] user32: Implement MOUSEHOOKSTRUCTEX
by Nikolay Sivov 21 Dec '15

21 Dec '15

On 21.12.2015 14:14, Kira Backes wrote: > - Fixes out-of-bounds access for programs which cast to MOUSEHOOKSTRUCTEX > - Fixes mouse wheel support for those programs > - Fixes Bug 38314 > > Signed-off-by: Kira Backes <kira.backes(a)nrwsoft.de> > --- > dlls/user32/message.c | 28 ++++++++++++++++------------ > include/winuser.h | 6 ++++++ > tools/winapi/tests.dat | 3 +++ > 3 files changed, 25 insertions(+), 12 deletions(-) > > diff --git a/dlls/user32/message.c b/dlls/user32/message.c > index 96e7f2e..c1fc45d 100644 > --- a/dlls/user32/message.c > +++ b/dlls/user32/message.c > @@ -2488,7 +2488,7 @@ static BOOL process_mouse_message( MSG *msg, > UINT hw_id, ULONG_PTR extra_info, H > INT hittest; > EVENTMSG event; > GUITHREADINFO info; > - MOUSEHOOKSTRUCT hook; > + MOUSEHOOKSTRUCTEX hookEx; > BOOL eatMsg; > Hi, Kira. Please keep variable name as it is, and resend using git-send-email or as an attachment - your mail client wrapped patch lines breaking a patch.

1 0

Re: [3/4 resend] riched20/tests: Add multibyte character tests for selection.
by Huw Davies 21 Dec '15

21 Dec '15

> diff --git a/dlls/riched20/tests/editor.c b/dlls/riched20/tests/editor.c > index 6c4195c..7c7200b 100644 > --- a/dlls/riched20/tests/editor.c > +++ b/dlls/riched20/tests/editor.c > @@ -4577,6 +4577,28 @@ static void test_EM_EXSETSEL(void) > + SendMessageA(hwndRichEdit, WM_SETTEXT, 0, (LPARAM)"abcdef\x8e\xf0ghijk"); > + /* 012345 6 78901 */ > + /* 10 */ I find this second comment line confusing. I assume you're trying to show that 'j' is at index 10. Either shift the '1' one place to the right so it's underneath the '0' and lose the '0' in this line, or better still just remove the second comment line completely (most people can figure out that zero after nine means ten). This obviously applies to similar lines in this patch and the next. Huw.

1 0

Re: user32: Set correct caret state in the server in SetCaretPos (try 2)
by Sebastian Lackner 20 Dec '15

20 Dec '15

On 20.12.2015 19:42, Anton Baskanov wrote: > Signed-off-by: Anton Baskanov <baskanov(a)gmail.com> > > The code in SetCaretPos doesn't change the caret state if it's position is unchanged. > Reflect this at the server side to avoid caret corruption. > > try2: > - fixed incorrect if statement in the server > --- > dlls/user32/caret.c | 2 +- > server/protocol.def | 3 ++- > server/queue.c | 5 +++++ > 3 files changed, 8 insertions(+), 2 deletions(-) > I assume the "corruption" you mean is that the state could get out of sync between wineserver and child process. However, is there a specific reason (for example testcase) which shows that this is the right way to fix it? A different (and much easier) possibility would be: - if (ret && !hidden && (x != r.left || y != r.top)) + if (ret && !hidden && (x != r.left || y != r.top || !old_state)) Regards, Sebastian

1 0

Re: user32: Set correct caret state in the server in SetCaretPos
by Dmitry Timoshkov 20 Dec '15

20 Dec '15

Anton Baskanov <baskanov(a)gmail.com> wrote: > @@ -3040,6 +3040,10 @@ DECL_HANDLER(set_caret_info) > if (req->flags & SET_CARET_STATE) > { > if (req->state == -1) input->caret_state = !input->caret_state; > + else if (req->state == -2 && > + (req->x != reply->old_rect.left || > + req->y != reply->old_rect.top)) > + input->caret_state = 1; > else input->caret_state = !!req->state; > } If state == -2 but the additional logic won't match this would fall into unexpected 3rd case. -- Dmitry.

2 1

Re: Wine release 1.8
by Ken Thomases 19 Dec '15

19 Dec '15

On Dec 19, 2015, at 10:05 AM, Alexandre Julliard <julliard(a)winehq.org> wrote: > > The Wine team is proud to announce that the stable release Wine 1.8 > is now available. Congratulations, all! Cheers, Ken

3 2

Calling convention (__stdcall/__cdecl) mismatches between windef.h and crtdefs.h
by Bob Ha 19 Dec '15

19 Dec '15

Hi, It seems crtdefs.h uses older #ifdef checks.Depending on the inclusion order, crtdefs.h's one is being used, e.g. for msvcp*.dll's windef.h # if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 2)) || defined(__APPLE__) crtdefs.h# ifdef __APPLE__ /* Mac OS X uses a 16-byte aligned stack and not a 4-byte one */ Is this something needed to be modified? Cheers ! Bob

2 1