December 2015 - Wine-devel - list.winehq.org

Re: shlwapi/tests: Test NULL handle duplication in SHMapHandle()
by Olivier F. R. Dierick 02 Dec '15

02 Dec '15

Le mardi 01 décembre 2015 à 19:51 +0800, Bruno Jesus a écrit : > Related to https://bugs.winehq.org/show_bug.cgi?id=36838 > > Not sure when Olivier Dierick will be back to this so I'm sending the > test I made. > > Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Thank you. The shlwapi functions are undocumented in MSDN. This is were I found documentation for the SHMapHandle() function: http://www.geoffchappell.com/studies/windows/shell/shlwapi/api/shared/mapha… -- Olivier F. R. Dierick o.dierick(a)piezo-forte.be

1 0

Re: Shell32: Check null handles before freeing
by Nikolay Sivov 01 Dec '15

01 Dec '15

On 25.11.2015 10:02, Olivier F. R. Dierick wrote: > Fix one of the error leak source that prevents the installer to succeed > (bug 36838). > > The original code did not check if the handles were null before freeing > them. For some reason they happen to be null and last error is set to > ERROR_INVALID_HANDLE. The game installer chokes at some point when the > last error is anything but zero and fails to complete the installation. > Checking if the handles are non-null before freeing them avoids this. > According to MSDN, it is not an error to have null values for those > handles. > > Signed-off-by: Olivier F. R. Dierick <o.dierick(a)piezo-forte.be> > --- > dlls/shell32/changenotify.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > We most likely have many more places that do same thing, it will need tests for SHFree() and CoTaskMemFree(). If it turns out error is not changed on NULLs, it's easier to return early from SHFree or CoTaskMemFree than fix all places where those are used.

2 2

Re: dinput: Implement device property DIPROP_USERNAME.
by Sebastian Lackner 01 Dec '15

01 Dec '15

On 01.12.2015 14:54, Bernhard Übelacker wrote: > https://bugs.winehq.org/show_bug.cgi?id=39667 > > Probably same issue as in https://bugs.winehq.org/show_bug.cgi?id=12432 . > (Attached backtrace seems equal.) > > Steps to reproduce: > - start launcher > - "Configure Controller" > - leave dialog with "Cancel" > - crash > > MotoGP 3 demo launcher uses ConfigureDevices for the key mapping. > The crash seems to happen because the result of a > GetProperty(DIPROP_USERNAME) is used without checking. > > This affects just the launcher. The game starts without problems with > a default key mapping. > > Signed-off-by: Bernhard Übelacker <bernhardu(a)vr-web.de> > --- > dlls/dinput/device.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/dinput/device_private.h | 1 + > dlls/dinput8/tests/device.c | 29 +++++++++++++++++++++++++++-- > 3 files changed, 72 insertions(+), 2 deletions(-) > > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c > index e525f01..1095c4c 100644 > --- a/dlls/dinput/device.c > +++ b/dlls/dinput/device.c > @@ -783,6 +783,7 @@ HRESULT _set_action_map(LPDIRECTINPUTDEVICE8W iface, LPDIACTIONFORMATW lpdiaf, L > DIOBJECTDATAFORMAT *obj_df = NULL; > DIPROPDWORD dp; > DIPROPRANGE dpr; > + DIPROPSTRING dps; > WCHAR username[MAX_PATH]; > DWORD username_size = MAX_PATH; > int i, action = 0, num_actions = 0; > @@ -863,6 +864,19 @@ HRESULT _set_action_map(LPDIRECTINPUTDEVICE8W iface, LPDIACTIONFORMATW lpdiaf, L > else > lstrcpynW(username, lpszUserName, MAX_PATH); > > + dps.diph.dwSize = sizeof(dps); > + dps.diph.dwHeaderSize = sizeof(DIPROPHEADER); > + dps.diph.dwObj = 0; > + dps.diph.dwHow = DIPH_DEVICE; > + lstrcpynW(dps.wsz, username, sizeof(dps.wsz)); > + IDirectInputDevice8_SetProperty(iface, DIPROP_USERNAME, &dps.diph); > + > + if (dwFlags & DIDSAM_NOUSER) > + { > + HeapFree(GetProcessHeap(), 0, This->username); > + This->username = NULL; > + } When I understand it correctly, if DISAM_NOUSER is set, you set the username just to reset it manually again afterwards? Why not pass an empty string to IDirectInputDevice8_SetProperty? > + > /* Save the settings to disk */ > save_mapping_settings(iface, lpdiaf, username); > > @@ -1100,6 +1114,9 @@ ULONG WINAPI IDirectInputDevice2WImpl_Release(LPDIRECTINPUTDEVICE8W iface) > /* Free action mapping */ > HeapFree(GetProcessHeap(), 0, This->action_map); > > + /* Free username */ > + HeapFree(GetProcessHeap(), 0, This->username); > + > EnterCriticalSection( &This->dinput->crit ); > list_remove( &This->entry ); > LeaveCriticalSection( &This->dinput->crit ); > @@ -1251,6 +1268,17 @@ HRESULT WINAPI IDirectInputDevice2WImpl_GetProperty(LPDIRECTINPUTDEVICE8W iface, > TRACE("buffersize = %d\n", pd->dwData); > break; > } > + case (DWORD_PTR) DIPROP_USERNAME: > + { > + LPDIPROPSTRING ps = (LPDIPROPSTRING)pdiph; > + > + if (pdiph->dwSize != sizeof(DIPROPSTRING)) return DIERR_INVALIDPARAM; > + > + ps->wsz[0] = 0; > + if (This->username) > + lstrcpynW(ps->wsz, This->username, sizeof(ps->wsz)); The last argument is wrong, it should be a WCHAR count. > + break; > + } > case (DWORD_PTR) DIPROP_VIDPID: > FIXME("DIPROP_VIDPID not implemented\n"); > return DIERR_UNSUPPORTED; > @@ -1324,6 +1352,22 @@ HRESULT WINAPI IDirectInputDevice2WImpl_SetProperty( > LeaveCriticalSection(&This->crit); > break; > } > + case (DWORD_PTR) DIPROP_USERNAME: > + { > + LPCDIPROPSTRING ps = (LPCDIPROPSTRING)pdiph; > + > + if (pdiph->dwSize != sizeof(DIPROPSTRING)) return DIERR_INVALIDPARAM; > + > + if (!This->username) > + This->username = HeapAlloc(GetProcessHeap(), 0, sizeof(ps->wsz)); > + if (!This->username) > + return DIERR_OUTOFMEMORY; > + > + This->username[0] = 0; > + if (ps->wsz) > + lstrcpynW(This->username, ps->wsz, sizeof(ps->wsz)); Same here. Also, it could make sense to look at the actual string length, instead of allocating a fixed size buffer. > + break; > + } > default: > WARN("Unknown property %s\n", debugstr_guid(rguid)); > return DIERR_UNSUPPORTED; > diff --git a/dlls/dinput/device_private.h b/dlls/dinput/device_private.h > index 52bbec4..26ec7c2 100644 > --- a/dlls/dinput/device_private.h > +++ b/dlls/dinput/device_private.h > @@ -81,6 +81,7 @@ struct IDirectInputDeviceImpl > /* Action mapping */ > int num_actions; /* number of actions mapped */ > ActionMap *action_map; /* array of mappings */ > + WCHAR *username; /* set in SetActionMap */ > }; > > extern BOOL get_app_key(HKEY*, HKEY*) DECLSPEC_HIDDEN; > diff --git a/dlls/dinput8/tests/device.c b/dlls/dinput8/tests/device.c > index 6495559..af8667d 100644 > --- a/dlls/dinput8/tests/device.c > +++ b/dlls/dinput8/tests/device.c > @@ -223,8 +223,8 @@ static BOOL CALLBACK enumeration_callback(const DIDEVICEINSTANCEA *lpddi, IDirec > dps.wsz[0] = '\0'; > > hr = IDirectInputDevice_GetProperty(lpdid, DIPROP_USERNAME, &dps.diph); > - todo_wine ok (SUCCEEDED(hr), "GetProperty failed hr=%08x\n", hr); > - todo_wine ok (!lstrcmpW(usernameW, dps.wsz), "Username not set correctly expected=%s, got=%s\n", wine_dbgstr_wn(usernameW, -1), wine_dbgstr_wn(dps.wsz, -1)); > + ok (SUCCEEDED(hr), "GetProperty failed hr=%08x\n", hr); > + ok (!lstrcmpW(usernameW, dps.wsz), "Username not set correctly expected=%s, got=%s\n", wine_dbgstr_wn(usernameW, -1), wine_dbgstr_wn(dps.wsz, -1)); > > /* Test buffer size */ > memset(&dp, 0, sizeof(dp)); > @@ -275,6 +275,7 @@ static void test_action_mapping(void) > HINSTANCE hinst = GetModuleHandleA(NULL); > IDirectInput8A *pDI = NULL; > DIACTIONFORMATA af; > + DIPROPSTRING dps; > struct enum_data data = {pDI, &af, NULL, NULL, NULL, 0}; > HWND hwnd; > > @@ -342,6 +343,30 @@ static void test_action_mapping(void) > > af.dwDataSize = 4 * sizeof(actionMapping) / sizeof(actionMapping[0]); > af.dwNumActions = sizeof(actionMapping) / sizeof(actionMapping[0]); > + > + /* test DIDSAM_NOUSER */ > + dps.diph.dwSize = sizeof(dps); > + dps.diph.dwHeaderSize = sizeof(DIPROPHEADER); > + dps.diph.dwObj = 0; > + dps.diph.dwHow = DIPH_DEVICE; > + dps.wsz[0] = '\0'; > + > + hr = IDirectInputDevice_GetProperty(data.keyboard, DIPROP_USERNAME, &dps.diph); > + ok (SUCCEEDED(hr), "GetProperty failed hr=%08x\n", hr); > + ok (dps.wsz[0] != 0, "Expected any username, got=%s\n", wine_dbgstr_wn(dps.wsz, -1)); > + > + hr = IDirectInputDevice8_SetActionMap(data.keyboard, data.lpdiaf, NULL, DIDSAM_NOUSER); > + ok (SUCCEEDED(hr), "SetActionMap failed hr=%08x\n", hr); > + > + dps.diph.dwSize = sizeof(dps); > + dps.diph.dwHeaderSize = sizeof(DIPROPHEADER); > + dps.diph.dwObj = 0; > + dps.diph.dwHow = DIPH_DEVICE; > + dps.wsz[0] = '\0'; > + > + hr = IDirectInputDevice_GetProperty(data.keyboard, DIPROP_USERNAME, &dps.diph); > + ok (SUCCEEDED(hr), "GetProperty failed hr=%08x\n", hr); > + ok (dps.wsz[0] == 0, "Expected empty username, got=%s\n", wine_dbgstr_wn(dps.wsz, -1)); > } > > if (data.mouse != NULL) >

1 0

Re: [PATCH 4/4 v2] dsound: Fail to create a version 8 3d buffer with DSBCAPS_CTRLPAN
by Alexandre Julliard 01 Dec '15

01 Dec '15

Michael Stefaniuc <mstefani(a)redhat.de> writes: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/dsound/dsound.c | 5 +++++ > dlls/dsound/tests/ds3d8.c | 1 - > 2 files changed, 5 insertions(+), 1 deletion(-) Does this one fix a bug or is it just a consequence of the tests? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 3/4] dsound: A version 1 3d secondary buffer allows SetPan().
by Marvin 01 Dec '15

01 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18692 Your paranoid android. === wxppro (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w2003std (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7u (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7pro64 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w8 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w864 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w1064 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7pro64 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w864 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w1064 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000

1 0

Re: [PATCH 2/4] dsound/tests: Test Pan for 3D secondary buffers too.
by Marvin 01 Dec '15

01 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18691 Your paranoid android. === wxppro (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w2003std (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7u (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7pro64 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w8 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w864 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w1064 (32 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w7pro64 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w864 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 === w1064 (64 bit ds3d) === ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000 ds3d.c:894: Test failed: IDirectSoundBuffer_GetPan() should have returned DSERR_CONTROLUNAVAIL, returned: 00000000

1 0

Re: [PATCH] ddraw/tests: 64-bit ddraw doesn't support textures.
by Marvin 01 Dec '15

01 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18683 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2184: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH] ole2disp: Implement VariantInit()
by Alexandre Julliard 01 Dec '15

01 Dec '15

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -39,4 +39,43 @@ INT16 WINAPI SysReAllocString16(LPBSTR16,LPCOLESTR16); > int WINAPI SysReAllocStringLen16(BSTR16*, const char*, int); > int WINAPI SysStringLen16(BSTR16); > > +typedef struct tagVARIANT16 { > + VARTYPE vt; > + WORD wReserved1; > + WORD wReserved2; > + WORD wReserved3; > + union { > + BYTE bVal; > + SHORT iVal; > + LONG lVal; > + FLOAT fltVal; > + DOUBLE dblVal; > + VARIANT_BOOL boolVal; > + SCODE scode; > + DATE date; > + BSTR16 bstrVal; > + CY cyVal; > + IUnknown *punkVal; > + IDispatch *pdispVal; > + SAFEARRAY *parray; > + BYTE *pbVal; > + SHORT *piVal; > + LONG *plVal; > + FLOAT *pfltVal; > + DOUBLE *pdblVal; > + VARIANT_BOOL *pboolVal; > + SCODE *pscode; > + DATE *pdate; > + BSTR16 *pbstrVal; > + struct tagVARIANT16 *pvarVal; > + void *byref; > + CY *pcyVal; > + IUnknown **ppunkVal; > + IDispatch **ppdispVal; > + SAFEARRAY **pparray; > + } u; > +} VARIANT16; The pointers should all be SEGPTR. Some of the existing definitions like BSTR16 probably need to be fixed too. In any case this will have to wait until after code freeze. -- Alexandre Julliard julliard(a)winehq.org

1 0

Make a 16-bit test in wine for krnl386.exe16
by Bruno Jesus 01 Dec '15

01 Dec '15

Hi all, I'm trying to create tests for GetPrivateProfileString16 but it is not working as expected because the test is calling the kernel32 version of the function instead of the krnl386.exe16. Is there any way to make a test that compiles and runs against krnl386 instead of kernel32? I tried a few different things and the attached patch is the last attempt (the tests are wrong but that is not the point yet). Any help is appreciated, thanks in advance, Bruno

7 11