December 2015 - Wine-devel - list.winehq.org

Re: [PATCH] wined3d: Set WINED3D_BUFFER_DOUBLEBUFFER for managed buffers as well.
by Marvin 08 Dec '15

08 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18871 Your paranoid android. === w1064 (32 bit device) === device.c:2613: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2618: Test failed: The focus window is active. device.c:2626: Test failed: Got unexpected hr 0x88760869. device.c:2632: Test failed: Got unexpect screen size 800x600. device.c:2647: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2656: Test failed: Got unexpect screen size 800x600. device.c:2669: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2677: Test failed: Got unexpect width 640. device.c:2678: Test failed: Got unexpect height 480.

1 0

Re: advapi32: Set last error to ERROR_SUCCESS in GetSidIdentifierAuthority.
by Marvin 08 Dec '15

08 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18853 Your paranoid android. === w1064 (32 bit security) === security.c:3740: Test failed: MACHINE\Software owner SID != Administrators SID. security.c:3780: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:3784: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:3793: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0)

1 0

Re: [PATCH] ddraw: Mark surfaces as lost on mode changes.
by Marvin 08 Dec '15

08 Dec '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=18845 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2337: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2186: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2253: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2522: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: po: Use lowercase+underscore names for the replaceable parts of the French usage messages.
by Alexandre Julliard 08 Dec '15

08 Dec '15

Francois Gouget <fgouget(a)free.fr> writes: > This brings consistency and this format keeps the spellchecker happy. > > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > po/fr.po | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) I figured it out this time, but when sending patches that depend on each other, could you please number them so I don't have to try all possible orderings? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: Call the EnumChildWindows callback using a wrapper.
by Sebastian Lackner 08 Dec '15

08 Dec '15

On 08.12.2015 09:53, Dmitry Timoshkov wrote: > +extern LRESULT WNDENUMPROC_wrapper( WNDENUMPROC proc, HWND hwnd, LPARAM lparam ); > +__ASM_GLOBAL_FUNC( WNDENUMPROC_wrapper, > + "pushl %ebp\n\t" > + __ASM_CFI(".cfi_adjust_cfa_offset 4\n\t") > + __ASM_CFI(".cfi_rel_offset %ebp,0\n\t") > + "movl %esp,%ebp\n\t" > + __ASM_CFI(".cfi_def_cfa_register %ebp\n\t") > + "pushl %edi\n\t" > + __ASM_CFI(".cfi_rel_offset %edi,-4\n\t") > + "pushl %esi\n\t" > + __ASM_CFI(".cfi_rel_offset %esi,-8\n\t") > + "pushl %ebx\n\t" > + __ASM_CFI(".cfi_rel_offset %ebx,-12\n\t") > + "pushl 16(%ebp)\n\t" > + "pushl 12(%ebp)\n\t" > + "movl 8(%ebp),%eax\n\t" > + "call *%eax\n\t" There is no need to safe edi/esi/ebx when the purpose is just to be compatible with cdecl calling conventions. Also, you should try to keep the stack aligned, like most other assembler wrappers do. Does it also work with something like: http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/dinput/dinput_main.c#… ? Regards, Sebastian

2 1

Re: [PATCH 2/2] d3dx9_36: Fix several issues in save_dds_surface_to_memory. (try 2)
by Henri Verbeet 08 Dec '15

08 Dec '15

Any time you find yourself writing something along the lines of "Fix several issues ..." in a patch description, that's an indication you should probably be writing several patches instead. On 7 December 2015 at 07:53, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > From: Christian Costa <titan.costa(a)gmail.com> > > This makes the default values line up with native. > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> I suppose a Signed-off-by from the original author as well would too much to ask. /shrug. > - header->size = sizeof(*header); > - header->flags = DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PITCH | DDS_PIXELFORMAT | DDS_MIPMAPCOUNT; > + /* The signature is not really part of the DDS header */ > + header->size = sizeof(*header) - sizeof(header->signature); This isn't necessarily wrong, although it would be more correct to write this kind of thing as "sizeof(*header) - FIELD_OFFSET(struct dds_header, size)". As the comment already indicates though, the real issue is that the signature field shouldn't be part of the same structure. > + header->flags = DDS_CAPS | DDS_HEIGHT | DDS_WIDTH | DDS_PIXELFORMAT; > header->height = src_desc.Height; > header->width = src_desc.Width; > header->pitch_or_linear_size = dst_pitch; You remove DDS_PITCH from the flags, but set the field here anyway. The test doesn't test it. Somewhat similarly, the test doesn't verify the value of the "caps" field.

1 0

Re: [PATCH 1/2] d3dx9_36/tests: Add D3DXSaveSurfaceToFileInMemory D3DXIFF_DDS tests (try 2)
by Henri Verbeet 08 Dec '15

08 Dec '15

On 7 December 2015 at 07:53, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > + SetRect(&rect, 0, 0, 0, 0); It's not a bit deal, but "SetRectEmpty(&rect);". > + hr = D3DXSaveSurfaceToFileInMemory(&buffer, D3DXIFF_DDS, surface, NULL, &rect); > + todo_wine ok(hr == D3D_OK, "D3DXSaveSurfaceToFileInMemory returned %#x, expected %#x\n", hr, D3D_OK); Just write something like "Got unexpected hr %#x.\n". You can easily tell what the expected value is by looking at the test. > + ok(header->size == 124, "Invalid DDS size %d.\n", header->size); > + ok(!header->height, "Wrong height %d.\n", header->height); > + ok(!header->width, "Wrong width %d.\n", header->width); > + ok(!header->depth, "Wrong depth %d.\n", header->depth); > + ok(!header->miplevels, "Wrong miplevels %d.\n", header->miplevels); These are all unsigned values, so use %u. Note that if a test returns something you didn't expect that's not necessarily wrong or invalid, just unexpected.

1 0

Re: po: Add a couple of missing ellipses to the Catalan translation.
by Alex Henrie 07 Dec '15

07 Dec '15

I'm attaching screenshots so you can see exactly what the problem is. I agree that having ellipses would be ideal, but would you please submit patches to fix this properly instead of breaking it in a different way? -Alex

2 1

Re: [3/4] winhttp/tests: Send a not empty payload in the server authorization response, check the received data on the client side.
by Hans Leidekker 07 Dec '15

07 Dec '15

On Mon, 2015-12-07 at 13:16 +0800, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/winhttp/tests/winhttp.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) It fails here: winhttp.c:2389: Test failed: expected 11, got 15

3 4

Re: [PATCH 2/3] include: add bluetoothapis.h
by Nikolay Sivov 04 Dec '15

04 Dec '15

On 05.12.2015 2:21, Austin English wrote: > +typedef struct _BLUETOOTH_ADDRESS { > + union { > + BTH_ADDR ullLong; > + BYTE rgBytes[ 6 ]; > + }; > +} BLUETOOTH_ADDRESS_STRUCT; > +#define BLUETOOTH_NULL_ADDRESS ( (ULONGLONG) 0x0) > +typedef struct _BLUETOOTH_FIND_RADIO_PARAMS { > + DWORD dwSize; > +} BLUETOOTH_FIND_RADIO_PARAMS; > +typedef struct _BLUETOOTH_DEVICE_SEARCH_PARAMS { > + DWORD dwSize; > + BOOL fReturnAuthenticated; > + BOOL fReturnRemembered; > + BOOL fReturnUnknown; > + BOOL fReturnConnected; > + BOOL fIssueInquiry; > + UCHAR cTimeoutMultiplier; > + HANDLE hRadio; > +} BLUETOOTH_DEVICE_SEARCH_PARAMS; > +/* Raw Attribute Enumeration */ Same as with 1/3, it's essentially a copy, that's not funny.

1 0