March 2015 - Wine-devel - list.winehq.org

WineConf 2015
by Michael Stefaniuc 17 Apr '15

17 Apr '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello guys, after we rethought WineConf and did it at/during FOSDEM for the last two years, it is time for a real WineConf again. We are missing too much our keynote, our governance discussions as well as our hackatons. Also the two full days should give more time for the most important topic aka the hallway discussions. After two years in Europe the old tradition would call for a session over in USA/Canada but this is not a strict requirement. Now the most important thing is to find volunteers that would want to host the WineConf. They have the bigger say in the date too, there are two options: - - either in late spring (preferred by me), - - or early fall (preferred by Jeremy) I have started also http://wiki.winehq.org/WineConf2015 please feel free to add agenda topics to it. bye michael -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlTY5awACgkQ0ei8kcpE1VG2YQCguwUys0se+wV96lPfjZ+Qi6LJ 8ooAoJDxist2eZLgMXsRqUZVloGpBRgz =7Ta5 -----END PGP SIGNATURE-----

6 12

Re: [PATCH] vbscript: Implemented Oct(try 4)
by Marvin 01 Apr '15

01 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12481 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

3 2

Re: [PATCH 4/4] d3drm/tests: Add QueryInterface tests for IDirect3DRMFrame3
by Aaryaman Vasishta 31 Mar '15

31 Mar '15

The tests also pass when the frame is created via IDirect3DRM_CreateFrame and IDirect3DRM2_CreateFrame. On Tue, Mar 31, 2015 at 1:36 AM, Aaryaman Vasishta < jem456.vasishta(a)gmail.com> wrote: > --- > dlls/d3drm/tests/d3drm.c | 99 > ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 99 insertions(+) > > diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c > index 515aace..6029b1a 100644 > --- a/dlls/d3drm/tests/d3drm.c > +++ b/dlls/d3drm/tests/d3drm.c > @@ -1841,6 +1841,104 @@ static void test_d3drm_qi(void) > IDirect3DRM_Release(d3drm); > } > > +static void test_frame_qi(void) > +{ > + static const struct qi_test tests[] = > + { > + { &IID_IDirect3DRMFrame3, &IID_IDirect3DRMFrame3, S_OK, > FALSE }, > + { &IID_IDirect3DRMFrame2, &IID_IDirect3DRMFrame3, S_OK, > FALSE }, > + { &IID_IDirect3DRMFrame, &IID_IDirect3DRMFrame3, S_OK, > FALSE }, > + { &IID_IDirect3DRM, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMDevice, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMObject, &IID_IDirect3DRMFrame3, S_OK, > FALSE }, > + { &IID_IDirect3DRMDevice2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMDevice3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMViewport, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMViewport2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRM3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRM2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMVisual, &IID_IDirect3DRMFrame3, S_OK, > FALSE }, > + { &IID_IDirect3DRMMesh, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMeshBuilder, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMeshBuilder2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMeshBuilder3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFace, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFace2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMLight, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMTexture, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMTexture2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMTexture3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMWrap, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMaterial, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMMaterial2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMAnimation, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMAnimation2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMAnimationSet, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMAnimationSet2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMObjectArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMDeviceArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMViewportArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFrameArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMVisualArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMLightArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMPickedArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMFaceArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMAnimationArray, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMUserVisual, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMShadow, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMShadow2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMInterpolator, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMProgressiveMesh, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMPicked2Array, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DRMClippedVisual, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawClipper, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawSurface7, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawSurface4, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawSurface3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawSurface2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDrawSurface, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DDevice7, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DDevice3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DDevice2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DDevice, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3D7, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3D3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3D2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3D, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDraw7, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDraw4, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDraw3, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDraw2, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirectDraw, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IDirect3DLight, NULL, > CLASS_E_CLASSNOTAVAILABLE, FALSE }, > + { &IID_IUnknown, &IID_IDirect3DRMFrame3, S_OK, > FALSE }, > + }; > + HRESULT hr; > + IDirect3DRM *d3drm; > + IDirect3DRM3 *d3drm3; > + IDirect3DRMFrame3 *frame3; > + > + hr = Direct3DRMCreate(&d3drm); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DRM interface (hr = %x)\n", > hr); > + > + if (FAILED(hr = IDirect3DRM_QueryInterface(d3drm, &IID_IDirect3DRM3, > (void **)&d3drm3))) > + { > + win_skip("Cannot get IDirect3DRM3 interface (hr = %x), skipping > tests\n", hr); > + IDirect3DRM_Release(d3drm); > + return; > + } > + > + hr = IDirect3DRM3_CreateFrame(d3drm3, NULL, &frame3); > + ok(hr == D3DRM_OK, "Cannot get IDirect3DRMFrame3 interface (hr = > %x)\n", hr); > + CHECK_REFCOUNT(frame3, 1); > + > + test_qi("frame_qi", (IUnknown *)frame3, &IID_IDirect3DRMFrame3, > tests, sizeof(tests) / sizeof(*tests)); > + > + IDirect3DRMFrame3_Release(frame3); > + IDirect3DRM3_Release(d3drm3); > + IDirect3DRM_Release(d3drm); > +} > + > START_TEST(d3drm) > { > test_MeshBuilder(); > @@ -1857,4 +1955,5 @@ START_TEST(d3drm) > test_d3drm_load(); > test_frame_mesh_materials(); > test_d3drm_qi(); > + test_frame_qi(); > } > -- > 1.9.3 (Apple Git-50) > >

2 2

Re: [PATCH] comctl32: Handle BM_SETSTATE sent to themed buttons.
by Nikolay Sivov 31 Mar '15

31 Mar '15

On 03/31/2015 10:45 PM, Mark Harmstone wrote: > This patch changes comctl32 to handle BM_SETSTATE itself when sent to > a themed button, rather than forwarding it to user32. This way, the > theming isn't temporarily lost when user32 repaints it. > > + case BM_SETSTATE: > + { > + int state = (int)SendMessageW(hwnd, BM_GETSTATE, 0, 0); > + if (wParam) > + SetWindowLongW(hwnd, 0, state | BST_PUSHED); > + else > + SetWindowLongW(hwnd, 0, state & ~BST_PUSHED); > + > + InvalidateRect(hwnd, NULL, FALSE); > + break; > + } > + I guess you can GetWindowLongW(...,0,...) instead of sending a message? But what's more important is that all these difference in behavior comparing to user32 controls should not be visible only when you have an active theme. It's actually another version of same Button control with additional messages and different behavior in some aspects, including theming-aware drawing. So my point is that theming support is secondary, what's important is class redirection support, and I'm worried if these theming-only changes will make it more difficult to fix properly later. P.S. 0 window data index is actually implementation details of user32 (I don't know if it's compatible with native one with that regard or not).

1 0

Re: gdiplus/tests: Use printf() for memory dumps instead of trace(). (try 2)
by Thomas Faber 31 Mar '15

31 Mar '15

On 2015-03-29 12:29, Thomas Faber wrote: > trace is unsuitable since it adds a file:line prefix every time. Is there a preferred way to handle this instead of using printf? Or is this simply a case that seems pointless to fix because tests should never fail anyway (in which case a patch to remove these dumps completely might make sense)? Thanks! -Thomas PS: Here's what I see with trace(), which was my reasoning for the patch: image.c:4241: Test marked todo: 16: data should match image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 80image.c:4249: 80image.c:4249: 80image.c:4249: 80image.c:4249: 80image.c:4249: 80image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4249: 40image.c:4250:

2 1

Re: [PATCH] gdiplus: Avoid unnecessary post-to-pre-multiplied alpha conversions in GdipDrawImagePointsRect
by Vincent Povirk 31 Mar '15

31 Mar '15

On Tue, Mar 31, 2015 at 9:05 AM, Andrew Eikum <aeikum(a)codeweavers.com> wrote: > + if (bg_alpha == 0) return fg; This doesn't seem right. Foreground is premultiplied, but we expect the result to not be premultiplied.

1 0

Re: [PATCH 6/7] ddraw/tests: Add more d3d7 lighting tests.
by Henri Verbeet 31 Mar '15

31 Mar '15

On 30 March 2015 at 20:18, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + static WORD Indices[] = {0, 1, 2, 2, 3, 0}; You have a typo here. :)

2 1

Re: [PATCH 1/7] ddraw: D3DLIGHT lights default to active.
by Henri Verbeet 31 Mar '15

31 Mar '15

On 30 March 2015 at 20:18, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > @@ -184,7 +184,7 @@ static HRESULT WINAPI d3d_light_SetLight(IDirect3DLight *iface, D3DLIGHT *data) > - if (data->dwSize >= sizeof(D3DLIGHT2) && (((D3DLIGHT2 *)data)->dwFlags & D3DLIGHT_NO_SPECULAR)) > + if (!(flags & D3DLIGHT_NO_SPECULAR)) > light7->dcvSpecular = data->dcvColor; > else > light7->dcvSpecular = *(const D3DCOLORVALUE *)zero_value; I'm not holding this against the patch too much because it's ddraw, but I think "if (flags & D3DLIGHT_NO_SPECULAR)" and then flipping the branches reads a bit nicer. If the declaration of "zero_value" is fixed you can avoid the cast as well. > @@ -200,9 +200,10 @@ static HRESULT WINAPI d3d_light_SetLight(IDirect3DLight *iface, D3DLIGHT *data) > + memcpy(&light->light, data, sizeof(D3DLIGHT)); There's something to be said for "sizeof(D3DLIGHT)" here, although I don't think "sizeof(*data)" would have been worse.

2 1

Re: [3/3] kernel32: force 4096 byte page alignment (resend)
by Alexandre Julliard 31 Mar '15

31 Mar '15

David Naylor <dbn(a)freebsd.org> writes: > FreeBSD prefers to use a 0x200000 (super) page alignment however this causes > the image base to be displaced from the requested 0x7b800000. Forcing a > smaller page size ensures FreeBSD can place the image startin at 0x7b800000. This would have to be done in winegcc, with appropriate configure checks. It's probably easier to change the address to leave more room. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: comctl32/tests: Fix couple of metrics tests that fail on some systems
by Dmitry Timoshkov 31 Mar '15

31 Mar '15

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + /* estimate using stock font metrics */ > + hdc = GetDC(0); > + hOldFont = SelectObject(hdc, GetStockObject (SYSTEM_FONT)); > + GetTextMetricsA(hdc, &tm); > + SelectObject(hdc, hOldFont); > + ReleaseDC(0, hdc); Probably DEFAULT_GUI_FONT should be used instead of SYSTEM, you really don't want to see SYSTEM_FONT on the screen, or just use its metrics. -- Dmitry.

2 1