March 2015 - Wine-devel - list.winehq.org

Re: [PATCH] wined3d: Fix some videocards property detection
by Stefan Dösinger 28 Mar '15

28 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Please keep wine-devel in CC. There are more developers than just myself :-) . Am 2015-03-28 um 12:38 schrieb Sergey Isakov: > I know this crash. It was appeared because this patch was > introduced in the wrong place as I describe in the bug 38277 Too > slow test Advanced Pixel Shaders in 3DMark2001SE > <https://bugs.winehq.org/show_bug.cgi?id=38277> My patch works > fine. It may work fine on the Macs you tested or even all the macs that ever shipped, but it is still ugly to hardcode GPU capabilities that the driver should provide. There are OpenGL flags winemac.drv can set to disable the software fallback: https://developer.apple.com/library/mac/qa/qa1502/_index.html . What happens when you set them? Do they influence the reported capabilities? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVFpW6AAoJEN0/YqbEcdMwaz4P/298Ha4rtgWPYEFF+w6HzAWP f7G9fenhHkgjaudNwjcFXTr1dweYTVwvVll5Ahpu9bRd4iC/hM4jyKf2TVcpcXbM +yIri1UnsgSt63YJ1+XRfvVsV28BYlhqnlZvqKkmNHf/5dxg0iOfz0noDYAcspFZ BjfVQOFgaRmuiS9AyVpgc5WO2+IptKvDa1ExSOSNhOO5ye7T9Nh071QoWCgakqza invrADPRjRm/Ri7JV6CtQeRZCLYdMjeONchhJOHif2KYjk8/J5PNVAUeSSt73ZXQ TPA/VmPAs9mge3QlKgD9NgIab8auPt0tHW3MLLluKbLmwOJSMsOuxx85VC4yxlvK K/h0Q7Ldx8BvmsraLjmNMPmB9FMUNuxmEhjrkdbN90v9FwfsfZs5PGm6V+Rmt4uq gBHQxY2wd6xUt6I4AFH+6s088Ubl7zQRdAsE12LTMnRHF0ctIvHZCVdtdgVG/0hu ZpxrnHgoWm4E9arzslkHOxaqAh1Tln8k9WtpF6PcGNv4xbLWKLNiRBHMF4fK9MQI PtbT7gzL71+38lArzqnCzKb4Ijw1X7PkgA//4ZlkENyCp9SKxWpLQaDq853mhGlQ Q8z6TqAgb1wIwqO/rfiX6Rqj+aWt9Zet4XDhLaLbsifRnGjr4gad9LSC28GzQfet d80ZXwigJshmdtl05+I6 =+1lX -----END PGP SIGNATURE-----

2 2

Re: [PATCH] krnl386.exe16: Fix NULL pointer dereferencing
by Stefan Dösinger 28 Mar '15

28 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-27 um 19:16 schrieb Sergey Isakov: > This if statement body will perform only if driver_request is NULL > pointer. Next statements will cause crash. Bug 38159 NULL pointer > dereferencing <https://bugs.winehq.org/show_bug.cgi?id=38159> I think in this case the segfault is intentional. The caller passes a stupid parameter. Also I'm not sure if it actually segfaults. In vm86 mode memory is mapped to this page, so NULL may be a valid address. The best solution would be to write a test and see what happens on an ancient DOS, but we don't have a test infrastructure for DOS and Win16. The next best idea might be to just remove the entire block. It's funny though since (according to git) the patch that added this check already added the "/* FIXME - to be deleted ?? */" comment. At some point we may as well remove the entire DOS code since we just call dosbox these days and 64 bit CPUs don't allow vm86 mode anyway. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVFpBqAAoJEN0/YqbEcdMwVUQP/itrU95T4mlo2vo7f4J3k7fd Wx4goKV1/s5iPT+56T3q+MsqYp0gcNgmiwmVrf+HSNl94jXo1ysWfsuD1LeAAPGi O6FJBpszJdjw+fjm0whKidM3L+QYOEqGb/8AP5ZuXQ2zE0+iDA2cGo5oFrP2LpmM ZR7t3uYTIqk4VYWuZz4rlfSaHu552LpT/zEIYghteL/ANTqkad+oVleOFLB6Nbb/ j1PK7QKl6D+n6Kd2KSwlI9jj3XADf14i96J2knNh7yyLVZAsjNTe/3F9eoI98N5M cI22fGkW6jp70HoS1yMpJG66jqrhamAi6QBzMUI2cfAhHtjngKj36X3MRZMXIiK7 4E1g/Z7hcJ3ZtbrfzHnUdUXCQMXHszA93U69QRERTnjatDB+VNTZ67AaPGMXBiE9 2i5KlGg5TXjZPJwPqetHuGZ18uUXwCXfbC5+VPXP5AqbhxltE6IPfbKs95Bo90gh EvZsooU7pqNJxNAfscDIKliDsIcFV3TATqEyr/LCeczKNbE1DOKQ/afBrGyivabe f/YzcLLHfx5x8Lxx5bsmn2+3xR+LVfppH/rCSC5YA2ZwU6gB8NeuDAHh/BvsV7E1 i9IkN43sbQ4xZQFckBsyhdcpJd0kCCp3n1kmCfCWx3c2uIwLNvzzwT9HM8mY36my qcBfCcz1CCOpKpaayCSL =78sc -----END PGP SIGNATURE-----

1 0

Re: [PATCH] user32: Use function parameter if it set to be not stub
by Stefan Dösinger 28 Mar '15

28 Mar '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-03-27 um 21:52 schrieb Sergey Isakov: > { + if (!lpDisplayDevice) { + return FALSE; + } This is probably correct, but it needs a test. Currently this function crashes if this parameter is NULL. I can imagine that EnumDisplayDevices(NULL, 1, NULL, 0) returns TRUE if display 1 exists and FALSE otherwise. > + + if (i) { FIXME("(%s,%d,%p,0x%08x), > stub!\n",debugstr_w(lpDevice),i,lpDisplayDevice,dwFlags); - - if > (i) return FALSE; + } This is an unrelated change and matters more for what the patch description says it does. Though if I understand this right we want this check to be "if (i || lpDevice)" because the application can also pass in a device name. > > + if (lpDevice) { + strcpyW(lpDisplayDevice->DeviceName, > lpDevice); + } else { memcpy(lpDisplayDevice->DeviceName, > primary_device_name, sizeof(primary_device_name)); + } This is yet another unrelated change. It looks OK, but I don't think it really matters. Copying the input display name will at best paper over the fact that our implementation of this function does not support multiple display devices. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVFo0tAAoJEN0/YqbEcdMw+eQP/1SnlfkRjPZ/8PW8+m3iOYHC OTLWOE7Io94FzLfFQO487pCbsqgd9199UWp3IolfUe/y2vS4LtosxQQh1tLG7j7A rsypwNjV8OwSHvXiL5BH/4QvZTAqoctW484E7z7IHzMXMqa2Oyrj5K3QXHVes6O5 9xEB1UuSkB19Z0jIQqHPR4Hc/o8gYuCAER05BiTqOZcBSsrVhfOOZ+FKR7krWqdP o3VkOmUSWhX+9ziTsKmWGsBEZk0r81RMG2cbT/eShAtBBZs/+YtUfYiNY2q+tCoF fMiEfiMU7e1TqroBJAw37gYju+qt3xon/RuyOQD13a3hwWSDzMeoE9PAf9TxCK4Q OinEV45U8RiDkczviuOQluojfmJSXmVCC2BjPPQ2ZtmGXyuRXLrlRZ4KsCE/xhyV p2+Za2U/cvfqy0ug5isnnFGu/lKi1RCeGXsbHX6ZF5amTEfuklQpWolacrGilxZ2 kYiBtV93A/IJzUPaj2d97JbEFG2nMP6pT+KTSFBJIY2bzzzhnX1Fltd8kt3Vp/rv MOUPs/peC9sv17wDc5LREPAbA7LOBuN4M3M+5O2glO/F96gt8FSsPYyZy9sMRXEv eEuQgGbFbm9KKCWBK53mm78aAFiulqEd3S4vFXnvNU5sFxUW/BO3TxDZJhPEAK2v BeJJ0ZjH01mfQ8lhDQph =RL+u -----END PGP SIGNATURE-----

1 0

Re: [PATCH] vbscript: Fixed Hex
by Marvin 28 Mar '15

28 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12482 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] vbscript: Implemented Oct(try 3)
by Marvin 28 Mar '15

28 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12480 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [2/9] kernel32/tests: Add tests for IsProcessInJob.
by Marvin 28 Mar '15

28 Mar '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12470 Your paranoid android. === w7u (32 bit process) === process.c:2177: Test failed: WaitForSingleObject returned 258

2 1

Re: [PATCH] vbscript: Implemented Oct(try 2)
by Shuai Meng 27 Mar '15

27 Mar '15

Hi, I find Oct("test") returns error number 13 on windows, while 445 on wine. So I shall resend this patch. 2015-03-27 23:28 GMT+08:00 Shuai Meng <mengshuaicalendr(a)gmail.com>: > testbot: > https://newtestbot.winehq.org/JobDetails.pl?Key=12461 > Changelog: > Added support for other subtypes; > Added more tests. > --- > dlls/vbscript/global.c | 53 ++++++++++++++++++++++++++++++ > +++++++++++++-- > dlls/vbscript/tests/api.vbs | 31 ++++++++++++++++++++++++++ > 2 files changed, 82 insertions(+), 2 deletions(-) > > >

1 0

winegcc & stdin
by Leon Bogaert 27 Mar '15

27 Mar '15

I'm getting an error when using winegcc with stdin: > $ cat test.c | winegcc -xc -c - > gcc: warning: ‘-x c’ after last input file has no effect > gcc: error: -E or -x required when input is from standard input > winegcc: gcc failed Does anyone know what I could be doing wrong? I'm trying to use stdin because that's what the go (cgo) build tool is trying to use. Leon

2 2

Re: [PATCH] icnsformat.c: wrong pointer to formal parameters
by Bruno Jesus 27 Mar '15

27 Mar '15

On Fri, Mar 27, 2015 at 3:01 PM, Sergey Isakov <isakov-sl(a)bk.ru> wrote: > Bug 38288 > Wrong pointer in icnsformat.c IcnsFrameEncode_WriteSource Hi Sergey. Usually the patch subject is the dll name followed by the change. I think a better subject in this case would be: windowscodecs: Fix wrong pointer to formal parameter

1 0

[GSOC 2015] Direct3DRM - Implement rendering for D3DRM
by Aaryaman Vasishta 27 Mar '15

27 Mar '15

Hello! I have submitted my proposal on melange. Please take a look at it whenever possible. Any feedback would be very appreciated. Thank You! jam

1 0