April 2015 - Wine-devel - list.winehq.org

Re: [PATCH 2/5] wined3d: Introduce resource-type specific format flags.
by Henri Verbeet 23 Apr '15

23 Apr '15

On 23 April 2015 at 11:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* Always check 2D textures here, we don't want to write this ERR when the app tried > + * to create a compressed volume texture but s3tc support is otherwise available. */ > if ((desc->format == WINED3DFMT_DXT1 || desc->format == WINED3DFMT_DXT2 || desc->format == WINED3DFMT_DXT3 > || desc->format == WINED3DFMT_DXT4 || desc->format == WINED3DFMT_DXT5) > - && !(format->flags & WINED3DFMT_FLAG_TEXTURE) && !once++) > + && !(format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_TEXTURE) && !once++) > ERR_(winediag)("The application tried to create a DXTn texture, but the driver does not support them.\n"); But now it's still going to write an ERR when it tries to create a volume texture and s3tc support is unavailable. Wouldn't it make more sense to just explicitly exclude volume textures by adding a "desc->resource_type != WINED3D_RTYPE_VOLUME_TEXTURE" condition?

2 2

Favor / heads up - wine tasks in a hackathon
by Jeremy White 23 Apr '15

23 Apr '15

My alma mater is putting on a hackathon for college students in our region. http://carlhacks.io/ As an experiment, I'm wanted to see if I could get any of these students interested in Wine hacking. So we've sponsored prize money for any students that can fix a bug in Wine or fix a test. I have no idea if any students are going to take it on or not, but if you see an influx of urgent requests on #winehackers or here, starting Saturday and ending Sunday, you'll know why :-/. And if any such student does actually succeed in contributing a clearly useful or even promising patch, please let me know, so I can make a point to award the prize money during the closing ceremonies. Cheers, Jeremy

1 0

Re: [PATCH 4/5] wined3d: Query info for each resource type from ARB_internalformat_query2.
by Henri Verbeet 23 Apr '15

23 Apr '15

On 23 April 2015 at 11:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > +static GLenum wined3d_gl_type_to_enum(enum wined3d_gl_resource_type type) > +{ > + switch (type) > + { > + case WINED3D_GL_RES_TYPE_TEX_1D: > + return GL_TEXTURE_1D; > + case WINED3D_GL_RES_TYPE_TEX_2D: > + return GL_TEXTURE_2D; > + case WINED3D_GL_RES_TYPE_TEX_3D: > + return GL_TEXTURE_3D; > + case WINED3D_GL_RES_TYPE_TEX_CUBE: > + return GL_TEXTURE_CUBE_MAP_ARB; > + case WINED3D_GL_RES_TYPE_TEX_RECT: > + return GL_TEXTURE_RECTANGLE_ARB; > + case WINED3D_GL_RES_TYPE_BUFFER: > + return GL_TEXTURE_2D; /* TODO: GL_TEXTURE_BUFFER. */ > + case WINED3D_GL_RES_TYPE_COUNT: > + break; > + } > + ERR("Unexpected GL resource type %u.\n", type); > + return 0; > +} > + > + You have an extra newline here. > + for (type = 0; type < sizeof(format->flags) / sizeof(*format->flags); ++type) This isn't wrong as such, but you can use ARRAY_SIZE for this now. > { > - TRACE("Format %s doesn't support %s.\n", debug_d3dformat(format->id), string); > - format_clear_flag(format, flag); > + gl_info->gl_ops.ext.p_glGetInternalformativ(wined3d_gl_type_to_enum(type), internal, pname, 1, &value); > + if (value == GL_FULL_SUPPORT) > + { > + TRACE("Format %s supports %s.\n", debug_d3dformat(format->id), string); It would probably be helpful if this mentioned the resource type as well.

1 0

Re: [PATCH 5/6] d3d9/tests: Add a specular lighting test.
by Henri Verbeet 23 Apr '15

23 Apr '15

On 22 April 2015 at 19:30, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +#define VERTICES_SIDE 5 > +#define INDICES_COUNT ((VERTICES_SIDE - 1) * (VERTICES_SIDE - 1) * 2 * 3) > + I don't think you really need to #define these, but if you do you should probably #undef them once you're done with them.

1 0

Re: [PATCH 3/6] wined3d: Introduce D3D7+ normal matrix computation.
by Henri Verbeet 23 Apr '15

23 Apr '15

On 22 April 2015 at 19:30, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +#define SWAP_ROWS(a, b) { float *tmp = a; a = b; b = tmp; } > + I assume this is mostly borrowed from Mesa like invert_matrix_3d(), but unfortunately Mesa isn't particularly good at writing macros, even though they have more than enough of them. This one happens to more or less work for the cases you have here, but consider the following in particular: if (...) SWAP_ROWS(a, b); else SWAP_ROWS(c, d); Please just use the standard "do { ... } while(0)" construction when you need to define a macro like that. In this particular case there's of course no reason you need a macro in the first place.

1 0

Re: [PATCH 2/2] ntdll: Add support for FileFsFullSizeInformation class in NtQueryVolumeInformationFile(try 2)
by Alexandre Julliard 23 Apr '15

23 Apr '15

"Jianqiu Zhang" <zhangjianqiu_133(a)yeah.net> writes: > + if(!S_ISREG(st.st_mode) && !S_ISDIR(st.st_mode)) > + { > + io->u.Status = STATUS_INVALID_DEVICE_REQUEST; > + } > + else > + { > + ULONGLONG bsize; > +#if !defined(linux) || !defined(HAVE_FSTATFS) > + struct statvfs stfs; > + > + if(fstatvfs( fd, &stfs ) < 0) > + { > + io->u.Status = FILE_GetNtStatus(); > + break; > + } > + bsize = stfs.f_frsize; > +#else > + struct statfs stfs; > + if(fstatfs( fd, &stfs ) < 0) > + { > + io->u.Status = FILE_GetNtStatus(); > + break; > + } > + bsize = stfs.f_bsize; > +#endif Please avoid duplicating all that code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ws2_32/tests: Add a trailing '\n' to an ok() call.
by Marvin 23 Apr '15

23 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12975 Your paranoid android. === w2008s64 (64 bit sock) === No test summary line found

1 0

Re: user32: After handling an internal message give a chance to real message to arrive.
by Marvin 23 Apr '15

23 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12973 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 00150136 msg.c:12252: Test failed: bad time 315f0/315ff

1 0

Re: [PATCH] user32/tests: Test SetUserObjectInformation for invisible winstation.
by Alexandre Julliard 23 Apr '15

23 Apr '15

Qian Hong <qhong(a)codeweavers.com> writes: > --- > dlls/user32/tests/winstation.c | 57 > ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) Can you please fix the test failures introduced by your previous changes first? cf. https://test.winehq.org/data/tests/user32:winstation.html -- Alexandre Julliard julliard(a)winehq.org

3 8

Re: [PATCH 2/2] krnl386: Invalid console handles should translate into real handles when creating a new process.
by Alexandre Julliard 23 Apr '15

23 Apr '15

"Erich E. Hoover" <erich.e.hoover(a)gmail.com> writes: > This patch fixes an issue exposed by the fix in patch 1. The current > mechanism for initializing the DOS handles for a process uses > DuplicateHandle, which converts INVALID_HANDLE_VALUE into a usable > handle (but not 0). Without this fix the Caesar III demo installer > crashes with an unhandled page fault, though it may be more desirable > to allocate new handles than to replicate the behavior we used to have > prior to patch 1. Proper handles would be better, simply open the null device or something like that. -- Alexandre Julliard julliard(a)winehq.org

1 0