April 2015 - Wine-devel - list.winehq.org

Re: server: Do not replace focus and active windows with NULL on thread_attach_input
by Marvin 20 Apr '15

20 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12889 Your paranoid android. === w7u (32 bit msg) === msg.c:12230: Test failed: unexpected hwnd 0014013E msg.c:12252: Test failed: bad time 3200d/3201d

1 0

Re: user32/tests: Add a test for sending inter-thread messages.
by Marvin 20 Apr '15

20 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12880 Your paranoid android. === w7u (32 bit msg) === msg.c:6957: Test failed: destroy child on thread exit: 0: the msg 0x0082 was expected, but got msg 0x0014 instead msg.c:6957: Test failed: destroy child on thread exit: 1: the msg 0x000f was expected, but got msg 0x0082 instead msg.c:6957: Test failed: destroy child on thread exit: 2: the msg 0x0014 was expected, but got msg 0x000f instead msg.c:6957: Test failed: destroy child on thread exit: 3: the msg sequence is not complete: expected 0000 - actual 0014 msg.c:12230: Test failed: unexpected hwnd 00060150 msg.c:12252: Test failed: bad time 31cc3/31cd2

1 0

GSoC 2015 Application
by lijianwei 20 Apr '15

20 Apr '15

Hi I'm a graduate student in NorthWestern Polytenical University.I have been study Parelism promraming,especially GPU programming for two year.So I want to accept task Implement OpenMP. But now,what should I do to begin my work. Watting for your answer! Than you! Best Regard

2 1

License of AppDb content and sql dump?
by Sebastian Lackner 20 Apr '15

20 Apr '15

Hiho, I've been wondering if there is any license information available for the appdb content. I've looked through lots of pages but didn't find any hint under which terms the data can be used. It would be nice if someone could clarify this situation a bit. For those who are wondering why I'm asking - I am planning to use the (anonymized) data (especially app names, categories and corresponding ratings) for further analysis and comparison between different Wine versions. There will of course be references to show where the data is from. Since the data is used in connection with the Wine project I would assume that it should be normally safe to do that - if anyone sees any legal issues please contact me. ;) Best regards, Sebastian

1 0

Re: [PATCH] urlmon: set hres also in else branch (Coverity)
by Nikolay Sivov 19 Apr '15

19 Apr '15

On 19.04.2015 14:42, Marcus Meissner wrote: > 718705 Unchecked return value > --- > dlls/urlmon/session.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/urlmon/session.c b/dlls/urlmon/session.c > index e01e647..001158f 100644 > --- a/dlls/urlmon/session.c > +++ b/dlls/urlmon/session.c > @@ -213,7 +213,7 @@ IInternetProtocolInfo *get_protocol_info(LPCWSTR url) > > hres = IClassFactory_QueryInterface(cf, &IID_IInternetProtocolInfo, (void**)&ret); > if(FAILED(hres)) > - IClassFactory_CreateInstance(cf, NULL, &IID_IInternetProtocolInfo, (void**)&ret); > + hres = IClassFactory_CreateInstance(cf, NULL, &IID_IInternetProtocolInfo, (void**)&ret); > IClassFactory_Release(cf); > > return ret; > It's still unchecked. If we want to use it we need to propagate return code to caller, right now it will return NULL interface pointer. So I'm thinking it's false positive.

2 1

Application for GSoC 2015 - Implement findstr.exe for Wine.
by KaiPeng Zeng 19 Apr '15

19 Apr '15

Hi folks, I’m Kaipeng Zeng who is a Linux user and Wine/CrossOver user from China. I am major in Biomedical Engineering in Guangdong Pharmaceutical University. I’d like to apply GSoC to work for Wine Project this year. My proposal is "Implementing findstr.exe for Wine". Though findstr is a quite independent program in Wine, I think it is valuable to implement. As far as I knew, there are some bugs about findstr in Bugzilla[1]. Any other programs in Chinese depend on it too. The implementation of findstr will help these programs and all the programs will also be good tests for our implementation. Besides, I think the code of grep will be helpful for implementing findstr. There are three parts in my plan: === Part 1: Add more tests for findstr.exe === I have submitted a patch for findstr’s test to wine-patches[2]. I will add more tests to prepare for the implementation. === Part 2: Implement an initial findstr.exe === With enough tests, I will try to implement the findstr gradually. My middle goal is having an initial implementation of findstr which can handle some simple work. Bug 35254[3] may be fixed after this part is finished. === Part 3: Add more parameters implementation === In this part, I will add more tests and try to implement more arguments for findstr, let it solve more things. [1] https://bugs.winehq.org/buglist.cgi?quicksearch=findstr&list_id=178519 [2] http://source.winehq.org/patches/data/110182 [3] https://bugs.winehq.org/show_bug.cgi

2 2

Re: [PATCH 2/2] winemac: Don't pump messages in ChangeDisplaySettings (v2).
by Ken Thomases 17 Apr '15

17 Apr '15

On Apr 17, 2015, at 4:09 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Version 2: Also update macdrv_displays_changed. Supersedes 110793. Looks OK to me. -Ken

1 0

Re: [PATCH 1/2] winex11: Don't pump messages in ChangeDisplaySettings (v2).
by Marvin 17 Apr '15

17 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12849 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2493: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2506: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

1 0

Re: [PATCH 2/2] winemac: Don't pump messages in ChangeDisplaySettings.
by Ken Thomases 17 Apr '15

17 Apr '15

Sorry for the double post. Sent by accident before I was finished. This hoists some of the knock-on effects of WM_MACDRV_UPDATE_DESKTOP_RECT to the place where it is sent. However, it only does so for one of the two places where it is sent. It is also sent in macdrv_displays_changed() which is called when something external to the process (may have) changed the display configuration. You would need to duplicate the hoisted code to that function, too, or find some other way to make sure the same work gets done. -Ken On Apr 16, 2015, at 5:18 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Same as the previous patch, just for winemac.drv. > > The message ping-pong between the ChangeDisplaySettings calling thread > and the desktop thread is more complicated here than in winex11. The > problem again is that sendMessageTimeout(SMTO_BLOCK) will not process > messages sent by the desktop, leading to a deadlock. Replacing > SendMessageTimeout in the desktop with PostMessage is not an option > either because then messages will be executed in a different order in > the thread that called ChangeDisplaySettings. > > This patch will lead to DISPLAYCHANGE messages being sent on redundant > changes. This matches the behavior of winex11 and happens to fix the > user32/sysparam.ok test, but it fixes it for the wrong reason (the real > problem afaics is that OSX only supports 32 bpp, so no change takes > place although one was requested). I think redundant changes should be > intercepted in user32 before the display driver is called. > --- > dlls/winemac.drv/display.c | 8 ++++++-- > dlls/winemac.drv/window.c | 4 ---- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/winemac.drv/display.c b/dlls/winemac.drv/display.c > index 10ecf67..f7ce163 100644 > --- a/dlls/winemac.drv/display.c > +++ b/dlls/winemac.drv/display.c > @@ -564,8 +564,12 @@ better: > size_t width = CGDisplayModeGetWidth(best_display_mode); > size_t height = CGDisplayModeGetHeight(best_display_mode); > > - SendMessageW(GetDesktopWindow(), WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, > - MAKELPARAM(width, height)); > + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, > + SMTO_BLOCK | SMTO_ABORTIFHUNG, 2000, NULL); > + SendMessageTimeoutW(GetDesktopWindow(), WM_MACDRV_UPDATE_DESKTOP_RECT, mode_bpp, > + MAKELPARAM(width, height), SMTO_BLOCK, ~0U, NULL); > + SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, mode_bpp, > + MAKELPARAM(width, height), SMTO_BLOCK | SMTO_ABORTIFHUNG, 2000, NULL); > ret = DISP_CHANGE_SUCCESSFUL; > } > else > diff --git a/dlls/winemac.drv/window.c b/dlls/winemac.drv/window.c > index 7a777e6..fa12af5 100644 > --- a/dlls/winemac.drv/window.c > +++ b/dlls/winemac.drv/window.c > @@ -1666,13 +1666,9 @@ LRESULT CDECL macdrv_WindowMessage(HWND hwnd, UINT msg, WPARAM wp, LPARAM lp) > if (!GetWindowRect(hwnd, &current_desktop_rect) || > !CGRectEqualToRect(cgrect_from_rect(current_desktop_rect), new_desktop_rect)) > { > - SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_RESET_DEVICE_METRICS, 0, 0, > - SMTO_ABORTIFHUNG, 2000, NULL); > SetWindowPos(hwnd, 0, CGRectGetMinX(new_desktop_rect), CGRectGetMinY(new_desktop_rect), > CGRectGetWidth(new_desktop_rect), CGRectGetHeight(new_desktop_rect), > SWP_NOZORDER | SWP_NOACTIVATE | SWP_DEFERERASE); > - SendMessageTimeoutW(HWND_BROADCAST, WM_MACDRV_DISPLAYCHANGE, wp, lp, > - SMTO_ABORTIFHUNG, 2000, NULL); > } > } > return 0; > -- > 2.3.4 > > >

2 1

Re: [PATCH] winex11: Don't pump messages in ChangeDisplaySettings (v2).
by Marvin 17 Apr '15

17 Apr '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=12824 Your paranoid android. === w8 (32 bit sysparams) === sysparams.c:2493: Test failed: Waiting for the WM_DISPLAYCHANGE message timed out sysparams.c:2506: Test failed: Set bpp 32, but WM_DISPLAYCHANGE reported bpp -1

2 1