June 2015 - Wine-devel - list.winehq.org

Re: [PATCH 2/3] configure: Check if -lunwind is needed for libunwind.
by Alexandre Julliard 15 Jun '15

15 Jun '15

Ken Thomases <ken(a)codeweavers.com> writes: > --- > configure.ac | 26 ++++++++++++++++++++++++++ > dlls/ntdll/Makefile.in | 2 +- > 2 files changed, 27 insertions(+), 1 deletion(-) I'm not sure what we gain by using libunwind on other platforms, but assuming it's useful it would have to be loaded dynamically. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/6] configure: Don't touch platform register x18 on ARM64
by Alexandre Julliard 15 Jun '15

15 Jun '15

André Hentschel <nerv(a)dawncrow.de> writes: > diff --git a/configure.ac b/configure.ac > index 79110c1..b26ae3e 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -178,6 +178,9 @@ case $host in > CFLAGS="$CFLAGS -marm" > AC_SUBST(TARGETFLAGS,"-marm") > ;; > + aarch64*) > + CFLAGS="$CFLAGS -ffixed-x18" I don't see how this can work. It would have to be made the toolchain default to apply to all system libraries. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] kernel32/tests: Add a partial test for GetConsoleFontSize
by Marvin 14 Jun '15

14 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14266 Your paranoid android. === w8 (32 bit console) === console.c:1511: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1511: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1511: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1755: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1755: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1755: Test failed: [18] Expected output count to be 3735928559, got 2359244

2 1

Re: [PATCH 1/2] kernel32/tests: Add a test for GetLargestConsoleWindowSize
by Marvin 14 Jun '15

14 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14265 Your paranoid android. === w8 (32 bit console) === console.c:1489: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1489: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1489: Test failed: [18] Expected output count to be 3735928559, got 2359244 console.c:1733: Test failed: [13] Expected output count to be 0, got 2359244 console.c:1733: Test failed: [15] Expected output count to be 0, got 2359244 console.c:1733: Test failed: [18] Expected output count to be 3735928559, got 2359244

2 1

Re: [PATCH] winscard: add stubs for SCardListReadersA/W
by Bruno Jesus 14 Jun '15

14 Jun '15

On Sunday, June 14, 2015, Marcus Meissner <marcus(a)jet.franken.de> wrote: > From: Austin English <austinenglish(a)gmail.com <javascript:;>> > > Fixes http://bugs.winehq.org/show_bug.cgi?id=26978 > --- > dlls/winscard/winscard.c | 12 ++++++++++++ > dlls/winscard/winscard.spec | 4 ++-- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/dlls/winscard/winscard.c b/dlls/winscard/winscard.c > index bcf8129..cf7d52d 100644 > --- a/dlls/winscard/winscard.c > +++ b/dlls/winscard/winscard.c > @@ -129,3 +129,15 @@ void WINAPI SCardReleaseStartedEvent(void) > { > FIXME("stub\n"); > } > + > +LONG WINAPI SCardListReadersA(SCARDCONTEXT context, LPCSTR groups, LPSTR > readers, LPDWORD buflen) > +{ > + FIXME("(%lx, %s, %p, %p) stub\n", context, debugstr_a(groups), > readers, buflen); > + return SCARD_F_INTERNAL_ERROR; > +} > + > +LONG WINAPI SCardListReadersW(SCARDCONTEXT context, LPCWSTR groups, > LPWSTR readers, LPDWORD buflen) > +{ > + FIXME("(%lx, %s, %p, %p) stub\n", context, debugstr_w(groups), > readers, buflen); > + return SCARD_F_INTERNAL_ERROR; > +} Hi, that is not a good return code for error, it's better to return SCARD_E_NO_READERS_AVAILABLE. Most applications I tested will understand this error more properly and display better diagnose message to user. Best Regards, Bruno

1 0

Re: [PATCH 2/3] configure: Check if -lunwind is needed for libunwind.
by Ken Thomases 14 Jun '15

14 Jun '15

On Jun 14, 2015, at 9:22 PM, Ken Thomases <ken(a)codeweavers.com> wrote: > --- > configure.ac | 26 ++++++++++++++++++++++++++ > dlls/ntdll/Makefile.in | 2 +- > 2 files changed, 27 insertions(+), 1 deletion(-) Forgot to mention: this is for <https://bugs.winehq.org/show_bug.cgi?id=38713>. -Ken

1 0

Re: [PATCH] advapi32: Implement GetWindowsAccountDomainSid.
by Marvin 14 Jun '15

14 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14271 Your paranoid android. === w2000pro (32 bit security) === security.c:5882: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5888: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5889: Test failed: expected size 24, got 68 security.c:5894: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5900: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 1337 security.c:5901: Test failed: expected size 24, got 1 security.c:5906: Test failed: GetWindowsAccountDomainSid failed with error 1337 security.c:5907: Test failed: last error should not change security.c:5908: Test failed: expected size 24, got 68 security: unhandled exception c0000005 at 0043AC94 === wxppro (32 bit security) === security.c:5882: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5888: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5889: Test failed: expected size 24, got 68 security.c:5894: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5900: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 1337 security.c:5901: Test failed: expected size 24, got 1 security.c:5906: Test failed: GetWindowsAccountDomainSid failed with error 1337 security.c:5907: Test failed: last error should not change security.c:5908: Test failed: expected size 24, got 68 security: unhandled exception c0000005 at 0043AC94 === w2003std (32 bit security) === security.c:5882: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5888: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5889: Test failed: expected size 24, got 68 security.c:5894: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5900: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 1337 security.c:5901: Test failed: expected size 24, got 1 security.c:5906: Test failed: GetWindowsAccountDomainSid failed with error 1337 security.c:5907: Test failed: last error should not change security.c:5908: Test failed: expected size 24, got 68 security: unhandled exception c0000005 at 0043AC94 === w7u (32 bit security) === security.c:5882: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5888: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5889: Test failed: expected size 24, got 68 security.c:5894: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5900: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 1337 security.c:5901: Test failed: expected size 24, got 1 security.c:5906: Test failed: GetWindowsAccountDomainSid failed with error 1337 security.c:5907: Test failed: last error should not change security.c:5908: Test failed: expected size 24, got 68 security: unhandled exception c0000005 at 0043AC94 === w8 (32 bit security) === security.c:5882: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5888: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5889: Test failed: expected size 24, got 68 security.c:5894: Test failed: expected ERROR_INVALID_PARAMETER, got 1337 security.c:5900: Test failed: expected ERROR_INSUFFICIENT_BUFFER, got 1337 security.c:5901: Test failed: expected size 24, got 1 security.c:5906: Test failed: GetWindowsAccountDomainSid failed with error 1337 security.c:5907: Test failed: last error should not change security.c:5908: Test failed: expected size 24, got 68 security: unhandled exception c0000005 at 0043AC94

1 0

Re: winemac.drv: Improved App name on windows and menus (Mac Driver)
by Theodore Dubois 14 Jun '15

14 Jun '15

I'm curious, given this, how Crossover manages to make the application menu title the same as the Windows program that is running, despite the actual executable being wineloader. Does it work if the executable has no bundle id? ~Theodore > But, more importantly, the title that a program sets for the application menu is ignored by Cocoa. It uses the bundle name regardless. So, this change has no effect.

2 1

Re: hlsl compiler question
by Matteo Bruni 14 Jun '15

14 Jun '15

2015-06-14 10:42 GMT+02:00 Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com>: > Hi Matteo, > > I was looking at this bug as if affects "Star Trek Online" as well. > > Do you know what/how much work it would be to get this fixed? > > http://bugs.winehq.org/show_bug.cgi?id=32932 > > Any help would be great. It still might be way out of my depth to fix. > > Best Regards > Alistair Leslie-Hughes Hi Alistair, fixing that specific bug (i.e. support for the ": register" syntax) is pretty trivial, I even have a patch for that in my queue. It's been postponed by other stuff for a long time but in principle I can send it in the next few days. The problem is that fixing it won't probably help for actually running Star Trek Online, nullDC or any other program currently blocked by that. The HLSL compiler is still missing a lot of stuff, only the parser is currently implemented and the code generation part is totally absent. Cheers, Matteo.

1 0

Re: gdiplus: Implement GdipCreateRegionRgnData.
by Vincent Povirk 13 Jun '15

13 Jun '15

Seems like there are some unnecessary changes (cases reordered, element type fixme changed, breaking from default case), but it looks good otherwise.

1 0