June 2015 - Wine-devel - list.winehq.org

Re: PATCH: ParseX509EncodedCertificateForListBoxEntry stub
by Alexandre Julliard 11 Jun '15

11 Jun '15

Marcus Meissner <marcus(a)jet.franken.de> writes: > From db29dec04c5c02ab2a96010d42aec00aaeccbec2 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 25 Feb 2015 01:04:56 -0600 > Subject: wininet: add ParseX509EncodedCertificateForListBoxEntry stub (try 2) > > Try 2: Fix prototype/spec file, add to winineti.h > Fixes https://bugs.winehq.org/show_bug.cgi?id=29842 It's still wrong. If you want to help, review the patch, figure out what's wrong, email the original author (CC'ing wine-devel), and ask them to fix their patch and resubmit. And if you can't figure out what's wrong, then maybe you shouldn't be submitting other people's patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winemac.drv: Improved App name on windows and menus (Mac Driver)
by Nikolay Sivov 11 Jun '15

11 Jun '15

On 06/10/2015 05:48 PM, Vitor Marques wrote: > + // Application name > bundleName = [[NSBundle mainBundle] objectForInfoDictionaryKey:(NSString*)kCFBundleNameKey]; > + if (!bundleName || ![bundleName lenght]) bundleName = @"Wine"; I can't say I understand objc, but this looks like a typo.

1 0

Re: dpnet: Simplify the storing of component data
by Stefan Dösinger 11 Jun '15

11 Jun '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I am OK with this patch in principle if you believe that it is an improvement. It reduces the code size, but on the other hand it means that you're having tiny allocations for DWORDs and GUIDs. Keep in mind that such allocations mean overhead in memory use, run time and memory fragmentation. I'd like to point out an alternative approach: You can give struct component a variable size, similar to how struct wined3d_private_data in include/wine/wined3d.h works. But overall I think this is a minor detail considering the overall state of the directplay libs and that there are more important issues to solve. I don't want to stand in your way by arguing about small things like this. I can't promise Alexandre agrees though. Either way, two style comments: The test is a good test to add, but should be in its own patch. Am 2015-06-10 um 06:41 schrieb Alistair Leslie-Hughes: > found = TRUE; > > - if(entry->type == DPNA_DATATYPE_STRING_ANSI) > - heap_free(entry->data.ansi); > - else if(entry->type == DPNA_DATATYPE_STRING) > - heap_free(entry->data.string); > - else if(entry->type == DPNA_DATATYPE_BINARY) > - heap_free(entry->data.binary); > + heap_free(entry->data); > > break; The added heap_free line is indented by 11 chars. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJVeAC0AAoJEN0/YqbEcdMws9oP/RyusEIcZnV4GWTAmfaSKfFn 0iheACWwmeL3GlWeqmY51S8ImuKcoD0HoZ/vQm6jMhTTJFK3jENVJkMk/Mjx8Kk6 ZPcit6nPB184lDgzLXV0gHbMlPkFxdTPJi++1ZfKa9LskJ3zIrgF7LcJFidtCSeG 7yHdg6C0BiQH4oXjBzY+fVRzaQluKEihncaa2tYdErfMUCzUf+RAi99/tnete2Re EiejXowzg5HcxjBHMupsGEcFocUnXtUlPzJf0UIawbptxzPYXk3H0VYPohIrLVm6 f/chcdKlvAi5xdUlCuF4nLw9TQxyC5h3mf5p7l/JdDbgRE8knCO1w/HrzOHJJJRB TnkU5EdrnIc3Bx6Tw/kQGTKsM3SAuSapdjBsQRracNaQVzdqYKfsMPaiQeRVmdQO LJbyeECFw3l3opf/LFd/TUguDws2hChASaBAOf25vorhD6wH8fnaoNnEh1qMtBH5 x1jJjxB+B0Uwa4nYKProoOc0Qw0/zoaVlv3vCKiiEggz+BkXEuYb58ZDysSg4A1w JVO0S6GAfumFPWvHMtoIEPsFxiPl6xHiwXsKzrHc8K5EpUTZ2Jcv0lam53x39Tb1 cJmluv1SyxrdrTWT1nCtgg+ma8ezid8HEpOj+aIWVwYcKwR9uF09jvDEaAzwSuAr V6ogftbNHriUDl15YrO+ =zne3 -----END PGP SIGNATURE-----

2 1

Re: [1/1] advapi32/tests: Add preliminary event tracing tests. (v2 resend)
by Marvin 11 Jun '15

11 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14142 Your paranoid android. === w2000pro (32 bit eventlog) === eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === wxppro (32 bit eventlog) === eventlog.c:687: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w2003std (32 bit eventlog) === eventlog.c:687: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === wvistau64 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w2008s64 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w7u (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87 === w8 (32 bit eventlog) === eventlog.c:696: Test failed: Expected ERROR_BAD_LENGTH, got 87 eventlog.c:779: Test failed: Expected ERROR_BAD_PATHNAME, got 87 eventlog.c:787: Test failed: Expected success eventlog.c:795: Test failed: Expected ERROR_ALREADY_EXISTS, got 87

1 0

Re: [PATCH 5/5] d3d9/tests: Test the default colors for fixed function vertex processing.
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14137 Your paranoid android. === w8 (32 bit visual) === visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test. visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test. visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test.

1 0

Re: [PATCH 4/5] d3d9/tests: Test the default diffuse color for vertex shaders.
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14136 Your paranoid android. === w8 (32 bit visual) === visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test. visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test. visual.c:7924: Test failed: Got unexpected color 0x00ffff00 for no color attribute test.

1 0

Re: [PATCH 4/4] d3drm/tests: Add refcount tests for IDirect3DRMDevice*
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14110 Your paranoid android. === w2000pro (32 bit d3drm) === d3drm.c:2037: Test failed: Expected 32 bpp, got 24d3drm.c:2054: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2058: Test failed: Expected 640x480, got 1024x768 d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840. === wxppro (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840. === w2003std (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840.

2 1

Re: [PATCH 2/2] mshtml: Implement IHTMLXMLHttpRequest as a stub. (try 2)
by Alexandre Julliard 10 Jun '15

10 Jun '15

Zhenbo Li <litimetal(a)gmail.com> writes: > try 2: > add test_disp in dom.c for DIID_DispHTMLXMLHttpRequest It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so dom && touch dom.ok dom.c:6110: Test failed: unexpected guid {3051040a-98b5-11cf-bb82-00aa00bdce0b} make: *** [dom.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winebuild: Set a valid major and minor linker version.
by Nikolay Sivov 10 Jun '15

10 Jun '15

On 10.06.2015 10:08, Sebastian Lackner wrote: > From: Michael Müller <michael(a)fds-team.de> > > Some apps expect a nonzero linker version. > Just out of curiosity, could you name some of those applications?

2 1

Re: [PATCH 3/4] d3drm/tests: Add test for IDirect3DRM*::CreateDeviceFromD3D.
by Marvin 10 Jun '15

10 Jun '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=14109 Your paranoid android. === w2000pro (32 bit d3drm) === d3drm.c:2037: Test failed: Expected 32 bpp, got 24d3drm.c:2054: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2058: Test failed: Expected 640x480, got 1024x768 d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840. === wxppro (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840. === w2003std (32 bit d3drm) === d3drm.c:2040: Test failed: Cannot set display mode to 8bpp (hr = 80004001). d3drm.c:2044: Test failed: Expected 16 bpp, got 32. d3drm.c:2138: Test failed: Expected 10006040 for caps, got 2840. d3drm.c:2306: Test failed: Expected 10006040 for caps, got 2840.

1 0