January 2016 - Wine-devel - list.winehq.org

Re: msdrm: add stub dll
by Alex Henrie 06 Jan '16

06 Jan '16

diff --git a/configure.ac b/configure.ac index d47f7e9..69ab604 100644 --- a/configure.ac +++ b/configure.ac @@ -3009,6 +3009,7 @@ WINE_CONFIG_TEST(dlls/msctf/tests) WINE_CONFIG_DLL(msctfp,,[clean]) WINE_CONFIG_DLL(msdaps,,[clean]) WINE_CONFIG_DLL(msdelta) +WINE_CONFIG_DLL(msdrm) WINE_CONFIG_DLL(msdmo,,[implib]) WINE_CONFIG_TEST(dlls/msdmo/tests) WINE_CONFIG_DLL(msftedit) If you're going for alphabetical order, msdmo would come before msdrm. -Alex

1 0

Re: [PATCH] quartz: Handle NULL target format in FilterGraph::ConvertTimeFormat.
by Nikolay Sivov 06 Jan '16

06 Jan '16

On 05.01.2016 14:13, Anton Baskanov wrote: > Signed-off-by: Anton Baskanov <baskanov(a)gmail.com> > --- > dlls/quartz/filtergraph.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c > index 5b4b080..5cb670e 100644 > --- a/dlls/quartz/filtergraph.c > +++ b/dlls/quartz/filtergraph.c > @@ -2530,6 +2530,9 @@ static HRESULT WINAPI MediaSeeking_ConvertTimeFormat(IMediaSeeking *iface, LONGL > if (!pSourceFormat) > pSourceFormat = &This->timeformatseek; > > + if (!pTargetFormat) > + pTargetFormat = &This->timeformatseek; > + > if (IsEqualGUID(pTargetFormat, pSourceFormat)) > *pTarget = Source; > else > Hi, Anton. According to msdn this looks correct to me. Could you add a simple test for that? Let's say one test with both formats as NULL; and a couple more with one format being NULL and another set to current format. Looks like it could be added easily to test_mediacontrol() as it has everything you'd need.

2 1

Wine Gecko 2.44-beta1
by Jacek Caban 06 Jan '16

06 Jan '16

Hi all, I prepared beta builds of the next Wine Gecko release. They are available via our new download site [1]. If you want to help testing, all that's needed is the attached patch (Wine will dowload the package for you). This build is based on Firefox 44 sources. It includes a few Wine-specific bug fixes. Also the way we hook IO in Gecko is redesigned. The new interface should be more stable and the code is cleaner. I think wine-staging may be a good way to have more testing before we do the final release. Please commit the patch to the tree. Thanks, Jacek [1] http://dl.winehq.org/wine/wine-gecko/2.44-beta1/

2 2

Re: [PATCH] mscoree: Set config path for default app domain
by Vincent Povirk 06 Jan '16

06 Jan '16

+ GetModuleFileNameA(NULL, base_dir, sizeof(base_dir)); + + slash = strrchr(base_dir, '\\'); + if (slash) + *slash = 0; + + TRACE("setting base_dir: %s, config_path: %s\n", base_dir, config_pathA); + mono_domain_set_config(This->default_domain, base_dir, config_pathA); Mono embedding api functions expect utf8-encoded paths. We need to use the W function and utf8-encode using WtoA.

1 0

Re: jscript: Added support for Function constructor called as a function.
by Marvin 06 Jan '16

06 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19463 Your paranoid android. === wxppro (32 bit) === No test summary line found === w2003std (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w7pro64 (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === w864 (32 bit) === No test summary line found === w1064 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found === w7pro64 (64 bit) === No test summary line found === w864 (64 bit) === No test summary line found === w1064 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/3] ddraw: Only allow DDSCAPS_MIPMAP on textures.
by Marvin 06 Jan '16

06 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19462 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2338: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw1) === ddraw1.c:2187: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2254: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2523: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 2/3] ddraw/tests: Merge MipMapCreationTest() with test_mipmap_lock().
by Marvin 06 Jan '16

06 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19461 Your paranoid android. === w1064 (32 bit ddraw4) === ddraw4.c:2523: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw2) === ddraw2.c:2338: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit dsurface) === dsurface.c:144: Test failed: Destination data after blitting is not correct dsurface.c:178: Test failed: Destination data after blitting is not correct dsurface.c:357: Test failed: Surface data after srckey blit does not match dsurface.c:382: Test failed: Surface data after src override key blit does not match dsurface.c:436: Test failed: Surface data after dest key blit does not match dsurface.c:462: Test failed: Surface data after dest key override blit does not match dsurface.c:524: Test failed: Surface data with src key and dest key blit does not match === w1064 (32 bit ddraw1) === ddraw1.c:2187: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2254: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [7/8] bcrypt: Add support for SHA hashes on Linux using Nettle.
by Bruno Jesus 06 Jan '16

06 Jan '16

On Wed, Jan 6, 2016 at 8:19 PM, Hans Leidekker <hans(a)codeweavers.com> wrote: > Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> > --- > configure.ac | 18 +++++++++ > dlls/bcrypt/Makefile.in | 1 + > dlls/bcrypt/bcrypt_main.c | 95 +++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 114 insertions(+) Hi, Hans. Great job in the patch series, but Is this change really necessary? Can't we reuse the internal libraries from rsaenh? I think it was a copy of tomcrypt lib, I'm not able to check right now. By using rsaenh or moving the tomcrypt to a more generic place it could be reused without need for external dependencies, right? Unless I'm missing something obvious. Best wishes, Bruno

3 3

Re: [8/8] bcrypt/tests: Add tests for SHA hashes.
by Marvin 06 Jan '16

06 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19459 Your paranoid android. === w864 (64 bit bcrypt) === bcrypt.c:259: Test failed: got c0000023 bcrypt.c:260: Test failed: hash not set bcrypt.c:263: Test failed: got c0000008 bcrypt.c:267: Test failed: got c0000008 bcrypt.c:268: Test failed: got 3735928559 bcrypt.c:269: Test failed: got 3735928559 bcrypt.c:273: Test failed: got c0000008 bcrypt.c:275: Test failed: got 0000000000000000000000000000000000000000000000000000000000000000 bcrypt.c:278: Test failed: got c000000d bcrypt.c:338: Test failed: got c0000023 bcrypt.c:339: Test failed: hash not set bcrypt.c:342: Test failed: got c0000008 bcrypt.c:346: Test failed: got c0000008 bcrypt.c:347: Test failed: got 3735928559 bcrypt.c:348: Test failed: got 3735928559 bcrypt.c:352: Test failed: got c0000008 bcrypt.c:354: Test failed: got 000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 bcrypt.c:357: Test failed: got c000000d bcrypt.c:418: Test failed: got c0000023 bcrypt.c:419: Test failed: hash not set bcrypt.c:422: Test failed: got c0000008 bcrypt.c:426: Test failed: got c0000008 bcrypt.c:427: Test failed: got 3735928559 bcrypt.c:428: Test failed: got 3735928559 bcrypt.c:432: Test failed: got c0000008 bcrypt.c:434: Test failed: got 00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 bcrypt.c:437: Test failed: got c000000d === w1064 (64 bit bcrypt) === bcrypt.c:180: Test failed: got c0000023 bcrypt.c:181: Test failed: hash not set bcrypt.c:184: Test failed: got c0000008 bcrypt.c:188: Test failed: got c0000008 bcrypt.c:189: Test failed: got 3735928559 bcrypt.c:190: Test failed: got 3735928559 bcrypt.c:194: Test failed: got c0000008 bcrypt.c:196: Test failed: got 0000000000000000000000000000000000000000 bcrypt.c:199: Test failed: got c000000d bcrypt.c:338: Test failed: got c0000023 bcrypt.c:339: Test failed: hash not set bcrypt.c:342: Test failed: got c0000008 bcrypt.c:346: Test failed: got c0000008 bcrypt.c:347: Test failed: got 3735928559 bcrypt.c:348: Test failed: got 3735928559 bcrypt.c:352: Test failed: got c0000008 bcrypt.c:354: Test failed: got 000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 bcrypt.c:357: Test failed: got c000000d bcrypt.c:418: Test failed: got c0000023 bcrypt.c:419: Test failed: hash not set bcrypt.c:422: Test failed: got c0000008 bcrypt.c:426: Test failed: got c0000008 bcrypt.c:427: Test failed: got 3735928559 bcrypt.c:428: Test failed: got 3735928559 bcrypt.c:432: Test failed: got c0000008 bcrypt.c:434: Test failed: got 00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 bcrypt.c:437: Test failed: got c000000d

1 0

Re: mshtml: Added IHTMLDocument4::hasFocus implementation.
by Marvin 06 Jan '16

06 Jan '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19458 Your paranoid android. === wxppro (32 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === w2003std (32 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === wvistau64 (32 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === w2008s64 (32 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === w7u (32 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === w7pro64 (32 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === w8 (32 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === w864 (32 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === w1064 (32 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === wvistau64 (64 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === w7pro64 (64 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff === w864 (64 bit dom) === dom.c:6263: Test failed: hasFocus returned 0, expected ffffffff

1 0