February 2016 - Wine-devel - list.winehq.org

Re: [2/4] ntdll/tests: Add separate tests for exception handling of int $0x3.
by Marvin 18 Feb '16

18 Feb '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20710 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:490: Test failed: 42: Unexpected eip 0x2c0000/0x2c0001 exception: unhandled exception 80000004 at 002C0000 exception.c:490: Test failed: 42: Unexpected eip 0x77baed97/0x2c0001 === w7u (32 bit exception) === exception.c:490: Test failed: 42: Unexpected eip 0x2f0000/0x2f0001 exception: unhandled exception 80000004 at 002F0000 exception.c:490: Test failed: 42: Unexpected eip 0x77cde34f/0x2f0001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9) === w1064 (64 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

1 0

Re: [1/4] ntdll/tests: Add additional tests for instruction pointer in debug service tests.
by Marvin 18 Feb '16

18 Feb '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20709 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:490: Test failed: 42: Unexpected eip 0x3c0000/0x3c0001 exception: unhandled exception 80000004 at 003C0000 exception.c:490: Test failed: 42: Unexpected eip 0x77baed97/0x3c0001 === w7u (32 bit exception) === exception.c:490: Test failed: 42: Unexpected eip 0x700000/0x700001 exception: unhandled exception 80000004 at 00700000 exception.c:490: Test failed: 42: Unexpected eip 0x77cde34f/0x700001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9) === w1064 (64 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

1 0

Re: [PATCH] kernel32/tests: Additional test for GetStringTypeW() and Zl/Zp categories
by Marvin 18 Feb '16

18 Feb '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20683 Your paranoid android. === w1064 (32 bit locale) === locale.c:2365: Test failed: LCMapStringEx should fail with bad locale name locale.c:2366: Test failed: unexpected error code -559038737 locale.c:2457: Test failed: Expected lcid == 0, got got 00001000, error -559038737 locale.c:4175: Test failed: IsValidLocaleName should have failed locale.c:4177: Test failed: IsValidLocaleName should have failed locale.c:4542: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4544: Test failed: For id 7, Expected IVC, got ''

2 1

Re: [PATCH] secur32: Don't print 32-bit values as long integers. (Clang)
by Ken Thomases 18 Feb '16

18 Feb '16

On Feb 18, 2016, at 2:20 PM, Charles Davis <cdavis5x(a)gmail.com> wrote: > > Signed-off-by: Charles Davis <cdavis5x(a)gmail.com> > --- > dlls/secur32/schannel_macosx.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) In several other places throughout this file, the same problem was solved by casting to long in the logging call. Of course, that means that Clang doesn't warn about those. I don't mind your approach, but I think this should be handled consistently throughout the file, one way or the other. -Ken

2 1

Re: [PATCH 1/2 v2] winemac.drv: Actually make the GL context current even if no drawables were given.
by Ken Thomases 18 Feb '16

18 Feb '16

On Feb 18, 2016, at 3:17 AM, Charles Davis <cdavis5x(a)gmail.com> wrote: > @@ -3108,7 +3108,7 @@ static BOOL macdrv_wglMakeContextCurrentARB(HDC draw_hdc, HDC read_hdc, struct w > (InterlockedCompareExchange(&context->update_swap_interval, FALSE, TRUE) || pbuffer != context->draw_pbuffer)) > set_swap_interval(context, 0); > } > - else > + else if (draw_hdc) > { > WARN("no window or pbuffer for DC\n"); > LeaveCriticalSection(&dc_pbuffers_section); I would prefer an explicit "if (!draw_hdc && !read_hdc) { /* clear context->draw_... */ } else" be introduced before the "if ((hwnd = WindowFromDC(draw_hdc)))". First, from my reading of the spec, a NULL draw_hdc and a non-NULL read_hdc should still be an error. Second, burying the logic in the pbuffer branch seems obscure. Thanks, Ken

1 0

Re: [PATCH] kernelbase: Add dll with forwards to kernel32.dll
by Nikolay Sivov 18 Feb '16

18 Feb '16

On 18.02.2016 19:36, Detlef Riekenberg wrote: > +#@ stdcall CancelThreadpoolIo ntdll.TpCancelAsyncIoOperation > +@ stub CancelThreadpoolIo Hi. I think for new dll it's fine to have a stub, even if kernel32 does not have it. Why did you keep commented forward to ntdll too?

1 0

Re: [PATCH 2/2 v3] user32: Add more dialog creation message tests
by Dmitry Timoshkov 18 Feb '16

18 Feb '16

Piotr Caban <piotr(a)codeweavers.com> wrote: > Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> > --- > dlls/user32/tests/msg.c | 72 > +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 72 insertions(+) It's getting better, but again doesn't show a lot of details. Please add parameters for most of the recorded messages in the sequence, in particular EM_SETSEL and WM_GETDLGCODE are the mandatory ones. Also, in order to see the origin of EM_SETSEL I'd suggest to call DefDlgProc() manually and use defwndproc_counter around it together with the defwinproc flag. -- Dmitry.

3 10

Re: [PATCH 1/3] msvcp110: Add tr2_sys__Symlink implementation and test.(try 2)
by Piotr Caban 18 Feb '16

18 Feb '16

On 02/18/16 10:54, YongHao Hu wrote: > + delete_flag = 1; > + for(i=0; i<sizeof(tests)/sizeof(tests[0]); i++) { > + errno = 0xdeadbeef; > + SetLastError(0xdeadbeef); > + ret = p_tr2_sys__Symlink(tests[i].existing_path, tests[i].new_path); > + if(ret==ERROR_PRIVILEGE_NOT_HELD || ret==ERROR_INVALID_FUNCTION) { > + delete_flag = 0; > + win_skip("Privilege not held or symbolic link not supported, skipping symbolic link tests.\n"); > + break; If second symlink creation fails we'll end up with some not deleted files while all tests are succeeding. I'm not sure if it's a real issue. I also think that it will be better if you remove the delete_flag variable. Something like this will be better in my opinion: ret = p_tr2_sys__Symlink(tests[i].existing_path, tests[i].new_path); if(!i && (ret==ERROR_PRIVILEGE_NOT_HELD || ret==ERROR_INVALID_FUNCTION)) { win_skip(...); ret = p_tr2_sys__Remove_dir("tr2_test_dir"); ok(ret == 1, "tr2_sys__Remove_dir(): expect 1 got %d\n", ret); return; } ok(ret == ERROR_SUCCESS, ...); > + if(tests[i].is_todo) > + todo_wine ok(ret == tests[i].last_error, "tr2_sys__Symlink(): test %d expect: %d, got %d\n", i+1, tests[i].last_error, ret); > + else > + ok(ret == tests[i].last_error, "tr2_sys__Symlink(): test %d expect: %d, got %d\n", i+1, tests[i].last_error, ret); Please use todo_wine_if here. Thanks, Piotr

2 2

Re: mshtml/tests: Trace the buffer when it is unexpectedly changed in mshtml:protocol.
by Jacek Caban 18 Feb '16

18 Feb '16

On 02/18/16 03:14, Francois Gouget wrote: > Signed-off-by: Francois Gouget <fgouget(a)free.fr> > --- > dlls/mshtml/tests/protocol.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/dlls/mshtml/tests/protocol.c b/dlls/mshtml/tests/protocol.c > index f9803df..9a511ba 100644 > --- a/dlls/mshtml/tests/protocol.c > +++ b/dlls/mshtml/tests/protocol.c > @@ -397,7 +397,7 @@ static void test_res_protocol(void) > hres = IInternetProtocolInfo_ParseUrl(protocol_info, blank_url, PARSE_DOMAIN, 0, buf, > sizeof(buf)/sizeof(buf[0]), &size, 0); > ok(hres == S_OK || hres == E_FAIL, "ParseUrl failed: %08x\n", hres); > - ok(buf[0] == '?', "buf changed\n"); > + ok(buf[0] == '?', "buf changed buf[0]='%c'\n", buf[0]); > Why don't you use wine_dbgstr_w here? Thanks, Jacek

1 0

Re: ntdll/tests: Add more tests for calling int $0x2d on x86 and x86_64. (v2)
by Marvin 18 Feb '16

18 Feb '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20657 Your paranoid android. === wvistau64 (32 bit exception) === exception.c:490: Test failed: 42: Unexpected eip 0x2c0000/0x2c0001 exception: unhandled exception 80000004 at 002C0000 exception.c:490: Test failed: 42: Unexpected eip 0x77baed97/0x2c0001 === w7u (32 bit exception) === exception.c:490: Test failed: 42: Unexpected eip 0x2f0000/0x2f0001 exception: unhandled exception 80000004 at 002F0000 exception.c:490: Test failed: 42: Unexpected eip 0x77cde34f/0x2f0001 === w1064 (32 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9) === w1064 (64 bit exception) === Failure running script in VM: network read timed out (Connect:AgentVersion.h:0/9)

1 0