February 2016 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] ntdll: Improve invalid parameter handling in NtAccessCheck. (try 3)
by Alexandre Julliard 23 Feb '16

23 Feb '16

Qian Hong <qhong(a)codeweavers.com> writes: > @@ -1629,8 +1630,28 @@ NtAccessCheck( > > status = wine_server_call( req ); > > - *ReturnLength = FIELD_OFFSET( PRIVILEGE_SET, Privilege ) + reply->privileges_len; > - PrivilegeSet->PrivilegeCount = reply->privileges_len / sizeof(LUID_AND_ATTRIBUTES); > + return_length = FIELD_OFFSET( PRIVILEGE_SET, Privilege ) + reply->privileges_len; > + if (return_length < sizeof(PRIVILEGE_SET)) > + return_length = sizeof(PRIVILEGE_SET); > + > + if (*ReturnLength == 0) > + { > + *ReturnLength = return_length; > + return STATUS_BUFFER_TOO_SMALL; > + } > + > + if (!PrivilegeSet) > + return STATUS_ACCESS_VIOLATION; It doesn't make sense to test this after it has already been passed to the server, what's more with an invalid length. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] wined3d: bind default sampler object when setting sampler state with no texture.
by Matteo Bruni 23 Feb '16

23 Feb '16

2016-02-20 15:00 GMT+01:00 Paul Gofman <gofmanp(a)gmail.com>: > When sampler state was applied and no stage texture was present in state, no glBindSampler > was issued for the stage after dummy texture was bound, and previously bound > sampler was still active. This could result in undefined behaviour, especially if previously > bound sampler was a shadow sample (this caused warnings from Nvidia driver). > > Signed-off-by: Paul Gofman <gofmanp(a)gmail.com> > --- > dlls/wined3d/state.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c > index 60bfd41..aa13a95 100644 > --- a/dlls/wined3d/state.c > +++ b/dlls/wined3d/state.c > @@ -3627,6 +3627,11 @@ static void sampler(struct wined3d_context *context, const struct wined3d_state > else > { > context_bind_texture(context, GL_NONE, 0); > + if (gl_info->supported[ARB_SAMPLER_OBJECTS]) > + { > + GL_EXTCALL(glBindSampler(mapped_stage, 0)); > + checkGLcall("glBindSampler"); > + } > } > } > > -- > 2.5.0 Henri is away this week so this patch will probably have to wait until he's back. FWIW I think this patch is fine, thank you.

2 1

Re: [PATCH 3/4] msvcp110: Add _Pad implementation
by Sebastian Lackner 22 Feb '16

22 Feb '16

On 22.02.2016 19:31, Piotr Caban wrote: > /* ??4_Pad(a)std@@QAEAAV01(a)ABV01@@Z */ > @@ -901,8 +907,12 @@ _Pad* __thiscall _Pad_ctor(_Pad *this) > DEFINE_THISCALL_WRAPPER(_Pad_op_assign, 8) > _Pad* __thiscall _Pad_op_assign(_Pad *this, const _Pad *copy) > { > - FIXME("(%p %p) stub\n", this, copy); > - return NULL; > + TRACE("(%p %p)\n", this, copy); > + > + this->cnd = copy->cnd; > + this->mtx = copy->mtx; > + this->launched = copy->launched; > + return this; > } The assignment of cnd and mtx looks a bit suspicious. Does that really work as expected (especially when the dtor is called later)?

2 1

Re: [PATCH 2/2 v2] winecoreaudio.drv: Don't print 32-bit values as long integers. (Clang)
by Andrew Eikum 22 Feb '16

22 Feb '16

I don't feel really strongly, but given the choice between OSStatus and int, I prefer OSStatus since it matches the API return type. It's one less thing for future code readers to wonder about. Chip, I think a search-and-replace script will fix this pretty easily. This seems to work in vim: :%s/%lx\(.*\), sc/%x\1, (int)sc/ Along with a careful manual review of each change and a check for any OSStatus not named 'sc'. Andrew On Mon, Feb 22, 2016 at 01:00:14AM -0700, Charles Davis wrote: > Signed-off-by: Charles Davis <cdavis5x(a)gmail.com> > --- > Try 2: Go back to casting for AudioDeviceIDs. > > The status prints are too numerous. I'm not changing them back to casts. > > dlls/winecoreaudio.drv/mmdevdrv.c | 84 +++++++++++++++++++-------------------- > 1 file changed, 42 insertions(+), 42 deletions(-) > > diff --git a/dlls/winecoreaudio.drv/mmdevdrv.c b/dlls/winecoreaudio.drv/mmdevdrv.c > index 60ff3d9..e586c8f 100644 > --- a/dlls/winecoreaudio.drv/mmdevdrv.c > +++ b/dlls/winecoreaudio.drv/mmdevdrv.c > @@ -388,7 +388,7 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, > AudioDeviceID *devices; > AudioDeviceID default_id; > AudioObjectPropertyAddress addr; > - OSStatus sc; > + int sc; > int i, ndevices; > > TRACE("%d %p %p %p\n", flow, ids, num, def_index); > @@ -406,7 +406,7 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, > sc = AudioObjectGetPropertyData(kAudioObjectSystemObject, &addr, 0, > NULL, &size, &default_id); > if(sc != noErr){ > - WARN("Getting _DefaultInputDevice property failed: %lx\n", sc); > + WARN("Getting _DefaultInputDevice property failed: %x\n", sc); > default_id = -1; > } > > @@ -414,7 +414,7 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, > sc = AudioObjectGetPropertyDataSize(kAudioObjectSystemObject, &addr, 0, > NULL, &devsize); > if(sc != noErr){ > - WARN("Getting _Devices property size failed: %lx\n", sc); > + WARN("Getting _Devices property size failed: %x\n", sc); > return osstatus_to_hresult(sc); > } > > @@ -425,7 +425,7 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, > sc = AudioObjectGetPropertyData(kAudioObjectSystemObject, &addr, 0, NULL, > &devsize, devices); > if(sc != noErr){ > - WARN("Getting _Devices property failed: %lx\n", sc); > + WARN("Getting _Devices property failed: %x\n", sc); > HeapFree(GetProcessHeap(), 0, devices); > return osstatus_to_hresult(sc); > } > @@ -462,7 +462,7 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, > sc = AudioObjectGetPropertyDataSize(devices[i], &addr, 0, NULL, &size); > if(sc != noErr){ > WARN("Unable to get _StreamConfiguration property size for " > - "device %lu: %lx\n", devices[i], sc); > + "device %u: %x\n", (unsigned int)devices[i], sc); > continue; > } > > @@ -480,7 +480,7 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, > &size, buffers); > if(sc != noErr){ > WARN("Unable to get _StreamConfiguration property for " > - "device %lu: %lx\n", devices[i], sc); > + "device %u: %x\n", (unsigned int)devices[i], sc); > HeapFree(GetProcessHeap(), 0, buffers); > continue; > } > @@ -502,8 +502,8 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, > sc = AudioObjectGetPropertyData(devices[i], &addr, 0, NULL, > &size, &name); > if(sc != noErr){ > - WARN("Unable to get _Name property for device %lu: %lx\n", > - devices[i], sc); > + WARN("Unable to get _Name property for device %u: %x\n", > + (unsigned int)devices[i], sc); > continue; > } > > @@ -528,7 +528,7 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, > *def_index = *num; > > TRACE("device %u: id %s key %u%s\n", *num, debugstr_w((*ids)[*num]), > - (unsigned int)devices[i], (*def_index == *num) ? " (default)" : ""); > + devices[i], (*def_index == *num) ? " (default)" : ""); > > (*num)++; > } > @@ -607,7 +607,7 @@ static AudioComponentInstance get_audiounit(EDataFlow dataflow, AudioDeviceID ad > AudioComponentInstance unit; > AudioComponent comp; > AudioComponentDescription desc; > - OSStatus sc; > + int sc; > > memset(&desc, 0, sizeof(desc)); > desc.componentType = kAudioUnitType_Output; > @@ -621,7 +621,7 @@ static AudioComponentInstance get_audiounit(EDataFlow dataflow, AudioDeviceID ad > > sc = AudioComponentInstanceNew(comp, &unit); > if(sc != noErr){ > - WARN("AudioComponentInstanceNew failed: %lx\n", sc); > + WARN("AudioComponentInstanceNew failed: %x\n", sc); > return NULL; > } > > @@ -632,7 +632,7 @@ static AudioComponentInstance get_audiounit(EDataFlow dataflow, AudioDeviceID ad > sc = AudioUnitSetProperty(unit, kAudioOutputUnitProperty_EnableIO, > kAudioUnitScope_Input, 1, &enableio, sizeof(enableio)); > if(sc != noErr){ > - WARN("Couldn't enable I/O on input element: %lx\n", sc); > + WARN("Couldn't enable I/O on input element: %x\n", sc); > AudioComponentInstanceDispose(unit); > return NULL; > } > @@ -641,7 +641,7 @@ static AudioComponentInstance get_audiounit(EDataFlow dataflow, AudioDeviceID ad > sc = AudioUnitSetProperty(unit, kAudioOutputUnitProperty_EnableIO, > kAudioUnitScope_Output, 0, &enableio, sizeof(enableio)); > if(sc != noErr){ > - WARN("Couldn't disable I/O on output element: %lx\n", sc); > + WARN("Couldn't disable I/O on output element: %x\n", sc); > AudioComponentInstanceDispose(unit); > return NULL; > } > @@ -1107,7 +1107,7 @@ static OSStatus feed_cb(AudioConverterRef converter, UInt32 *nframes, AudioBuffe > static void capture_resample(ACImpl *This) > { > UINT32 resamp_period_frames = MulDiv(This->period_frames, This->dev_desc.mSampleRate, This->fmt->nSamplesPerSec); > - OSStatus sc; > + int sc; > > /* the resampling process often needs more source frames than we'd > * guess from a straight conversion using the sample rate ratio. so > @@ -1131,7 +1131,7 @@ static void capture_resample(ACImpl *This) > sc = AudioConverterFillComplexBuffer(This->converter, feed_cb, > This, &wanted_frames, &converted_list, NULL); > if(sc != noErr){ > - WARN("AudioConverterFillComplexBuffer failed: %lx\n", sc); > + WARN("AudioConverterFillComplexBuffer failed: %x\n", sc); > break; > } > > @@ -1215,18 +1215,18 @@ static OSStatus ca_capture_cb(void *user, AudioUnitRenderActionFlags *flags, > static void dump_adesc(const char *aux, AudioStreamBasicDescription *desc) > { > TRACE("%s: mSampleRate: %f\n", aux, desc->mSampleRate); > - TRACE("%s: mBytesPerPacket: %ld\n", aux, desc->mBytesPerPacket); > - TRACE("%s: mFramesPerPacket: %ld\n", aux, desc->mFramesPerPacket); > - TRACE("%s: mBytesPerFrame: %ld\n", aux, desc->mBytesPerFrame); > - TRACE("%s: mChannelsPerFrame: %ld\n", aux, desc->mChannelsPerFrame); > - TRACE("%s: mBitsPerChannel: %ld\n", aux, desc->mBitsPerChannel); > + TRACE("%s: mBytesPerPacket: %u\n", aux, (unsigned int)desc->mBytesPerPacket); > + TRACE("%s: mFramesPerPacket: %u\n", aux, (unsigned int)desc->mFramesPerPacket); > + TRACE("%s: mBytesPerFrame: %u\n", aux, (unsigned int)desc->mBytesPerFrame); > + TRACE("%s: mChannelsPerFrame: %u\n", aux, (unsigned int)desc->mChannelsPerFrame); > + TRACE("%s: mBitsPerChannel: %u\n", aux, (unsigned int)desc->mBitsPerChannel); > } > > static HRESULT ca_setup_audiounit(EDataFlow dataflow, AudioComponentInstance unit, > const WAVEFORMATEX *fmt, AudioStreamBasicDescription *dev_desc, > AudioConverterRef *converter) > { > - OSStatus sc; > + int sc; > HRESULT hr; > > if(dataflow == eCapture){ > @@ -1245,7 +1245,7 @@ static HRESULT ca_setup_audiounit(EDataFlow dataflow, AudioComponentInstance uni > sc = AudioUnitGetProperty(unit, kAudioUnitProperty_StreamFormat, > kAudioUnitScope_Input, 1, dev_desc, &size); > if(sc != noErr){ > - WARN("Couldn't get unit format: %lx\n", sc); > + WARN("Couldn't get unit format: %x\n", sc); > return osstatus_to_hresult(sc); > } > dump_adesc("hardware", dev_desc); > @@ -1258,13 +1258,13 @@ static HRESULT ca_setup_audiounit(EDataFlow dataflow, AudioComponentInstance uni > sc = AudioUnitSetProperty(unit, kAudioUnitProperty_StreamFormat, > kAudioUnitScope_Output, 1, dev_desc, sizeof(*dev_desc)); > if(sc != noErr){ > - WARN("Couldn't set unit format: %lx\n", sc); > + WARN("Couldn't set unit format: %x\n", sc); > return osstatus_to_hresult(sc); > } > > sc = AudioConverterNew(dev_desc, &desc, converter); > if(sc != noErr){ > - WARN("Couldn't create audio converter: %lx\n", sc); > + WARN("Couldn't create audio converter: %x\n", sc); > return osstatus_to_hresult(sc); > } > }else{ > @@ -1276,7 +1276,7 @@ static HRESULT ca_setup_audiounit(EDataFlow dataflow, AudioComponentInstance uni > sc = AudioUnitSetProperty(unit, kAudioUnitProperty_StreamFormat, > kAudioUnitScope_Input, 0, dev_desc, sizeof(*dev_desc)); > if(sc != noErr){ > - WARN("Couldn't set format: %lx\n", sc); > + WARN("Couldn't set format: %x\n", sc); > return osstatus_to_hresult(sc); > } > } > @@ -1291,7 +1291,7 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, > { > ACImpl *This = impl_from_IAudioClient(iface); > HRESULT hr; > - OSStatus sc; > + int sc; > int i; > > TRACE("(%p)->(%x, %x, %s, %s, %p, %s)\n", This, mode, flags, > @@ -1383,7 +1383,7 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, > sc = AudioUnitSetProperty(This->unit, kAudioOutputUnitProperty_SetInputCallback, > kAudioUnitScope_Output, 1, &input, sizeof(input)); > if(sc != noErr){ > - WARN("Couldn't set callback: %lx\n", sc); > + WARN("Couldn't set callback: %x\n", sc); > AudioConverterDispose(This->converter); > This->converter = NULL; > CoTaskMemFree(This->fmt); > @@ -1401,7 +1401,7 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, > sc = AudioUnitSetProperty(This->unit, kAudioUnitProperty_SetRenderCallback, > kAudioUnitScope_Input, 0, &input, sizeof(input)); > if(sc != noErr){ > - WARN("Couldn't set callback: %lx\n", sc); > + WARN("Couldn't set callback: %x\n", sc); > CoTaskMemFree(This->fmt); > This->fmt = NULL; > OSSpinLockUnlock(&This->lock); > @@ -1411,7 +1411,7 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, > > sc = AudioUnitInitialize(This->unit); > if(sc != noErr){ > - WARN("Couldn't initialize: %lx\n", sc); > + WARN("Couldn't initialize: %x\n", sc); > if(This->converter){ > AudioConverterDispose(This->converter); > This->converter = NULL; > @@ -1426,7 +1426,7 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, > * a while to return */ > sc = AudioOutputUnitStart(This->unit); > if(sc != noErr){ > - WARN("Unit failed to start: %lx\n", sc); > + WARN("Unit failed to start: %x\n", sc); > if(This->converter){ > AudioConverterDispose(This->converter); > This->converter = NULL; > @@ -1515,7 +1515,7 @@ static HRESULT ca_get_max_stream_latency(ACImpl *This, UInt32 *max) > AudioObjectPropertyAddress addr; > AudioStreamID *ids; > UInt32 size; > - OSStatus sc; > + int sc; > int nstreams, i; > > addr.mScope = This->scope; > @@ -1525,7 +1525,7 @@ static HRESULT ca_get_max_stream_latency(ACImpl *This, UInt32 *max) > sc = AudioObjectGetPropertyDataSize(This->adevid, &addr, 0, NULL, > &size); > if(sc != noErr){ > - WARN("Unable to get size for _Streams property: %lx\n", sc); > + WARN("Unable to get size for _Streams property: %x\n", sc); > return osstatus_to_hresult(sc); > } > > @@ -1535,7 +1535,7 @@ static HRESULT ca_get_max_stream_latency(ACImpl *This, UInt32 *max) > > sc = AudioObjectGetPropertyData(This->adevid, &addr, 0, NULL, &size, ids); > if(sc != noErr){ > - WARN("Unable to get _Streams property: %lx\n", sc); > + WARN("Unable to get _Streams property: %x\n", sc); > HeapFree(GetProcessHeap(), 0, ids); > return osstatus_to_hresult(sc); > } > @@ -1551,7 +1551,7 @@ static HRESULT ca_get_max_stream_latency(ACImpl *This, UInt32 *max) > sc = AudioObjectGetPropertyData(ids[i], &addr, 0, NULL, > &size, &latency); > if(sc != noErr){ > - WARN("Unable to get _Latency property: %lx\n", sc); > + WARN("Unable to get _Latency property: %x\n", sc); > continue; > } > > @@ -1570,7 +1570,7 @@ static HRESULT WINAPI AudioClient_GetStreamLatency(IAudioClient *iface, > ACImpl *This = impl_from_IAudioClient(iface); > UInt32 latency, stream_latency, size; > AudioObjectPropertyAddress addr; > - OSStatus sc; > + int sc; > HRESULT hr; > > TRACE("(%p)->(%p)\n", This, out); > @@ -1593,7 +1593,7 @@ static HRESULT WINAPI AudioClient_GetStreamLatency(IAudioClient *iface, > sc = AudioObjectGetPropertyData(This->adevid, &addr, 0, NULL, > &size, &latency); > if(sc != noErr){ > - WARN("Couldn't get _Latency property: %lx\n", sc); > + WARN("Couldn't get _Latency property: %x\n", sc); > OSSpinLockUnlock(&This->lock); > return osstatus_to_hresult(sc); > } > @@ -1730,7 +1730,7 @@ static HRESULT WINAPI AudioClient_GetMixFormat(IAudioClient *iface, > { > ACImpl *This = impl_from_IAudioClient(iface); > WAVEFORMATEXTENSIBLE *fmt; > - OSStatus sc; > + int sc; > UInt32 size; > Float64 rate; > AudioBufferList *buffers; > @@ -1756,7 +1756,7 @@ static HRESULT WINAPI AudioClient_GetMixFormat(IAudioClient *iface, > sc = AudioObjectGetPropertyDataSize(This->adevid, &addr, 0, NULL, &size); > if(sc != noErr){ > CoTaskMemFree(fmt); > - WARN("Unable to get size for _StreamConfiguration property: %lx\n", sc); > + WARN("Unable to get size for _StreamConfiguration property: %x\n", sc); > return osstatus_to_hresult(sc); > } > > @@ -1771,7 +1771,7 @@ static HRESULT WINAPI AudioClient_GetMixFormat(IAudioClient *iface, > if(sc != noErr){ > CoTaskMemFree(fmt); > HeapFree(GetProcessHeap(), 0, buffers); > - WARN("Unable to get _StreamConfiguration property: %lx\n", sc); > + WARN("Unable to get _StreamConfiguration property: %x\n", sc); > return osstatus_to_hresult(sc); > } > > @@ -1788,7 +1788,7 @@ static HRESULT WINAPI AudioClient_GetMixFormat(IAudioClient *iface, > sc = AudioObjectGetPropertyData(This->adevid, &addr, 0, NULL, &size, &rate); > if(sc != noErr){ > CoTaskMemFree(fmt); > - WARN("Unable to get _NominalSampleRate property: %lx\n", sc); > + WARN("Unable to get _NominalSampleRate property: %x\n", sc); > return osstatus_to_hresult(sc); > } > fmt->Format.nSamplesPerSec = rate; > @@ -2820,7 +2820,7 @@ static const IAudioSessionControl2Vtbl AudioSessionControl2_Vtbl = > static HRESULT ca_setvol(ACImpl *This, UINT32 index) > { > Float32 level; > - OSStatus sc; > + int sc; > > if(This->session->mute) > level = 0.; > @@ -2842,7 +2842,7 @@ static HRESULT ca_setvol(ACImpl *This, UINT32 index) > sc = AudioUnitSetParameter(This->unit, kHALOutputParam_Volume, > kAudioUnitScope_Global, 0, level, 0); > if(sc != noErr) > - WARN("Couldn't set volume: %lx\n", sc); > + WARN("Couldn't set volume: %x\n", sc); > > return S_OK; > } > -- > 2.7.1 > > >

1 0

Re: user32: Always enable owner window in EndDialog.
by Marvin 22 Feb '16

22 Feb '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=20807 Your paranoid android. === w1064 (32 bit msg) === msg.c:6290: Test failed: Update region shouldn't be empty msg.c:6524: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6526: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6296: Test failed: Regions are different msg.c:6296: Test failed: Regions are different msg.c:6296: Test failed: Regions are different

1 0

Re: wine/test.h: Compare winetest_platform to the same value everywhere.
by Alexandre Julliard 22 Feb '16

22 Feb '16

Francois Gouget <fgouget(a)free.fr> writes: > todo_wine*() should have the same pltform check as broken(), win_skip() > and main(). The idea is that the tests are a description of the Windows APIs, not of a specific implementation. There can potentially be other implementations of the same APIs (for instance in ReactOS). broken() is a property of the Windows implementation, so it checks for the Windows platform. todo_wine is a property specific to the Wine implementation, so it checks for Wine. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] configure: Look for iODBC if we can't find unixODBC.
by Alexandre Julliard 22 Feb '16

22 Feb '16

Charles Davis <cdavis5x(a)gmail.com> writes: > iODBC is another ODBC implementation for Unix. It comes by default with > Mac OS. > > Signed-off-by: Charles Davis <cdavis5x(a)gmail.com> I haven't checked the Mac version, but at least on Linux the SQLWCHAR definition is incompatible, which means it can't be used as a simple replacement. -- Alexandre Julliard julliard(a)winehq.org

2 1

Success in todo depending on the Wine platform
by Francois Gouget 22 Feb '16

22 Feb '16

What should we do if a test succeeds in a todo_wine on Mac but fails on Linux, FreeBSD and Solaris. Specifically I'm thinking about this test: /* Check if we have some return values */ trace("WorkingSetSize : %ld\n", pvi.WorkingSetSize); todo_wine ok( pvi.WorkingSetSize > 0, "Expected a WorkingSetSize > 0\n"); Which the following commit caused to succeed on OSX: commit 1f9fe124b2bd7e69dad5c90b7897380e32d43481 Author: Snorri Sturluson <snorri.sturluson(a)ccpgames.com> Date: Thu Jan 28 17:22:10 2016 +0000 ntdll: Fill in memory counters under OS X. I find it pretty ironic that the OSX results, which already have more than their fair share or failures, are saddled with one extra failure when it is in fact the only Wine platform where the test succeeds! I guess implementing fill_VM_COUNTERS() on Linux, FreeBSD and Solaris would be one solution. It might not even be that hard depending on how correct you want the implementation to be. But do we have other solutions? I initially thought setting WINETEST_PLATFORM to Linux, FreeBSD, etc. could do the trick. But it currently it is only ever be set to Windows or Wine. Even worse, todo_wine explicitly checks if it is set to "wine" so anything else would break it. Should todo_wine check for 'not windows' instead? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Computers are like airconditioners They stop working properly if you open WINDOWS

3 3

Re: [PATCH 2/2] winecoreaudio.drv: Don't print 32-bit values as long integers. (Clang)
by Bruno Jesus 22 Feb '16

22 Feb '16

On Sat, Feb 20, 2016 at 4:18 AM, Charles Davis <cdavis5x(a)gmail.com> wrote: > > Signed-off-by: Charles Davis <cdavis5x(a)gmail.com> > --- > I couldn't get rid of all the casts. In particular, some of them are of a > system-defined structure that we obviously can't change. > > dlls/winecoreaudio.drv/mmdevdrv.c | 84 +++++++++++++++++++-------------------- > 1 file changed, 42 insertions(+), 42 deletions(-) > > diff --git a/dlls/winecoreaudio.drv/mmdevdrv.c b/dlls/winecoreaudio.drv/mmdevdrv.c > index 60ff3d9..90124bc 100644 > --- a/dlls/winecoreaudio.drv/mmdevdrv.c > +++ b/dlls/winecoreaudio.drv/mmdevdrv.c > @@ -385,10 +385,10 @@ HRESULT WINAPI AUDDRV_GetEndpointIDs(EDataFlow flow, WCHAR ***ids, > GUID **guids, UINT *num, UINT *def_index) > { > UInt32 devsize, size; > - AudioDeviceID *devices; > + unsigned int *devices; > AudioDeviceID default_id; > AudioObjectPropertyAddress addr; > - OSStatus sc; > + int sc; > int i, ndevices; Hi, Charles. I usually don't review patches but it feels weird to me that you are changing the type of the variable because AudioObjectGetPropertyData expects an AudioDeviceID and not an unsigned int. Even if they are the same I believe using the correct type is better. The same for OSStatus which is the return for AudioObjectGetPropertyData. Best wishes, Bruno

6 7

advapi32: add stub for AddAuditAccessObjectAce
by Louis Lenders 22 Feb '16

22 Feb '16

>Also I think it's better to do a little bit more and forward them to >ntdll Rtl* calls, like some existing calls already do, it's safe to >assume prototype are the same between the two. Hi Nicolai, RtlAddAuditAccessObjectAce and other are still not implemented in ntdll (and ntdll.spec) Am i right that you suggest to write the stubs for Rtl* in ntdll, and then forward advapi32 calls to Rtl* functions? Regards Louis

2 1