April 2016 - Wine-devel - list.winehq.org

Re: [PATCH 2/2] user32: Limit broadcast messages to system and registered ones
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21971 Your paranoid android. === wvistau64 (32 bit msg) === msg.c:11018: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:11030: Test failed: msg.message = 275 instead of WM_USER msg.c:11032: Test failed: expected PeekMessage to return FALSE, got 1 msg.c:11041: Test failed: msg.message = 1024 instead of WM_TIMER msg.c:11043: Test failed: expected PeekMessage to return FALSE, got 1 === w864 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (32 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w864 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different === w1064 (64 bit msg) === msg.c:6417: Test failed: Update region shouldn't be empty msg.c:6651: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected 0085 - actual 0000 msg.c:6653: Test failed: Paint: 0: the msg sequence is not complete: expected 000f - actual 0000 msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different msg.c:6423: Test failed: Regions are different

1 0

Re: [PATCH 3/3] mshtml: Added more IHTMLXMLHttpRequst::send tests.
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21965 Your paranoid android. === w1064 (64 bit xmlhttprequest) === The test timed out

1 0

Re: [v9 4/6] d3dx9: Add basic opcodes to preshader.
by Matteo Bruni 07 Apr '16

07 Apr '16

2016-04-01 13:21 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > +static double pres_rsq(double *args, int ncomp) > +{ > +double v; Indentation. You could also probably rename ncomp to just n. Also I get this on 32 bit: effect.c:3838: Test succeeded inside todo block: Operation rsq, component 2, expected 0x3f2c985c, got 0x3f2c985c (0.6742). effect.c:3838: Test succeeded inside todo block: Operation rsq, component 3, expected 0x1f800001, got 0x1f800001 (5.42101e-20).

2 2

Re: [v9 3/6] d3dx9: Implement fxlc constants (expressions) in effect.
by Matteo Bruni 07 Apr '16

07 Apr '16

2016-04-01 13:21 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: > +static double regstore_get_double(struct d3dx_regstore *rs, unsigned int table, unsigned int offset) > +{ > + BYTE *p; > + > + p = (BYTE *)rs->tables[table] + table_info[table].component_size * offset; > + switch (table_info[table].type) > + { > + case PRES_VT_FLOAT : return *(float *)p; > + case PRES_VT_DOUBLE: return *(double *)p; > + case PRES_VT_INT : return *(int *)p; > + case PRES_VT_BOOL : return *(BOOL *)p ? 1.0f : 0.0f; The 'f' suffix is now wrong since you're returning double. Something like "return !!*(BOOL *)p;" would be probably preferable, although I don't think you're ever supposed to read from PRES_VT_INT or PRES_VT_BOOL tables so maybe replacing the last two cases with a FIXME or similar is even better. > +static void regstore_set_double(struct d3dx_regstore *rs, unsigned int table, unsigned int offset, double v) > +{ > + BYTE *p; > + unsigned int reg_idx; > + > + p = (BYTE *)rs->tables[table] + table_info[table].component_size * offset; > + switch (table_info[table].type) > + { > + case PRES_VT_FLOAT : *(float *)p = v; break; > + case PRES_VT_DOUBLE: *(double *)p = v; break; > + case PRES_VT_INT : *(int *)p = roundf(v); break; Same here. Also it's not clear that rounding away from 0 is correct, this would need tests (although IIRC preshaders generated by the MS compiler explicitly compute integral values for integer constants, that would make this hard to test and mostly irrelevant in practice). So please try to test for rounding behavior with 0.5 / -0.5 / 1.5, if nothing else to confirm that my memory serves me right. BTW unless testing proves otherwise lrint() is probably the best option here since it generates much nicer code (at least when building with gcc for 32 bits). > + case PRES_VT_BOOL : *(BOOL *)p = !!v; break; The !! here might also be unnecessary strictly speaking but this isn't quite as significant and it's okay to me either way. > + transpose = (desc.Class == D3DXPC_MATRIX_COLUMNS && param->class == D3DXPC_MATRIX_ROWS) || > + (param->class == D3DXPC_MATRIX_COLUMNS && desc.Class == D3DXPC_MATRIX_ROWS); It looks like you forgot to move the operator at the start of the next line here (while you did that e.g. in patch 6/6).

2 2

[GSoC] Further work on the Visual C++ iostream library
by Piotr Caban 07 Apr '16

07 Apr '16

Hi Iván, could you please provide us with timeline for your project? It doesn't have to be very specific. Thanks, Piotr

2 1

Re: [PATCH] msvcp90: Add codecvt<wchar_t>::do_encoding that returns 0
by Piotr Caban 07 Apr '16

07 Apr '16

On 04/06/16 18:51, Daniel Lehman wrote: > seems to be only msvcp90 that returns 1 > > all others return 0 (which seems more correct anyway) Msvcp100 behaves the same as msvcp90. Please also update codecvt_short virtual functions table. Thanks, Piotr

1 0

Wine is "Community Choice" SourceForge Project of the Month
by Marcus Meissner 07 Apr '16

07 Apr '16

Hi, We are the "Community Choice" Project of the Month April 2016 at SourceForge. https://sourceforge.net/blog/april-2016-community-choice-project-of-the-mon… Ciao, Marcus

2 2

Re: ntdll: Do not update iosb.Status after FSCTL_PIPE_LISTEN call. (v2)
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21960 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: ntdll: Do not update iosb.Status after FSCTL_PIPE_LISTEN call. (v2)
by Marvin 07 Apr '16

07 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=21959 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [4/4] ntdll: Do not update iosb.Status after FSCTL_PIPE_LISTEN call.
by Alexandre Julliard 07 Apr '16

07 Apr '16

Sebastian Lackner <sebastian(a)fds-team.de> writes: > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > --- > > The change only affects FSCTL_PIPE_LISTEN because we probably want > more tests before changing the rest. Indeed we do, so you should probably move this out of the default case. -- Alexandre Julliard julliard(a)winehq.org

1 0