April 2016 - Wine-devel - list.winehq.org

Re: [v2 PATCH 2/3] ucrtbase: Implement _register_onexit_function()
by Piotr Caban 25 Apr '16

25 Apr '16

On 04/24/16 20:51, Nikolay Sivov wrote: > + len = table->_end - table->_first; > + > + /* grow if full */ > + if (table->_last == table->_end) > + { > + table->_first = MSVCRT_realloc(table->_first, 2 * len * sizeof(void *)); > + table->_end = table->_first + 2 * len; > + table->_last = table->_first + len; > + } Please move len initialization/definition into the if block. Also please handle allocation failure. Thanks, Piotr

1 0

Re: [PATCH] hidclass.sys: add missing case/missing heapfree (Coverity)
by Aric Stewart 25 Apr '16

25 Apr '16

Signed-off-by: Aric Stewart <aric(a)codeweavers.com> On 4/23/16 1:03 PM, Marcus Meissner wrote: > 1358558 Resource leak > > (actually switch on the enum, then the compiler will see missing cases) > > 2nd try, also use variable in debug directly > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/hidclass.sys/pnp.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/dlls/hidclass.sys/pnp.c b/dlls/hidclass.sys/pnp.c > index d97184f..87b19ac 100644 > --- a/dlls/hidclass.sys/pnp.c > +++ b/dlls/hidclass.sys/pnp.c > @@ -292,10 +292,9 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp) > case IRP_MN_QUERY_ID: > { > BASE_DEVICE_EXTENSION *ext = device->DeviceExtension; > - ULONG type = irpsp->Parameters.QueryId.IdType; > WCHAR *id = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(WCHAR)*REGSTR_VAL_MAX_HCID_LEN); > - TRACE("IRP_MN_QUERY_ID[%i]\n", type); > - switch (type) > + TRACE("IRP_MN_QUERY_ID[%i]\n", irpsp->Parameters.QueryId.IdType); > + switch (irpsp->Parameters.QueryId.IdType) > { > case BusQueryHardwareIDs: > case BusQueryCompatibleIDs: > @@ -326,6 +325,10 @@ NTSTATUS WINAPI HID_PNP_Dispatch(DEVICE_OBJECT *device, IRP *irp) > irp->IoStatus.Information = (ULONG_PTR)id; > rc = STATUS_SUCCESS; > break; > + case BusQueryDeviceSerialNumber: > + FIXME("BusQueryDeviceSerialNumber not implemented\n"); > + HeapFree(GetProcessHeap(), 0, id); > + break; > } > break; > } >

1 0

Re: kernel32: Print a FIXME only once in LCMapStringEx
by Andrew Eikum 25 Apr '16

25 Apr '16

On Mon, Apr 25, 2016 at 04:58:55PM +0200, Louis Lenders wrote: > diff --git a/dlls/kernel32/locale.c b/dlls/kernel32/locale.c > index 7418da9..8901870 100644 > --- a/dlls/kernel32/locale.c > +++ b/dlls/kernel32/locale.c > @@ -2974,10 +2974,13 @@ INT WINAPI LCMapStringEx(LPCWSTR name, DWORD flags, LPCWSTR src, INT srclen, LPW > LPNLSVERSIONINFO version, LPVOID reserved, LPARAM lparam) > { > LPWSTR dst_ptr; > + static int once; > > if (version) FIXME("unsupported version structure %p\n", version); > if (reserved) FIXME("unsupported reserved pointer %p\n", reserved); > - if (lparam) FIXME("unsupported lparam %lx\n", lparam); > + > + if (!once++) > + if (lparam) FIXME("unsupported lparam %lx\n", lparam); I think you got the if statements backwards here. You should print the first time lparam is non-zero, not only if it's non-zero on the first LCMapStringEx call. Andrew

1 0

Re: Wine 1.8.1
by Michael Stefaniuc 25 Apr '16

25 Apr '16

Hello Berto, On 04/25/2016 04:13 PM, Berto Niker wrote: > How do I install Wine 1.8.1 in Ubuntu (Xenial and Trusty)? I added the current Stable version is 1.8.2 already. > repository and it only has 1.8.0. Wine Stable is not part yet of the repositories provided by winehq.org. It is planned though. > I am not interested in the development build 1.9.x. I do not want to > worry about things breaking every two weeks. Sure, that's the reason we do Wine Stable. bye michael

1 0

Re: [PATCH 6/6] ddraw/tests: Test creating flippable cubemaps.
by Bruno Jesus 25 Apr '16

25 Apr '16

On Mon, Apr 25, 2016 at 12:25 PM, Józef Kucia <jkucia(a)codeweavers.com> wrote: > Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> > --- > dlls/ddraw/surface.c | 2 ++ > dlls/ddraw/tests/ddraw7.c | 50 Hi, the subject says you are adding tests but you also change dll source, was it a leftover? Or maybe the subject should be changed to reflect the source change IMO.

2 1

Re: [PATCH 6/6] ddraw/tests: Test creating flippable cubemaps.
by Marvin 25 Apr '16

25 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22544 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: Experimental 64 bit OS X packages ready for testing
by Diego Vicioso 25 Apr '16

25 Apr '16

Any updates if it will be included into normal wine or future wine staging packages? Sent from my mac

2 1

Re: [PATCH] kernel32/tests: Add initial tests for GetConsoleFontInfo (v2)
by Sebastian Lackner 25 Apr '16

25 Apr '16

On 22.04.2016 15:21, Hugh McMaster wrote: > Changes since v1: Use CONSOLE_FONT_INFO instead of undocumented CONSOLE_FONT. > The structure is identical. > > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > dlls/kernel32/tests/console.c | 57 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > You'll have to add a stub first, otherwise it breaks the tests: $ (cd dlls/kernel32/tests/; make console.ok) ../../../tools/runtest -q -P wine -T ../../.. -M kernel32.dll -p kernel32_test.exe.so console && touch console.ok fixme:console:GetConsoleProcessList ((nil),0): stub fixme:console:GetConsoleProcessList ((nil),1): stub fixme:console:GetConsoleProcessList (0x118ca0,0): stub fixme:console:GetConsoleProcessList (0x118ca0,1): stub fixme:console:GetConsoleProcessList (0x118ca0,0): stub fixme:console:SetConsoleFont (0x63, 0): stub! fixme:console:SetConsoleFont (0x63, 0): stub! wine: Call from 0x7b43b8a2 to unimplemented function KERNEL32.dll.GetConsoleFontInfo, aborting wine: Unimplemented function KERNEL32.dll.GetConsoleFontInfo called at address 0x7b43b8a2 (thread 0009), starting debugger...

2 2

Re: Fix a heap corruption when printing specific REG_MULTI_SZ values.
by Hugh McMaster 25 Apr '16

25 Apr '16

On Saturday, 23 April 2016 3:35 AM, Sebastian Lackner wrote: >The current calculation does not take the terminating \0 into account. > -buffer = HeapAlloc(GetProcessHeap(), 0, tmp_size * 2); > +buffer = HeapAlloc(GetProcessHeap(), 0, tmp_size * 2 + sizeof(WCHAR)); Which particular cases cause the heap corruption? -- Hugh McMaster

2 4

Re: [PATCH 3/4] d3drm/tests: Replace test_Texture. (v2)
by Stefan Dösinger 25 Apr '16

25 Apr '16

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Am 2016-04-24 um 16:50 schrieb Aaryaman Vasishta: > + hr = IDirect3DRMTexture_GetClassName(texture1, &size, cname); > + ok(hr == E_INVALIDARG, "GetClassName failed with %x\n", hr); > + ok(size == sizeof("Texture") - 1, "wrong size: %u\n", size); > + ok(!strcmp(cname, "Texture"), "Expected cname to be \"Texture\", but got \"%s\"\n", cname); The strcmp check here is misleading. The content is a leftover from the previous successful call. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXHSYsAAoJEN0/YqbEcdMwVzUQAI5igH0GyGwby4/FQMWpOaDl gXwxyST6BOhwnMfSNSdY/yFT0WqgLxm23+uE1fDsApaENRTEn1JzfSC8/DzeSeEd KHv4QU2KeHlRtLl01CWJclwGgwgdCaP1b1+8mSzxXtWgfjZ2RRtGJON4STzDqLvt G8DYYKJVEAgGQXq2o4N0ZtqRJmmOyOY9iR6Etwz1SoUOe3PgKHwbHEeAJ9YmbbzV zJKkYxdEjuRcyO6Z5xXb5XLV2OBdYD/pqYPMwodQWfJIaht0Ui2GYrSI7Tw1b+DL d/B6M6gYfYm9DAivlL5DflZoyLI4OIm95BRmOgtJZ3EY+qsR0UPuHEybCZnzy0u5 0qQNTGs4+sWecIcFQMmtOqj5wcesV0XPLiRr3nAPMuuIaiBNO3Yyvxu2f/KyLIEa 3E3u6HmJtnyLJPK1btsc1mjsr21LpBA2sQ2AXYV/9wfQyIBhKUdk9gsC9lYNQEvm eVRCtTg4BDIUTxze8lXGqslyio/5IEPr1dX0suX5Rj61tpcDgp6C1MdSiHZkliM3 dTuk7Wu3dfdXCAZfGS/J+QfoQfXwP6NqYhIx6bzY48XGeL/N+m9rGC2lG1mMVROu xW5lgCuZ5/Vt2Z7+qzfEVuI0HxQ+cXO86IEq1RClvszje+1stblLpTQDrAg/hy6G X1q4jNhSjnxRP6Q0r2Ls =39F6 -----END PGP SIGNATURE-----

2 3