April 2016 - Wine-devel - list.winehq.org

Re: [PATCH 3/8] ddraw: Return early in d3d_device7_DrawIndexedPrimitive() with a 0 vertex or index count.
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22462 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 2/8] ddraw: Return early in d3d_device7_DrawIndexedPrimitiveStrided() with a 0 vertex or index count.
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22461 Your paranoid android. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

Re: [PATCH 1/8] ddraw/tests: Add some tests for draw parameter validation.
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22460 Your paranoid android. === w1064 (32 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw2) === ddraw2.c:2360: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw4) === ddraw4.c:2545: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (32 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}. === w1064 (64 bit ddraw7) === ddraw7.c:2275: Test failed: Expected {0, 0, 512, 384}, got {0, 0, 1024, 768}.

1 0

How do I register a DirectShow class?
by Alex Henrie 22 Apr '16

22 Apr '16

Hi, I've been trying to fix <https://bugs.winehq.org/show_bug.cgi?id=32473>, you can see my work at <https://github.com/alexhenrie/wine/commits/master>. I defined the AMTimeline class and its interfaces and I added a complete stub implementation, but I'm still getting the same error: err:ole:CoGetClassObject class {78530b75-61f9-11d2-8cad-00a024580902} not registered err:ole:CoGetClassObject no class object {78530b75-61f9-11d2-8cad-00a024580902} could be created for context 0x1 What am I missing? -Alex

3 3

Re: [PATCH] qedit: List parameters in order in create function traces.
by Andrew Eikum 22 Apr '16

22 Apr '16

Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Thanks. Just for my own information, are you working in this area? I'm working on video embedding in Office 2010 (Bug 40179) at the moment. Andrew On Fri, Apr 22, 2016 at 12:18:00AM -0600, Alex Henrie wrote: > Cc: Andrew Eikum <aeikum(a)codeweavers.com> > > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > dlls/qedit/mediadet.c | 2 +- > dlls/qedit/samplegrabber.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/qedit/mediadet.c b/dlls/qedit/mediadet.c > index 9098223..53ab75a 100644 > --- a/dlls/qedit/mediadet.c > +++ b/dlls/qedit/mediadet.c > @@ -640,7 +640,7 @@ static const IMediaDetVtbl IMediaDet_VTable = > HRESULT MediaDet_create(IUnknown * pUnkOuter, LPVOID * ppv) { > MediaDetImpl* obj = NULL; > > - TRACE("(%p,%p)\n", ppv, pUnkOuter); > + TRACE("(%p,%p)\n", pUnkOuter, ppv); > > obj = CoTaskMemAlloc(sizeof(MediaDetImpl)); > if (NULL == obj) { > diff --git a/dlls/qedit/samplegrabber.c b/dlls/qedit/samplegrabber.c > index e9e4906..946dba9 100644 > --- a/dlls/qedit/samplegrabber.c > +++ b/dlls/qedit/samplegrabber.c > @@ -1262,7 +1262,7 @@ HRESULT SampleGrabber_create(IUnknown *pUnkOuter, LPVOID *ppv) > ISeekingPassThru *passthru; > HRESULT hr; > > - TRACE("(%p,%p)\n", ppv, pUnkOuter); > + TRACE("(%p,%p)\n", pUnkOuter, ppv); > > obj = CoTaskMemAlloc(sizeof(SG_Impl)); > if (NULL == obj) { > -- > 2.8.0 >

2 1

Re: [v6 PATCH] comctl32/tooltip: Protect TTM_ADDTOOLW from invalid text pointers
by Nikolay Sivov 22 Apr '16

22 Apr '16

On 22.04.2016 10:55, Alistair Leslie-Hughes wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=10347 > > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > --- > dlls/comctl32/tests/tooltips.c | 39 +++++++++++++++++++++++++++++++++++++++ > dlls/comctl32/tooltips.c | 5 ++++- > 2 files changed, 43 insertions(+), 1 deletion(-) > > diff --git a/dlls/comctl32/tests/tooltips.c b/dlls/comctl32/tests/tooltips.c > index 3382fce..db3d3c4 100644 > --- a/dlls/comctl32/tests/tooltips.c > +++ b/dlls/comctl32/tests/tooltips.c > @@ -446,6 +446,45 @@ static void test_gettext(void) > r = SendMessageW(hwnd, TTM_ADDTOOLW, 0, (LPARAM)&toolinfoW); > ok(!r, "Adding the tool to the tooltip succeeded!\n"); > > + /* lpszText with an invalid address */ > + toolinfoW.cbSize = sizeof(TTTOOLINFOW); > + toolinfoW.hwnd = notify; > + toolinfoW.hinst = GetModuleHandleA(NULL); > + toolinfoW.uFlags = 0; > + toolinfoW.uId = 0; > + toolinfoW.lpszText = (LPWSTR)0xdeadbeef; > + toolinfoW.lParam = 0; > + GetClientRect(hwnd, &toolinfoW.rect); > + r = SendMessageA(hwnd, TTM_ADDTOOLW, 0, (LPARAM)&toolinfoW); > + ok(!r, "Adding the tool to the tooltip succeeded!\n"); > + > + /* lpszText with an callback address */ > + toolinfoW.cbSize = sizeof(TTTOOLINFOW); > + toolinfoW.hwnd = notify; > + toolinfoW.hinst = GetModuleHandleA(NULL); > + toolinfoW.uFlags = 0; > + toolinfoW.uId = 0; > + toolinfoW.lpszText = LPSTR_TEXTCALLBACKW; > + toolinfoW.lParam = 0; > + GetClientRect(hwnd, &toolinfoW.rect); > + r = SendMessageA(hwnd, TTM_ADDTOOLW, 0, (LPARAM)&toolinfoW); > + todo_wine ok(!r, "Adding the tool to the tooltip succeeded!\n"); > + This is broken, 'notify' is invalid at this point, take a look at a patch I sent couple days ago. Also these tests don't work for me even with valid string pointers, and with reduce cbSize and invalid pointers they crash on Windows. So the whole idea might be wrong. > if (0) /* crashes on NT4 */ > { > toolinfoW.hwnd = NULL; > diff --git a/dlls/comctl32/tooltips.c b/dlls/comctl32/tooltips.c > index 8bf6919..804e9ed 100644 > --- a/dlls/comctl32/tooltips.c > +++ b/dlls/comctl32/tooltips.c > @@ -1038,7 +1038,10 @@ TOOLTIPS_AddToolT (TOOLTIPS_INFO *infoPtr, const TTTOOLINFOW *ti, BOOL isW) > infoPtr->hwndSelf, ti->hwnd, ti->uId, > (ti->uFlags & TTF_IDISHWND) ? " TTF_IDISHWND" : ""); > > - if (ti->cbSize >= TTTOOLINFOW_V2_SIZE && !ti->lpszText && isW) > + if (ti->cbSize >= TTTOOLINFOW_V2_SIZE && isW > + && !TOOLTIPS_IsCallbackString(ti->lpszText, isW) > + && !(ti->lpszText && IS_INTRESOURCE(ti->lpszText)) > + && IsBadStringPtrW(ti->lpszText, sizeof(WCHAR)) ) > return FALSE; Text check is wrong.

1 0

Re: [PATCH] kernel32/tests: Add initial tests for GetConsoleFontInfo (v2)
by Marvin 22 Apr '16

22 Apr '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=22458 Your paranoid android. === w8 (32 bit console) === console.c:1445: Test failed: [13] Expected output count to be 0, got 2703919542 console.c:1445: Test failed: [15] Expected output count to be 0, got 2703919542 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 2703919542 console.c:1689: Test failed: [13] Expected output count to be 0, got 2703919542 console.c:1689: Test failed: [15] Expected output count to be 0, got 2703919542 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 2703919542 === w864 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 1919911434 console.c:1445: Test failed: [15] Expected output count to be 0, got 1919911434 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 1919911434 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 1919911434 console.c:1689: Test failed: [15] Expected output count to be 0, got 1919911434 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 1919911434 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (32 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [13] Expected output count to be 0, got 418781008 console.c:1445: Test failed: [15] Expected output count to be 0, got 418781008 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 418781008 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [13] Expected output count to be 0, got 418781008 console.c:1689: Test failed: [15] Expected output count to be 0, got 418781008 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 418781008 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1 === w1064 (64 bit console) === console.c:2567: Test failed: expected ERROR_INVALID_HANDLE, got 1 console.c:2573: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2580: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:2587: Test failed: expected ERROR_NOT_ENOUGH_MEMORY, got 998 console.c:1270: Test failed: expected VerifyConsoleIoHandle to succeed console.c:1445: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1445: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [3] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [11] Expected output count to be 3735928559, got 0 console.c:1689: Test failed: [18] Expected output count to be 3735928559, got 0 console.c:2148: Test failed: [7] Expected count to be 0, got 1 console.c:2214: Test failed: [7] Expected count to be 0, got 1 console.c:2280: Test failed: [7] Expected count to be 0, got 1

1 0

Re: [PATCH v4 5/7] wined3d: Implement readback from 2D array textures using glGet[Compressed]TexImage().
by Henri Verbeet 22 Apr '16

22 Apr '16

On 22 April 2016 at 11:18, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + if (surface->texture_target == GL_TEXTURE_2D_ARRAY) > + { > + /* We don't expect to ever need to emulate NP2 textures when we have EXT_texture_array. */ > + if (texture->flags & WINED3D_TEXTURE_COND_NP2_EMULATED) > + { > + FIXME("Cannot download surface %p, level %u, layer %u.\n", > + surface, surface->texture_level, surface->texture_layer); > + return; > + } Note that you can enforce that in texture_init(). It currently checks for WINED3DUSAGE_LEGACY_CUBEMAP, but it would be easy to check the layer count instead.

1 0

Re: [PATCH] dwrite: Implement newer version of CreateFontFromLOGFONT()
by Jacek Caban 22 Apr '16

22 Apr '16

Hi Nikolay, On 04/21/16 19:48, Nikolay Sivov wrote: > + hr = IDWriteFontCollection_FindFamilyName(collection, logfont->lfFaceName, &index, &exists); > + if (FAILED(hr)) { > + IDWriteFontCollection_Release(collection); > + goto done; > + } You release collection twice in error path. Cheers, Jacek

1 0

Re: [04/10] webservices: Add support for reading double values.
by Hans Leidekker 22 Apr '16

22 Apr '16

On Fri, 2016-04-22 at 09:42 +0200, Hans Leidekker wrote: Please disregard this patch, Henri pointed out a problem with the use of strtod.

1 0