June 2016 - Wine-devel - list.winehq.org

Re: mshtml/tests: Fix a typo in ok() message.
by Michael Stefaniuc 23 Jun '16

23 Jun '16

On 06/23/2016 11:56 AM, Andrey Gusev wrote: > > mshtml-tests-Fix-a-typo-in-ok-message.txt > > > From d30dec56bc2f7f716ab786516ee6080c9cdea67f Mon Sep 17 00:00:00 2001 > Message-Id: <d30dec56bc2f7f716ab786516ee6080c9cdea67f.1466675739.git.andrey.goosev(a)gma…> > From: Andrey Gusev <andrey.goosev(a)gmail.com> > Date: Thu, 23 Jun 2016 12:55:21 +0300 > Subject: [PATCH] mshtml/tests: Fix a typo in ok() message. > > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/mshtml/tests/dom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c > index dce65d5..5c4261e 100644 > --- a/dlls/mshtml/tests/dom.c > +++ b/dlls/mshtml/tests/dom.c > @@ -7497,7 +7497,7 @@ static void test_table_elem(IHTMLElement *elem) > VariantClear(&v); > hres = IHTMLTable_get_width(table, &v); > ok(hres == S_OK, "get_width = %08x\n", hres); > - ok(!strcmp_wa(V_BSTR(&v), "40.2%"), "Expected 40.2%%, got %s\n", wine_dbgstr_w(V_BSTR(&v))); > + ok(!strcmp_wa(V_BSTR(&v), "40.2%"), "Expected 40.2%, got %s\n", wine_dbgstr_w(V_BSTR(&v))); That is not a typo, one of this commands would have told you that: - man 3 printf - make bye michael

1 0

Re: mshtml/tests: Allow ParseUrl to clear buffer on Win10
by Marvin 22 Jun '16

22 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23818 Your paranoid android. === w1064 (32 bit protocol) === protocol.c:723: Test failed: buf changed === w1064 (64 bit protocol) === protocol.c:723: Test failed: buf changed

1 0

Re: [2/2] advapi32/tests: Allow Win8+ flags for Admins ACE
by Marvin 22 Jun '16

22 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23817 Your paranoid android. === w1064 (32 bit security) === security.c:4011: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4015: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4024: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4011: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4015: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4024: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: [1/2] advapi32/tests: Allow MACHINE\Software to be owned by local system
by Marvin 22 Jun '16

22 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23816 Your paranoid android. === w864 (32 bit security) === security.c:4024: Test failed: Builtin Admins ACE has unexpected flags (0xa != 0x0) === w1064 (32 bit security) === security.c:4011: Test failed: Builtin Users ACE has unexpected flags (0x12 != 0xa) security.c:4015: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4024: Test failed: Builtin Admins ACE has unexpected flags (0x12 != 0x0) === w1064 (64 bit security) === security.c:4011: Test failed: Builtin Users ACE has unexpected flags (0x2 != 0xa) security.c:4015: Test failed: Builtin Users ACE has unexpected mask (0x20019 != 0x80000000) security.c:4024: Test failed: Builtin Admins ACE has unexpected flags (0x2 != 0x0)

1 0

Re: kernel32/tests: Fix a typo
by Marvin 22 Jun '16

22 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23815 Your paranoid android. === w1064 (32 bit locale) === locale.c:2370: Test failed: LCMapStringEx should fail with bad locale name locale.c:2371: Test failed: unexpected error code -559038737 locale.c:2462: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4192: Test failed: IsValidLocaleName should have failed locale.c:4194: Test failed: IsValidLocaleName should have failed locale.c:4577: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4579: Test failed: For id 7, Expected IVC, got '' === w1064 (64 bit locale) === locale.c:2370: Test failed: LCMapStringEx should fail with bad locale name locale.c:2371: Test failed: unexpected error code -559038737 locale.c:2462: Test failed: Expected lcid == 0, got 00001000, error -559038737 locale.c:4192: Test failed: IsValidLocaleName should have failed locale.c:4194: Test failed: IsValidLocaleName should have failed locale.c:4577: Test failed: For id 7, expected ret == 4, got 1, error 87 locale.c:4579: Test failed: For id 7, Expected IVC, got ''

1 0

Re: apphelp: add SdbGetAppPatchDir stub (try 2)
by Sebastian Lackner 22 Jun '16

22 Jun '16

On 22.06.2016 09:23, Austin English wrote: > Using WCHAR * > > Previous try dropped without comment. Fixes > https://bugs.winehq.org/show_bug.cgi?id=35892 > > -- -Austin GPG: 14FB D7EA A041 937B > > > 0001-apphelp-add-SdbGetAppPatchDir-stub.patch > > > From 12b43f471b437309d80bf8625cdc4d518a225c72 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 22 Jun 2016 02:17:19 -0500 > Subject: [PATCH] apphelp: add SdbGetAppPatchDir stub > > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > dlls/apphelp/apphelp.c | 5 +++++ > dlls/apphelp/apphelp.spec | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/dlls/apphelp/apphelp.c b/dlls/apphelp/apphelp.c > index 64dcd87..122642c 100644 > --- a/dlls/apphelp/apphelp.c > +++ b/dlls/apphelp/apphelp.c > @@ -111,3 +111,8 @@ void WINAPI SdbCloseDatabase(PDB pdb) > { > FIXME("stub: %p\n", pdb); > } > + > +void WINAPI SdbGetAppPatchDir(HSDB hsdb, WCHAR *path, DWORD size) > +{ > + FIXME("stub: %p %s %d\n", hsdb, debugstr_w(path), size); Path is an output buffer, it does not make sense to use debugstr_w here. Also, MSDN says "If the function fails, this parameter is set to the empty string ("").". It would probably make sense to implement that, too. > +} > diff --git a/dlls/apphelp/apphelp.spec b/dlls/apphelp/apphelp.spec > index a658e5c..0119a48 100644 > --- a/dlls/apphelp/apphelp.spec > +++ b/dlls/apphelp/apphelp.spec > @@ -49,7 +49,7 @@ > @ stub SdbFreeFileInfo > @ stub SdbFreeFlagInfo > @ stub SdbGetAppCompatDataSize > -@ stub SdbGetAppPatchDir > +@ stdcall SdbGetAppPatchDir(ptr wstr long) HSDB is a handle, so "long" is more appropriate. > @ stub SdbGetBinaryTagData > @ stub SdbGetDatabaseID > @ stub SdbGetDatabaseInformation > -- 2.8.1 > > >

1 0

Re: [PATCH 1/2] include: add wmium.h (try 2) (resend)
by Sebastian Lackner 22 Jun '16

22 Jun '16

On 22.06.2016 00:18, Austin English wrote: On the first sight, your patch still contains the same errors I pointed out in my earlier review: https://www.winehq.org/pipermail/wine-devel/2016-June/113414.html Is this really the latest version? Regards, Sebastian

1 0

Re: [v2 PATCH] inetcomm: Implement IMimeBody GetPropInfo
by Alexandre Julliard 22 Jun '16

22 Jun '16

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > + memset(&info, 0, sizeof(info)); > + hr = IMimeBody_GetPropInfo(body, "Subject", &info); > + ok(hr == S_OK, "ret %08x\n", hr); > + if(hr == S_OK) > + { > + ok(info.dwMask == 0, "Invalid mask 0x%08x\n", info.dwFlags); > + ok(info.dwFlags == 0, "Invalid flags 0x%08x\n", info.dwFlags); > + ok(info.ietEncoding == 0, "Invalid encoding %d\n", info.ietEncoding); > + ok(info.dwPropId == 0, "Invalid propid %d\n", info.dwPropId); > + } > + > + memset(&info, 0, sizeof(info)); > + info.dwPropId = 1024; > + info.ietEncoding = 99; > + hr = IMimeBody_GetPropInfo(body, "Subject", &info); > + ok(hr == S_OK, "ret %08x\n", hr); > + if(hr == S_OK) > + { > + ok(info.dwMask == 0, "Invalid mask 0x%08x\n", info.dwFlags); > + ok(info.dwFlags == 0, "Invalid flags 0x%08x\n", info.dwFlags); > + ok(info.ietEncoding == 99, "Invalid encoding %d\n", info.ietEncoding); > + ok(info.dwPropId == 1024, "Invalid propid %d\n", info.dwPropId); > + } I still think it would be better to memset with a non-zero value so you can reliably see what has been set. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v2 4/7] msvcirt: Implement ostream::operator<< for floats
by Piotr Caban 22 Jun '16

22 Jun '16

On 06/22/16 11:53, Iván Matellanes wrote: > + str_length += _scprintf(sprintf_fmt, prec, d); /* number representation */ > + if (str_length > 24) { > + /* too long to output */ > + ostream_writepad(ostr, "", ""); Could you please add a test for it? Also a comment saying that this is expected behavior would be useful. > + float param_float[] = {1.0f, 0.0f, 4.25f, 3.999f, 12.0005f, 15.33582f, 15.0f, 15.22f, 21.123f, 0.1f, > + 13.14159f, 0.00013f, 0.000013f, 1.0f / 0.0f, -1.0f / 0.0f, 0.0f / 0.0f}; Please do something similar as in dlls/msvcrt/tests/misc.c to define INFINITY/NAN in tests. Thanks, Piotr

2 2

Re: user32/tests: Avoid using CopyRect().
by Marvin 22 Jun '16

22 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23786 Your paranoid android. === w864 (64 bit win) === win.c:8733: Test failed: msg.message = 320

2 1