June 2016 - Wine-devel - list.winehq.org

Re: [v2 1/7] msvcirt: Implement ostream::operator<< for characters
by Piotr Caban 22 Jun '16

22 Jun '16

On 06/22/16 11:53, Iván Matellanes wrote: > + enum { CHAR } type; It's better to avoid using enum values identical as Windows types. It will make it impossible to use CHAR type. Thanks, Piotr

1 0

Re: [v2 3/7] msvcirt: Implement ostream::operator<< for integers
by Piotr Caban 22 Jun '16

22 Jun '16

On 06/22/16 11:53, Iván Matellanes wrote: > int param_int[] = {0, 7, 10, 24 ,55, 1024, 1023, 65536, 2147483647, 2147483648, 4294967295, -20}; It causes compilation warning: ../../../../wine_src/dlls/msvcirt/tests/msvcirt.c:3023:5: warning: this decimal constant is unsigned only in ISO C90 int param_int[] = {0, 7, 10, 24 ,55, 1024, 1023, 65536, 2147483647, 2147483648, 4294967295, -20}; ^ ../../../../wine_src/dlls/msvcirt/tests/msvcirt.c:3023:5: warning: this decimal constant is unsigned only in ISO C90 Thanks, Piotr

1 0

Re: [PATCH 5/5] wined3d: Send query destruction through the command stream.
by Henri Verbeet 22 Jun '16

22 Jun '16

On 22 June 2016 at 10:39, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> > --- > dlls/wined3d/palette.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > The subject should of course read "wined3d: Send palette destruction through the command stream."

1 0

Re: include: Add an inline version of CopyRect() too.
by Alexandre Julliard 21 Jun '16

21 Jun '16

Michael Stefaniuc <mstefani(a)redhat.de> writes: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > Around 95 use cases. > No, I do *not* want to do change RECT struct assignments to CopyRect(). Good, but how about changing CopyRect to assignments? ;-) -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] msvcrt: Implement _wperror (v2)
by Piotr Caban 21 Jun '16

21 Jun '16

On 06/21/16 14:42, Hugh McMaster wrote: > + size = MSVCRT_wcstombs(NULL, str, 0) + 1; > + buffer = MSVCRT_malloc(size); > + if (!buffer) return; > + MSVCRT_wcstombs(buffer, str, size); Please handle MSVCRT_wcstombs failure. Thanks, Piotr

2 2

Re: [2/8] msvcirt: Implement ostream::operator<< for characters
by Piotr Caban 21 Jun '16

21 Jun '16

On 06/21/16 11:54, Iván Matellanes wrote: > @@ -2608,8 +2615,7 @@ ostream* __thiscall ostream_print_char(ostream *this, char c) > DEFINE_THISCALL_WRAPPER(ostream_print_unsigned_char, 8) > ostream* __thiscall ostream_print_unsigned_char(ostream *this, unsigned char c) > { > - FIXME("(%p %c) stub\n", this, c); > - return this; > + return ostream_print_char(this, (char) c); > } The cast here is not needed. > + pssb = (strstreambuf*) call_func1(p_strstreambuf_ctor, &ssb); > + ok(pssb == &ssb, "wrong return, expected %p got %p\n", &ssb, pssb); > + pos = (ostream*) call_func3(p_ostream_sb_ctor, &os, (streambuf*) &ssb, TRUE); As well as this ones. Such casts can potentially hide problems otherwise visible during 64-bit compilation. > + pos = (ostream*) call_func2(p_ostream_print_char, &os, (int) tests[i].param.c); break; The cast here is also not needed. Thanks, Piotr

1 0

Re: [7/8] msvcirt: Implement ostream::operator<< for streambuf
by Marvin 21 Jun '16

21 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23764 Your paranoid android. === wxppro (32 bit msvcirt) === Found no trace of the test summary line or of a crash === w2003std (32 bit msvcirt) === Found no trace of the test summary line or of a crash

1 0

Re: [6/8] msvcirt: Implement ostream::operator<< for pointers
by Marvin 21 Jun '16

21 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23763 Your paranoid android. === wxppro (32 bit msvcirt) === Found no trace of the test summary line or of a crash === w2003std (32 bit msvcirt) === Found no trace of the test summary line or of a crash

1 0

Re: [2/8] msvcirt: Implement ostream::operator<< for characters
by Piotr Caban 21 Jun '16

21 Jun '16

On 06/21/16 11:54, Iván Matellanes wrote: > + struct ostream_print_test { > + enum { CHAR } type; > + union { > + char c; > + } param; > + ios_io_state state; > + ios_flags flags; > + int precision; > + int fill; > + int width; > + const char *expected_text; > + ios_io_state expected_flags; > + } tests[] = { > + /* char */ > + {CHAR, {.c = 'a'}, IOSTATE_badbit, 0, 6, ' ', 0, "", IOSTATE_badbit|IOSTATE_failbit}, > + {CHAR, {.c = 'a'}, IOSTATE_eofbit, 0, 6, ' ', 0, "", IOSTATE_eofbit|IOSTATE_failbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, 0, 6, ' ', 0, "a", IOSTATE_goodbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, 0, 6, ' ', 4, " a", IOSTATE_goodbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, 0, 6, 'x', 3, "xxa", IOSTATE_goodbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, FLAGS_left, 6, ' ', 4, "a ", IOSTATE_goodbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, FLAGS_left|FLAGS_internal, 6, ' ', 4, " a", IOSTATE_goodbit}, > + {CHAR, {.c = 'a'}, IOSTATE_goodbit, FLAGS_internal|FLAGS_hex|FLAGS_showbase, 6, ' ', 4, " a", IOSTATE_goodbit}, > + {CHAR, {.c = '9'}, IOSTATE_goodbit, FLAGS_oct|FLAGS_showbase|FLAGS_uppercase, 6, 'i', 2, "i9", IOSTATE_goodbit}, > + {CHAR, {.c = '9'}, IOSTATE_goodbit, FLAGS_showpos|FLAGS_scientific, 0, 'i', 2, "i9", IOSTATE_goodbit}, > + {CHAR, {.c = 'e'}, IOSTATE_goodbit, FLAGS_left|FLAGS_right|FLAGS_uppercase, 0, '*', 8, "e*******", IOSTATE_goodbit} > + }; This is not portable (the {.c = 'a'} part). Thanks, Piotr

1 0

Re: [5/8] msvcirt: Implement ostream::operator<< for floats
by Marvin 21 Jun '16

21 Jun '16

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=23762 Your paranoid android. === wxppro (32 bit msvcirt) === Found no trace of the test summary line or of a crash === w2003std (32 bit msvcirt) === Found no trace of the test summary line or of a crash

1 0