January 2017 - Wine-devel - list.winehq.org

Re: [PATCH] setupapi: Stub CM_Open_DevNode_Key and CM_Get_Child
by Nikolay Sivov 19 Jan '17

19 Jan '17

On 18.01.2017 22:40, Christoph Brill wrote: > Both are necessary to start Lord of the Rings Online as of January 2017 > > Signed-off-by: Christoph Brill <egore911(a)gmail.com> > --- > dlls/setupapi/setupapi.spec | 4 ++-- > dlls/setupapi/stubs.c | 22 ++++++++++++++++++++++ > 2 files changed, 24 insertions(+), 2 deletions(-) > > diff --git a/dlls/setupapi/setupapi.spec b/dlls/setupapi/setupapi.spec > index 0eb8359ee1..5c57c23431 100644 > --- a/dlls/setupapi/setupapi.spec > +++ b/dlls/setupapi/setupapi.spec > @@ -53,7 +53,7 @@ > @ stub CM_Free_Res_Des > @ stub CM_Free_Res_Des_Ex > @ stub CM_Free_Res_Des_Handle > -@ stub CM_Get_Child > +@ stdcall CM_Get_Child(ptr long long) > @ stub CM_Get_Child_Ex > @ stub CM_Get_Class_Key_NameA > @ stub CM_Get_Class_Key_NameW > @@ -144,7 +144,7 @@ > @ stub CM_Open_Class_KeyW > @ stub CM_Open_Class_Key_ExA > @ stub CM_Open_Class_Key_ExW > -@ stub CM_Open_DevNode_Key > +@ stdcall CM_Open_DevNode_Key(long long long long ptr long) > @ stub CM_Open_DevNode_Key_Ex > @ stub CM_Query_And_Remove_SubTreeA > @ stub CM_Query_And_Remove_SubTreeW > diff --git a/dlls/setupapi/stubs.c b/dlls/setupapi/stubs.c > index 6ecf240c86..1f76b08a3d 100644 > --- a/dlls/setupapi/stubs.c > +++ b/dlls/setupapi/stubs.c > @@ -79,6 +79,28 @@ CONFIGRET WINAPI CM_Disconnect_Machine(HMACHINE handle) > } > > /*********************************************************************** > + * CM_Open_DevNode_Key (SETUPAPI.@) > + */ > +CONFIGRET WINAPI CM_Open_DevNode_Key( > + DEVINST dnDevInst, REGSAM access, ULONG ulHardwareProfile, ULONG /*REGDISPOSITION*/ disposition, > + PHKEY phkDevice, ULONG ulFlags) > +{ > + FIXME("0x%08x 0x%08x 0x%08x 0x%08x %p 0x%08x : stub\n", dnDevInst, access, ulHardwareProfile, > + disposition, phkDevice, ulFlags); > + return CR_SUCCESS; > +} > + > +/*********************************************************************** > + * CM_Get_Child (SETUPAPI.@) > + */ > +CONFIGRET WINAPI CM_Get_Child( > + PDEVINST pdnDevInst, DEVINST dnDevInst, ULONG ulFlags) > +{ > + FIXME("%p 0x%08x 0x%08x: stub\n", pdnDevInst, dnDevInst, ulFlags); > + return CR_SUCCESS; > +} > + Hi, Christoph. Please add prototypes to corresponding public header too. This will also fix REGDISPOSITION case - no reason not to have proper typedef for it. Also please run ./tools/make_specfiles to update dependent dlls.

1 0

Re: iphlpapi/tests: Add test for AllocateAndGetTcpExTableFromStack
by Sebastian Lackner 18 Jan '17

18 Jan '17

On 16.01.2017 17:55, André Hentschel wrote: > + ok( ret == ERROR_INVALID_PARAMETER || broken(ERROR_NOT_SUPPORTED) /* win2k */, "got %u\n", ret ); That is not how broken() works.

1 0

Re: regedit: Select a treeitem on right mouse click
by Nikolay Sivov 18 Jan '17

18 Jan '17

On 17.01.2017 12:47, Hugh McMaster wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=14606 > > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > programs/regedit/childwnd.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/programs/regedit/childwnd.c b/programs/regedit/childwnd.c > index 08eeec1..c9a35be 100644 > --- a/programs/regedit/childwnd.c > +++ b/programs/regedit/childwnd.c > @@ -411,8 +411,19 @@ LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lPa > g_pChildWnd->nFocusPanel = 0; > break; > case NM_RCLICK: { > - POINT pt; > + POINT pt, client_pt; > + TVHITTESTINFO ht; > + HTREEITEM treeitem; > + HWND hTree = ((NMHDR *)lParam)->hwndFrom; > + > GetCursorPos(&pt); > + client_pt = pt; > + ScreenToClient(hWnd, &client_pt); > + ht.pt = client_pt; > + treeitem = (HTREEITEM)SendMessageA(hTree, TVM_HITTEST, 0, (LPARAM)&ht); > + if (!treeitem) return 1; > + SendMessageW(hTree, TVM_SELECTITEM, TVGN_CARET, (LPARAM)treeitem); > + > TrackPopupMenu(GetSubMenu(hPopupMenus, PM_NEW), > TPM_RIGHTBUTTON, pt.x, pt.y, 0, hFrameWnd, NULL); > break; > This looks like a workaround, according to https://bugs.winehq.org/show_bug.cgi?id=14606 you should be able to TVM_GETNEXTITEM with TVGN_CARET, as selection should happen automatically.

2 1

Re: [PATCH v2] shlwapi: Fix the return value of SHAddDataBlock
by Marvin 17 Jan '17

17 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27838 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH] msvcrt: Implement nan
by Piotr Caban 17 Jan '17

17 Jan '17

On 01/14/17 00:11, Daniel Lehman wrote: > +double CDECL MSVCR120_nan(const char *tagp) > +{ > + /* Windows ignores input (MSDN) and Linux crashes on NULL */ > + const char *dummy = "NAN"; > +#ifdef HAVE_NAN > + return nan(dummy); > +#else > + return strtod(dummy, NULL); > +#endif > +} Why can't you just "return NAN;" here? Thanks, Piotr

2 1

Wine po issue page broken?
by Julian Rüger 17 Jan '17

17 Jan '17

Hi Francois and list, the po issue page http://fgouget.free.fr/wine-po/ has not updated for quite some time. It shows abb221fa81b60f53c14f6864bbfb9453455aeeeb as its latest commit id (that is the git commit id, right?), which is the release of 1.9.14, July 2016. First of all, did I miss something? I find that page quite useful, personally. What about the other translators? Seems there is not much interest...? http://source.winehq.org/transl/ is broken for me as well. It would be nice to hear from other translators, how much do you use these pages, would you like them to be fixed? If it's just me, please don't bother; otherwise it would be great if someone could look into it! All the best and a happy new year to everyone! Julian

6 9

Re: [PATCH 09/12] d3d9/tets: Remove redundant state setting calls.
by Marvin 17 Jan '17

17 Jan '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=27756 Your paranoid android. === w8 (32 bit visual) === visual.c:7986: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors).

3 2

Re: [2/2] iphlpapi: Use the new version of the IP_ADAPTER_UNICAST_ADDRESS structure (try 2)
by Hans Leidekker 16 Jan '17

16 Jan '17

On Fri, 2017-01-13 at 13:27 +0100, André Hentschel wrote: > diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c > index 54f7a37..223d980 100644 > --- a/dlls/iphlpapi/iphlpapi_main.c > +++ b/dlls/iphlpapi/iphlpapi_main.c > @@ -1065,6 +1065,13 @@ static ULONG adapterAddressesFromIndex(ULONG family, ULONG flags, IF_INDEX index > debugstr_ipv4(&sa->sin_addr.S_un.S_addr, addr_buf)); > fill_unicast_addr_data(aa, ua); > > + ua->OnLinkPrefixLength = 0; > + for (j = 0; j < sizeof(*v4masks) * 8; j++) > + { > + if (v4masks[i] & 1 << j) ua->OnLinkPrefixLength++; > + else break; > + } > + Please add a helper to compute prefix length instead of duplicating this code. This should probably wait until the code freeze is over.

3 6

Re: [PATCH] msvcrt: Trace clean_type_info_names_internal
by Piotr Caban 16 Jan '17

16 Jan '17

On 01/12/17 23:57, Jarkko Korpi wrote: > > Signed-off-by: Jarkko Korpi <jarkko_korpi(a)hotmail.com> > > There are only 2 fixmes in the file, all others are traces. And the other fixme is printed only once. This is printed quite often. There are only 2 FIXMEs in the file because other functions are implemented. I don't think this FIXME is very annoying taking into account that it's mainly printed when the application exits. Is it causing any issues for you? I prefer to have it printed unless it breaks application or makes logs unusable. Thanks, Piotr

1 0

Re: wined3d: Do not set DDCAPS_ALIGNBOUNDARYSRC caps for ddraw.
by Henri Verbeet 16 Jan '17

16 Jan '17

On 16 January 2017 at 15:07, Sebastian Lackner <sebastian(a)fds-team.de> wrote: > The ALIGNBOUNDARYSRC flag suddenly appeared in c8901d6f6253f6c97610eb1068ac4ff89758ed0a, > although dwAlignBoundarySrc is not initialized. > It should be set to 0 by ddraw, although I could certainly see that causing issues.

1 0