October 2017 - Wine-devel - list.winehq.org

Re: [PATCH] msvcrt: Implement _memicmp_l()
by Marvin 23 Oct '17

23 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33712 Your paranoid android. === wxppro (32 bit string) === 09f0:string: unhandled exception c0000005 at 77C4835C === w2003std (32 bit string) === 05f0:string: unhandled exception c0000005 at 77BD929C

1 0

Re: [PATCH] comctl32: Add RegisterClassNameW stub
by Nikolay Sivov 22 Oct '17

22 Oct '17

I don't think you need separate export to register classes. As a test create your own dll with such export, and see if it's called from test exe when some referenced class name is requested, as far as I remember this was only used in early versions.

2 3

Re: [PATCH 2/2] msi: Don't leak memory on failure.
by Nikolay Sivov 22 Oct '17

22 Oct '17

On 21.10.2017 12:50, Pierre Schweitzer wrote: > row = MSI_CreateRecord(1); > if (!row) > + { > + msi_free(buffer); > return NULL; > + } > MSI_RecordSetStringW(row, 1, buffer); > msi_free(buffer); > return row; You can replace this with: --- row = MSI_CreateRecord(1); if (row) MSI_RecordSetStringW(row, 1, buffer); msi_free(buffer); return row; ---

2 2

Re: [PATCH 5/5] msi: Add more feature action tests
by Marvin 20 Oct '17

20 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33689 Your paranoid android. === w2003std (32 bit package) === package.c:3763: Test failed: Expected ERROR_SUCCESS, got 1603 === w7u (32 bit package) === The task timed out

1 0

Re: [PATCH 4/5] msi: Add install test with no arguments on already installed product
by Marvin 20 Oct '17

20 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33688 Your paranoid android. === w2003std (32 bit package) === package.c:3710: Test failed: Expected ERROR_SUCCESS, got 1603

1 0

Re: [resend PATCH 4/4] gdiplus/metafile: Implement EmfPlusRecordTypeSetClipRegion playback
by Vincent Povirk 20 Oct '17

20 Oct '17

> + return GdipSetClipRegion(real_metafile->playback_graphics, real_metafile->objtable[region].u.region, > + (flags >> 8) & 0xf); This clip region needs to be intersected with the clip region from when the metafile began playing, similar to what we do for world transforms. Alternately, we could try to repurpose our existing code for handling gdi32 clipping and transforms. It just occurred to me that applications could tell the difference between those approaches, so we should probably have tests.

1 0

Re: [PATCH 12/14] mshtml: Don't use fire_event to dispatch script readystatechange event.
by Marvin 20 Oct '17

20 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33685 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [01/10] secur32: Implement AcquireCredentialsHandle for Kerberos.
by Dmitry Timoshkov 20 Oct '17

20 Oct '17

Hi Hans, Hans Leidekker <hans(a)codeweavers.com> wrote: > This series is based on a patch by Rob Shearman. Since during some time I was involved in the project that aims adding Kerberos support to Wine (it's still not fully finished yet, that's why we haven't published it yet) I have some comments on your approach. Our main target for testing was KerberosAuthenticationTester.exe from http://blog.michelbarneveld.nl/michel/archive/2009/12/05/kerberos-authentic… (the author doesn't provide the sources, but it's pretty trivial to get full C# source for the whole application, so understanding and debugging is not an issue). Another good test is klist.exe from (older) PSDK. Our team also decided to use Rob's patch as a base for SSP, and in addition we've also implemented Kerberos ticket management API. Main difference between your and our approaches is the architecture. We decided to add support for Kerberos using an approximation to what Windows has in place: implement Authentication Package (AP) manager in secur32 (LSA APIs) which dinamically loads APs listed in the registry. All the real code (both SSP and AP) is implemented in kerberos.dll, which dynamically loads libkrb5.so and gssapi_krb5.so. Did you consider moving the Kerberos support into separate kerberos AP/SSP dll? -- Dmitry.

2 16

Re: [2/3] ole32/tests: Add a test for IOleCache storage contents created by IPersistStorage_Save(). (v2)
by Huw Davies 20 Oct '17

20 Oct '17

On Fri, Oct 20, 2017 at 09:58:57AM +0800, Dmitry Timoshkov wrote: > v2: Call IPersistStorage_Save() directly instead of OleSave(). > > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ole32/tests/ole2.c | 402 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 402 insertions(+) > > diff --git a/dlls/ole32/tests/ole2.c b/dlls/ole32/tests/ole2.c > index 0773bbf189..9ed19f1f9b 100644 > --- a/dlls/ole32/tests/ole2.c > +++ b/dlls/ole32/tests/ole2.c > +static void check_storage_contents(IStorage *stg, const struct storage_def *stg_def, > + int *enumerated_streams, int *matched_streams) > +{ > + HRESULT hr; > + IEnumSTATSTG *enumstg; > + IStream *stream; > + STATSTG stat; > + int i, seen_stream[MAX_STREAM] = { 0 }; > + > + if (winetest_debug > 1) > + trace("check_storage_contents:\n=============================================\n"); > + > + *enumerated_streams = 0; > + *matched_streams = 0; > + > + hr = IStorage_Stat(stg, &stat, STATFLAG_NONAME); > + ok(hr == S_OK, "unexpected %#x\n", hr); > +todo_wine_if(!IsEqualCLSID(stg_def->clsid, &stat.clsid)) > + ok(IsEqualCLSID(stg_def->clsid, &stat.clsid), "expected %s, got %s\n", > + wine_dbgstr_guid(stg_def->clsid), wine_dbgstr_guid(&stat.clsid)); > + > + hr = IStorage_EnumElements(stg, 0, NULL, 0, &enumstg); > + ok(hr == S_OK, "unexpected %#x\n", hr); > + > + for (;;) > + { > + ULONG bytes; > + int clipformat = -1; > + PresentationDataHeader header; > + char name[32]; > + BYTE data[256]; > + > + memset(&header, 0, sizeof(header)); > + > + hr = IEnumSTATSTG_Next(enumstg, 1, &stat, NULL); > + if(hr == S_FALSE) break; > + ok(hr == S_OK, "unexpected %#x\n", hr); > + > + if (winetest_debug > 1) > + trace("name %s, type %u, size %d, clsid %s\n", > + wine_dbgstr_w(stat.pwcsName), stat.type, stat.cbSize.u.LowPart, wine_dbgstr_guid(&stat.clsid)); > + > + ok(stat.type == STGTY_STREAM, "unexpected %#x\n", stat.type); > + > + WideCharToMultiByte(CP_ACP, 0, stat.pwcsName, -1, name, sizeof(name), NULL, NULL); > + > + hr = IStorage_OpenStream(stg, stat.pwcsName, NULL, STGM_READ | STGM_SHARE_EXCLUSIVE, 0, &stream); > + ok(hr == S_OK, "unexpected %#x\n", hr); > + > + if (!memcmp(name, "\2OlePres", 7)) > + { > + clipformat = read_clipformat(stream); > + > + hr = IStream_Read(stream, &header, sizeof(header), &bytes); > + ok(hr == S_OK, "unexpected %#x\n", hr); > + ok(bytes >= 24, "read %u bytes, expected to read %u bytes\n", bytes, sizeof(header)); > + You're using sizeof as an argument to a fprintf-like function which, for example, gives a warning on macOS. ole2.c:3532:82: warning: format specifies type 'unsigned int' but the argument has type 'unsigned long' [-Wformat] Also, while you're at it, couldn't that '24' be sizeof(header) instead? Huw.

2 2

Re: [3/3] ole32: Remove an optimization from DataCache_Save() that copies whole original storage.
by Marvin 20 Oct '17

20 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33675 Your paranoid android. === wxppro (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w2003std (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === wvistau64 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w2008s64 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w7u (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w7pro64 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w8 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w864 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w1064 (32 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === wvistau64 (64 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w2008s64 (64 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w7pro64 (64 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w864 (64 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes === w1064 (64 bit ole2) === ole2.c:3529: Test failed: read 24 bytes ole2.c:3529: Test failed: read 24 bytes

1 0