October 2017 - Wine-devel - list.winehq.org

Re: [2/3] ole32/tests: Add a test for IOleCache storage contents created by IPersistStorage_Save(). (v3)
by Marvin 20 Oct '17

20 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33674 Your paranoid android. === wxppro (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w2003std (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === wvistau64 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w2008s64 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w7u (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w7pro64 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w8 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w864 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w1064 (32 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === wvistau64 (64 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w2008s64 (64 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w7pro64 (64 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w864 (64 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes === w1064 (64 bit ole2) === ole2.c:3532: Test failed: read 24 bytes ole2.c:3532: Test failed: read 24 bytes

1 0

Re: [PATCH 1/4] gdiplus/metafile: Partially implement EmfPlusPen support for playback
by Vincent Povirk 19 Oct '17

19 Oct '17

Some of the size calculations don't seem to match. + if (pendata->PenDataFlags & PenDataTransform) + offset += sizeof(GpMatrix); + if (pendata->PenDataFlags & PenDataTransform) + { + FIXME("PenDataTransform is not supported.\n"); + offset += sizeof(EmfPlusTransformMatrix); + } + if (pendata->PenDataFlags & PenDataDashedLine) + { + EmfPlusDashedLineData *dashedline = (EmfPlusDashedLineData *)((BYTE *)data + offset); + + offset += FIELD_OFFSET(EmfPlusDashedLineData, data); + if (data_size <= offset) + return InvalidParameter; + + offset += dashedline->DashedLineDataSize; + } + if (pendata->PenDataFlags & PenDataDashedLine) + { + EmfPlusDashedLineData *dashedline = (EmfPlusDashedLineData *)((BYTE *)pendata + offset); + FIXME("PenDataDashedLine is not supported.\n"); + offset += dashedline->DashedLineDataSize; + }

2 1

Font rendering issues after some update.
by John Found 19 Oct '17

19 Oct '17

After an update of the system, WINE stopped to render the fonts properly. Regardless of the registry or other system settings, following behaviour is observed: 1. The antialiasing is only grayscale. 2. The antialiasing is only if the font size is bigger than 14px. Smaller fonts are not smoothed at all. 3. The hinting seems to be switched off. At least for some fonts. The bitmap fonts or the fonts designed to not use smoothing (for example FixedSys Excelsior) look like usual. All this seems to not depend on any settings of the system configuration or WINE registry. Thinking that the problem is simply broken WINE/fontconfig/freetype I tried all possible configuration tweaks from Internet. Without any effect. I mean, the font rendering never changes even by pixel. I have second system, that worked fine, but after the today update (I am using it very rarely) the problem appeared as well. In the same time, all other Linux applications work normally, I can change the rendering options from the usual GUI applets. I can't say when exactly the problem appeared for the first time. But on this second system, the updated versions are: wine: from 2.4-1 to 2.18-1 fontconfig: from 2.12.1-4 to 2.12.6-1 freetype: from 2.7.1-1 to 2.8.1-1 Any ideas how to fix the problem? Or at least how to continue the research. -- http://fresh.flatassembler.net http://asm32.info John Found <johnfound(a)asm32.info>

2 3

Re: [PATCH 3/9] mshtml: Set current event target in fire_event_obj.
by Marvin 19 Oct '17

19 Oct '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33648 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath

1 0

Re: [PATCH 2/2] user32: Implement IDI_SHIELD.
by Alexandre Julliard 19 Oct '17

19 Oct '17

Alex Henrie <alexhenrie24(a)gmail.com> writes: > From 28d5fcc630dcf3ee9b559f05a9a0fb5d6c3e06bd Mon Sep 17 00:00:00 2001 > From: Alex Henrie <alexhenrie24(a)gmail.com> > Date: Thu, 19 Oct 2017 01:30:55 -0600 > Subject: [PATCH 2/2] user32: Implement IDI_SHIELD. > > Fixes https://bugs.winehq.org/show_bug.cgi?id=43770 > > Steps to create these icons: Thanks! While you are at it, how about adding some colors to it? On a gray background it's going to be pretty much invisible. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/4] d3d9/tests: Windows 10 17.09 added an undocumented query type (v2).
by Henri Verbeet 19 Oct '17

19 Oct '17

On 19 October 2017 at 10:09, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > @@ -5552,7 +5552,9 @@ static void test_query_support(void) > > for (i = 0; i < 40; ++i) > { > - if (D3DQUERYTYPE_VCACHE <= i && i <= D3DQUERYTYPE_MEMORYPRESSURE) > + /* Windows 10 17.09 (build 16299.19) added an undocumented query with an enum value of 0x16 (=22). > + * It returns D3D_OK when asking for support and E_FAIL when trying to actually create it. */ > + if (D3DQUERYTYPE_VCACHE <= i && i <= D3DQUERYTYPE_MEMORYPRESSURE || i == 0x16) This introduces a warning: device.c: In function ‘test_query_support’: device.c:5566:38: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] if (D3DQUERYTYPE_VCACHE <= i && i <= D3DQUERYTYPE_MEMORYPRESSURE || i == 0x16)

1 0

Re: [PATCH 2/2] msi: Remove full reinstall special handling
by Hans Leidekker 19 Oct '17

19 Oct '17

On Wed, 2017-10-18 at 17:25 +0200, Piotr Caban wrote: > This patch fixes "change office 2010 serial key" functionality. This code was introduced to fix the Enterprise Architect installer after I broke it with e2900c23c7f0b143078da780c9a0ff19a895bf45. (see https://bugs.winehq.org/show_bug.cgi?id=32387) Your patch breaks this installer again because the condition for entering the maintenance dialog tests the Preselected property. Given your test it seems that we shouldn't set REINSTALL at all (since it causes Preselected to be set) or that we should set it only after evaluating command line overrides.

2 1

Re: [3/3] ole32: Use a shortcut in DataCache_Save only if fSameAsLoad set to TRUE.
by Huw Davies 19 Oct '17

19 Oct '17

On Wed, Sep 20, 2017 at 02:54:21PM +0300, Dmitry Timoshkov wrote: > This looks like a typo, and this patch makes saving data in a pretty complex > application work. > > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ole32/datacache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/ole32/datacache.c b/dlls/ole32/datacache.c > index 4e684b4189..c3383176f8 100644 > --- a/dlls/ole32/datacache.c > +++ b/dlls/ole32/datacache.c > @@ -1663,7 +1663,7 @@ static HRESULT WINAPI DataCache_Save( > } > > /* this is a shortcut if nothing changed */ > - if (!dirty && !fSameAsLoad && This->presentationStorage) > + if (!dirty && fSameAsLoad && This->presentationStorage) > { > return IStorage_CopyTo(This->presentationStorage, 0, NULL, NULL, pStg); > } No, this isn't a typo. The idea is to copy the loaded storage to a fresh storage that is passed when fSameAsLoad is FALSE. I'm aware that there are issues related to the storage handling in both the cache and the default handler. That's on my list of things to look into, but feel free to investigate further. Huw.

2 7

Re: [1/2] ole32/tests: Add a test for OleSave() called for a IOleCache storage.
by Huw Davies 19 Oct '17

19 Oct '17

On Thu, Oct 19, 2017 at 01:06:50PM +0800, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ole32/tests/ole2.c | 214 +++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 202 insertions(+), 12 deletions(-) This looks ok, but could you please call IPersistStorage_Save() directly rather than using the OleSave() helper? Also fix the function name to reflect that. Thanks, Huw.

2 2

Re: [2/2] ole32/tests: Add a test for IOleCache storage contents created by OleSave().
by Huw Davies 19 Oct '17

19 Oct '17

On Thu, Oct 19, 2017 at 01:07:01PM +0800, Dmitry Timoshkov wrote: > Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> > --- > dlls/ole32/tests/ole2.c | 372 ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 372 insertions(+) > Again, please use IPersistStorage_Save() in this one. Huw.

1 0