November 2017 - Wine-devel - list.winehq.org

Re: [PATCH 2/3] wined3d: Show the device window when changing fullscreen resolutions (v2).
by Henri Verbeet 07 Nov '17

07 Nov '17

On 6 November 2017 at 21:33, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c > index e23e99b67b..a26185ae4d 100644 > --- a/dlls/wined3d/swapchain.c > +++ b/dlls/wined3d/swapchain.c > @@ -1429,6 +1429,7 @@ HRESULT CDECL wined3d_swapchain_set_fullscreen(struct wined3d_swapchain *swapcha > device->filter_messages = TRUE; > > MoveWindow(swapchain->device_window, 0, 0, width, height, TRUE); > + ShowWindow(swapchain->device_window, SW_SHOWNORMAL); > This breaks the ddraw tests: ddraw1.c:2683: Test failed: Expected (0,0)-(2880,1620), got (0,0)-(2048,1536). ddraw1.c:2690: Test failed: Expected (0,0)-(2880,1620), got (0,0)-(2048,1536). ddraw1.c:2716: Test failed: Expected (0,0)-(2880,1620), got (0,0)-(2048,1536). ddraw1.c:2739: Test failed: Expected (0,0)-(2880,1620), got (0,0)-(2048,1536). ddraw1.c:2768: Test failed: Expected (0,0)-(2880,1620), got (0,0)-(2048,1536). ddraw1.c:2794: Test failed: Expected (0,0)-(2880,1620), got (0,0)-(2048,1536). ddraw1.c:2814: Test failed: Expected (0,0)-(2880,1620), got (0,0)-(2048,1536). ddraw1.c:2850: Test failed: Expected (0,0)-(2880,1620), got (0,0)-(2048,1536).

1 0

Re: [PATCH 2/9] winemine: Update faces.bmp with one from ReactOS project
by Alexandre Julliard 07 Nov '17

07 Nov '17

"Yandex Mail" <and-semakin(a)ya.ru> writes: > From 4cef6694e5153202a119c01a2d88ef617543d7cc Mon Sep 17 00:00:00 2001 > From: Andrey Semakin <and-semakin(a)ya.ru> > Date: Mon, 6 Nov 2017 13:08:53 +0500 > Subject: [PATCH 2/9] winemine: Update faces.bmp with one from ReactOS project > > Signed-off-by: Andrey Semakin <and-semakin(a)ya.ru> > --- > programs/winemine/faces.bmp | Bin 1558 -> 1558 bytes > 1 file changed, 0 insertions(+), 0 deletions(-) It would be better to redesign these using SVG files, so we can make them scale properly for high-DPI. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v2 PATCH] msvcrt: Implement _memicmp_l()
by Marvin 07 Nov '17

07 Nov '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33995 Your paranoid android. === wvistau64 (32 bit string) === string.c:178: Test failed: errno = 0, expected EINVAL string.c:185: Test failed: errno = 0, expected EINVAL string.c:192: Test failed: errno = 0, expected EINVAL string.c:221: Test failed: errno = 0, expected EINVAL string.c:228: Test failed: errno = 0, expected EINVAL string.c:235: Test failed: errno = 0, expected EINVAL === w7u (32 bit string) === string.c:178: Test failed: errno = 0, expected EINVAL string.c:185: Test failed: errno = 0, expected EINVAL string.c:192: Test failed: errno = 0, expected EINVAL string.c:221: Test failed: errno = 0, expected EINVAL string.c:228: Test failed: errno = 0, expected EINVAL string.c:235: Test failed: errno = 0, expected EINVAL === w1064 (32 bit string) === string.c:178: Test failed: errno = 0, expected EINVAL string.c:185: Test failed: errno = 0, expected EINVAL string.c:192: Test failed: errno = 0, expected EINVAL string.c:221: Test failed: errno = 0, expected EINVAL string.c:228: Test failed: errno = 0, expected EINVAL string.c:235: Test failed: errno = 0, expected EINVAL === wvistau64 (64 bit string) === string.c:178: Test failed: errno = 0, expected EINVAL string.c:185: Test failed: errno = 0, expected EINVAL string.c:192: Test failed: errno = 0, expected EINVAL string.c:221: Test failed: errno = 0, expected EINVAL string.c:228: Test failed: errno = 0, expected EINVAL string.c:235: Test failed: errno = 0, expected EINVAL === w1064 (64 bit string) === string.c:178: Test failed: errno = 0, expected EINVAL string.c:185: Test failed: errno = 0, expected EINVAL string.c:192: Test failed: errno = 0, expected EINVAL string.c:221: Test failed: errno = 0, expected EINVAL string.c:228: Test failed: errno = 0, expected EINVAL string.c:235: Test failed: errno = 0, expected EINVAL

1 0

Re: [v2 PATCH 1/3] gdiplus/metafile: Support linear gradient brushes in playback
by Dmitry Timoshkov 07 Nov '17

07 Nov '17

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > + status = GdipCreateLineBrush(&startpoint, &endpoint, data->BrushData.lineargradient.StartColor, > + data->BrushData.lineargradient.EndColor, data->BrushData.lineargradient.WrapMode, &gradient); > + if (status == Ok && transform) > + status = GdipSetLineTransform(gradient, (const GpMatrix *)transform); Result of the above calls is ignored. > + if (brushflags & BrushDataPresetColors) > + status = GdipSetLinePresetBlend(gradient, (ARGB *)(record_data + offset + position_count * sizeof(REAL)), > + (REAL *)(record_data + offset), position_count); > + else if (brushflags & BrushDataBlendFactorsH) > + status = GdipSetLineBlend(gradient, (REAL *)(record_data + offset + position_count * sizeof(REAL)), > + (REAL *)(record_data + offset), position_count); > + > + if (brushflags & BrushDataIsGammaCorrected) > + FIXME("BrushDataIsGammaCorrected is not handled.\n"); > + > + if (status == Ok) > + *brush = (GpBrush *)gradient; > + else > + GdipDeleteBrush((GpBrush *)gradient); > + > + break; > + } -- Dmitry.

1 0

Re: [PATCH 3/4] oleaut32: Implement asm proxys for x86_64.
by Alexandre Julliard 07 Nov '17

07 Nov '17

Marcus Meissner <marcus(a)jet.franken.de> writes: > From: Sebastian Lackner <sebastian(a)fds-team.de> > > Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/oleaut32/tmarshal.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 52 insertions(+), 2 deletions(-) The existing code is ugly, and instead of trying to retrofit 64-bit support into it, I'd suggest looking into reusing the rpcrt4 routines which already handle pretty much all of this in a more correct way. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: [PATCH 1/9] vulkan: Add initial Wine vulkan header.
by Sebastian Lackner 07 Nov '17

07 Nov '17

On 06.11.2017 09:08, Roderick Colenbrander wrote: > This file is directly generated from Vulkan's vk.xml. For now it contains Core > Vulkan types and functions. Will be extended with extensions when we support them. > Note there are 4 lines of C++ style comments, but these directly come from the spec > and appear in the regular headers as well. > > Signed-off-by: Roderick Colenbrander <thunderbird2k(a)gmail.com> > --- > include/wine/vulkan.h | 2367 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 2367 insertions(+) > create mode 100644 include/wine/vulkan.h I'm not sure if you are already aware that the struct sizes/alignments do not match between Linux and Windows. There are many structs which have to be defined twice and converted on-the-fly to be compatible with 32-bit.

2 3

Re: [PATCH v4 2/2] quartz/tests: Add test AVI and MPG files.
by Marvin 07 Nov '17

07 Nov '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33983 Your paranoid android. === wxppro (32 bit avisplitter) === avisplitter.c:527: Test failed: The thread count should be 3 not 4 === w2003std (32 bit avisplitter) === avisplitter.c:527: Test failed: The thread count should be 4 not 5 === wvistau64 (32 bit avisplitter) === avisplitter.c:527: Test failed: The thread count should be 3 not 4 === w2008s64 (32 bit avisplitter) === avisplitter.c:475: Test failed: Could not create null renderer: 80040154 === w7pro64 (32 bit avisplitter) === avisplitter.c:527: Test failed: The thread count should be 3 not 4 === w1064 (32 bit avisplitter) === avisplitter.c:527: Test failed: The thread count should be 5 not 6 === wvistau64 (64 bit avisplitter) === avisplitter.c:527: Test failed: The thread count should be 3 not 4 === w2008s64 (64 bit avisplitter) === avisplitter.c:475: Test failed: Could not create null renderer: 80040154 === w7pro64 (64 bit avisplitter) === avisplitter.c:527: Test failed: The thread count should be 3 not 4 === w864 (64 bit avisplitter) === avisplitter.c:527: Test failed: The thread count should be 3 not 4 === w1064 (64 bit avisplitter) === avisplitter.c:527: Test failed: The thread count should be 5 not 6

1 0

Re: [PATCH v3 2/2] quartz/tests: Add test AVI and MPG files.
by Marvin 07 Nov '17

07 Nov '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33980 Your paranoid android. === wxppro (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w2003std (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 4 not 5 === wvistau64 (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w2008s64 (32 bit avisplitter) === avisplitter.c:473: Test failed: Could not create null renderer: 80040154 === w7pro64 (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w864 (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w1064 (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 5 not 7 === wvistau64 (64 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w2008s64 (64 bit avisplitter) === avisplitter.c:473: Test failed: Could not create null renderer: 80040154 === w7pro64 (64 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w864 (64 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w1064 (64 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 5 not 6

1 0

Re: [PATCH 2/2] quartz/tests: Add test AVI and MPG files.
by Marvin 07 Nov '17

07 Nov '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33978 Your paranoid android. === wxppro (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w2003std (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 4 not 5 === wvistau64 (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w2008s64 (32 bit avisplitter) === avisplitter.c:473: Test failed: Could not create null renderer: 80040154 === w7pro64 (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w864 (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w1064 (32 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 5 not 7 === wvistau64 (64 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w2008s64 (64 bit avisplitter) === avisplitter.c:473: Test failed: Could not create null renderer: 80040154 === w7pro64 (64 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w864 (64 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 3 not 4 === w1064 (64 bit avisplitter) === avisplitter.c:525: Test failed: The thread count should be 5 not 6

1 0

Re: [PATCH 2/2] quartz/tests: Add test AVI and MPG files.
by Dmitry Timoshkov 07 Nov '17

07 Nov '17

Zebediah Figura <z.figura12(a)gmail.com> wrote: > --- a/dlls/quartz/tests/avisplitter.c > +++ b/dlls/quartz/tests/avisplitter.c ... > + WCHAR *filename = load_resource(avifile); ... > if (file == INVALID_HANDLE_VALUE) > { > - skip("Could not read test file \"%s\", skipping test\n", afile); > + skip("Could not read test file \"%s\", skipping test\n", wine_dbgstr_w(filename)); > return; > } etc. > --- a/dlls/quartz/tests/filtergraph.c > +++ b/dlls/quartz/tests/filtergraph.c ... > + WCHAR *filename = load_resource(file); ... > + hr = IGraphBuilder_RenderFile(pgraph, filename, NULL); > + if (hr == VFW_E_CANNOT_RENDER) > + skip("%s: codec not supported; skipping test\n", wine_dbgstr_w(file)); > + else > + { > + ok(hr == S_OK || hr == VFW_S_AUDIO_NOT_RENDERED, "RenderFile failed: %x\n", hr); > + rungraph(); > + } > > releasefiltergraph(); > > /* check reference leaks */ > - h = CreateFileW(file, GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, NULL); > + h = CreateFileW(filename, GENERIC_READ, 0, NULL, OPEN_EXISTING, 0, NULL); > ok(h != INVALID_HANDLE_VALUE, "CreateFile failed: err=%d\n", GetLastError()); > CloseHandle(h); > } It seems that new tests leave the temporary created files behind. -- Dmitry.

2 2