November 2017 - Wine-devel - list.winehq.org

Re: [PATCH] ole32: handle length=0 in save datacache
by Dmitry Timoshkov 05 Nov '17

05 Nov '17

Marcus Meissner <marcus(a)jet.franken.de> wrote: > The ole2 test crashes for me, reason is that length is 0 > and we use length-1 for accessing whats returned. ... > + if (!length) > + return DV_E_CLIPFORMAT; The test intentionally creates the storage streams with length field set to 0, and as the tests show this is not an error. So the fix should be probably different. -- Dmitry.

2 1

Re: [PATCH] comctl32/taskdialog: Implement nDefaultButton and add tests
by Nikolay Sivov 05 Nov '17

05 Nov '17

On 04.11.2017 18:22, Fabian Maurer wrote: > Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> > --- > dlls/comctl32/taskdialog.c | 21 +++++-- > dlls/comctl32/tests/taskdialog.c | 115 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 130 insertions(+), 6 deletions(-) > > diff --git a/dlls/comctl32/taskdialog.c b/dlls/comctl32/taskdialog.c > index 5c4af2ab03..4f80311a61 100644 > --- a/dlls/comctl32/taskdialog.c > +++ b/dlls/comctl32/taskdialog.c > @@ -151,7 +151,7 @@ static void taskdialog_get_text_extent(const struct taskdialog_template_desc *de > } > > static unsigned int taskdialog_add_control(struct taskdialog_template_desc *desc, WORD id, const WCHAR *class, > - HINSTANCE hInstance, const WCHAR *text, short x, short y, short cx, short cy) > + HINSTANCE hInstance, const WCHAR *text, DWORD style, short x, short y, short cx, short cy) > { > struct taskdialog_control *control = Alloc(sizeof(*control)); > unsigned int size, class_size, text_size; > @@ -178,7 +178,7 @@ static unsigned int taskdialog_add_control(struct taskdialog_template_desc *desc > control->template = template = Alloc(size); > control->template_size = size; > > - template->style = WS_VISIBLE; > + template->style = WS_VISIBLE | style; > template->dwExtendedStyle = 0; > template->x = x; > template->y = y; > @@ -206,7 +206,7 @@ static unsigned int taskdialog_add_static_label(struct taskdialog_template_desc > taskdialog_get_text_extent(desc, str, TRUE, &sz); > > desc->dialog_height += DIALOG_SPACING; > - size = taskdialog_add_control(desc, id, WC_STATICW, desc->taskconfig->hInstance, str, DIALOG_SPACING, > + size = taskdialog_add_control(desc, id, WC_STATICW, desc->taskconfig->hInstance, str, 0, DIALOG_SPACING, > desc->dialog_height, sz.cx, sz.cy); > desc->dialog_height += sz.cy + DIALOG_SPACING; > return size; > @@ -268,6 +268,7 @@ static unsigned int taskdialog_add_buttons(struct taskdialog_template_desc *desc > unsigned int location_x, *line_widths, alignment = ~0u; > const TASKDIALOGCONFIG *taskconfig = desc->taskconfig; > struct taskdialog_button_desc *buttons; > + int default_button; > > /* Allocate enough memory for the custom and the default buttons. Maximum 6 default buttons possible. */ > buttons_size = 6; > @@ -340,18 +341,26 @@ static unsigned int taskdialog_add_buttons(struct taskdialog_template_desc *desc > alignment = new_alignment; > } > > + /* Check if the default button is actually valid, if no default to the first created button */ > + default_button = buttons[0].id; > + for (i = 0; i < count; i++) > + if (buttons[i].id == taskconfig->nDefaultButton) > + default_button = taskconfig->nDefaultButton; > + We already iterate over custom buttons and check every common button flag before this point, so it shouldn't be necessary to have another loop. > @@ -583,7 +592,7 @@ HRESULT WINAPI TaskDialogIndirect(const TASKDIALOGCONFIG *taskconfig, int *butto > Free(template); > > if (button) *button = ret; > - if (radio_button) *radio_button = taskconfig->nDefaultButton; > + if (radio_button) *radio_button = FALSE; > if (verification_flag_checked) *verification_flag_checked = TRUE; > Same as with verification flag, we don't implement radio buttons currently so it's better to leave it as is to avoid possible regressions until we add support for them. Also you're supposed to return button id, not binary flags. > > +static TASKDIALOG_BUTTON* buttons_make(void) > +{ > + static const WCHAR str_format[] = {'%','0','2','d',0}; > + static TASKDIALOG_BUTTON buttons[TEST_NUM_BUTTONS]; > + static WCHAR titles[TEST_NUM_BUTTONS * 3]; /* Each button has two digits as title, plus null-terminator */ > + int i; > + > + for (i = 0; i < TEST_NUM_BUTTONS; i++) > + { > + WCHAR *text = &titles[i * 3]; > + wsprintfW(text, str_format, i); > + > + buttons[i].pszButtonText = text; > + buttons[i].nButtonID = ID_START_BUTTON + i; > + } > + return buttons; > +} > + Please merge this to test function.

2 2

Unhandled exception
by Ran Shalit 05 Nov '17

05 Nov '17

Hello, I have an issue trying to run application with wine, in which I get the below exception. It first (before getting this exception) said that mfc100u.dll is required, so I had to download and put it in the same folder as .exe, but then trying to run the application, I got this exception. I use wine 1.8. Thank you for any suggestion. user(a)user-VirtualBox:~/2.1.2$ wine record_channels.exe system.reg is not a valid registry file userdef.reg is not a valid registry file user.reg is not a valid registry file err:ole:marshal_object couldn't get IPSFactory buffer for interface {00000131-0000-0000-c000-000000000046} err:ole:marshal_object couldn't get IPSFactory buffer for interface {6d5140c1-7436-11ce-8034-00aa006009fa} err:ole:StdMarshalImpl_MarshalInterface Failed to create ifstub, hres=0x80004002 err:ole:CoMarshalInterface Failed to marshal the interface {6d5140c1-7436-11ce-8034-00aa006009fa}, 80004002 err:ole:get_local_server_stream Failed: 80004002 fixme:thread:GetThreadPreferredUILanguages 52, 0x32f9d8, 0x32fc54 0x32f9e0 fixme:heap:RtlSetHeapInformation (nil) 1 (nil) 0 stub fixme:thread:GetThreadPreferredUILanguages 52, 0x32f680, 0x32f8fc 0x32f688 wine: Unhandled exception 0xc06d007e in thread 12 at address 0x7b83c3ae (thread 0012), starting debugger... Unhandled exception: 0xc06d007e in 32-bit code (0x7b83c3ae). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:7b83c3ae ESP:0086dfc4 EBP:0086e038 EFLAGS:00000287( - -- I S - -P-C) EAX:7b827a69 EBX:7b8c0000 ECX:0086e060 EDX:0086dfe4 ESI:c06d007e EDI:00000000 Stack dump: 0x0086dfc4: 0086e0b0 00000004 7b85ac31 c06d007e 0x0086dfd4: 00000000 00000000 7b83c3ae 00000001 0x0086dfe4: 0086e060 00000000 00000000 4d430003 0x0086dff4: 7b85abfc 0086e020 7b8c0000 0043db3c 0x0086e004: 00000000 0086e038 7b85ac9d 00000000 0x0086e014: 00000000 0086e038 7b85ac9d 0042d7b0 Backtrace: =>0 0x7b83c3ae in kernel32 (+0x2c3ae) (0x0086e038) 1 0x00411033 in record_channels (+0x11032) (0x0086e0a4) 2 0x00410e0e in record_channels (+0x10e0d) (0x0086e600) 3 0x00427e10 in record_channels (+0x27e0f) (0x0086e7a0) 4 0x004285f6 in record_channels (+0x285f5) (0x0086e9cc) 5 0x00428e09 in record_channels (+0x28e08) (0x0086e9d8) 6 0x7bc84470 call_thread_func_wrapper+0xb() in ntdll (0x0086e9e8) 7 0x7bc8763d call_thread_func+0x7c() in ntdll (0x0086eab8) 8 0x7bc8444e RtlRaiseException+0x21() in ntdll (0x0086ead8) 9 0x7bc8fe69 in ntdll (+0x7fe68) (0x0086f358) 10 0xb74fff70 start_thread+0xcf() in libpthread.so.0 (0x0086f428) 11 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 12 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 13 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 14 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 15 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 16 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 17 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 18 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 19 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 20 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 21 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 22 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 23 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 24 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 25 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 26 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 27 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 28 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 29 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 30 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 31 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 32 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 33 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 34 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 35 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 36 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 37 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 38 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 39 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 40 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 41 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 42 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 43 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 44 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 45 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 46 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 47 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 48 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 49 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 50 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 51 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 52 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 53 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 54 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 55 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 56 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 57 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 58 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 59 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 60 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 61 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 62 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 63 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 64 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 65 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 66 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 67 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 68 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 69 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 70 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 71 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 72 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 73 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 74 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 75 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 76 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 77 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 78 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 79 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 80 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 81 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 82 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 83 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 84 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 85 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 86 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 87 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 88 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 89 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 90 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 91 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 92 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 93 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 94 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 95 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 96 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 97 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 98 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 99 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 100 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 101 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 102 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 103 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 104 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 105 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 106 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 107 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 108 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 109 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 110 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 111 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 112 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 113 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 114 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 115 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 116 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 117 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 118 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 119 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 120 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 121 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 122 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 123 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 124 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 125 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 126 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 127 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 128 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 129 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 130 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 131 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 132 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 133 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 134 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 135 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 136 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 137 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 138 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 139 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 140 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 141 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 142 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 143 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 144 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 145 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 146 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 147 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 148 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 149 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 150 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 151 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 152 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 153 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 154 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 155 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 156 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 157 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 158 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 159 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 160 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 161 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 162 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 163 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 164 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 165 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 166 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 167 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 168 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 169 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 170 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 171 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 172 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 173 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 174 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 175 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 176 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 177 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 178 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 179 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 180 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 181 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 182 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 183 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 184 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 185 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 186 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 187 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 188 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 189 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 190 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 191 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 192 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 193 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 194 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 195 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 196 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 197 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 198 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 199 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 200 0xb743050e __clone+0x5d() in libc.so.6 (0x00000000) 0x7b83c3ae: subl $4,%esp Modules: Module Address Debug info Name (79 modules) PE 400000- 44d000 Export record_channels PE 10000000-1000a000 Deferred recordings_channels_dll PE 785f0000-78a22000 Deferred mfc100u ELF 7b800000-7ba6a000 Dwarf kernel32<elf> \-PE 7b810000-7ba6a000 \ kernel32 ELF 7bc00000-7bcf3000 Dwarf ntdll<elf> \-PE 7bc10000-7bcf3000 \ ntdll ELF 7bf00000-7bf04000 Deferred <wine-loader> ELF 7dacc000-7db10000 Deferred usp10<elf> \-PE 7dad0000-7db10000 \ usp10 ELF 7db9a000-7dbd3000 Deferred uxtheme<elf> \-PE 7dba0000-7dbd3000 \ uxtheme ELF 7dbd3000-7dbd9000 Deferred libxfixes.so.3 ELF 7dbd9000-7dbe4000 Deferred libxcursor.so.1 ELF 7dbe4000-7dbf4000 Deferred libxi.so.6 ELF 7dbf4000-7dbf8000 Deferred libxcomposite.so.1 ELF 7dbf8000-7dc03000 Deferred libxrandr.so.2 ELF 7dc03000-7dc0e000 Deferred libxrender.so.1 ELF 7dc0e000-7dc14000 Deferred libxxf86vm.so.1 ELF 7dc14000-7dc18000 Deferred libxinerama.so.1 ELF 7dc18000-7dc1f000 Deferred libxdmcp.so.6 ELF 7dc1f000-7dc23000 Deferred libxau.so.6 ELF 7dc23000-7dc45000 Deferred libxcb.so.1 ELF 7dc45000-7dd79000 Deferred libx11.so.6 ELF 7dd79000-7dd8c000 Deferred libxext.so.6 ELF 7dd90000-7dda6000 Deferred dwmapi<elf> \-PE 7dda0000-7dda6000 \ dwmapi ELF 7dda8000-7de3c000 Deferred winex11<elf> \-PE 7ddb0000-7de3c000 \ winex11 ELF 7de3c000-7de61000 Deferred imm32<elf> \-PE 7de40000-7de61000 \ imm32 ELF 7dffa000-7e023000 Deferred libexpat.so.1 ELF 7e023000-7e05e000 Deferred libfontconfig.so.1 ELF 7e05e000-7e086000 Deferred libpng12.so.0 ELF 7e086000-7e0a0000 Deferred libz.so.1 ELF 7e0a0000-7e140000 Deferred libfreetype.so.6 ELF 7e140000-7e162000 Deferred libtinfo.so.5 ELF 7e162000-7e187000 Deferred libncurses.so.5 ELF 7e1a3000-7e1df000 Deferred ws2_32<elf> \-PE 7e1b0000-7e1df000 \ ws2_32 ELF 7e201000-7e310000 Deferred msvcp100<elf> \-PE 7e240000-7e310000 \ msvcp100 ELF 7e310000-7e55e000 Deferred shell32<elf> \-PE 7e320000-7e55e000 \ shell32 ELF 7e55e000-7e572000 Deferred msimg32<elf> \-PE 7e560000-7e572000 \ msimg32 ELF 7e572000-7e67e000 Deferred comctl32<elf> \-PE 7e580000-7e67e000 \ comctl32 ELF 7e67e000-7e6f9000 Deferred shlwapi<elf> \-PE 7e690000-7e6f9000 \ shlwapi ELF 7e6f9000-7e7c2000 Deferred msvcr100<elf> \-PE 7e710000-7e7c2000 \ msvcr100 ELF 7e7c2000-7e7ed000 Deferred msacm32<elf> \-PE 7e7d0000-7e7ed000 \ msacm32 ELF 7e7ed000-7e872000 Deferred rpcrt4<elf> \-PE 7e800000-7e872000 \ rpcrt4 ELF 7e872000-7e9b7000 Deferred ole32<elf> \-PE 7e890000-7e9b7000 \ ole32 ELF 7e9b7000-7ea33000 Deferred advapi32<elf> \-PE 7e9c0000-7ea33000 \ advapi32 ELF 7ea33000-7eb54000 Deferred gdi32<elf> \-PE 7ea40000-7eb54000 \ gdi32 ELF 7eb54000-7ecb1000 Deferred user32<elf> \-PE 7eb70000-7ecb1000 \ user32 ELF 7ecb1000-7ed6c000 Deferred winmm<elf> \-PE 7ecc0000-7ed6c000 \ winmm ELF 7ef6c000-7ef79000 Deferred libnss_files.so.2 ELF 7ef79000-7ef85000 Deferred libnss_nis.so.2 ELF 7ef85000-7ef9e000 Deferred libnsl.so.1 ELF 7ef9e000-7efe4000 Deferred libm.so.6 ELF 7efe6000-7f000000 Deferred version<elf> \-PE 7eff0000-7f000000 \ version ELF b7344000-b74f3000 Dwarf libc.so.6 ELF b74f3000-b74f8000 Deferred libdl.so.2 ELF b74f9000-b7515000 Dwarf libpthread.so.0 ELF b7517000-b7520000 Deferred libnss_compat.so.2 ELF b7531000-b76e7000 Dwarf libwine.so.1 ELF b76e9000-b770b000 Deferred ld-linux.so.2 ELF b770b000-b770c000 Deferred [vdso].so Threads: process tid prio (all id:s are in hex) 00000008 (D) Z:\home\user\2.1.2\record_channels.exe 00000013 0 <== 00000012 0 00000009 0 0000000c services.exe 0000000f 0 0000000e 0 0000000d 0 00000010 explorer.exe 00000011 0 System information: Wine build: wine-1.8 Platform: i386 Version: Windows XP Host system: Linux Host version: 3.16.0-30-generic user(a)user-VirtualBox:~/2.1.2$ Best Regards, Ran

1 1

Re: xmllite: Avoid warning in test_read_state related to -1 not being in XmlReadState.
by Nikolay Sivov 05 Nov '17

05 Nov '17

On 11/03/2017 01:26 AM, Gerald Pfeifer wrote: > Hi Nikolay and others, > > the patch below avoids a warning of the kind > > reader.c:276:20: warning: comparison of constant -1 with expression of type > 'XmlReadState' (aka 'enum XmlReadState') is always false > [-Wtautological-constant-out-of-range-compare] > if (exp_broken == -1) > ~~~~~~~~~~ ^ ~~ > > which clang issues, so I hope it can be included? > > Gerald > > > Signed-off-by: Gerald Pfeifer <gerald(a)pfeifer.com> > --- > dlls/xmllite/tests/reader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c > index 0f03c3b42e..2a93a76ddb 100644 > --- a/dlls/xmllite/tests/reader.c > +++ b/dlls/xmllite/tests/reader.c > @@ -273,7 +273,7 @@ static void test_read_state(IXmlReader *reader, XmlReadState expected, > state = -1; /* invalid state value */ > IXmlReader_GetProperty(reader, XmlReaderProperty_ReadState, &state); > > - if (exp_broken == -1) > + if (exp_broken == (XmlReadState)-1) > broken_state = FALSE; > else > broken_state = broken(exp_broken == state); Hi, Gerald. Is this warning enabled by default in some release clang version? I'm not necessarily opposed in silencing it like that, but I imagine you'll see many more instances like that, and if it's not default set of warnings I don't know if we should bother.

2 3

Re: [PATCH] oleaut32: fixed 64bit crash on tmarshal test
by Donna Whisnant 04 Nov '17

04 Nov '17

> On 04.11.2017 17:28, Marcus Meissner wrote: > >> > >> Any idea why is this specific to 64 bit? > > > > Well, the call fails in because we have no 64bit typelib threaded marshaller. > > > > ... > > > > We could exit PSFacBuf_CreateProxy earlier on x86_64 with a different error. > > > > (or implement the typelib marshaller ;) > > Right, there is a fix for that linked from bug > https://bugs.winehq.org/show_bug.cgi?id=26768. It would be nice to have > that for 3.0. > And while you guys are working on it, it would also be nice to have typelib marshaller support for ARM in 3.0 too. ;-)

1 0

Re: [PATCH] oleaut32: fixed 64bit crash on tmarshal test
by Nikolay Sivov 04 Nov '17

04 Nov '17

On 03.11.2017 14:15, Marcus Meissner wrote: > Test will fail now, but no longer crash. > > Signed-off-by: Marcus Meissner <marcus(a)jet.franken.de> > --- > dlls/oleaut32/tests/tmarshal.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/dlls/oleaut32/tests/tmarshal.c b/dlls/oleaut32/tests/tmarshal.c > index d2b8dc92d6..f19cbf451b 100644 > --- a/dlls/oleaut32/tests/tmarshal.c > +++ b/dlls/oleaut32/tests/tmarshal.c > @@ -2010,7 +2010,8 @@ static void test_external_connection(void) > todo_wine > ok(external_connections == 2, "external_connections = %d\n", external_connections); > > - ITestSecondDisp_Release(second); > + if (hres == S_OK) > + ITestSecondDisp_Release(second); > todo_wine > ok(external_connections == 2, "external_connections = %d\n", external_connections); > > Any idea why is this specific to 64 bit?

2 2

Re: ws2_32/tests: Add some tests for sockets bound to a completion port.
by Alexandre Julliard 04 Nov '17

04 Nov '17

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > + if (pNtClose) > + { > + pNtClose((HANDLE)src); > + break; > + } > + win_skip("NtClose is not available on this platform"); > + how_to_close = 1; The test and skip are not necessary, we no longer support win9x in tests. > + ok(ovl_iocp->Internal == STATUS_CONNECTION_ABORTED || STATUS_LOCAL_DISCONNECT /* XP */, "got %#lx\n", ovl_iocp->Internal); The second part of the || is always true so this is not testing anything. > + ok(ovl_iocp->Internal == STATUS_CONNECTION_ABORTED || STATUS_LOCAL_DISCONNECT /* XP */, "got %#lx\n", ovl_iocp->Internal); Same here. -- Alexandre Julliard julliard(a)winehq.org

2 1

Setting a source directory in winedbg
by Mihai Todor 03 Nov '17

03 Nov '17

Hi Everyone, I noticed that I can set the source directory via the `dir` command in winedbg, but, for some reason, it rejects absolute paths, like Z:\bla\blah, claiming that ":" is a syntax error. I tried to enclose the path in quotes / double quotes, but then the quote / double quote is rejected as a syntax error. I don't have sufficient knowledge of bison to grok the code in programs/winedbg/dbg.y, so is there a way to escape the colon symbol? As a workaround, I mapped my build directory under Wine, but that is really annoying. Thank you, Mihai Todor

1 1

Re: [PATCH v2] kernel32/tests: Detect and handle a redirected stdin.
by Zebediah Figura 03 Nov '17

03 Nov '17

On 11/03/2017 05:43 AM, Alex Henrie wrote: > Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> > --- > v2: Simply skip the tests if the input is redirected. > --- > dlls/kernel32/tests/console.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/dlls/kernel32/tests/console.c b/dlls/kernel32/tests/console.c > index a14bc45034..926c052686 100644 > --- a/dlls/kernel32/tests/console.c > +++ b/dlls/kernel32/tests/console.c > @@ -2582,6 +2582,11 @@ static void test_ReadConsole(void) > > SetLastError(0xdeadbeef); > ret = GetFileSize(std_input, NULL); > + if (GetLastError() == 0xdeadbeef) > + { > + skip("stdin is redirected\n"); > + return; > + } > ok(ret == INVALID_FILE_SIZE, "expected INVALID_FILE_SIZE, got %#x\n", ret); > ok(GetLastError() == ERROR_INVALID_HANDLE || > GetLastError() == ERROR_INVALID_FUNCTION, /* Win 8, 10 */ > Couldn't we just skip those two tests? The others don't seem to fail under that circumstance.

2 1

Re: Józef Kucia : wined3d: Implement indirect draws.
by Ken Thomases 03 Nov '17

03 Nov '17

Hi Józef, On Nov 2, 2017, at 5:28 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > > Module: wine > Branch: master > Commit: f4aa2911a689f95783fe2061a516440dc3d3f39e > URL: http://source.winehq.org/git/wine.git/?a=commit;h=f4aa2911a689f95783fe2061a… > > Author: Józef Kucia <jkucia(a)codeweavers.com> > Date: Wed Nov 1 22:08:42 2017 +0100 > > wined3d: Implement indirect draws. If I'm reading this commit correctly, the new indexed indirect draw code does not make use of state->index_offset (via idx_data, for example). Is that how it should be? Or should DrawIndexedInstancedIndirect() respect the index buffer offset? Thanks, Ken

2 1