May 2017 - Wine-devel - list.winehq.org

Re: [7/8] d3d11/tests: Add R9G9B9E5_SHAREDEXP to test_create_texture3d.
by Józef Kucia 25 May '17

25 May '17

On Thu, May 25, 2017 at 12:15 PM, Sven Hesse <drmccoy(a)drmccoy.de> wrote: > {DXGI_FORMAT_R8G8B8A8_UNORM, D3D11_BIND_DEPTH_STENCIL, FALSE, FALSE}, > {DXGI_FORMAT_D24_UNORM_S8_UINT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, > {DXGI_FORMAT_D32_FLOAT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, D3D10_BIND_RENDER_TARGET, FALSE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, D3D10_BIND_DEPTH_STENCIL, FALSE, FALSE}, Please use D3D11 enum values.

1 0

Re: [6/8] d3d11/tests: Add R9G9B9E5_SHAREDEXP to test_create_texture2d.
by Józef Kucia 25 May '17

25 May '17

On Thu, May 25, 2017 at 12:15 PM, Sven Hesse <drmccoy(a)drmccoy.de> wrote: > {DXGI_FORMAT_D32_FLOAT, 1, D3D11_BIND_RENDER_TARGET, 0, FALSE, FALSE}, > {DXGI_FORMAT_D32_FLOAT, 1, D3D11_BIND_DEPTH_STENCIL, 0, TRUE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, 1, D3D10_BIND_SHADER_RESOURCE, 0, TRUE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, 1, D3D10_BIND_RENDER_TARGET, 0, FALSE, FALSE}, > + {DXGI_FORMAT_R9G9B9E5_SHAREDEXP, 1, D3D10_BIND_DEPTH_STENCIL, 0, FALSE, FALSE}, > }; Please use D3D11 enum values.

1 0

Re: [5/8] d3d10core/tests: Add R9G9B9E5_SHAREDEXP to test_texture.
by Józef Kucia 25 May '17

25 May '17

On Thu, May 25, 2017 at 12:15 PM, Sven Hesse <drmccoy(a)drmccoy.de> wrote: > + static const DWORD r9g9b9e5_colors[16] = { Please try to put opening brackets on a new line (applies also to the d3d11 version).

1 0

Re: [PATCH 1/5] d3dx9/tests: Use ARRAY_SIZE in test_D3DXSHEvalDirectionalLight().
by Matteo Bruni 24 May '17

24 May '17

2017-05-23 11:04 GMT+02:00 Henri Verbeet <hverbeet(a)codeweavers.com>: > @@ -2908,7 +2908,7 @@ static void test_D3DXSHEvalDirectionalLight(void) > green_out = test[l].green_in; > blue_out = test[l].blue_in; > > - for (j = 0; j < 49; j++) > + for (j = 0; j < ARRAY_SIZE(red_out); ++j) red_out here is defined as a pointer, not an array.

1 0

Re: [v5 PATCH 3/3] wined3d: Update only dirty regions in wined3d_cs_exec_update_texture().
by Marvin 24 May '17

24 May '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31147 Your paranoid android. === w1064 (32 bit visual) === visual.c:8016: Test failed: Got unexpected color 0x00007580 for quad 2 (different colors).

1 0

Re: [PATCH] iphlpapi: Implement if_nametoindex.
by Bruno Jesus 24 May '17

24 May '17

On Wed, May 24, 2017 at 7:39 AM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > ... > diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c > index 796950e0f9..4cceb65621 100644 > --- a/dlls/iphlpapi/iphlpapi_main.c > +++ b/dlls/iphlpapi/iphlpapi_main.c > @@ -36,6 +36,9 @@ > #ifdef HAVE_RESOLV_H > # include <resolv.h> > #endif > +#ifdef HAVE_NET_IF_H > +# include <net/if.h> > +#endif > > #define NONAMELESSUNION > #define NONAMELESSSTRUCT > @@ -3208,3 +3211,12 @@ DWORD WINAPI ConvertInterfaceNameToLuidW(const WCHAR *name, NET_LUID *luid) > luid->Info.IfType = row.dwType; > return NO_ERROR; > } > + > +/****************************************************************** > + * if_nametoindex (IPHLPAPI.@) > + */ > +IF_INDEX WINAPI IPHLP_if_nametoindex(const char *name) > +{ > + TRACE("(%s)\n", name); > + return if_nametoindex(name); > +} Hi, this seems to be the ASCII version of GetAdapterIndex, can't you call getInterfaceIndexByName and avoid the new #include? Best wishes, Bruno

3 8

Re: [PATCH 2/2] winex11.drv: Implement clipboard changes tracking using xfixes extension
by Alexandre Julliard 24 May '17

24 May '17

Piotr Caban <piotr(a)codeweavers.com> writes: > @@ -499,6 +499,7 @@ extern Atom systray_atom DECLSPEC_HIDDEN; > typedef BOOL (*x11drv_event_handler)( HWND hwnd, XEvent *event ); > > extern void X11DRV_register_event_handler( int type, x11drv_event_handler handler, const char *name ) DECLSPEC_HIDDEN; > +extern void X11DRV_register_XFixesSelectionNotify( int type ) DECLSPEC_HIDDEN; Is there a reason you can't use X11DRV_register_event_handler? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/2] regedit: Add 'Expand' and 'Collapse' options to the treeview pop-up menu
by Nikolay Sivov 24 May '17

24 May '17

On 24.05.2017 11:21, Hugh McMaster wrote: > + item.mask = TVIF_CHILDREN | TVIF_HANDLE | TVIF_STATE; > + item.stateMask = TVIS_EXPANDED | TVIS_EXPANDEDONCE | TVIS_EXPANDPARTIAL; > + SendMessageW(hwndTV, TVM_GETITEMW, 0, (LPARAM)&item) Later you only test for TVIS_EXPANDED, is it necessary to request other bits?

2 1

Re: [PATCH 2/2] regedit: Add 'Expand' and 'Collapse' options to the treeview pop-up menu
by Nikolay Sivov 24 May '17

24 May '17

On 24.05.2017 11:21, Hugh McMaster wrote: > + case ID_TREE_EXPAND: > + { > + HTREEITEM selected = (HTREEITEM)SendMessageW(g_pChildWnd->hTreeWnd, TVM_GETNEXTITEM, TVGN_CARET, 0); > + SendMessageW(g_pChildWnd->hTreeWnd, TVM_EXPAND, TVE_TOGGLE, (LPARAM)selected); > + break; > + } Maybe it's better to name it ID_TREE_EXPAND_COLLAPSE, since it does not only expand.

2 1

Re: [PATCH] authz: document missorted function in specfile
by Alexandre Julliard 24 May '17

24 May '17

Austin English <austinenglish(a)gmail.com> writes: > Signed-off-by: Austin English <austinenglish(a)gmail.com> > --- > dlls/authz/authz.spec | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dlls/authz/authz.spec b/dlls/authz/authz.spec > index eb9e044d2a..1e9edefc59 100644 > --- a/dlls/authz/authz.spec > +++ b/dlls/authz/authz.spec > @@ -35,6 +35,8 @@ > @ stub AuthziInitializeAuditQueue > @ stub AuthziInitializeContextFromSid > @ stub AuthziLogAuditEvent > +# AuthziModifyAuditEvent2 comes before AuthziModifyAuditEvent on native, > +# even though AuthzInitializeObjectAccessAuditEvent is before AuthzInitializeObjectAccessAuditEvent2 > @ stub AuthziModifyAuditEvent2 > @ stub AuthziModifyAuditEvent > @ stub AuthziModifyAuditEventType There are many functions that aren't sorted, I don't think this warrants a comment. If you have a script for this, you may want to maintain a list of exceptions inside the script instead. -- Alexandre Julliard julliard(a)winehq.org

3 4