May 2017 - Wine-devel - list.winehq.org

Re: [PATCH] comctl32/listview: Do not select the first list item when drawing a marquee rectangle
by Nikolay Sivov 23 May '17

23 May '17

On 22.05.2017 16:02, Hugh McMaster wrote: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > dlls/comctl32/listview.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c > index c681451..a117f83 100644 > --- a/dlls/comctl32/listview.c > +++ b/dlls/comctl32/listview.c > @@ -3892,6 +3892,9 @@ static void LISTVIEW_MarqueeHighlight(LISTVIEW_INFO *infoPtr, const POINT *coord > if ((scroll & SCROLL_DOWN) && (coords_orig->y >= infoPtr->rcList.bottom)) > LISTVIEW_Scroll(infoPtr, 0, (coords_orig->y - infoPtr->rcList.bottom)); > > + if (IsRectEmpty(&infoPtr->marqueeRect)) > + infoPtr->marqueeRect = rect; > + > iterator_frameditems_absolute(&old_elems, infoPtr, &infoPtr->marqueeRect); > > infoPtr->marqueeRect = rect; > How can I reproduce this issue?

1 0

Re: [PATCH 2/2] d3d11/tests: Add additional test for occlusion query.
by Henri Verbeet 22 May '17

22 May '17

On 20 May 2017 at 14:12, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + for (i = 0; i < 500; ++i) > + { > + if ((hr = ID3D11DeviceContext_GetData(context, query, NULL, 0, 0)) != S_FALSE) > + break; > + Sleep(10); > + } > + ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); > + hr = ID3D11DeviceContext_GetData(context, query, &data, sizeof(data), 0); > + ok(hr == S_OK, "Got unexpected hr %#x.\n", hr); > + todo_wine ok(data.dword[0] == 0x1000 && !data.dword[1], > + "Got unexpected query result 0x%08x%08x.\n", data.dword[1], data.dword[0]); This fails about half of the time with csmt enabled: d3d11.c:4872: Test succeeded inside todo block: Got unexpected query result 0x0000000000001000.

2 2

Re: [PATCH 5/5] d2d1: Implement initial support for quadratic bezier outlines.
by Dmitry Timoshkov 22 May '17

22 May '17

Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > +static void d2d_point_lerp(D2D1_POINT_2F *out, > + const D2D1_POINT_2F *a, const D2D1_POINT_2F *b, float t) > +{ > + out->x = a->x * (1.0f - t) + b->x * t; > + out->y = a->y * (1.0f - t) + b->y * t; > +} According to my investigation of a better bilinear blending (lerp) implementation the above formula is better to explicitely simplify to out->x = a->x + (b->x - a->x) * t; out->y = a->y + (b->y - a->y) * t; or even better to avoid floating point operations at all by replacing them either by fixed point math or a mmx/sse helper, which is able to considerably (x10) improve performance. -- Dmitry.

3 9

What is the best way to debug a freeze in wine?
by Derek Lesho 22 May '17

22 May '17

This is my first time posting in a mailing list, so if this is the wrong place to ask or I am doing something wrong, please tell me. Anyway, In wine 2.8, GTA-V is able to be run, however there is a major bug in which any key press will freeze the game for a few seconds. However, if you bind any actions to the mouse, say mouse4 or mouse5, the issue is not present. GTA-V has also worked for people using xbox 360 controllers. I have moderate programming knowledge, and I would like to find the source of this bug, however I have no found a good way to do it yet. I have tried winedbg, however when I get a backtrace of the process, there are atleast 50 threads running and I am unsure which one is locking up the game. I would use perf, however so far I haven't figured out how to make it tell me which functions are taking up most of the time. My question is, do any of you know of good tools/techniques that would help me debug this sort of problem? It would be greatly appreciated. P.S. for any of you who are also interested in this specific problem, many error messages are sent out at a very fast speed, but when the game is frozen due to this bug, all error messages temporarily halt with the exception of these two: fixme:keyboard:X11DRV_ActivateKeyboardLayout 0x4090409, 40000000: semi-stub! fixme:keyboard:X11DRV_ActivateKeyboardLayout flags 40000000 not supported Which are output a slow interval instead until the game unfreezes at which point the console output returns back to its normal sporadic behavior. Also, here is a normal backtrace from winedbg while the issue is occuring: http://paste.ubuntu.com/24539530/

2 1

Re: [PATCH 7/7] d3dx9/tests: Use static test blob in test_effect_preshader_ops().
by Matteo Bruni 22 May '17

22 May '17

2017-05-19 13:56 GMT+02:00 Paul Gofman <gofmanp(a)gmail.com>: Thanks, I do think this is an improvement compared to the old tests. A few comments below. > static const struct > { > - unsigned int pos; > + const char *mnem; > + unsigned int expected_result[4]; > unsigned int result_index; > - unsigned int ins_count; > + float *result; > + D3DXVECTOR4 opvect1, opvect2, opvect3; > + unsigned int ulps; > + BOOL todo[4]; > } I assume ulps and todo are there for future tests? > + for (j = 0; j < 4; ++j) > + { > + const float *v = op_tests[i].result; Can you put the initialization of 'v' outside of the inner loop? I'm sure the compiler sees the optimization and the generated code is ultimately the same (not that it would really matter for a test anyway...) but it seems a bit nicer to do that in the "correct" block. You could also call it "result" or similar. > + todo_wine_if(op_tests[i].todo[j]) > + ok(compare_float(v[j], ((float *)op_tests[i].expected_result)[j], op_tests[i].ulps), > + "Operation %s, component %u, expected %#x (%g), got %#x (%g).\n", op_tests[i].mnem, > + j, op_tests[i].expected_result[j], ((float *)op_tests[i].expected_result)[j], > + ((unsigned int *)v)[j], v[j]); Just an idea, maybe use %.8e to print the float values? Mostly for consistency with the usual d3d stuff, although in this case it doesn't matter much since you're also printing the bit encoding in hex. Also you can clean the ok() a bit by defining a "const float *expected_float;" variable (similarly to test_effect_preshader_relative_addressing()). BTW, notice that you're currently casting away const from v.

2 2

Re: [v2 2/2] d3d11/tests: Add tests for SM5 instructions gather4_c/gather4_po_c
by Henri Verbeet 22 May '17

22 May '17

On 19 May 2017 at 14:31, Sven Hesse <drmccoy(a)drmccoy.de> wrote: > Signed-off-by: Sven Hesse <drmccoy(a)drmccoy.de> > --- > dlls/d3d11/tests/d3d11.c | 230 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 230 insertions(+) > This fails here: d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 1.00000000e+00, 0.00000000e+00, 0.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 0.00000000e+00, 0.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 0.00000000e+00, 0.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 0.00000000e+00, 0.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 1.00000000e+00, 0.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 0.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 0.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 0.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 0.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 1.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 1.00000000e+00, 0.00000000e+00, 0.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 0.00000000e+00, 0.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 1.00000000e+00, 1.00000000e+00, 0.00000000e+00}. d3d11.c:19637: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 0.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 0.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 0.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 0.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 1.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 1.00000000e+00, 0.00000000e+00, 0.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 0.00000000e+00, 0.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 0.00000000e+00, 0.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 1.00000000e+00, 1.00000000e+00, 0.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {0.00000000e+00, 1.00000000e+00, 1.00000000e+00, 0.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 1.00000000e+00, 1.00000000e+00}. d3d11.c:19658: Test failed: Got {0.00000000e+00, 0.00000000e+00, 0.00000000e+00, 0.00000000e+00}, expected {1.00000000e+00, 1.00000000e+00, 1.00000000e+00, 1.00000000e+00}.

2 2

Re: [PATCH 1/2] kernel32/tests: Added more PeedNamedPipe tests.
by Marvin 22 May '17

22 May '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31084 Your paranoid android. === w7u (32 bit pipe) === pipe.c:2631: Test failed: FlushFileBuffers failed: 0

1 0

D3D command stream patches for testing
by A.S. 21 May '17

21 May '17

Hello, I have low frame rate (~16-18) problem in Unreal Tournament 3, wine 2.8. "stat fps", "stat ld" commands were enabled in game console and showed relation that fps drop after 'static mesh tris' goes higher than >200 000 So I applied patchset from https://www.winehq.org/pipermail/wine-devel/2013-September/101116.html to wine 1.7 with CXXFLAGS -o3 -m native, and tested it. Yes, finnaly my fps imroves to ~30 on same maps where it was lower before. Thank you Stefan. same issue was reported by many unreal engine 3 players on windows, so AFAIK this could be ue3 problem itself. the patchset could be step in right direction, or workaround, but not a total fix, cuz even minimal ~30 frame rate is lower than expected on Core2Duo, gf GTS450, when other games works better. Thanks, Lex.

1 0

Re: [PATCH 2/2] kernel32/tests: Test bytes left in PeekNamedPipe().
by Marvin 21 May '17

21 May '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=31073 Your paranoid android. === wvistau64 (64 bit pipe) === pipe.c:356: Test failed: peek3 got -21 bytes left pipe.c:395: Test failed: peek4 got -21 bytes left === w2008s64 (64 bit pipe) === pipe.c:356: Test failed: peek3 got -21 bytes left pipe.c:395: Test failed: peek4 got -21 bytes left === w7pro64 (64 bit pipe) === pipe.c:356: Test failed: peek3 got -21 bytes left pipe.c:395: Test failed: peek4 got -21 bytes left === w864 (64 bit pipe) === pipe.c:356: Test failed: peek3 got -21 bytes left pipe.c:395: Test failed: peek4 got -21 bytes left === w1064 (64 bit pipe) === pipe.c:356: Test failed: peek3 got -21 bytes left pipe.c:395: Test failed: peek4 got -21 bytes left

3 2

Re: [PATCH] wined3d: Add Brian Paul recognize code
by Henri Verbeet 19 May '17

19 May '17

On 16 May 2017 at 16:09, Jarkko Korpi <jarkko_korpi(a)hotmail.com> wrote: > This is for bug #42538 > As explained in that bug, I don't object to adding this in principle, but would still like to see how this can be triggered in practice.

1 0