August 2017 - Wine-devel - list.winehq.org

Re: [PATCH 1/2] user32/tests: Test DialogBoxParam using a dialog template with invalid control class.
by Dmitry Timoshkov 17 Aug '17

17 Aug '17

Andrew Eikum <aeikum(a)codeweavers.com> wrote: > From: Dmitry Timoshkov <dmitry(a)baikal.ru> > > Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> > --- > dlls/user32/tests/dialog.c | 6 ++++++ > dlls/user32/tests/resource.rc | 6 ++++++ > 2 files changed, 12 insertions(+) I think that I've expressed my opinion clear enough in my response to your private e-mail that I don't allow you to send my patches included in the wine-staging tree to winehq, and explained well enough my reasoning. The only person who has my permission is Sebastian Lackner - wine-staging maintainer. I'm too sometimes sending the patches, but I have to admit that's pretty rare cases these days, and usually that's not my personal decision. Please try to find your own areas to work on, and stop stealing patches created by somebody else, especially when directly asked not to. -- Dmitry.

3 12

Re: [v5 PATCH 1/3] dwrite: Protect cached fontface list when accessed from multiple threads
by Sebastian Lackner 17 Aug '17

17 Aug '17

On 15.08.2017 13:40, Nikolay Sivov wrote: > if (cached_key_size == key_size && !memcmp(cached_key, key, key_size)) { > + if (FAILED(hr = IDWriteFontFace4_QueryInterface(cached->fontface, riid, obj))) > + WARN("Failed to get %s from fontface, hr %#x.\n", debugstr_guid(riid), hr); > + > TRACE("returning cached fontface %p\n", cached->fontface); > - *font_face = (IDWriteFontFace*)cached->fontface; > - return S_OK; > + break; > } > } There is still a minor problem (no race condition though). Lets assume a fontface is just about to be destroyed, then the code above will abort enumeration after reaching the fontface with refcount == 0. Lets assume the newly created fontface is added after the old one, then all following attempts to get the fontface from the cache will fail, until the old one has finally be removed. This issue can be avoided by doing "continue;" instead of "break;" for E_FAIL.

1 0

Re: [PATCH] kernel32/nls: Added LOCALE_SNAN entries
by Henri Verbeet 17 Aug '17

17 Aug '17

On 17 August 2017 at 00:28, Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > diff --git a/dlls/kernel32/nls/far.nls b/dlls/kernel32/nls/far.nls > index 0f5b17068b..2baf289223 100644 > --- a/dlls/kernel32/nls/far.nls > +++ b/dlls/kernel32/nls/far.nls > @@ -124,6 +124,7 @@ STRINGTABLE LANGUAGE LANG_PERSIAN, SUBLANG_DEFAULT > LOCALE_SMONTHNAME13 "" > LOCALE_SMONTHOUSANDSEP "٬" > LOCALE_SNAME "fa-IR" > + LOCALE_SNAN "ﻥﺎﻋﺩﺩ" That doesn't look right. According to http://www.unicode.org/cldr/charts/latest/by_type/numbers.symbols.html#2a6d… "ناعدد" is correct, but the above is using the Presentation Forms-B characters.

2 1

Re: [PATCH] msi: Print error number when GetProcAddress fails
by Hans Leidekker 17 Aug '17

17 Aug '17

On Wed, 2017-08-16 at 17:20 +0100, Carlos Palminha wrote: > diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c > index 922927e8903..cfdfe852efb 100644 > --- a/dlls/msi/custom.c > +++ b/dlls/msi/custom.c > @@ -608,7 +608,7 @@ static DWORD ACTION_CallDllFunction( const GUID *guid ) > ERR("failed to create handle for %p\n", remote_package ); > } > else > - ERR("GetProcAddress(%s) failed\n", debugstr_w( function ) ); > + ERR("GetProcAddress(%s) failed: %d\n", debugstr_w( function ), GetLastError() ); > > FreeLibrary(hModule); This doesn't appear to add any useful information. Our implementation of GetProcAddress sets either ERROR_PROC_NOT_FOUND or ERROR_MOD_NOT_FOUND and LoadLibrary must have succeeded before reaching this code.

3 2

Re: [PATCH v3] user32/combo: Set listview popup height correctly and add tests
by Nikolay Sivov 16 Aug '17

16 Aug '17

It's a listbox, not listview.

2 1

D3D8 Software Vertex Processing
by Jan Havran 16 Aug '17

16 Aug '17

Hello, i am trying to fix #9337 [1] for VietCong game (game is crashing during loading 3D objects) for which exists community util which fixes it. This util was made to fix issues for VC on newer Windows - fixing this bug in Wine was just side effect. Anyway, i have talked to creator of this util (Brchi from The Archi Family) about it. The game originally use software vertexes only, but he edited the game and switched to hardware vertexes (which increased FPS rapidly on Windows), but he was facing the same problem - the game was crashing. Fortunately, he found that the game uses different code branches when hardware vertex are used - developers probably never finished support for hardware vertexes and that is reason why it is crashing when HW vertexes are used. He fixed game code so it works with HW vertexes (even in Wine). The problem is that game uses only SW vertexes and these unfinished branches are called only when HW vertexes are used, which is not a problem for Windows (which support SW vertexes). But for some reason Wine uses HW vertexes even if game wants to use SW vertexes. Thats why the game works in Wine only with this util applied. I can see from report [2] that game tries to use SW vertexes, which are unsupported by Wine. Can I simply edit some code in Wine (some D3D flag) so the game will think that it use SW vertexes, so after checking some flags by game it will not jump into some unfinished branches for HW vertexes? I just want to test if it is really caused by this. From application view, what is difference between using SW and HW vertexes, do you think that using HW vertexes with code done for SW vertexes will work? [1] https://bugs.winehq.org/show_bug.cgi?id=9337 [2] https://bugs.winehq.org/show_bug.cgi?id=9337#c35 Thanks, Jan

2 6

Re: [PATCH] gdiplus: Implement transform matrix for line gradient brushes
by Vincent Povirk 16 Aug '17

16 Aug '17

I wrote a test program (attached), and it doesn't work when the start point isn't 0,0. > + if (line->startpoint.X == line->endpoint.X) > + t = line->startpoint.Y > line->endpoint.Y ? 3.f * M_PI / 2.f : M_PI / 2.f; > + else > + t = atanf((line->endpoint.Y - line->startpoint.Y) / (line->endpoint.X - line->startpoint.X)); > + > + t_cos = cosf(t); > + t_sin = sinf(t); This seems like an oddly complicated and fragile way to normalize a vector.

2 1

Re: [PATCH] avrt: Add AvQuerySystemResponsiveness stub.
by Huw Davies 16 Aug '17

16 Aug '17

On Wed, Aug 16, 2017 at 02:22:13PM +0300, Andrey Gusev wrote: > Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> > --- > dlls/avrt/avrt.spec | 2 +- > dlls/avrt/main.c | 6 ++++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/dlls/avrt/avrt.spec b/dlls/avrt/avrt.spec > index 640a12ac22..a7dfc42879 100644 > --- a/dlls/avrt/avrt.spec > +++ b/dlls/avrt/avrt.spec > @@ -1,4 +1,4 @@ > -@ stub AvQuerySystemResponsiveness > +@ stdcall AvQuerySystemResponsiveness(long ptr) > @ stdcall AvRevertMmThreadCharacteristics(long) > @ stub AvRtCreateThreadOrderingGroup > @ stub AvRtCreateThreadOrderingGroupExA > diff --git a/dlls/avrt/main.c b/dlls/avrt/main.c > index 8a110250ae..68e44d6098 100644 > --- a/dlls/avrt/main.c > +++ b/dlls/avrt/main.c > @@ -83,6 +83,12 @@ HANDLE WINAPI AvSetMmThreadCharacteristicsW(LPCWSTR TaskName, LPDWORD TaskIndex) > return (HANDLE)0x12345678; > } > > +BOOL WINAPI AvQuerySystemResponsiveness(HANDLE AvrtHandle, PULONG SystemResponsivenessValue) > +{ > + FIXME("(%p, %p): stub\n", AvrtHandle, SystemResponsivenessValue); > + return TRUE; > +} > + If you're going to return TRUE, you need to initialize *SystemResponsivenessValue to something meaningful. While you're at it, we generally prefer 'ULONG *' to 'PULONG', although I realise there are several of the latter form in this file. Huw.

2 3

Re: [PATCH v2] server: Use queue_irp() also for synchronous IRPs.
by Alexandre Julliard 16 Aug '17

16 Aug '17

Zebediah Figura <z.figura12(a)gmail.com> writes: > Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> > --- > server/device.c | 46 ++++++++++++++++++++-------------------------- > 1 file changed, 20 insertions(+), 26 deletions(-) It's probably a matter of taste, but this doesn't look to me like an improvement. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [v4 5/5] kernel32/tests: Add tests for LoadLibrary with LIBRARY_SEARCH_* flags
by Marvin 16 Aug '17

16 Aug '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32694 Your paranoid android. === wvistau64 (32 bit module) === module.c:479: Test failed: Expected ERROR_MOD_NOT_FOUND or ERROR_DLL_NOT_FOUND (win9x) or ERROR_INVALID_PARAMETER (win2003), got 8 === w2008s64 (32 bit module) === module.c:479: Test failed: Expected ERROR_MOD_NOT_FOUND or ERROR_DLL_NOT_FOUND (win9x) or ERROR_INVALID_PARAMETER (win2003), got 8 === wvistau64 (64 bit module) === module.c:479: Test failed: Expected ERROR_MOD_NOT_FOUND or ERROR_DLL_NOT_FOUND (win9x) or ERROR_INVALID_PARAMETER (win2003), got 8 === w2008s64 (64 bit module) === module.c:479: Test failed: Expected ERROR_MOD_NOT_FOUND or ERROR_DLL_NOT_FOUND (win9x) or ERROR_INVALID_PARAMETER (win2003), got 8

1 0