August 2017 - Wine-devel - list.winehq.org

Re: [PATCH] gdiplus: Support GdipSetClipRegion in metafiles
by Vincent Povirk 10 Aug '17

10 Aug '17

+ stat = GdipGetRegionData(region, (BYTE*)object_record + FIELD_OFFSET(EmfPlusObject, Header.Size), size, NULL); + object_record->Header.DataSize = object_record->Header.Size; + object_record->Header.Size = record_size; This is a little too clever. I'd rather have a solution similar to write_path_data.

1 0

Re: [v4 PATCH 1/2] dwrite: Protect cached fontface list when accessed from multiple threads
by Sebastian Lackner 10 Aug '17

10 Aug '17

On 10.08.2017 15:41, Nikolay Sivov wrote: > @@ -861,6 +877,10 @@ HRESULT factory_get_cached_fontface(IDWriteFactory5 *iface, IDWriteFontFile * co > const void *cached_key; > IDWriteFontFile *file; > > + if (IDWriteFontFace4_AddRef(cached->fontface) == 1) > + continue; > + IDWriteFontFace4_Release(cached->fontface); This will not work as expected. The refcount also matters when the object is about to be destroyed. There could be multiple threads running factory_get_cached_fontface() before _Release() can finally remove the fontface from the list. Please note that always calling _Release() also wouldn't be correct because it would run the destructor twice. It is not really necessary to access the private structs from other parts of dwrite, but you should either: * change AddRef to use something like interlocked_dec_if_nonzero (see ntdll/sync.c) * implement the check in QueryInterface (manually run InterlockedDecrement to decrement the refcount without going through the destructor) There are probably also other ways, for example using a flag to make sure the destructor is not called twice. Best regards, Sebastian

1 0

Re: [v2 PATCH 2/2] dwrite: Added a helper to check for supported characters
by Dmitry Timoshkov 10 Aug '17

10 Aug '17

Nikolay Sivov <nsivov(a)codeweavers.com> wrote: > - TRACE("(%p)->(0x%08x)\n", This, ch); > + TRACE("(%p)->(0x%#x)\n", This, ch); This will cause printing of the 0x prefix twice. Same applies to other places. -- Dmitry.

1 0

Re: wineandroid: Add suffix to lib directory and wine binary on 64-bit
by Alexandre Julliard 10 Aug '17

10 Aug '17

André Hentschel <nerv(a)dawncrow.de> writes: > This fixes at least arm64-v8a builds, where you have lib64/libwine.so and bin/wine64 > > Signed-off-by: André Hentschel <nerv(a)dawncrow.de> > --- > > This and "winebuild: Improved position independent code generation" enable Wine on ARM64 Android phones (e.g. most Android devices). > The check for 64 in the CPU_ABI can be discussed, but I think it's reliable and fast. > > dlls/wineandroid.drv/WineActivity.java | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) We already prefix with the ABI, so I think plain "lib" is better. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH v2 2/5] include: Add initial ieautomation.idl
by Nikolay Sivov 09 Aug '17

09 Aug '17

On 08.08.2017 21:04, Zebediah Figura wrote: > +[ > + object, > + uuid(acc84351-04ff-44f9-b23f-655ed168c6d5), > + oleautomation > +] > +interface IInternetExplorerManager : IUnknown > +{ > + HRESULT CreateObject([in] DWORD config, [in, unique] LPCWSTR url, [in] REFIID riid, [out, iid_is(riid)] void **ppv); > +} This is not how it's defined in SDK - oleautomation is not used there and "url" argument has different attributes.

3 2

Re: [PATCH v2 5/5] ieproxy: Add proxy/stub for IInternetExplorerManager.
by Alistair Leslie-Hughes 09 Aug '17

09 Aug '17

Hi Zebediah, On 09/08/17 04:04, Zebediah Figura wrote: > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > interface IInternetExplorerManager : IUnknown > { > - HRESULT CreateObject([in] DWORD config, [in, unique] LPCWSTR url, [in] REFIID riid, [out, iid_is(riid)] void **ppv); > + [local] HRESULT CreateObject([in] DWORD config, [in, unique] LPCWSTR url, [in] REFIID riid, [out, iid_is(riid)] void **ppv); > + [call_as(CreateObject)] HRESULT RemoteCreateObject([in] DWORD config, [in, unique] LPCWSTR url, [in] REFIID riid, [out, iid_is(riid)] void **ppv); The public API doesn't have the RemoteCreateObject function. Best Regards Alistair.

2 1

Re: [PATCH 3/5] setupapi: Fix compiler warnings when converting between pointers and integers on 64-bit systems
by Alexandre Julliard 09 Aug '17

09 Aug '17

Hugh McMaster <hugh.mcmaster(a)outlook.com> writes: > Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> > --- > dlls/setupapi/devinst.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) That's only hiding the bug. -- Alexandre Julliard julliard(a)winehq.org

4 3

Re: [PATCH v2 5/5] ieproxy: Add proxy/stub for IInternetExplorerManager.
by Alistair Leslie-Hughes 09 Aug '17

09 Aug '17

Hi Zebediah, On 09/08/17 04:04, Zebediah Figura wrote: > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > interface IInternetExplorerManager : IUnknown > { > - HRESULT CreateObject([in] DWORD config, [in, unique] LPCWSTR url, [in] REFIID riid, [out, iid_is(riid)] void **ppv); > + [local] HRESULT CreateObject([in] DWORD config, [in, unique] LPCWSTR url, [in] REFIID riid, [out, iid_is(riid)] void **ppv); > + [call_as(CreateObject)] HRESULT RemoteCreateObject([in] DWORD config, [in, unique] LPCWSTR url, [in] REFIID riid, [out, iid_is(riid)] void **ppv); The public API doesn't have the RemoteCreateObject function. Best Regards Alistair.

1 0

Re: [PATCH] kernel32: Uncomment Win7 stubs in specfile.
by Sebastian Lackner 08 Aug '17

08 Aug '17

On 08.08.2017 21:38, Zebediah Figura wrote: > These were originally commented since the default Windows version > was still XP. As I see you want to increase your regression count. ;) Whats the point of advertising all those functions when Wine has no implementation yet?

3 3

Re: [PATCH 5/5] ieproxy: Add proxy/stub for IInternetExplorerManager.
by Marvin 08 Aug '17

08 Aug '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=32620 Your paranoid android. === build (build) === Make in include dir failed

1 0