September 2017 - Wine-devel

Re: [PATCH 3/3] mshtml/tests: Run events tests in IE9 mode.
by Alexandre Julliard 29 Sep '17

29 Sep '17

Jacek Caban <jacek(a)codeweavers.com> writes: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/mshtml/tests/events.c | 132 > +++++++++++++++++++++++++++++++++++---------- > 1 file changed, 103 insertions(+), 29 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so events && touch events.ok events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:1242: Test failed: pdp->cArgs = 1 events.c:1218: Test failed: pdp->cArgs = 1 events.c:1242: Test failed: pdp->cArgs = 1 events.c:1218: Test failed: pdp->cArgs = 1 events.c:1242: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1060: Test failed: pdp->cArgs = 1 events.c:1085: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1085: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1060: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1191: Test failed: pdp->cArgs = 1 Makefile:267: recipe for target 'events.ok' failed make[1]: *** [events.ok] Error 37 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 1/3] mshtml: Inherit document mode from parent document.
by Marvin 29 Sep '17

29 Sep '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33334 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5092: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

1 0

Re: mshtml: Inherit document mode from parent document.
by Gijs Vermeulen 29 Sep '17

29 Sep '17

Hi, 2017-09-28 19:50 GMT+02:00 Jacek Caban <jacek(a)codeweavers.com>: > > + TRACE("parnet mode %u\n", parent_mode); > > There seems to be a typo here. Sincerely, Gijs

2 1

Re: [v7 1/5] server: Named pipe query SD from pipe object
by Jacek Caban 29 Sep '17

29 Sep '17

Hi Jonathan, Your tests still don't really show intended behaviour. Your calls that set security descriptor use new SD that has the same tested values as before the call, then what's the point in setting it? Anyway, I cleaned it up and changed a bit to see how it's really supposed to work. See the attachment. It looks like client and served should indeed share security descriptor, but pipe object should not, so that part is wrong. Thanks, Jacek

2 2

Re: mshtml: Inherit document mode from parent document.
by Marvin 28 Sep '17

28 Sep '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33325 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5092: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

1 0

Re: [PATCH] midimap: Add warning for user in case midi won't work
by Alexandre Julliard 28 Sep '17

28 Sep '17

Fabian Maurer <dark.shadow4(a)web.de> writes: > When no midi port or only the midi-through port > is found, we can inform the user that midi > won't work as expected. This should probably use the winediag debug channel. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH v3 2/3] hlink/tests: Add tests for navigating from a string reference.
by Jacek Caban 28 Sep '17

28 Sep '17

Hi Zebediah, This test leaves iexplore instance running on Wine. Jacek

2 1

Re: [PATCH 2/9] sapi: Implement SpDataKey::SetKey().
by Marvin 28 Sep '17

28 Sep '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33314 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

2 1

Re: [PATCH 2/2] fonts: Increase the Em size to fix a build failure with freetype 2.8.1
by Dmitry Timoshkov 28 Sep '17

28 Sep '17

Michael Stefaniuc <mstefani(a)winehq.org> wrote: > -UnderlinePosition: -100 > -UnderlineWidth: 50 > -Ascent: 11 > -Descent: 2 > +UnderlinePosition: -15753.8 > +UnderlineWidth: 7876.92 > +Ascent: 1733 > +Descent: 315 > +InvalidEm: 0 > LayerCount: 2 > Layer: 0 0 "Back" 1 > Layer: 1 0 "Fore" 0 > @@ -21,7 +22,7 @@ OS2_UseTypoMetrics: 0 > PfmFamily: 49 > TTFWeight: 400 > TTFWidth: 5 > -LineGap: 1 > +LineGap: 158 > VLineGap: 0 > Panose: 2 0 6 9 0 0 0 0 0 0 > OS2TypoAscent: 0 > @@ -56,770 +57,770 @@ BeginChars: 65536 498 > > StartChar: space > Encoding: 32 32 0 > -Width: 8 > +Width: 1260 > Flags: W > LayerCount: 2 > EndChar > > StartChar: exclam > Encoding: 33 33 1 > -Width: 8 > +Width: 1260 > Flags: W > LayerCount: 2 > EndChar Did you test that after this patch font and glyph metrics still stay the same? -- Dmitry.

2 3

Re: [PATCH 9/9] sapi: Add a partial implementation of SpObjectTokenCategory::EnumTokens().
by Marvin 28 Sep '17

28 Sep '17

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33316 Your paranoid android. === build (build) === Recreation of tests/Makefile failed

1 0