April 2019 - Wine-devel - list.winehq.org

[PATCH 1/4] wined3d: Make the adapter responsible for creating devices.
by Józef Kucia 18 Apr '19

18 Apr '19

Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- dlls/wined3d/adapter_gl.c | 33 +++++++++++ dlls/wined3d/adapter_vk.c | 42 ++++++++++++++ dlls/wined3d/device.c | 100 +++++++++++++++++---------------- dlls/wined3d/directx.c | 50 +++++++++++++---- dlls/wined3d/wined3d_private.h | 10 +++- 5 files changed, 173 insertions(+), 62 deletions(-) diff --git a/dlls/wined3d/adapter_gl.c b/dlls/wined3d/adapter_gl.c index c195bf4993db..36c29c9a7f58 100644 --- a/dlls/wined3d/adapter_gl.c +++ b/dlls/wined3d/adapter_gl.c @@ -4246,6 +4246,37 @@ static void wined3d_adapter_init_fb_cfgs(struct wined3d_adapter_gl *adapter_gl, } } +static HRESULT adapter_gl_create_device(struct wined3d *wined3d, const struct wined3d_adapter *adapter, + enum wined3d_device_type device_type, HWND focus_window, unsigned int flags, BYTE surface_alignment, + const enum wined3d_feature_level *levels, unsigned int level_count, + struct wined3d_device_parent *device_parent, struct wined3d_device **device) +{ + struct wined3d_device_gl *device_gl; + HRESULT hr; + + if (!(device_gl = heap_alloc_zero(sizeof(*device_gl)))) + return E_OUTOFMEMORY; + + if (FAILED(hr = wined3d_device_init(&device_gl->d, wined3d, adapter->ordinal, device_type, + focus_window, flags, surface_alignment, levels, level_count, device_parent))) + { + WARN("Failed to initialize device, hr %#x.\n", hr); + heap_free(device_gl); + return hr; + } + + *device = &device_gl->d; + return WINED3D_OK; +} + +static void adapter_gl_destroy_device(struct wined3d_device *device) +{ + struct wined3d_device_gl *device_gl = wined3d_device_gl(device); + + wined3d_device_cleanup(&device_gl->d); + heap_free(device_gl); +} + static void adapter_gl_get_wined3d_caps(const struct wined3d_adapter *adapter, struct wined3d_caps *caps) { const struct wined3d_d3d_info *d3d_info = &adapter->d3d_info; @@ -4516,6 +4547,8 @@ static void adapter_gl_destroy(struct wined3d_adapter *adapter) static const struct wined3d_adapter_ops wined3d_adapter_gl_ops = { adapter_gl_destroy, + adapter_gl_create_device, + adapter_gl_destroy_device, wined3d_adapter_gl_create_context, adapter_gl_get_wined3d_caps, adapter_gl_check_format, diff --git a/dlls/wined3d/adapter_vk.c b/dlls/wined3d/adapter_vk.c index d8937c2983b4..848c02c52d3b 100644 --- a/dlls/wined3d/adapter_vk.c +++ b/dlls/wined3d/adapter_vk.c @@ -24,6 +24,16 @@ WINE_DEFAULT_DEBUG_CHANNEL(d3d); +struct wined3d_device_vk +{ + struct wined3d_device d; +}; + +static inline struct wined3d_device_vk *wined3d_device_vk(struct wined3d_device *device) +{ + return CONTAINING_RECORD(device, struct wined3d_device_vk, d); +} + static inline const struct wined3d_adapter_vk *wined3d_adapter_vk_const(const struct wined3d_adapter *adapter) { return CONTAINING_RECORD(adapter, struct wined3d_adapter_vk, a); @@ -96,6 +106,36 @@ static void adapter_vk_destroy(struct wined3d_adapter *adapter) heap_free(adapter_vk); } +static HRESULT adapter_vk_create_device(struct wined3d *wined3d, const struct wined3d_adapter *adapter, + enum wined3d_device_type device_type, HWND focus_window, unsigned int flags, BYTE surface_alignment, + const enum wined3d_feature_level *levels, unsigned int level_count, + struct wined3d_device_parent *device_parent, struct wined3d_device **device) +{ + struct wined3d_device_vk *device_vk; + HRESULT hr; + + if (!(device_vk = heap_alloc_zero(sizeof(*device_vk)))) + return E_OUTOFMEMORY; + + if (FAILED(hr = wined3d_device_init(&device_vk->d, wined3d, adapter->ordinal, device_type, + focus_window, flags, surface_alignment, levels, level_count, device_parent))) + { + WARN("Failed to initialize device, hr %#x.\n", hr); + heap_free(device_vk); + return hr; + } + + return WINED3D_OK; +} + +static void adapter_vk_destroy_device(struct wined3d_device *device) +{ + struct wined3d_device_vk *device_vk = wined3d_device_vk(device); + + wined3d_device_cleanup(device); + heap_free(device_vk); +} + static BOOL adapter_vk_create_context(struct wined3d_context *context, struct wined3d_texture *target, const struct wined3d_format *ds_format) { @@ -210,6 +250,8 @@ static BOOL adapter_vk_check_format(const struct wined3d_adapter *adapter, static const struct wined3d_adapter_ops wined3d_adapter_vk_ops = { adapter_vk_destroy, + adapter_vk_create_device, + adapter_vk_destroy_device, adapter_vk_create_context, adapter_vk_get_wined3d_caps, adapter_vk_check_format, diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 361ac6b1e360..23ba41c56b48 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -476,6 +476,54 @@ static void device_leftover_sampler(struct wine_rb_entry *entry, void *context) ERR("Leftover sampler %p.\n", sampler); } +void wined3d_device_cleanup(struct wined3d_device *device) +{ + unsigned int i; + + if (device->swapchain_count) + wined3d_device_uninit_3d(device); + + wined3d_stateblock_state_cleanup(&device->stateblock_state); + + wined3d_cs_destroy(device->cs); + + if (device->recording && wined3d_stateblock_decref(device->recording)) + ERR("Something's still holding the recording stateblock.\n"); + device->recording = NULL; + + state_cleanup(&device->state); + + for (i = 0; i < ARRAY_SIZE(device->multistate_funcs); ++i) + { + heap_free(device->multistate_funcs[i]); + device->multistate_funcs[i] = NULL; + } + + if (!list_empty(&device->resources)) + { + struct wined3d_resource *resource; + + ERR("Device released with resources still bound.\n"); + + LIST_FOR_EACH_ENTRY(resource, &device->resources, struct wined3d_resource, resource_list_entry) + { + ERR("Leftover resource %p with type %s (%#x).\n", + resource, debug_d3dresourcetype(resource->type), resource->type); + } + } + + if (device->contexts) + ERR("Context array not freed!\n"); + if (device->hardwareCursor) + DestroyCursor(device->hardwareCursor); + device->hardwareCursor = 0; + + wine_rb_destroy(&device->samplers, device_leftover_sampler, NULL); + + wined3d_decref(device->wined3d); + device->wined3d = NULL; +} + ULONG CDECL wined3d_device_decref(struct wined3d_device *device) { ULONG refcount = InterlockedDecrement(&device->ref); @@ -484,52 +532,8 @@ ULONG CDECL wined3d_device_decref(struct wined3d_device *device) if (!refcount) { - UINT i; - - if (device->swapchain_count) - wined3d_device_uninit_3d(device); - - wined3d_stateblock_state_cleanup(&device->stateblock_state); - - wined3d_cs_destroy(device->cs); - - if (device->recording && wined3d_stateblock_decref(device->recording)) - ERR("Something's still holding the recording stateblock.\n"); - device->recording = NULL; - - state_cleanup(&device->state); - - for (i = 0; i < ARRAY_SIZE(device->multistate_funcs); ++i) - { - heap_free(device->multistate_funcs[i]); - device->multistate_funcs[i] = NULL; - } - - if (!list_empty(&device->resources)) - { - struct wined3d_resource *resource; - - ERR("Device released with resources still bound.\n"); - - LIST_FOR_EACH_ENTRY(resource, &device->resources, struct wined3d_resource, resource_list_entry) - { - ERR("Leftover resource %p with type %s (%#x).\n", - resource, debug_d3dresourcetype(resource->type), resource->type); - } - } - - if (device->contexts) - ERR("Context array not freed!\n"); - if (device->hardwareCursor) - DestroyCursor(device->hardwareCursor); - device->hardwareCursor = 0; - - wine_rb_destroy(&device->samplers, device_leftover_sampler, NULL); - - wined3d_decref(device->wined3d); - device->wined3d = NULL; - heap_free(wined3d_device_gl(device)); - TRACE("Freed device %p.\n", device); + device->adapter->adapter_ops->adapter_destroy_device(device); + TRACE("Destroyed device %p.\n", device); } return refcount; @@ -5271,8 +5275,8 @@ static BOOL wined3d_select_feature_level(const struct wined3d_adapter *adapter, return FALSE; } -HRESULT device_init(struct wined3d_device *device, struct wined3d *wined3d, - UINT adapter_idx, enum wined3d_device_type device_type, HWND focus_window, DWORD flags, +HRESULT wined3d_device_init(struct wined3d_device *device, struct wined3d *wined3d, + unsigned int adapter_idx, enum wined3d_device_type device_type, HWND focus_window, unsigned int flags, BYTE surface_alignment, const enum wined3d_feature_level *levels, unsigned int level_count, struct wined3d_device_parent *device_parent) { diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index e21b8beaa884..3c89fad7d1a1 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -2169,7 +2169,8 @@ HRESULT CDECL wined3d_device_create(struct wined3d *wined3d, unsigned int adapte const enum wined3d_feature_level *feature_levels, unsigned int feature_level_count, struct wined3d_device_parent *device_parent, struct wined3d_device **device) { - struct wined3d_device_gl *device_gl; + const struct wined3d_adapter *adapter; + struct wined3d_device *object; HRESULT hr; TRACE("wined3d %p, adapter_idx %u, device_type %#x, focus_window %p, flags %#x, " @@ -2180,20 +2181,14 @@ HRESULT CDECL wined3d_device_create(struct wined3d *wined3d, unsigned int adapte if (adapter_idx >= wined3d->adapter_count) return WINED3DERR_INVALIDCALL; - if (!(device_gl = heap_alloc_zero(sizeof(*device_gl)))) - return E_OUTOFMEMORY; - - if (FAILED(hr = device_init(&device_gl->d, wined3d, adapter_idx, + adapter = wined3d->adapters[adapter_idx]; + if (FAILED(hr = adapter->adapter_ops->adapter_create_device(wined3d, adapter, device_type, focus_window, flags, surface_alignment, - feature_levels, feature_level_count, device_parent))) - { - WARN("Failed to initialize device, hr %#x.\n", hr); - heap_free(device_gl); + feature_levels, feature_level_count, device_parent, &object))) return hr; - } - TRACE("Created device %p.\n", device_gl); - *device = &device_gl->d; + TRACE("Created device %p.\n", object); + *device = object; device_parent->ops->wined3d_device_created(device_parent, *device); @@ -2206,6 +2201,35 @@ static void adapter_no3d_destroy(struct wined3d_adapter *adapter) heap_free(adapter); } +static HRESULT adapter_no3d_create_device(struct wined3d *wined3d, const struct wined3d_adapter *adapter, + enum wined3d_device_type device_type, HWND focus_window, unsigned int flags, BYTE surface_alignment, + const enum wined3d_feature_level *levels, unsigned int level_count, + struct wined3d_device_parent *device_parent, struct wined3d_device **device) +{ + struct wined3d_device *object; + HRESULT hr; + + if (!(object = heap_alloc_zero(sizeof(*object)))) + return E_OUTOFMEMORY; + + if (FAILED(hr = wined3d_device_init(object, wined3d, adapter->ordinal, device_type, + focus_window, flags, surface_alignment, levels, level_count, device_parent))) + { + WARN("Failed to initialize device, hr %#x.\n", hr); + heap_free(object); + return hr; + } + + *device = object; + return WINED3D_OK; +} + +static void adapter_no3d_destroy_device(struct wined3d_device *device) +{ + wined3d_device_cleanup(device); + heap_free(device); +} + static BOOL wined3d_adapter_no3d_create_context(struct wined3d_context *context, struct wined3d_texture *target, const struct wined3d_format *ds_format) { @@ -2226,6 +2250,8 @@ static BOOL adapter_no3d_check_format(const struct wined3d_adapter *adapter, static const struct wined3d_adapter_ops wined3d_adapter_no3d_ops = { adapter_no3d_destroy, + adapter_no3d_create_device, + adapter_no3d_destroy_device, wined3d_adapter_no3d_create_context, adapter_no3d_get_wined3d_caps, adapter_no3d_check_format, diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 9f63f3d8d628..15876e4f1edc 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2691,6 +2691,11 @@ void wined3d_driver_info_init(struct wined3d_driver_info *driver_info, struct wined3d_adapter_ops { void (*adapter_destroy)(struct wined3d_adapter *adapter); + HRESULT (*adapter_create_device)(struct wined3d *wined3d, const struct wined3d_adapter *adapter, + enum wined3d_device_type device_type, HWND focus_window, unsigned int flags, + BYTE surface_alignment, const enum wined3d_feature_level *levels, unsigned int level_count, + struct wined3d_device_parent *device_parent, struct wined3d_device **device); + void (*adapter_destroy_device)(struct wined3d_device *device); BOOL (*adapter_create_context)(struct wined3d_context *context, struct wined3d_texture *target, const struct wined3d_format *ds_format); void (*adapter_get_wined3d_caps)(const struct wined3d_adapter *adapter, struct wined3d_caps *caps); @@ -3163,13 +3168,14 @@ struct wined3d_device UINT context_count; }; +void wined3d_device_cleanup(struct wined3d_device *device) DECLSPEC_HIDDEN; void device_clear_render_targets(struct wined3d_device *device, UINT rt_count, const struct wined3d_fb_state *fb, UINT rect_count, const RECT *rects, const RECT *draw_rect, DWORD flags, const struct wined3d_color *color, float depth, DWORD stencil) DECLSPEC_HIDDEN; BOOL device_context_add(struct wined3d_device *device, struct wined3d_context *context) DECLSPEC_HIDDEN; void device_context_remove(struct wined3d_device *device, struct wined3d_context *context) DECLSPEC_HIDDEN; -HRESULT device_init(struct wined3d_device *device, struct wined3d *wined3d, - UINT adapter_idx, enum wined3d_device_type device_type, HWND focus_window, DWORD flags, +HRESULT wined3d_device_init(struct wined3d_device *device, struct wined3d *wined3d, + unsigned int adapter_idx, enum wined3d_device_type device_type, HWND focus_window, unsigned int flags, BYTE surface_alignment, const enum wined3d_feature_level *levels, unsigned int level_count, struct wined3d_device_parent *device_parent) DECLSPEC_HIDDEN; LRESULT device_process_message(struct wined3d_device *device, HWND window, BOOL unicode, -- 2.21.0

2 1

[PATCH 3/4] [resend] [v2] user32/tests: Use calculated WM_SETFONT margins in the CJK case.
by Akihiro Sagawa 18 Apr '19

18 Apr '19

Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/user32/tests/edit.c | 52 ++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 44 insertions(+), 8 deletions(-)

1 0

[PATCH 2/4] [resend] user32/tests: Remove win9x workarounds in margin tests.
by Akihiro Sagawa 18 Apr '19

18 Apr '19

Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/user32/tests/edit.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-)

1 0

[PATCH 1/4] [resend] user32/tests: Use GREEK_CHARSET in margin tests to avoid Associated Charset feature.
by Akihiro Sagawa 18 Apr '19

18 Apr '19

Due to Associated Charset feature, we currently use Chinese typeface in the test in zh_CN locale. For consistency with another locale, we should avoid the fature in tests. Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> --- dlls/user32/tests/edit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[PATCH vkd3d 4/8] tests: Introduce universal create_command_queue() helper.
by Józef Kucia 18 Apr '19

18 Apr '19

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- tests/d3d12.c | 123 +++++++++++++----------------------- tests/d3d12_invalid_usage.c | 9 +-- tests/d3d12_test_utils.h | 27 +++++--- tests/vkd3d_api.c | 23 +------ 4 files changed, 68 insertions(+), 114 deletions(-) diff --git a/tests/d3d12.c b/tests/d3d12.c index 0c19bf3289b8..148989b543b0 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -762,7 +762,6 @@ static ID3D12CommandSignature *create_command_signature_(unsigned int line, #define init_compute_test_context(context) init_compute_test_context_(__LINE__, context) static bool init_compute_test_context_(unsigned int line, struct test_context *context) { - D3D12_COMMAND_QUEUE_DESC command_queue_desc; ID3D12Device *device; HRESULT hr; @@ -775,21 +774,16 @@ static bool init_compute_test_context_(unsigned int line, struct test_context *c } device = context->device; - command_queue_desc.Type = D3D12_COMMAND_LIST_TYPE_COMPUTE; - command_queue_desc.Priority = D3D12_COMMAND_QUEUE_PRIORITY_NORMAL; - command_queue_desc.Flags = D3D12_COMMAND_QUEUE_FLAG_NONE; - command_queue_desc.NodeMask = 0; - hr = ID3D12Device_CreateCommandQueue(device, &command_queue_desc, - &IID_ID3D12CommandQueue, (void **)&context->queue); - ok_(line)(SUCCEEDED(hr), "Failed to create command queue, hr %#x.\n", hr); + context->queue = create_command_queue_(line, device, + D3D12_COMMAND_LIST_TYPE_COMPUTE, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); hr = ID3D12Device_CreateCommandAllocator(device, D3D12_COMMAND_LIST_TYPE_COMPUTE, &IID_ID3D12CommandAllocator, (void **)&context->allocator); - ok_(line)(SUCCEEDED(hr), "Failed to create command allocator, hr %#x.\n", hr); + ok_(line)(hr == S_OK, "Failed to create command allocator, hr %#x.\n", hr); hr = ID3D12Device_CreateCommandList(device, 0, D3D12_COMMAND_LIST_TYPE_COMPUTE, context->allocator, NULL, &IID_ID3D12GraphicsCommandList, (void **)&context->list); - ok_(line)(SUCCEEDED(hr), "Failed to create command list, hr %#x.\n", hr); + ok_(line)(hr == S_OK, "Failed to create command list, hr %#x.\n", hr); return true; } @@ -2753,7 +2747,6 @@ static void test_object_interface(void) { D3D12_DESCRIPTOR_HEAP_DESC descriptor_heap_desc; D3D12_QUERY_HEAP_DESC query_heap_desc; - D3D12_COMMAND_QUEUE_DESC queue_desc; ID3D12RootSignature *root_signature; ULONG refcount, expected_refcount; ID3D12CommandAllocator *allocator; @@ -2819,13 +2812,8 @@ static void test_object_interface(void) else if (IsEqualGUID(tests[i], &IID_ID3D12CommandQueue)) { vkd3d_test_set_context("command queue"); - queue_desc.Type = D3D12_COMMAND_LIST_TYPE_DIRECT; - queue_desc.Priority = D3D12_COMMAND_QUEUE_PRIORITY_NORMAL; - queue_desc.Flags = D3D12_COMMAND_QUEUE_FLAG_NONE; - queue_desc.NodeMask = 0; - hr = ID3D12Device_CreateCommandQueue(device, &queue_desc, - &IID_IUnknown, (void **)&unknown); - ok(hr == S_OK, "Failed to create command queue, hr %#x.\n", hr); + unknown = (IUnknown *)create_command_queue(device, + D3D12_COMMAND_LIST_TYPE_DIRECT, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); } else if (IsEqualGUID(tests[i], &IID_ID3D12CommandSignature)) { @@ -3578,7 +3566,6 @@ static void test_cpu_signal_fence(void) static void test_gpu_signal_fence(void) { - D3D12_COMMAND_QUEUE_DESC command_queue_desc; ID3D12CommandQueue *queue; HANDLE event1, event2; ID3D12Device *device; @@ -3594,30 +3581,24 @@ static void test_gpu_signal_fence(void) return; } - command_queue_desc.Type = D3D12_COMMAND_LIST_TYPE_DIRECT; - command_queue_desc.Priority = D3D12_COMMAND_QUEUE_PRIORITY_NORMAL; - command_queue_desc.Flags = D3D12_COMMAND_QUEUE_FLAG_NONE; - command_queue_desc.NodeMask = 0; - hr = ID3D12Device_CreateCommandQueue(device, &command_queue_desc, - &IID_ID3D12CommandQueue, (void **)&queue); - ok(SUCCEEDED(hr), "Failed to create command queue, hr %#x.\n", hr); + queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_DIRECT, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); hr = ID3D12Device_CreateFence(device, 0, D3D12_FENCE_FLAG_NONE, &IID_ID3D12Fence, (void **)&fence); - ok(SUCCEEDED(hr), "Failed to create fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to create fence, hr %#x.\n", hr); /* XXX: It seems that when a queue is idle a fence is signalled immediately * in D3D12. Vulkan implementations don't signal a fence immediately so * libvkd3d doesn't as well. In order to make this test reliable * wait_queue_idle() is inserted after every ID3D12CommandQueue_Signal(). */ hr = ID3D12CommandQueue_Signal(queue, fence, 10); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); value = ID3D12Fence_GetCompletedValue(fence); ok(value == 10, "Got unexpected value %"PRIu64".\n", value); hr = ID3D12CommandQueue_Signal(queue, fence, 0); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); value = ID3D12Fence_GetCompletedValue(fence); ok(value == 0, "Got unexpected value %"PRIu64".\n", value); @@ -3629,11 +3610,11 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12Fence_SetEventOnCompletion(fence, 5, event1); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, 5); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_OBJECT_0, "Got unexpected return value %#x.\n", ret); @@ -3641,11 +3622,11 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12Fence_SetEventOnCompletion(fence, 6, event1); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, 7); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_OBJECT_0, "Got unexpected return value %#x.\n", ret); @@ -3653,34 +3634,34 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, 10); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); /* Attach one event to multiple values. */ hr = ID3D12CommandQueue_Signal(queue, fence, 0); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12Fence_SetEventOnCompletion(fence, 3, event1); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); hr = ID3D12Fence_SetEventOnCompletion(fence, 5, event1); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); hr = ID3D12Fence_SetEventOnCompletion(fence, 9, event1); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); hr = ID3D12Fence_SetEventOnCompletion(fence, 12, event1); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); hr = ID3D12Fence_SetEventOnCompletion(fence, 12, event1); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); for (i = 1; i < 13; ++i) { hr = ID3D12CommandQueue_Signal(queue, fence, i); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); if (i == 3 || i == 5 || i == 9 || i == 12) { @@ -3693,7 +3674,7 @@ static void test_gpu_signal_fence(void) /* Tests with 2 events. */ hr = ID3D12CommandQueue_Signal(queue, fence, 0); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); value = ID3D12Fence_GetCompletedValue(fence); ok(value == 0, "Got unexpected value %"PRIu64".\n", value); @@ -3706,12 +3687,12 @@ static void test_gpu_signal_fence(void) ret = wait_event(event2, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12Fence_SetEventOnCompletion(fence, 100, event1); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); hr = ID3D12Fence_SetEventOnCompletion(fence, ~(UINT64)0, event2); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); hr = ID3D12CommandQueue_Signal(queue, fence, 50); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); @@ -3719,7 +3700,7 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, 99); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); @@ -3727,7 +3708,7 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, 100); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_OBJECT_0, "Got unexpected return value %#x.\n", ret); @@ -3737,7 +3718,7 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, 101); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); @@ -3745,7 +3726,7 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, 0); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); @@ -3753,7 +3734,7 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, 100); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); @@ -3761,7 +3742,7 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, ~(UINT64)0); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); @@ -3771,14 +3752,14 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, ~(UINT64)0); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); ret = wait_event(event2, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, 0); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); @@ -3787,7 +3768,7 @@ static void test_gpu_signal_fence(void) /* Attach two events to the same value. */ hr = ID3D12CommandQueue_Signal(queue, fence, 0); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); @@ -3795,15 +3776,15 @@ static void test_gpu_signal_fence(void) ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12Fence_SetEventOnCompletion(fence, 1, event1); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); hr = ID3D12Fence_SetEventOnCompletion(fence, 1, event2); - ok(SUCCEEDED(hr), "Failed to set event on completion, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); ret = wait_event(event1, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); ret = wait_event(event2, 0); ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, fence, 3); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); wait_queue_idle(device, queue); ret = wait_event(event1, 0); ok(ret == WAIT_OBJECT_0, "Got unexpected return value %#x.\n", ret); @@ -3866,7 +3847,6 @@ static void fence_busy_wait_main(void *untyped_data) static void test_multithread_fence_wait(void) { struct multithread_fence_wait_data thread_data; - D3D12_COMMAND_QUEUE_DESC command_queue_desc; ID3D12CommandQueue *queue; ID3D12Device *device; unsigned int ret; @@ -3880,20 +3860,14 @@ static void test_multithread_fence_wait(void) return; } - command_queue_desc.Type = D3D12_COMMAND_LIST_TYPE_DIRECT; - command_queue_desc.Priority = D3D12_COMMAND_QUEUE_PRIORITY_NORMAL; - command_queue_desc.Flags = D3D12_COMMAND_QUEUE_FLAG_NONE; - command_queue_desc.NodeMask = 0; - hr = ID3D12Device_CreateCommandQueue(device, &command_queue_desc, - &IID_ID3D12CommandQueue, (void **)&queue); - ok(SUCCEEDED(hr), "Failed to create command queue, hr %#x.\n", hr); + queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_DIRECT, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); thread_data.event = create_event(); thread_data.value = 0; ok(thread_data.event, "Failed to create event.\n"); hr = ID3D12Device_CreateFence(device, thread_data.value, D3D12_FENCE_FLAG_NONE, &IID_ID3D12Fence, (void **)&thread_data.fence); - ok(SUCCEEDED(hr), "Failed to create fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to create fence, hr %#x.\n", hr); /* Signal fence on host. */ ++thread_data.value; @@ -3903,7 +3877,7 @@ static void test_multithread_fence_wait(void) ok(ret == WAIT_OBJECT_0, "Failed to wait for thread start, return value %#x.\n", ret); hr = ID3D12Fence_Signal(thread_data.fence, thread_data.value); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); ok(join_thread(thread), "Failed to join thread.\n"); @@ -3914,7 +3888,7 @@ static void test_multithread_fence_wait(void) ok(ret == WAIT_OBJECT_0, "Failed to wait for thread start, return value %#x.\n", ret); hr = ID3D12Fence_Signal(thread_data.fence, thread_data.value); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); ok(join_thread(thread), "Failed to join thread.\n"); @@ -3926,7 +3900,7 @@ static void test_multithread_fence_wait(void) ok(ret == WAIT_OBJECT_0, "Failed to wait for thread start, return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, thread_data.fence, thread_data.value); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); ok(join_thread(thread), "Failed to join thread.\n"); @@ -3937,7 +3911,7 @@ static void test_multithread_fence_wait(void) ok(ret == WAIT_OBJECT_0, "Failed to wait for thread start, return value %#x.\n", ret); hr = ID3D12CommandQueue_Signal(queue, thread_data.fence, thread_data.value); - ok(SUCCEEDED(hr), "Failed to signal fence, hr %#x.\n", hr); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); ok(join_thread(thread), "Failed to join thread.\n"); @@ -5740,7 +5714,6 @@ static void test_draw_uav_only(void) static void test_texture_resource_barriers(void) { - D3D12_COMMAND_QUEUE_DESC command_queue_desc; ID3D12CommandAllocator *command_allocator; ID3D12GraphicsCommandList *command_list; D3D12_RESOURCE_BARRIER barriers[8]; @@ -5756,13 +5729,7 @@ static void test_texture_resource_barriers(void) return; } - command_queue_desc.Type = D3D12_COMMAND_LIST_TYPE_DIRECT; - command_queue_desc.Priority = D3D12_COMMAND_QUEUE_PRIORITY_NORMAL; - command_queue_desc.Flags = D3D12_COMMAND_QUEUE_FLAG_NONE; - command_queue_desc.NodeMask = 0; - hr = ID3D12Device_CreateCommandQueue(device, &command_queue_desc, - &IID_ID3D12CommandQueue, (void **)&queue); - ok(SUCCEEDED(hr), "Failed to create command queue, hr %#x.\n", hr); + queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_DIRECT, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); hr = ID3D12Device_CreateCommandAllocator(device, D3D12_COMMAND_LIST_TYPE_DIRECT, &IID_ID3D12CommandAllocator, (void **)&command_allocator); diff --git a/tests/d3d12_invalid_usage.c b/tests/d3d12_invalid_usage.c index 69ffda64fdba..ab5deb5b1e11 100644 --- a/tests/d3d12_invalid_usage.c +++ b/tests/d3d12_invalid_usage.c @@ -35,7 +35,6 @@ static void recreate_command_list_(unsigned int line, ID3D12Device *device, static void test_invalid_texture_resource_barriers(void) { ID3D12Resource *texture, *readback_buffer, *upload_buffer; - D3D12_COMMAND_QUEUE_DESC command_queue_desc; ID3D12CommandAllocator *command_allocator; ID3D12GraphicsCommandList *command_list; ID3D12CommandQueue *queue; @@ -49,13 +48,7 @@ static void test_invalid_texture_resource_barriers(void) return; } - command_queue_desc.Type = D3D12_COMMAND_LIST_TYPE_DIRECT; - command_queue_desc.Priority = D3D12_COMMAND_QUEUE_PRIORITY_NORMAL; - command_queue_desc.Flags = D3D12_COMMAND_QUEUE_FLAG_NONE; - command_queue_desc.NodeMask = 0; - hr = ID3D12Device_CreateCommandQueue(device, &command_queue_desc, - &IID_ID3D12CommandQueue, (void **)&queue); - ok(hr == S_OK, "Failed to create command queue, hr %#x.\n", hr); + queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_DIRECT, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); hr = ID3D12Device_CreateCommandAllocator(device, D3D12_COMMAND_LIST_TYPE_DIRECT, &IID_ID3D12CommandAllocator, (void **)&command_allocator); diff --git a/tests/d3d12_test_utils.h b/tests/d3d12_test_utils.h index 6eb9ceae5576..22ab9e7fcfb4 100644 --- a/tests/d3d12_test_utils.h +++ b/tests/d3d12_test_utils.h @@ -214,6 +214,24 @@ static void transition_sub_resource_state(ID3D12GraphicsCommandList *list, ID3D1 ID3D12GraphicsCommandList_ResourceBarrier(list, 1, &barrier); } +#define create_command_queue(a, b, c) create_command_queue_(__LINE__, a, b, c) +static inline ID3D12CommandQueue *create_command_queue_(unsigned int line, ID3D12Device *device, + D3D12_COMMAND_LIST_TYPE type, int priority) +{ + D3D12_COMMAND_QUEUE_DESC queue_desc; + ID3D12CommandQueue *queue; + HRESULT hr; + + queue_desc.Type = type; + queue_desc.Priority = priority; + queue_desc.Flags = D3D12_COMMAND_QUEUE_FLAG_NONE; + queue_desc.NodeMask = 0; + hr = ID3D12Device_CreateCommandQueue(device, &queue_desc, &IID_ID3D12CommandQueue, (void **)&queue); + ok_(line)(hr == S_OK, "Failed to create command queue, hr %#x.\n", hr); + + return queue; +} + static void transition_resource_state(ID3D12GraphicsCommandList *list, ID3D12Resource *resource, D3D12_RESOURCE_STATES state_before, D3D12_RESOURCE_STATES state_after) { @@ -743,7 +761,6 @@ static void create_render_target_(unsigned int line, struct test_context *contex static inline bool init_test_context_(unsigned int line, struct test_context *context, const struct test_context_desc *desc) { - D3D12_COMMAND_QUEUE_DESC command_queue_desc; D3D12_DESCRIPTOR_HEAP_DESC rtv_heap_desc; ID3D12Device *device; HRESULT hr; @@ -757,13 +774,7 @@ static inline bool init_test_context_(unsigned int line, struct test_context *co } device = context->device; - command_queue_desc.Type = D3D12_COMMAND_LIST_TYPE_DIRECT; - command_queue_desc.Priority = D3D12_COMMAND_QUEUE_PRIORITY_NORMAL; - command_queue_desc.Flags = D3D12_COMMAND_QUEUE_FLAG_NONE; - command_queue_desc.NodeMask = 0; - hr = ID3D12Device_CreateCommandQueue(device, &command_queue_desc, - &IID_ID3D12CommandQueue, (void **)&context->queue); - ok_(line)(SUCCEEDED(hr), "Failed to create command queue, hr %#x.\n", hr); + context->queue = create_command_queue_(line, device, D3D12_COMMAND_LIST_TYPE_DIRECT, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); hr = ID3D12Device_CreateCommandAllocator(device, D3D12_COMMAND_LIST_TYPE_DIRECT, &IID_ID3D12CommandAllocator, (void **)&context->allocator); diff --git a/tests/vkd3d_api.c b/tests/vkd3d_api.c index 0bc481775f77..14d0914512bc 100644 --- a/tests/vkd3d_api.c +++ b/tests/vkd3d_api.c @@ -82,23 +82,6 @@ static ID3D12Device *create_device(void) return SUCCEEDED(hr) ? device : NULL; } -static ID3D12CommandQueue *create_command_queue(ID3D12Device *device, - D3D12_COMMAND_LIST_TYPE type) -{ - D3D12_COMMAND_QUEUE_DESC desc; - ID3D12CommandQueue *queue; - HRESULT hr; - - desc.Type = type; - desc.Priority = D3D12_COMMAND_QUEUE_PRIORITY_NORMAL; - desc.Flags = D3D12_COMMAND_QUEUE_FLAG_NONE; - desc.NodeMask = 0; - hr = ID3D12Device_CreateCommandQueue(device, &desc, - &IID_ID3D12CommandQueue, (void **)&queue); - ok(hr == S_OK, "Failed to create command queue, hr %#x.\n", hr); - return queue; -} - static void test_create_instance(void) { struct vkd3d_instance_create_info create_info; @@ -699,11 +682,11 @@ static void test_vkd3d_queue(void) device = create_device(); ok(device, "Failed to create device.\n"); - direct_queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_DIRECT); + direct_queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_DIRECT, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); ok(direct_queue, "Failed to create direct command queue.\n"); - compute_queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_COMPUTE); + compute_queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_COMPUTE, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); ok(compute_queue, "Failed to create compute command queue.\n"); - copy_queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_COPY); + copy_queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_COPY, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); ok(copy_queue, "Failed to create copy command queue.\n"); vk_queue_family = vkd3d_get_vk_queue_family_index(direct_queue); -- 2.21.0

2 1

[PATCH vkd3d 2/8] vkd3d: Signal Vulkan semaphore in d3d12_command_queue_Signal().
by Józef Kucia 18 Apr '19

18 Apr '19

From: Józef Kucia <jkucia(a)codeweavers.com> For d3d12_command_queue_Wait(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- libs/vkd3d/command.c | 219 ++++++++++++++++++++++++++++++++++--- libs/vkd3d/vkd3d_private.h | 9 ++ 2 files changed, 212 insertions(+), 16 deletions(-) diff --git a/libs/vkd3d/command.c b/libs/vkd3d/command.c index 6c9b145fc522..0d30f430367a 100644 --- a/libs/vkd3d/command.c +++ b/libs/vkd3d/command.c @@ -80,6 +80,29 @@ void vkd3d_queue_release(struct vkd3d_queue *queue) pthread_mutex_unlock(&queue->mutex); } +static VkResult vkd3d_queue_wait_idle(struct vkd3d_queue *queue, + const struct vkd3d_vk_device_procs *vk_procs) +{ + VkQueue vk_queue; + VkResult vr; + + if ((vk_queue = vkd3d_queue_acquire(queue))) + { + vr = VK_CALL(vkQueueWaitIdle(vk_queue)); + vkd3d_queue_release(queue); + + if (vr < 0) + WARN("Failed to wait for queue, vr %d.\n", vr); + } + else + { + ERR("Failed to acquire queue %p.\n", queue); + vr = VK_ERROR_OUT_OF_HOST_MEMORY; + } + + return vr; +} + /* Fence worker thread */ static HRESULT vkd3d_enqueue_gpu_fence(struct vkd3d_fence_worker *worker, VkFence vk_fence, struct d3d12_fence *fence, uint64_t value) @@ -377,6 +400,104 @@ static struct d3d12_fence *impl_from_ID3D12Fence(ID3D12Fence *iface) return CONTAINING_RECORD(iface, struct d3d12_fence, ID3D12Fence_iface); } +#define VKD3D_MAX_VK_SEMAPHORE_COUNT_PER_D3D12_FENCE 4 + +static void d3d12_fence_destroy_vk_semaphores_locked(struct d3d12_fence *fence, bool destroy_all) +{ + struct d3d12_device *device = fence->device; + const struct vkd3d_vk_device_procs *vk_procs = &device->vk_procs; + VkSemaphore vk_semaphore; + size_t semaphore_count; + unsigned int i, j; + + semaphore_count = fence->semaphore_count; + if (!destroy_all && fence->semaphore_count < VKD3D_MAX_VK_SEMAPHORE_COUNT_PER_D3D12_FENCE) + return; + + for (i = 0, j = 0; i < fence->semaphore_count; ++i) + { + if (!destroy_all && semaphore_count < VKD3D_MAX_VK_SEMAPHORE_COUNT_PER_D3D12_FENCE) + break; + + /* The semaphore doesn't have a pending signal operation if the fence + * was signaled. */ + if (!fence->semaphores[i].vk_fence || destroy_all) + { + vk_semaphore = fence->semaphores[i].vk_semaphore; + if (fence->semaphores[i].vk_fence) + WARN("Destroying potentially pending semaphore.\n"); + VK_CALL(vkDestroySemaphore(device->vk_device, vk_semaphore, NULL)); + --semaphore_count; + } + else + { + if (i != j) + fence->semaphores[j] = fence->semaphores[i]; + ++j; + } + } + for (; i < fence->semaphore_count; ++i) + { + fence->semaphores[j++] = fence->semaphores[i]; + } + + if (j != fence->semaphore_count) + TRACE("Destroyed %zu Vulkan semaphores.\n", fence->semaphore_count - j); + + fence->semaphore_count = j; +} + +static void d3d12_fence_destroy_vk_semaphores(struct d3d12_fence *fence) +{ + int rc; + + if ((rc = pthread_mutex_lock(&fence->mutex))) + { + ERR("Failed to lock mutex, error %d.\n", rc); + return; + } + + d3d12_fence_destroy_vk_semaphores_locked(fence, true); + + pthread_mutex_unlock(&fence->mutex); +} + +static HRESULT d3d12_fence_add_vk_semaphore(struct d3d12_fence *fence, + VkSemaphore vk_semaphore, VkFence vk_fence, uint64_t value) +{ + HRESULT hr = S_OK; + int rc; + + TRACE("fence %p, value %#"PRIx64".\n", fence, value); + + if ((rc = pthread_mutex_lock(&fence->mutex))) + { + ERR("Failed to lock mutex, error %d.\n", rc); + return E_FAIL; + } + + /* Destroy old Vulkan semaphores. */ + d3d12_fence_destroy_vk_semaphores_locked(fence, false); + + if (vkd3d_array_reserve((void **)&fence->semaphores, &fence->semaphores_size, + fence->semaphore_count + 1, sizeof(*fence->semaphores))) + { + fence->semaphores[fence->semaphore_count].value = value; + fence->semaphores[fence->semaphore_count].vk_semaphore = vk_semaphore; + fence->semaphores[fence->semaphore_count].vk_fence = vk_fence; + ++fence->semaphore_count; + } + else + { + ERR("Failed to add semaphore.\n"); + hr = E_OUTOFMEMORY; + } + + pthread_mutex_unlock(&fence->mutex); + + return hr; +} + static HRESULT d3d12_fence_signal(struct d3d12_fence *fence, uint64_t value, VkFence vk_fence) { struct d3d12_device *device = fence->device; @@ -414,6 +535,17 @@ static HRESULT d3d12_fence_signal(struct d3d12_fence *fence, uint64_t value, VkF } fence->event_count = j; + if (vk_fence) + { + for (i = 0; i < fence->semaphore_count; ++i) + { + struct vkd3d_signaled_semaphore *current = &fence->semaphores[i]; + + if (current->vk_fence == vk_fence) + current->vk_fence = VK_NULL_HANDLE; + } + } + pthread_mutex_unlock(&fence->mutex); return S_OK; @@ -467,6 +599,10 @@ static ULONG STDMETHODCALLTYPE d3d12_fence_Release(ID3D12Fence *iface) vkd3d_fence_worker_remove_fence(&device->fence_worker, fence); + /* Destroy all Vulkan semaphores associated with this fence. */ + d3d12_fence_destroy_vk_semaphores(fence); + vkd3d_free(fence->semaphores); + vkd3d_free(fence->events); if ((rc = pthread_mutex_destroy(&fence->mutex))) ERR("Failed to destroy mutex, error %d.\n", rc); @@ -656,6 +792,9 @@ static HRESULT d3d12_fence_init(struct d3d12_fence *fence, struct d3d12_device * fence->events = NULL; fence->events_size = 0; fence->event_count = 0; + fence->semaphores = NULL; + fence->semaphores_size = 0; + fence->semaphore_count = 0; if (FAILED(hr = vkd3d_private_store_init(&fence->private_store))) { @@ -4915,58 +5054,106 @@ static HRESULT STDMETHODCALLTYPE d3d12_command_queue_Signal(ID3D12CommandQueue * { struct d3d12_command_queue *command_queue = impl_from_ID3D12CommandQueue(iface); const struct vkd3d_vk_device_procs *vk_procs; + VkSemaphore vk_semaphore = VK_NULL_HANDLE; + VkSemaphoreCreateInfo semaphore_info; + VkFence vk_fence = VK_NULL_HANDLE; VkFenceCreateInfo fence_info; struct d3d12_device *device; struct d3d12_fence *fence; - VkFence vk_fence; + VkSubmitInfo submit_info; VkQueue vk_queue; VkResult vr; + HRESULT hr; TRACE("iface %p, fence %p, value %#"PRIx64".\n", iface, fence_iface, value); device = command_queue->device; vk_procs = &device->vk_procs; + /* XXX: It may be a good idea to re-use Vulkan fences/semaphores. */ + fence = unsafe_impl_from_ID3D12Fence(fence_iface); fence_info.sType = VK_STRUCTURE_TYPE_FENCE_CREATE_INFO; fence_info.pNext = NULL; fence_info.flags = 0; - - /* XXX: It may be a good idea to re-use Vulkan fences. */ if ((vr = VK_CALL(vkCreateFence(device->vk_device, &fence_info, NULL, &vk_fence))) < 0) { WARN("Failed to create Vulkan fence, vr %d.\n", vr); - return hresult_from_vk_result(vr); + vk_fence = VK_NULL_HANDLE; + goto fail_vkresult; } + semaphore_info.sType = VK_STRUCTURE_TYPE_SEMAPHORE_CREATE_INFO; + semaphore_info.pNext = NULL; + semaphore_info.flags = 0; + if ((vr = VK_CALL(vkCreateSemaphore(device->vk_device, &semaphore_info, NULL, &vk_semaphore))) < 0) + { + WARN("Failed to create Vulkan semaphore, vr %d.\n", vr); + vk_semaphore = VK_NULL_HANDLE; + goto fail_vkresult; + } + + submit_info.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO; + submit_info.pNext = NULL; + submit_info.waitSemaphoreCount = 0; + submit_info.pWaitSemaphores = NULL; + submit_info.pWaitDstStageMask = NULL; + submit_info.commandBufferCount = 0; + submit_info.pCommandBuffers = NULL; + submit_info.signalSemaphoreCount = 1; + submit_info.pSignalSemaphores = &vk_semaphore; + if (!(vk_queue = vkd3d_queue_acquire(command_queue->vkd3d_queue))) { ERR("Failed to acquire queue %p.\n", command_queue->vkd3d_queue); - return E_FAIL; + hr = E_FAIL; + goto fail; } - vr = VK_CALL(vkQueueSubmit(vk_queue, 0, NULL, vk_fence)); + vr = VK_CALL(vkQueueSubmit(vk_queue, 1, &submit_info, vk_fence)); vkd3d_queue_release(command_queue->vkd3d_queue); if (vr < 0) { - WARN("Failed to submit fence, vr %d.\n", vr); - VK_CALL(vkDestroyFence(device->vk_device, vk_fence, NULL)); - return hresult_from_vk_result(vr); + WARN("Failed to submit, vr %d.\n", vr); + goto fail_vkresult; } + if (SUCCEEDED(hr = d3d12_fence_add_vk_semaphore(fence, vk_semaphore, vk_fence, value))) + vk_semaphore = VK_NULL_HANDLE; + vr = VK_CALL(vkGetFenceStatus(device->vk_device, vk_fence)); - if (vr == VK_SUCCESS) + if (vr == VK_NOT_READY) { - return d3d12_fence_signal(fence, value, vk_fence); + if (SUCCEEDED(hr = vkd3d_enqueue_gpu_fence(&device->fence_worker, vk_fence, fence, value))) + vk_fence = VK_NULL_HANDLE; } - if (vr != VK_NOT_READY) + else if (vr == VK_SUCCESS) { - WARN("Failed to get fence status, vr %d.\n", vr); - VK_CALL(vkDestroyFence(device->vk_device, vk_fence, NULL)); - return hresult_from_vk_result(vr); + TRACE("Already signaled %p, value %#"PRIx64".\n", fence, value); + hr = d3d12_fence_signal(fence, value, vk_fence); + vk_fence = VK_NULL_HANDLE; + } + else + { + FIXME("Failed to get fence status, vr %d.\n", vr); + hr = hresult_from_vk_result(vr); } - return vkd3d_enqueue_gpu_fence(&device->fence_worker, vk_fence, fence, value); + if (vk_fence || vk_semaphore) + { + /* In case of an unexpected failure, try to safely destroy Vulkan objects. */ + vkd3d_queue_wait_idle(command_queue->vkd3d_queue, vk_procs); + goto fail; + } + + return hr; + +fail_vkresult: + hr = hresult_from_vk_result(vr); +fail: + VK_CALL(vkDestroyFence(device->vk_device, vk_fence, NULL)); + VK_CALL(vkDestroySemaphore(device->vk_device, vk_semaphore, NULL)); + return hr; } static HRESULT STDMETHODCALLTYPE d3d12_command_queue_Wait(ID3D12CommandQueue *iface, diff --git a/libs/vkd3d/vkd3d_private.h b/libs/vkd3d/vkd3d_private.h index 68a51c0d85d6..3ca80c0c3031 100644 --- a/libs/vkd3d/vkd3d_private.h +++ b/libs/vkd3d/vkd3d_private.h @@ -260,6 +260,15 @@ struct d3d12_fence size_t events_size; size_t event_count; + struct vkd3d_signaled_semaphore + { + uint64_t value; + VkSemaphore vk_semaphore; + VkFence vk_fence; + } *semaphores; + size_t semaphores_size; + size_t semaphore_count; + struct d3d12_device *device; struct vkd3d_private_store private_store; -- 2.21.0

2 1

[PATCH vkd3d 8/8] vkd3d: Reject D3D12_COMMAND_QUEUE_PRIORITY_GLOBAL_REALTIME.
by Józef Kucia 18 Apr '19

18 Apr '19

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- include/vkd3d_d3d12.idl | 1 + libs/vkd3d/command.c | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/include/vkd3d_d3d12.idl b/include/vkd3d_d3d12.idl index 3cefd1fdb33f..ec78c6652109 100644 --- a/include/vkd3d_d3d12.idl +++ b/include/vkd3d_d3d12.idl @@ -1547,6 +1547,7 @@ typedef enum D3D12_COMMAND_QUEUE_PRIORITY { D3D12_COMMAND_QUEUE_PRIORITY_NORMAL = 0, D3D12_COMMAND_QUEUE_PRIORITY_HIGH = 100, + D3D12_COMMAND_QUEUE_PRIORITY_GLOBAL_REALTIME = 10000, } D3D12_COMMAND_QUEUE_PRIORITY; typedef enum D3D12_COMMAND_QUEUE_FLAGS diff --git a/libs/vkd3d/command.c b/libs/vkd3d/command.c index 7b4daa4c0564..cdccfe8dca56 100644 --- a/libs/vkd3d/command.c +++ b/libs/vkd3d/command.c @@ -5301,6 +5301,12 @@ static HRESULT d3d12_command_queue_init(struct d3d12_command_queue *queue, if (!(queue->vkd3d_queue = d3d12_device_get_vkd3d_queue(device, desc->Type))) return E_NOTIMPL; + if (desc->Priority == D3D12_COMMAND_QUEUE_PRIORITY_GLOBAL_REALTIME) + { + FIXME("Global realtime priority is not implemented.\n"); + return E_NOTIMPL; + } + if (desc->Priority) FIXME("Ignoring priority %#x.\n", desc->Priority); if (desc->Flags) -- 2.21.0

2 1

[PATCH vkd3d 7/8] tests: Add test for ID3D12CommandQueue_Wait().
by Józef Kucia 18 Apr '19

18 Apr '19

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- tests/d3d12.c | 252 +++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 251 insertions(+), 1 deletion(-) diff --git a/tests/d3d12.c b/tests/d3d12.c index d44fff02b998..d37223855a7c 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -303,6 +303,27 @@ static const DXGI_FORMAT depth_stencil_formats[] = DXGI_FORMAT_D16_UNORM, }; +static void init_readback(struct resource_readback *rb, ID3D12Resource *buffer, + uint64_t buffer_size, uint64_t width, uint64_t height, unsigned int depth, uint64_t row_pitch) +{ + D3D12_RANGE read_range; + HRESULT hr; + + rb->width = width; + rb->height = height; + rb->depth = depth; + rb->resource = buffer; + rb->row_pitch = row_pitch; + rb->data = NULL; + + ID3D12Resource_AddRef(rb->resource); + + read_range.Begin = 0; + read_range.End = buffer_size; + hr = ID3D12Resource_Map(rb->resource, 0, &read_range, &rb->data); + ok(hr == S_OK, "Failed to map readback buffer, hr %#x.\n", hr); +} + static void get_buffer_readback_with_command_list(ID3D12Resource *buffer, DXGI_FORMAT format, struct resource_readback *rb, ID3D12CommandQueue *queue, ID3D12GraphicsCommandList *command_list) { @@ -6275,7 +6296,7 @@ static void test_bundle_state_inheritance(void) if (!vkd3d_test_platform_is_windows()) { - /* Avoid 2048 test todos. */ + /* FIXME: Avoid 2048 test todos. */ skip("Bundles are not implemented yet.\n"); return; } @@ -27581,6 +27602,234 @@ done: destroy_test_context(&context); } +static void test_queue_wait(void) +{ + D3D12_TEXTURE_COPY_LOCATION dst_location, src_location; + ID3D12GraphicsCommandList *command_list; + ID3D12Resource *readback_buffer, *cb; + ID3D12CommandQueue *queue, *queue2; + D3D12_RESOURCE_DESC resource_desc; + uint64_t row_pitch, buffer_size; + struct test_context_desc desc; + struct resource_readback rb; + ID3D12Fence *fence, *fence2; + struct test_context context; + ID3D12Device *device; + unsigned int ret; + uint64_t value; + float color[4]; + HANDLE event; + HRESULT hr; + + static const float blue[] = {0.0f, 0.0f, 1.0f, 1.0f}; + static const float green[] = {0.0f, 1.0f, 0.0f, 1.0f}; + static const float white[] = {1.0f, 1.0f, 1.0f, 1.0f}; + static const DWORD ps_code[] = + { +#if 0 + float4 color; + + float4 main(float4 position : SV_POSITION) : SV_Target + { + return color; + } +#endif + 0x43425844, 0xd18ead43, 0x8b8264c1, 0x9c0a062d, 0xfc843226, 0x00000001, 0x000000e0, 0x00000003, + 0x0000002c, 0x00000060, 0x00000094, 0x4e475349, 0x0000002c, 0x00000001, 0x00000008, 0x00000020, + 0x00000000, 0x00000001, 0x00000003, 0x00000000, 0x0000000f, 0x505f5653, 0x5449534f, 0x004e4f49, + 0x4e47534f, 0x0000002c, 0x00000001, 0x00000008, 0x00000020, 0x00000000, 0x00000000, 0x00000003, + 0x00000000, 0x0000000f, 0x545f5653, 0x65677261, 0xabab0074, 0x58454853, 0x00000044, 0x00000050, + 0x00000011, 0x0100086a, 0x04000059, 0x00208e46, 0x00000000, 0x00000001, 0x03000065, 0x001020f2, + 0x00000000, 0x06000036, 0x001020f2, 0x00000000, 0x00208e46, 0x00000000, 0x00000000, 0x0100003e, + }; + static const D3D12_SHADER_BYTECODE ps = {ps_code, sizeof(ps_code)}; + + memset(&desc, 0, sizeof(desc)); + desc.no_root_signature = true; + if (!init_test_context(&context, &desc)) + return; + device = context.device; + command_list = context.list; + queue = context.queue; + + queue2 = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_DIRECT, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); + + event = create_event(); + ok(event, "Failed to create event.\n"); + + hr = ID3D12Device_CreateFence(device, 1, D3D12_FENCE_FLAG_NONE, &IID_ID3D12Fence, (void **)&fence); + ok(hr == S_OK, "Failed to create fence, hr %#x.\n", hr); + hr = ID3D12Device_CreateFence(device, 0, D3D12_FENCE_FLAG_NONE, &IID_ID3D12Fence, (void **)&fence2); + ok(hr == S_OK, "Failed to create fence, hr %#x.\n", hr); + + context.root_signature = create_cb_root_signature(context.device, + 0, D3D12_SHADER_VISIBILITY_PIXEL, D3D12_ROOT_SIGNATURE_FLAG_NONE); + context.pipeline_state = create_pipeline_state(context.device, + context.root_signature, context.render_target_desc.Format, NULL, &ps, NULL); + + cb = create_upload_buffer(device, sizeof(color), NULL); + + resource_desc = ID3D12Resource_GetDesc(context.render_target); + + row_pitch = align(resource_desc.Width * format_size(resource_desc.Format), D3D12_TEXTURE_DATA_PITCH_ALIGNMENT); + buffer_size = row_pitch * resource_desc.Height; + readback_buffer = create_readback_buffer(device, buffer_size); + + ID3D12GraphicsCommandList_ClearRenderTargetView(command_list, context.rtv, white, 0, NULL); + ID3D12GraphicsCommandList_OMSetRenderTargets(command_list, 1, &context.rtv, FALSE, NULL); + ID3D12GraphicsCommandList_SetGraphicsRootSignature(command_list, context.root_signature); + ID3D12GraphicsCommandList_SetPipelineState(command_list, context.pipeline_state); + ID3D12GraphicsCommandList_IASetPrimitiveTopology(command_list, D3D_PRIMITIVE_TOPOLOGY_TRIANGLELIST); + ID3D12GraphicsCommandList_RSSetViewports(command_list, 1, &context.viewport); + ID3D12GraphicsCommandList_RSSetScissorRects(command_list, 1, &context.scissor_rect); + ID3D12GraphicsCommandList_SetGraphicsRootConstantBufferView(command_list, 0, + ID3D12Resource_GetGPUVirtualAddress(cb)); + ID3D12GraphicsCommandList_DrawInstanced(command_list, 3, 1, 0, 0); + + transition_resource_state(command_list, context.render_target, + D3D12_RESOURCE_STATE_RENDER_TARGET, D3D12_RESOURCE_STATE_COPY_SOURCE); + + dst_location.pResource = readback_buffer; + dst_location.Type = D3D12_TEXTURE_COPY_TYPE_PLACED_FOOTPRINT; + dst_location.PlacedFootprint.Offset = 0; + dst_location.PlacedFootprint.Footprint.Format = resource_desc.Format; + dst_location.PlacedFootprint.Footprint.Width = resource_desc.Width; + dst_location.PlacedFootprint.Footprint.Height = resource_desc.Height; + dst_location.PlacedFootprint.Footprint.Depth = 1; + dst_location.PlacedFootprint.Footprint.RowPitch = row_pitch; + src_location.pResource = context.render_target; + src_location.Type = D3D12_TEXTURE_COPY_TYPE_SUBRESOURCE_INDEX; + src_location.SubresourceIndex = 0; + ID3D12GraphicsCommandList_CopyTextureRegion(command_list, &dst_location, 0, 0, 0, &src_location, NULL); + + transition_resource_state(command_list, context.render_target, + D3D12_RESOURCE_STATE_COPY_SOURCE, D3D12_RESOURCE_STATE_RENDER_TARGET); + + hr = ID3D12GraphicsCommandList_Close(command_list); + ok(hr == S_OK, "Failed to close command list, hr %#x.\n", hr); + + /* Wait() with signaled fence */ + update_buffer_data(cb, 0, sizeof(green), &green); + hr = ID3D12CommandQueue_Wait(queue, fence, 1); + ok(hr == S_OK, "Failed to submit wait operation to queue, hr %#x.\n", hr); + exec_command_list(queue, command_list); + wait_queue_idle(device, queue); + init_readback(&rb, readback_buffer, buffer_size, resource_desc.Width, resource_desc.Height, 1, row_pitch); + check_readback_data_uint(&rb, NULL, 0xff00ff00, 0); + release_resource_readback(&rb); + + if (!vkd3d_test_platform_is_windows()) + { + skip("Wait() is not implemented yet.\n"); /* FIXME */ + goto skip_tests; + } + + /* Wait() before CPU signal */ + update_buffer_data(cb, 0, sizeof(blue), &blue); + hr = ID3D12CommandQueue_Wait(queue, fence, 2); + ok(hr == S_OK, "Failed to submit wait operation to queue, hr %#x.\n", hr); + exec_command_list(queue, command_list); + hr = ID3D12CommandQueue_Signal(queue, fence2, 1); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + hr = ID3D12Fence_SetEventOnCompletion(fence2, 1, event); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); + ret = wait_event(event, 0); + ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); + init_readback(&rb, readback_buffer, buffer_size, resource_desc.Width, resource_desc.Height, 1, row_pitch); + check_readback_data_uint(&rb, NULL, 0xff00ff00, 0); + release_resource_readback(&rb); + value = ID3D12Fence_GetCompletedValue(fence2); + ok(value == 0, "Got unexpected value %"PRIu64".\n", value); + + hr = ID3D12Fence_Signal(fence, 2); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + ret = wait_event(event, INFINITE); + ok(ret == WAIT_OBJECT_0, "Got unexpected return value %#x.\n", ret); + ret = wait_event(event, 0); + ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); + init_readback(&rb, readback_buffer, buffer_size, resource_desc.Width, resource_desc.Height, 1, row_pitch); + check_readback_data_uint(&rb, NULL, 0xffff0000, 0); + release_resource_readback(&rb); + value = ID3D12Fence_GetCompletedValue(fence2); + ok(value == 1, "Got unexpected value %"PRIu64".\n", value); + + /* Wait() before GPU signal */ + update_buffer_data(cb, 0, sizeof(green), &green); + hr = ID3D12CommandQueue_Wait(queue, fence, 3); + ok(hr == S_OK, "Failed to submit wait operation to queue, hr %#x.\n", hr); + exec_command_list(queue, command_list); + hr = ID3D12CommandQueue_Signal(queue, fence2, 2); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + hr = ID3D12Fence_SetEventOnCompletion(fence2, 2, event); + ok(hr == S_OK, "Failed to set event on completion, hr %#x.\n", hr); + ret = wait_event(event, 0); + ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); + init_readback(&rb, readback_buffer, buffer_size, resource_desc.Width, resource_desc.Height, 1, row_pitch); + check_readback_data_uint(&rb, NULL, 0xffff0000, 0); + release_resource_readback(&rb); + value = ID3D12Fence_GetCompletedValue(fence2); + ok(value == 1, "Got unexpected value %"PRIu64".\n", value); + + hr = ID3D12CommandQueue_Signal(queue2, fence, 3); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + ret = wait_event(event, INFINITE); + ok(ret == WAIT_OBJECT_0, "Got unexpected return value %#x.\n", ret); + ret = wait_event(event, 0); + ok(ret == WAIT_TIMEOUT, "Got unexpected return value %#x.\n", ret); + init_readback(&rb, readback_buffer, buffer_size, resource_desc.Width, resource_desc.Height, 1, row_pitch); + check_readback_data_uint(&rb, NULL, 0xff00ff00, 0); + release_resource_readback(&rb); + value = ID3D12Fence_GetCompletedValue(fence2); + ok(value == 2, "Got unexpected value %"PRIu64".\n", value); + + /* update constant buffer after Wait() */ + hr = ID3D12CommandQueue_Wait(queue, fence, 5); + ok(hr == S_OK, "Failed to submit wait operation to queue, hr %#x.\n", hr); + exec_command_list(queue, command_list); + hr = ID3D12Fence_Signal(fence, 4); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + update_buffer_data(cb, 0, sizeof(blue), &blue); + hr = ID3D12Fence_Signal(fence, 5); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + wait_queue_idle(device, queue); + init_readback(&rb, readback_buffer, buffer_size, resource_desc.Width, resource_desc.Height, 1, row_pitch); + check_readback_data_uint(&rb, NULL, 0xffff0000, 0); + release_resource_readback(&rb); + + hr = ID3D12Fence_Signal(fence, 6); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + update_buffer_data(cb, 0, sizeof(green), &green); + exec_command_list(queue, command_list); + wait_queue_idle(device, queue); + init_readback(&rb, readback_buffer, buffer_size, resource_desc.Width, resource_desc.Height, 1, row_pitch); + check_readback_data_uint(&rb, NULL, 0xff00ff00, 0); + release_resource_readback(&rb); + +skip_tests: + /* Signal() and Wait() in the same command queue */ + update_buffer_data(cb, 0, sizeof(blue), &blue); + hr = ID3D12CommandQueue_Signal(queue, fence, 7); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + hr = ID3D12CommandQueue_Wait(queue, fence, 7); + ok(hr == S_OK, "Failed to submit wait operation to queue, hr %#x.\n", hr); + exec_command_list(queue, command_list); + wait_queue_idle(device, queue); + init_readback(&rb, readback_buffer, buffer_size, resource_desc.Width, resource_desc.Height, 1, row_pitch); + check_readback_data_uint(&rb, NULL, 0xffff0000, 0); + release_resource_readback(&rb); + + value = ID3D12Fence_GetCompletedValue(fence); + ok(value == 7, "Got unexpected value %"PRIu64".\n", value); + + destroy_event(event); + ID3D12Fence_Release(fence); + ID3D12Fence_Release(fence2); + ID3D12Resource_Release(cb); + ID3D12CommandQueue_Release(queue2); + ID3D12Resource_Release(readback_buffer); + destroy_test_context(&context); +} + START_TEST(d3d12) { parse_args(argc, argv); @@ -27725,4 +27974,5 @@ START_TEST(d3d12) run_test(test_primitive_restart); run_test(test_vertex_shader_stream_output); run_test(test_read_write_subresource); + run_test(test_queue_wait); } -- 2.21.0

2 1

[PATCH vkd3d 6/8] vkd3d: Return S_OK from d3d12_command_queue_Wait().
by Józef Kucia 18 Apr '19

18 Apr '19

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- libs/vkd3d/command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/vkd3d/command.c b/libs/vkd3d/command.c index 6410dd2875ae..7b4daa4c0564 100644 --- a/libs/vkd3d/command.c +++ b/libs/vkd3d/command.c @@ -5217,7 +5217,7 @@ static HRESULT STDMETHODCALLTYPE d3d12_command_queue_Wait(ID3D12CommandQueue *if { FIXME("iface %p, fence %p, value %#"PRIx64" stub!\n", iface, fence, value); - return E_NOTIMPL; + return S_OK; } static HRESULT STDMETHODCALLTYPE d3d12_command_queue_GetTimestampFrequency(ID3D12CommandQueue *iface, -- 2.21.0

2 1

[PATCH vkd3d 5/8] tests: Add simple test for fence values.
by Józef Kucia 18 Apr '19

18 Apr '19

From: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> --- tests/d3d12.c | 82 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) diff --git a/tests/d3d12.c b/tests/d3d12.c index 148989b543b0..d44fff02b998 100644 --- a/tests/d3d12.c +++ b/tests/d3d12.c @@ -3922,6 +3922,87 @@ static void test_multithread_fence_wait(void) ok(!refcount, "ID3D12Device has %u references left.\n", (unsigned int)refcount); } +static void test_fence_values(void) +{ + ID3D12CommandQueue *queue; + UINT64 value, next_value; + ID3D12Device *device; + ID3D12Fence *fence; + ULONG refcount; + unsigned int i; + HRESULT hr; + + if (!(device = create_device())) + { + skip("Failed to create device.\n"); + return; + } + + queue = create_command_queue(device, D3D12_COMMAND_LIST_TYPE_DIRECT, D3D12_COMMAND_QUEUE_PRIORITY_NORMAL); + + next_value = (uint64_t)1 << 60; + hr = ID3D12Device_CreateFence(device, next_value, D3D12_FENCE_FLAG_NONE, &IID_ID3D12Fence, (void **)&fence); + ok(hr == S_OK, "Failed to create fence, hr %#x.\n", hr); + + value = ID3D12Fence_GetCompletedValue(fence); + ok(value == next_value, "Got value %#"PRIx64", expected %#"PRIx64".\n", value, next_value); + + for (i = 0; i < 100; ++i) + { + ++next_value; + hr = ID3D12CommandQueue_Signal(queue, fence, next_value); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + wait_queue_idle(device, queue); + value = ID3D12Fence_GetCompletedValue(fence); + ok(value == next_value, "Got value %#"PRIx64", expected %#"PRIx64".\n", value, next_value); + } + + for (i = 0; i < 100; ++i) + { + next_value += 10000; + hr = ID3D12Fence_Signal(fence, next_value); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + value = ID3D12Fence_GetCompletedValue(fence); + ok(value == next_value, "Got value %#"PRIx64", expected %#"PRIx64".\n", value, next_value); + } + + ID3D12Fence_Release(fence); + + hr = ID3D12Device_CreateFence(device, 0, D3D12_FENCE_FLAG_NONE, &IID_ID3D12Fence, (void **)&fence); + ok(hr == S_OK, "Failed to create fence, hr %#x.\n", hr); + next_value = (uint64_t)1 << 60; + hr = ID3D12Fence_Signal(fence, next_value); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + value = ID3D12Fence_GetCompletedValue(fence); + ok(value == next_value, "Got value %#"PRIx64", expected %#"PRIx64".\n", value, next_value); + next_value = 0; + hr = ID3D12Fence_Signal(fence, next_value); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + value = ID3D12Fence_GetCompletedValue(fence); + ok(value == next_value, "Got value %#"PRIx64", expected %#"PRIx64".\n", value, next_value); + ID3D12Fence_Release(fence); + + hr = ID3D12Device_CreateFence(device, 0, D3D12_FENCE_FLAG_NONE, &IID_ID3D12Fence, (void **)&fence); + ok(hr == S_OK, "Failed to create fence, hr %#x.\n", hr); + next_value = (uint64_t)1 << 60; + hr = ID3D12CommandQueue_Signal(queue, fence, next_value); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + wait_queue_idle(device, queue); + value = ID3D12Fence_GetCompletedValue(fence); + ok(value == next_value, "Got value %#"PRIx64", expected %#"PRIx64".\n", value, next_value); + next_value = 0; + hr = ID3D12CommandQueue_Signal(queue, fence, next_value); + ok(hr == S_OK, "Failed to signal fence, hr %#x.\n", hr); + wait_queue_idle(device, queue); + value = ID3D12Fence_GetCompletedValue(fence); + ok(value == next_value, "Got value %#"PRIx64", expected %#"PRIx64".\n", value, next_value); + ID3D12Fence_Release(fence); + + ID3D12CommandQueue_Release(queue); + refcount = ID3D12Device_Release(device); + ok(!refcount, "ID3D12Device has %u references left.\n", (unsigned int)refcount); +} + static void test_clear_depth_stencil_view(void) { static const float expected_values[] = {0.5f, 0.1f, 0.1f, 0.6, 1.0f, 0.5f}; @@ -27532,6 +27613,7 @@ START_TEST(d3d12) run_test(test_cpu_signal_fence); run_test(test_gpu_signal_fence); run_test(test_multithread_fence_wait); + run_test(test_fence_values); run_test(test_clear_depth_stencil_view); run_test(test_clear_render_target_view); run_test(test_clear_unordered_access_view); -- 2.21.0

2 1