July 2022 - Wine-devel - list.winehq.org

Re: [PATCH 3/4] ws2_32: Map AFD_POLL_RESET to both POLLHUP and POLLERR.
by Marvin 22 Jul '22

22 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119426 Your paranoid android. === debian11 (32 bit report) === ws2_32: sock.c:12874: Test failed: got wrong events 0x12 === debian11 (32 bit Arabic:Morocco report) === ws2_32: sock.c:12874: Test failed: got wrong events 0x12 === debian11 (32 bit German report) === ws2_32: sock.c:12874: Test failed: got wrong events 0x12 === debian11 (32 bit French report) === ws2_32: sock.c:12874: Test failed: got wrong events 0x12 === debian11 (32 bit Hebrew:Israel report) === ws2_32: sock.c:12874: Test failed: got wrong events 0x12 === debian11 (32 bit Hindi:India report) === ws2_32: sock.c:12874: Test failed: got wrong events 0x12 === debian11 (32 bit Japanese:Japan report) === ws2_32: sock.c:12874: Test failed: got wrong events 0x12 === debian11 (32 bit Chinese:China report) === ws2_32: sock.c:12874: Test failed: got wrong events 0x12 === debian11 (32 bit WoW report) === ws2_32: sock.c:12874: Test failed: got wrong events 0x12 === debian11 (64 bit WoW report) === ws2_32: sock.c:12874: Test failed: got wrong events 0x12

1 0

Re: [PATCH v2 6/9] win32u/tests: Add tests for catching exceptions from timer proc.
by Marvin 22 Jul '22

22 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119391 Your paranoid android. === build (build log) === error: patch failed: dlls/user32/message.c:856 error: patch failed: dlls/user32/user_private.h:89 error: patch failed: dlls/user32/winproc.c:719 error: patch failed: dlls/win32u/message.c:2952 error: patch failed: include/ntuser.h:276 error: patch failed: dlls/user32/message.c:877 error: patch failed: dlls/win32u/message.c:2496 error: patch failed: dlls/win32u/sysparams.c:4880 error: patch failed: dlls/win32u/win32u_private.h:436 error: patch failed: include/ntuser.h:902 error: patch failed: dlls/user32/message.c:597 error: patch failed: dlls/win32u/hook.c:60 error: patch failed: dlls/win32u/message.c:109 error: patch failed: dlls/win32u/tests/win32u.c:425 error: patch failed: dlls/win32u/win32u_private.h:391 error: patch failed: dlls/ntdll/signal_arm.c:533 error: patch failed: dlls/ntdll/signal_arm64.c:576 error: patch failed: dlls/ntdll/signal_i386.c:257 error: patch failed: dlls/ntdll/signal_x86_64.c:661 error: patch failed: dlls/ntdll/unix/signal_arm.c:721 error: patch failed: dlls/ntdll/unix/signal_arm64.c:730 error: patch failed: dlls/ntdll/unix/signal_i386.c:1575 error: patch failed: dlls/ntdll/unix/signal_x86_64.c:2327 error: patch failed: dlls/win32u/gdiobj.c:1158 error: patch failed: dlls/win32u/message.c:2514 error: patch failed: dlls/win32u/syscall.c:117 error: patch failed: dlls/win32u/win32u.spec:839 error: patch failed: dlls/win32u/win32u_private.h:215 error: patch failed: dlls/win32u/wrappers.c:855 error: patch failed: dlls/wow64win/syscall.h:104 error: patch failed: dlls/wow64win/user.c:78 error: patch failed: dlls/win32u/tests/win32u.c:632 Task: Patch failed to apply

1 0

Re: [PATCH v2 3/9] win32u: Avoid using client callbacks for NtUserSendMessage.
by Marvin 22 Jul '22

22 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119388 Your paranoid android. === build (build log) === error: patch failed: dlls/user32/message.c:856 error: patch failed: dlls/user32/user_private.h:89 error: patch failed: dlls/user32/winproc.c:719 error: patch failed: dlls/win32u/message.c:2952 error: patch failed: include/ntuser.h:276 error: patch failed: dlls/user32/message.c:877 error: patch failed: dlls/win32u/message.c:2496 error: patch failed: dlls/win32u/sysparams.c:4880 error: patch failed: dlls/win32u/win32u_private.h:436 error: patch failed: include/ntuser.h:902 error: patch failed: dlls/user32/message.c:597 error: patch failed: dlls/win32u/hook.c:60 error: patch failed: dlls/win32u/message.c:109 error: patch failed: dlls/win32u/tests/win32u.c:425 error: patch failed: dlls/win32u/win32u_private.h:391 Task: Patch failed to apply

1 0

Re: [PATCH 3/4] server: Report the socket error in sock_poll_event() on POLLERR or POLLHUP.
by Marvin 22 Jul '22

22 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119378 Your paranoid android. === build (build log) === error: patch failed: server/sock.c:1090 error: patch failed: server/sock.c:645 error: patch failed: dlls/ws2_32/tests/afd.c:162 error: patch failed: server/sock.c:1145 Task: Patch failed to apply

1 0

Re: [PATCH 1/1] d3d11: Use CRT allocation functions.
by Marvin 22 Jul '22

22 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119444 Your paranoid android. === debian11 (64 bit WoW report) === d3d11: d3d11.c:1567: Test succeeded inside todo block: d3d11.c:1570: Test succeeded inside todo block: Got unexpected hr 0. d3d11.c:1570: Test succeeded inside todo block: d3d11.c:1570: Test succeeded inside todo block: Got unexpected hr 0.

1 0

Re: [PATCH 3/3] shell32: Reimplement SHBindToParent.
by Marvin 22 Jul '22

22 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119430 Your paranoid android. === debian11 (32 bit report) === shell32: shlfolder.c:5549: Test failed: got DEADBEEF === debian11 (32 bit Chinese:China report) === shell32: shlfolder.c:5549: Test failed: got DEADBEEF === debian11 (32 bit WoW report) === shell32: shlfolder.c:5549: Test failed: got DEADBEEF === debian11 (64 bit WoW report) === shell32: shlfolder.c:5549: Test failed: got 00000000DEADBEEF

1 0

Re: [PATCH v4] ntdll: Add RtlGetDeviceFamilyInfoEnum and RtlConvertDeviceFamilyInfoToString
by Kacper Rączy 21 Jul '22

21 Jul '22

Is there anything else to be changed there, to get this accepted? BR, Kacper > > Wiadomość napisana przez Kacper rączy <gfw.kra(a)gmail.com> w dniu 06.07.2022, o godz. 14:10: > > >> === debian11 (64 bit WoW report) === >> ntdll: >> env.c:461: Test failed: wrong end ptr 000000000086195C/0000000000861960 > It also fails without the patch on my machine.

1 0

Re: [PATCH 1/3] wined3d: Do not try to unmap already unmapped BOs in wined3d_buffer_update_sub_resource().
by Marvin 21 Jul '22

21 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119373 Your paranoid android. === debian11 (build log) === WineRunWineTest.pl:error: The previous 1 run(s) terminated abnormally

1 0

[PATCH 2/2] kernel32: Implement GetFileMUIInfo.
by Dmitry Timoshkov 21 Jul '22

21 Jul '22

Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/kernel32/tests/resource.c | 7 ++ dlls/kernelbase/locale.c | 145 ++++++++++++++++++++++++++++++++- 2 files changed, 149 insertions(+), 3 deletions(-) diff --git a/dlls/kernel32/tests/resource.c b/dlls/kernel32/tests/resource.c index 626645a8979..f8a49990e6b 100644 --- a/dlls/kernel32/tests/resource.c +++ b/dlls/kernel32/tests/resource.c @@ -617,6 +617,7 @@ static void test_GetFileMUIInfo(void) ret = GetFileMUIInfo(0, path, info, &size); ok(!ret, "GetFileMUIInfo should fail\n"); ok(GetLastError() == ERROR_INVALID_PARAMETER, "got %lu\n", GetLastError()); + todo_wine ok(!size, "got %lu\n", size); ok(info->dwSize == sizeof(*info), "got %lu\n", info->dwSize); ok(!info->dwVersion, "got %08lx\n", info->dwVersion); @@ -653,7 +654,9 @@ static void test_GetFileMUIInfo(void) full_size = 0; SetLastError(0xdeadbeef); ret = GetFileMUIInfo(MUI_QUERY_ALL, path, NULL, &full_size); + todo_wine ok(!ret, "GetFileMUIInfo should fail\n"); + todo_wine ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "got %lu\n", GetLastError()); memset(buf, 0, sizeof(buf)); @@ -666,7 +669,9 @@ static void test_GetFileMUIInfo(void) ok(!ret, "GetFileMUIInfo should fail\n"); ok(GetLastError() == ERROR_INVALID_PARAMETER, "got %lu\n", GetLastError()); ok(info->dwVersion == 0, "got %08lx\n", info->dwVersion); + todo_wine ok(info->dwFileType == 0, "got %08lx\n", info->dwFileType); + todo_wine ok(!memcmp(info->abBuffer, zero, 8), "got %.8s\n", info->abBuffer); memset(buf, 0, sizeof(buf)); @@ -700,8 +705,10 @@ static void test_GetFileMUIInfo(void) ret = GetFileMUIInfo(MUI_QUERY_ALL, path, info, &size); ok(!ret, "GetFileMUIInfo should fail\n"); ok(GetLastError() == ERROR_INVALID_PARAMETER, "got %lu\n", GetLastError()); + todo_wine ok(size == 0, "got %08lx\n", size); ok(info->dwVersion == 0, "got %08lx\n", info->dwVersion); + todo_wine ok(info->dwFileType == 0, "got %08lx\n", info->dwFileType); ok(!memcmp(info->abBuffer, zero, 8), "got %.8s\n", info->abBuffer); diff --git a/dlls/kernelbase/locale.c b/dlls/kernelbase/locale.c index 0c20c858a7a..19c4707cec8 100644 --- a/dlls/kernelbase/locale.c +++ b/dlls/kernelbase/locale.c @@ -5699,15 +5699,154 @@ done: } +typedef struct +{ + DWORD dwSignature; + DWORD dwSize; + DWORD dwVersion; + DWORD unknown1; + DWORD unknown2; + DWORD unknown3; + DWORD dwFileType; + BYTE pServiceChecksum[16]; + BYTE pChecksum[16]; + DWORD unknown4[6]; + DWORD dwTypeNameMainOffset; + DWORD dwTypeNameMainSize; + DWORD dwTypeIDMainOffset; + DWORD dwTypeIDMainSize; + DWORD dwTypeNameMUIOffset; + DWORD dwTypeNameMUISize; + DWORD dwTypeIDMUIOffset; + DWORD dwTypeIDMUISize; + DWORD unknown5; + DWORD unknown6; + DWORD dwLanguageNameOffset; + DWORD dwLanguageNameSize; +} MUI_RC_CONFIG; + /****************************************************************************** * GetFileMUIInfo (kernelbase.@) */ BOOL WINAPI /* DECLSPEC_HOTPATCH */ GetFileMUIInfo( DWORD flags, const WCHAR *path, FILEMUIINFO *info, DWORD *size ) { - FIXME( "stub: %lu, %s, %p, %p\n", flags, debugstr_w(path), info, size ); - SetLastError( ERROR_CALL_NOT_IMPLEMENTED ); - return FALSE; + HMODULE module; + HRSRC rsrc; + MUI_RC_CONFIG *rc_cfg; + DWORD rc_size; + + TRACE( "(%08lx,%s,%p,%p)\n", flags, debugstr_w(path), info, size ); + + if (!size) + { + SetLastError( ERROR_INVALID_PARAMETER ); + return FALSE; + } + + if (info) + { + if (*size < sizeof(FILEMUIINFO)) + { + SetLastError( ERROR_INSUFFICIENT_BUFFER ); + return FALSE; + } + + if (*size != info->dwSize || !info->dwVersion) + { + SetLastError( ERROR_INVALID_PARAMETER ); + return FALSE; + } + } + else if (*size) + { + SetLastError( ERROR_INVALID_PARAMETER ); + return FALSE; + } + + module = LoadLibraryExW( path, 0, LOAD_LIBRARY_AS_IMAGE_RESOURCE | LOAD_LIBRARY_AS_DATAFILE ); + if (!module) return FALSE; + + rsrc = FindResourceW( module, MAKEINTRESOURCEW(1), L"MUI" ); + if (!rsrc) + { + FreeLibrary( module ); + return FALSE; + } + + rc_cfg = LockResource( LoadResource( module, rsrc ) ); + + rc_size = sizeof(*info); + if (flags & MUI_QUERY_RESOURCE_TYPES) + { + rc_size += rc_cfg->dwTypeNameMainSize; + rc_size += rc_cfg->dwTypeIDMainSize; + rc_size += rc_cfg->dwTypeNameMUISize; + rc_size += rc_cfg->dwTypeIDMUISize; + } + if (flags & MUI_QUERY_LANGUAGE_NAME) + rc_size += rc_cfg->dwLanguageNameSize; + + if (info) + { + char *p = (char *)(info + 1); + DWORD offset = sizeof(*info); + + memset( (char *)info + 8, 0, *size - 8 ); /* keep original dwSize/dwVersion */ + + if (flags & MUI_QUERY_TYPE) + info->dwFileType = rc_cfg->dwFileType; + + if (flags & MUI_QUERY_CHECKSUM) + { + memcpy( info->pChecksum, rc_cfg->pChecksum, sizeof(info->pChecksum) ); + memcpy( info->pServiceChecksum, rc_cfg->pServiceChecksum, sizeof(info->pServiceChecksum) ); + } + + if (*size < rc_size) + { + FreeLibrary( module ); + SetLastError( ERROR_INSUFFICIENT_BUFFER ); + return FALSE; + } + + if (flags & MUI_QUERY_RESOURCE_TYPES) + { + info->dwTypeNameMainOffset = offset; + memcpy( p, (char *)rc_cfg + rc_cfg->dwTypeNameMainOffset, rc_cfg->dwTypeNameMainSize ); + p += rc_cfg->dwTypeNameMainSize; + offset += rc_cfg->dwTypeNameMainSize; + + info->dwTypeIDMainOffset = offset; + info->dwTypeIDMainSize = rc_cfg->dwTypeIDMainSize / sizeof(DWORD); + memcpy( p, (char *)rc_cfg + rc_cfg->dwTypeIDMainOffset, rc_cfg->dwTypeIDMainSize ); + p += rc_cfg->dwTypeIDMainSize; + offset += rc_cfg->dwTypeIDMainSize; + + info->dwTypeNameMUIOffset = offset; + memcpy( p, (char *)rc_cfg + rc_cfg->dwTypeNameMUIOffset, rc_cfg->dwTypeNameMUISize ); + p += rc_cfg->dwTypeNameMUISize; + offset += rc_cfg->dwTypeNameMUISize; + + info->dwTypeIDMUIOffset = offset; + info->dwTypeIDMUISize = rc_cfg->dwTypeIDMUISize / sizeof(DWORD); + memcpy( p, (char *)rc_cfg + rc_cfg->dwTypeIDMUIOffset, rc_cfg->dwTypeIDMUISize ); + p += rc_cfg->dwTypeIDMUISize; + offset += rc_cfg->dwTypeIDMUISize; + } + + if (flags & MUI_QUERY_LANGUAGE_NAME) + { + info->dwLanguageNameOffset = offset; + memcpy( p, (char *)rc_cfg + rc_cfg->dwLanguageNameOffset, rc_cfg->dwLanguageNameSize ); + } + } + else + *size = rc_size; + + FreeLibrary( module ); + + return TRUE; } -- 2.37.1

1 0

[PATCH 1/2] kernel32/tests: Add some tests for GetFileMUIInfo().
by Dmitry Timoshkov 21 Jul '22

21 Jul '22

MUI_RC_CONFIG layout is based on the description from http://hostagebrain.blogspot.com/2015/11/multilingual-user-interface.html Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> --- dlls/kernel32/tests/resource.c | 235 ++++++++++++++++++++++++++++++++- 1 file changed, 234 insertions(+), 1 deletion(-) diff --git a/dlls/kernel32/tests/resource.c b/dlls/kernel32/tests/resource.c index 6c5bc99c0c5..626645a8979 100644 --- a/dlls/kernel32/tests/resource.c +++ b/dlls/kernel32/tests/resource.c @@ -2,6 +2,7 @@ * Unit test suite for resource functions. * * Copyright 2006 Mike McCormack + * Copyright 2022 Dmitry Timoshkov * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -18,8 +19,10 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include <windows.h> +#include <stdarg.h> #include <stdio.h> +#include <assert.h> +#include <windows.h> #include "wine/test.h" @@ -520,10 +523,240 @@ static void test_internal_structure(void) ok( EndUpdateResourceW( res, TRUE ), "EndUpdateResourceW failed\n"); } +typedef struct +{ + DWORD dwSignature; + DWORD dwSize; + DWORD dwVersion; + DWORD unknown1; + DWORD unknown2; + DWORD unknown3; + DWORD dwFileType; + BYTE pServiceChecksum[16]; + BYTE pChecksum[16]; + DWORD unknown4[6]; + DWORD dwTypeNameMainOffset; + DWORD dwTypeNameMainSize; + DWORD dwTypeIDMainOffset; + DWORD dwTypeIDMainSize; + DWORD dwTypeNameMUIOffset; + DWORD dwTypeNameMUISize; + DWORD dwTypeIDMUIOffset; + DWORD dwTypeIDMUISize; + DWORD unknown5; + DWORD unknown6; + DWORD dwLanguageNameOffset; + DWORD dwLanguageNameSize; +} MUI_RC_CONFIG; + +static void *offset_to_data(void *base, DWORD offset) +{ + return (char *)base + offset; +} + +static void test_GetFileMUIInfo(void) +{ +#define MUI_QUERY_ALL (MUI_QUERY_TYPE | MUI_QUERY_CHECKSUM | MUI_QUERY_LANGUAGE_NAME | MUI_QUERY_RESOURCE_TYPES) + static const BYTE zero[8]; + static const WCHAR path[] = L"urlmon.dll"; + char buf[1024]; + HRSRC rsrc; + MUI_RC_CONFIG *rc_cfg; + char *p1, *p2; + FILEMUIINFO *info = (FILEMUIINFO *)buf; + DWORD size, full_size; + HMODULE module; + int ret; + + module = LoadLibraryExW(path, 0, LOAD_LIBRARY_AS_IMAGE_RESOURCE | LOAD_LIBRARY_AS_DATAFILE); + ok(module != NULL, "LoadLibraryEx error %lu\n", GetLastError()); + rsrc = FindResourceW(module, MAKEINTRESOURCEW(1), L"MUI"); + todo_wine + ok(rsrc != 0, "MUI resource not found\n"); + if (!rsrc) + { + skip("MUI resource not found\n"); + FreeLibrary(module); + return; + } + rc_cfg = LockResource(LoadResource(module, rsrc)); + ok(rc_cfg->dwVersion == MAKELONG(0,1), "got %08lx\n", rc_cfg->dwVersion); + ok(rc_cfg->dwFileType == MUI_FILETYPE_LANGUAGE_NEUTRAL_MAIN, "got %08lx\n", rc_cfg->dwFileType); + + SetLastError(0xdeadbeef); + ret = GetFileMUIInfo(0, path, NULL, NULL); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "got %lu\n", GetLastError()); + + info->dwSize = sizeof(*info); + SetLastError(0xdeadbeef); + ret = GetFileMUIInfo(0, path, info, NULL); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "got %lu\n", GetLastError()); + + size = 0xdeadbeef; + SetLastError(0xdeadbeef); + ret = GetFileMUIInfo(MUI_QUERY_ALL, path, NULL, &size); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "got %lu\n", GetLastError()); + + size = 0; + ret = GetFileMUIInfo(0, path, NULL, &size); + ok(ret, "GetFileMUIInfo error %lu\n", GetLastError()); + ok(size == sizeof(FILEMUIINFO), "got %lu bytes\n", size); + + memset(info, 0, sizeof(*info)); + size = info->dwSize = sizeof(*info) - 1; + SetLastError(0xdeadbeef); + ret = GetFileMUIInfo(0, path, info, &size); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "got %lu\n", GetLastError()); + + memset(info, 0, sizeof(*info)); + size = info->dwSize = sizeof(*info); + ret = GetFileMUIInfo(0, path, info, &size); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "got %lu\n", GetLastError()); + ok(!size, "got %lu\n", size); + ok(info->dwSize == sizeof(*info), "got %lu\n", info->dwSize); + ok(!info->dwVersion, "got %08lx\n", info->dwVersion); + + memset(info, 0, sizeof(*info)); + size = info->dwSize = sizeof(*info); + info->dwVersion = MUI_FILEINFO_VERSION; + ret = GetFileMUIInfo(0, path, info, &size); + ok(ret, "GetFileMUIInfo error %lu\n", GetLastError()); + + memset(buf, 0, sizeof(buf)); + size = info->dwSize = 1; + info->dwVersion = MUI_FILEINFO_VERSION; + info->dwFileType = 0xdeadbeef; + SetLastError(0xdeadbeef); + ret = GetFileMUIInfo(0, path, info, &size); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "got %lu\n", GetLastError()); + ok(info->dwVersion == MUI_FILEINFO_VERSION, "got %08lx\n", info->dwVersion); + ok(info->dwFileType == 0xdeadbeef, "got %08lx\n", info->dwFileType); + + memset(buf, 0, sizeof(buf)); + info->dwSize = sizeof(*info); + size = sizeof(*info) + 1; + info->dwVersion = MUI_FILEINFO_VERSION; + info->dwFileType = 0xdeadbeef; + SetLastError(0xdeadbeef); + ret = GetFileMUIInfo(0, path, info, &size); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "got %lu\n", GetLastError()); + ok(info->dwVersion == MUI_FILEINFO_VERSION, "got %08lx\n", info->dwVersion); + ok(info->dwFileType == 0xdeadbeef, "got %08lx\n", info->dwFileType); + + full_size = 0; + SetLastError(0xdeadbeef); + ret = GetFileMUIInfo(MUI_QUERY_ALL, path, NULL, &full_size); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "got %lu\n", GetLastError()); + + memset(buf, 0, sizeof(buf)); + info->dwSize = size = sizeof(*info); + info->dwVersion = 0; + info->dwFileType = 0xdeadbeef; + memcpy(info->abBuffer, "deadbeef", 8); + SetLastError(0xdeadbeef); + ret = GetFileMUIInfo(MUI_QUERY_ALL, path, info, &size); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "got %lu\n", GetLastError()); + ok(info->dwVersion == 0, "got %08lx\n", info->dwVersion); + ok(info->dwFileType == 0, "got %08lx\n", info->dwFileType); + ok(!memcmp(info->abBuffer, zero, 8), "got %.8s\n", info->abBuffer); + + memset(buf, 0, sizeof(buf)); + info->dwSize = size = sizeof(*info); + info->dwVersion = 0xdeadbeef; + info->dwFileType = 0xdeadbeef; + memcpy(info->abBuffer, "deadbeef", 8); + SetLastError(0xdeadbeef); + ret = GetFileMUIInfo(MUI_QUERY_ALL, path, info, &size); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "got %lu\n", GetLastError()); + ok(info->dwVersion == 0xdeadbeef, "got %08lx\n", info->dwVersion); + ok(info->dwFileType == MUI_FILETYPE_LANGUAGE_NEUTRAL_MAIN, "got %08lx\n", info->dwFileType); + ok(!memcmp(info->abBuffer, zero, 8), "got %.8s\n", info->abBuffer); + + memset(buf, 0, sizeof(buf)); + info->dwSize = size = sizeof(*info); + info->dwVersion = 0xdeadbeef; + info->dwFileType = 0xdeadbeef; + SetLastError(0xdeadbeef); + ret = GetFileMUIInfo(MUI_QUERY_ALL, path, info, &size); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "got %lu\n", GetLastError()); + ok(info->dwVersion == 0xdeadbeef, "got %08lx\n", info->dwVersion); + ok(info->dwFileType == MUI_FILETYPE_LANGUAGE_NEUTRAL_MAIN, "got %08lx\n", info->dwFileType); + + memset(buf, 0, sizeof(buf)); + info->dwSize = size = full_size; + info->dwVersion = 0; + info->dwFileType = 0xdeadbeef; + ret = GetFileMUIInfo(MUI_QUERY_ALL, path, info, &size); + ok(!ret, "GetFileMUIInfo should fail\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "got %lu\n", GetLastError()); + ok(size == 0, "got %08lx\n", size); + ok(info->dwVersion == 0, "got %08lx\n", info->dwVersion); + ok(info->dwFileType == 0, "got %08lx\n", info->dwFileType); + ok(!memcmp(info->abBuffer, zero, 8), "got %.8s\n", info->abBuffer); + + memset(buf, 0, sizeof(buf)); + info->dwSize = size = full_size; + info->dwVersion = MUI_FILEINFO_VERSION; + info->dwFileType = 0xdeadbeef; + ret = GetFileMUIInfo(MUI_QUERY_ALL, path, info, &size); + ok(ret || broken(GetLastError() == ERROR_INSUFFICIENT_BUFFER) /* Some Win10 versions */, "GetFileMUIInfo error %lu\n", GetLastError()); + while (!ret) /* Try to recover from Win10 breakage */ + { + size += 2; + assert(size <= sizeof(buf)); + info->dwSize = size; + ret = GetFileMUIInfo(MUI_QUERY_ALL, path, info, &size); + } + ok(info->dwVersion == MUI_FILEINFO_VERSION, "got %08lx\n", info->dwVersion); + ok(info->dwFileType == MUI_FILETYPE_LANGUAGE_NEUTRAL_MAIN, "got %08lx\n", info->dwFileType); + + ok(!memcmp(info->pChecksum, rc_cfg->pChecksum, 16), "Checksum doesn't match\n"); + ok(!memcmp(info->pServiceChecksum, rc_cfg->pServiceChecksum, 16), "ServiceChecksum doesn't match\n"); + + p1 = offset_to_data(rc_cfg, rc_cfg->dwLanguageNameOffset); + p2 = offset_to_data(info, info->dwLanguageNameOffset); + ok(!memcmp(p1, p2, rc_cfg->dwLanguageNameSize), "LanguageName doesn't match\n"); + + p1 = offset_to_data(rc_cfg, rc_cfg->dwTypeNameMainOffset); + p2 = offset_to_data(info, info->dwTypeNameMainOffset); + ok(!memcmp(p1, p2, rc_cfg->dwTypeNameMainSize), "TypeNameMain doesn't match\n"); + + p1 = offset_to_data(rc_cfg, rc_cfg->dwTypeIDMainOffset); + p2 = offset_to_data(info, info->dwTypeIDMainOffset); + ok(rc_cfg->dwTypeIDMainSize == info->dwTypeIDMainSize * sizeof(DWORD), "dwTypeIDMainSize %#08lx != %08lx\n", + rc_cfg->dwTypeIDMainSize, info->dwTypeIDMainSize); + ok(!memcmp(p1, p2, rc_cfg->dwTypeIDMainSize), "TypeIDMain doesn't match\n"); + + p1 = offset_to_data(rc_cfg, rc_cfg->dwTypeIDMUIOffset); + p2 = offset_to_data(info, info->dwTypeIDMUIOffset); + ok(rc_cfg->dwTypeIDMUISize == info->dwTypeIDMUISize * sizeof(DWORD), "dwTypeIDMUISize %#08lx != %08lx\n", + rc_cfg->dwTypeIDMUISize, info->dwTypeIDMUISize); + ok(!memcmp(p1, p2, rc_cfg->dwTypeIDMUISize), "TypeIDMUI doesn't match\n"); + + p1 = offset_to_data(rc_cfg, rc_cfg->dwTypeNameMUIOffset); + p2 = offset_to_data(info, info->dwTypeNameMUIOffset); + ok(!memcmp(p1, p2, rc_cfg->dwTypeNameMUISize), "TypeNameMUI doesn't match\n"); + + FreeLibrary(module); +} + START_TEST(resource) { DWORD i; + test_GetFileMUIInfo(); + DeleteFileA( filename ); update_missing_exe(); -- 2.37.1

1 0