July 2022 - Wine-devel - list.winehq.org

'wrc' weirdness
by Gisle Vanem 17 Jul '22

17 Jul '22

Hello again list. I'm still struggling with understanding the build of Wine on Win-10 using MSVC or clang-cl. E.g. the 'wrc' program behaves rather different from MSVC's 'rc'. When for example using 'wrc' to build 'attrib.exe', the output of 'attrib.exe /?' looks like this: ATTRIB - Displays or changes file attributes. Syntax: ATTRIB [+R | -R] [+A | -A ] [+S | -S] [+H | -H] [drive:][path][filename] [/S [/D]] Where: + Sets an attribute. ---------------- All lines are doubled up (?!). But using 'rc', there is this issue: ATTRIB - Displays or changes file attributes. Syntax: ATTRIB [+R | -R] [+A | -A ] [+S | -S] [+H | -H] [drive:][path][filename] \ [/S [/D]] \Where: \ + Sets an attribute. \ - Clears an attribute. -------------- The extra '\' at each line (!?). I've tried converting 'attrib.rc' to Unix/DOS line-endings to no avail. And BTW, I used: wrc -D__WINESRC__ -I../../include --output objdir/attrib.res attrib.rc to compile it. What is going on with this, please? -- --gv

2 4

[PATCH v3 1/2] qedit/tests: Test adding a reference to the sample from ISampleGrabberCB::SampleCB().
by Zebediah Figura 17 Jul '22

17 Jul '22

From: Brendan McGrath <brendan(a)redmandi.com> Unravel Two adds a reference to the IMediaSample during its callback. This patch adds a test that checks if an application does do this, that it can free it later and the reference count will finish at zero. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51616 Signed-off-by: Brendan McGrath <brendan(a)redmandi.com> Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- v3: Some stylistic fixups; make commit messages a bit more specific. dlls/qedit/tests/mediadet.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c index 3202baca924..6e7017f865c 100644 --- a/dlls/qedit/tests/mediadet.c +++ b/dlls/qedit/tests/mediadet.c @@ -866,6 +866,17 @@ static void test_put_filter(void) ok(!ref, "Got outstanding refcount %ld.\n", ref); } +struct test_sample +{ + IMediaSample sample; + LONG refcount; +}; + +static struct test_sample *impl_from_IMediaSample(IMediaSample *iface) +{ + return CONTAINING_RECORD(iface, struct test_sample, sample); +} + static HRESULT WINAPI ms_QueryInterface(IMediaSample *iface, REFIID riid, void **ppvObject) { @@ -874,12 +885,14 @@ static HRESULT WINAPI ms_QueryInterface(IMediaSample *iface, REFIID riid, static ULONG WINAPI ms_AddRef(IMediaSample *iface) { - return 2; + struct test_sample *sample = impl_from_IMediaSample(iface); + return InterlockedIncrement(&sample->refcount); } static ULONG WINAPI ms_Release(IMediaSample *iface) { - return 1; + struct test_sample *sample = impl_from_IMediaSample(iface); + return InterlockedDecrement(&sample->refcount); } static HRESULT WINAPI ms_GetPointer(IMediaSample *iface, BYTE **ppBuffer) @@ -989,7 +1002,7 @@ static const IMediaSampleVtbl my_sample_vt = { ms_SetMediaTime }; -static IMediaSample my_sample = { &my_sample_vt }; +static struct test_sample my_sample = { {&my_sample_vt}, 0 }; static BOOL samplecb_called = FALSE; @@ -1012,8 +1025,9 @@ static ULONG WINAPI sgcb_Release(ISampleGrabberCB *iface) static HRESULT WINAPI sgcb_SampleCB(ISampleGrabberCB *iface, double SampleTime, IMediaSample *pSample) { - ok(pSample == &my_sample, "Got wrong IMediaSample: %p, expected %p\n", pSample, &my_sample); + ok(pSample == &my_sample.sample, "Got wrong IMediaSample: %p, expected %p\n", pSample, &my_sample); samplecb_called = TRUE; + IMediaSample_AddRef(pSample); return E_NOTIMPL; } @@ -1043,6 +1057,7 @@ static void test_samplegrabber(void) IEnumPins *pins; HRESULT hr; FILTER_STATE fstate; + ULONG refcount; /* Invalid RIID */ hr = CoCreateInstance(&CLSID_SampleGrabber, NULL, CLSCTX_INPROC_SERVER, &IID_IClassFactory, @@ -1074,10 +1089,13 @@ static void test_samplegrabber(void) hr = IPin_QueryInterface(pin, &IID_IMemInputPin, (void**)&inpin); ok(hr == S_OK, "Got hr %#lx.\n", hr); - hr = IMemInputPin_Receive(inpin, &my_sample); + hr = IMemInputPin_Receive(inpin, &my_sample.sample); ok(hr == S_OK, "Got hr %#lx.\n", hr); ok(samplecb_called == TRUE, "SampleCB should have been called\n"); + refcount = IUnknown_Release(&my_sample.sample); + todo_wine ok(!refcount, "Got unexpected refcount %ld.\n", refcount); + IMemInputPin_Release(inpin); IPin_Release(pin); -- 2.36.1

3 4

Re: [PATCH v3 3/5] dlls/msvcrt: fix and cleanup undecoration of templatized functions and methods
by Marvin 16 Jul '22

16 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. 1 TestBot errors prevented a full analysis of your patch. If the test caused the operating system (e.g. Windows) to crash or reboot you will probably have to modify it to avoid that. Other issues should be reported to the TestBot administrators. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119173 Your paranoid android. === build (build log) === WineRunBuild.pl:error: An error occurred while waiting for the build to complete: network read timed out (wait2:ListSize:0/4) WineRunBuild.pl:error: BotError: The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died)

1 0

Wine staging 7.13 release
by Alistair Leslie-Hughes 16 Jul '22

16 Jul '22

Binary packages for various distributions will be available from: https://www.winehq.org/download Summary since last release * Rebased to current wine 7.13 (543 patches are applied to wine vanilla) Upstreamed (Either directly from staging or fixed with a similar patch). * None Added: * None Updated: * None Where can you help * Run Steam/Battle.net/GOG/UPlay/Epic * Test your favorite game. * Test your favorite applications. * Improve staging patches and get them accepted upstream. As always, if you find a bug, please report it via https://bugs.winehq.org Best Regards Alistair.

1 0

Re: [PATCH v2 2/5] msvcrt: add support for C++11 operator "" in demangling
by Marvin 16 Jul '22

16 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119164 Your paranoid android. === w1064v1507 (32 bit report) === ucrtbase: cpp.c:207: Test failed: unDName returned "??__K_l@@YA?AUCC@@I(a)Z" for #2 === w1064v1507 (64 bit report) === ucrtbase: cpp.c:207: Test failed: unDName returned "??__K_l@@YA?AUCC@@I(a)Z" for #2

1 0

Re: [PATCH 3/3] taskschd: Return SCHED_S_TASK_HAS_NOT_RUN from regtask_get_LastRunTime() stub.
by Marvin 16 Jul '22

16 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119160 Your paranoid android. === w7u_adm (32 bit report) === taskschd: scheduler.c:791: Test failed: DeleteTask error 0x80070005 scheduler.c:787: Test failed: 1: expected 0, got 0x800700b7 scheduler.c:787: Test failed: 2: expected 0x80070002, got 0 scheduler.c:791: Test failed: DeleteTask error 0x80070005 scheduler.c:791: Test failed: DeleteTask error 0x80070005 scheduler.c:807: Test failed: RegisterTask error 0x800700b7 scheduler.c:953: Test failed: DeleteTask error 0x80070005 scheduler.c:955: Test failed: DeleteTask error 0x80070005 scheduler.c:958: Test failed: expected ERROR_FILE_NOT_FOUND, got 0x80070005

1 0

Re: [PATCH 2/3] schedsvc: Read task enable state from XML in SchRpcGetTaskInfo().
by Marvin 16 Jul '22

16 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119159 Your paranoid android. === w7u_adm (32 bit report) === taskschd: scheduler.c:790: Test failed: DeleteTask error 0x80070005 scheduler.c:786: Test failed: 1: expected 0, got 0x800700b7 scheduler.c:786: Test failed: 2: expected 0x80070002, got 0 scheduler.c:790: Test failed: DeleteTask error 0x80070005 scheduler.c:790: Test failed: DeleteTask error 0x80070005 scheduler.c:806: Test failed: RegisterTask error 0x800700b7 scheduler.c:937: Test failed: DeleteTask error 0x80070005 scheduler.c:939: Test failed: DeleteTask error 0x80070005 scheduler.c:942: Test failed: expected ERROR_FILE_NOT_FOUND, got 0x80070005

1 0

Re: [PATCH 1/5] ws2_32/tests: Add more tests for SO_CONNECT_TIME.
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119152 Your paranoid android. === debian11 (32 bit Japanese:Japan report) === ws2_32: sock.c:6295: Test succeeded inside todo block: expected timeout

1 0

Re: [PATCH v2 7/7] shell32: Implement SHOpenFolderAndSelectItems().
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119127 Your paranoid android. === w1064_2qxl (64 bit report) === shell32: shlfolder.c:5008: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2) === w10pro64 (64 bit report) === shell32: shlfolder.c:4991: Test failed: MKDIR: expected notification type 8, got: 40000 === w10pro64_ar (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64_ja (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 shlfolder.c:4991: Test failed: MKDIR: expected notification type 8, got: 40000 === w10pro64_zh_CN (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000

1 0

Re: [PATCH v2 6/7] shell32/tests: Add SHOpenFolderAndSelectItems() tests.
by Marvin 15 Jul '22

15 Jul '22

Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=119126 Your paranoid android. === w1064v1809 (32 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w1064v1809 (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w1064 (64 bit report) === shell32: shlfolder.c:4991: Test failed: MKDIR: expected notification type 8, got: 40000 === w10pro64_en_AE_u8 (64 bit report) === shell32: shlfolder.c:4991: Test failed: RMDIR: expected notification type 10, got: 40000 === w10pro64_ar (64 bit report) === shell32: shlfolder.c:4991: Test failed: MKDIR: expected notification type 8, got: 40000 === w10pro64_ja (64 bit report) === shell32: shlfolder.c:5008: Test failed: Didn't expect a WM_USER_NOTIFY message (event: 2)

1 0